* [PATCH] drm/i915/selftest: Fix potential memory leak
@ 2021-01-22 1:56 ` Pan Bian
0 siblings, 0 replies; 7+ messages in thread
From: Pan Bian @ 2021-01-22 1:56 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, Chris Wilson, Matthew Auld, Andi Shyti,
Mika Kuoppala
Cc: intel-gfx, dri-devel, linux-kernel, Pan Bian
Object out is not released on path that no VMA instance found. The root
cause is jumping to an unexpected label on the error path.
Fixes: a47e788c2310 ("drm/i915/selftests: Exercise CS TLB invalidation")
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
index c53a222e3dec..713770fb2b92 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
@@ -1880,7 +1880,7 @@ static int igt_cs_tlb(void *arg)
vma = i915_vma_instance(out, vm, NULL);
if (IS_ERR(vma)) {
err = PTR_ERR(vma);
- goto out_put_batch;
+ goto out_put_out;
}
err = i915_vma_pin(vma, 0, 0,
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Intel-gfx] [PATCH] drm/i915/selftest: Fix potential memory leak
@ 2021-01-22 1:56 ` Pan Bian
0 siblings, 0 replies; 7+ messages in thread
From: Pan Bian @ 2021-01-22 1:56 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, Chris Wilson, Matthew Auld, Andi Shyti,
Mika Kuoppala
Cc: Pan Bian, intel-gfx, linux-kernel, dri-devel
Object out is not released on path that no VMA instance found. The root
cause is jumping to an unexpected label on the error path.
Fixes: a47e788c2310 ("drm/i915/selftests: Exercise CS TLB invalidation")
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
index c53a222e3dec..713770fb2b92 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
@@ -1880,7 +1880,7 @@ static int igt_cs_tlb(void *arg)
vma = i915_vma_instance(out, vm, NULL);
if (IS_ERR(vma)) {
err = PTR_ERR(vma);
- goto out_put_batch;
+ goto out_put_out;
}
err = i915_vma_pin(vma, 0, 0,
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] drm/i915/selftest: Fix potential memory leak
@ 2021-01-22 1:56 ` Pan Bian
0 siblings, 0 replies; 7+ messages in thread
From: Pan Bian @ 2021-01-22 1:56 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, Chris Wilson, Matthew Auld, Andi Shyti,
Mika Kuoppala
Cc: Pan Bian, intel-gfx, linux-kernel, dri-devel
Object out is not released on path that no VMA instance found. The root
cause is jumping to an unexpected label on the error path.
Fixes: a47e788c2310 ("drm/i915/selftests: Exercise CS TLB invalidation")
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
index c53a222e3dec..713770fb2b92 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
@@ -1880,7 +1880,7 @@ static int igt_cs_tlb(void *arg)
vma = i915_vma_instance(out, vm, NULL);
if (IS_ERR(vma)) {
err = PTR_ERR(vma);
- goto out_put_batch;
+ goto out_put_out;
}
err = i915_vma_pin(vma, 0, 0,
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915/selftest: Fix potential memory leak
2021-01-22 1:56 ` Pan Bian
(?)
@ 2021-01-22 9:29 ` Chris Wilson
-1 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2021-01-22 9:29 UTC (permalink / raw)
To: Andi Shyti, Daniel Vetter, David Airlie, Jani Nikula,
Joonas Lahtinen, Matthew Auld, Mika Kuoppala, Pan Bian,
Rodrigo Vivi
Cc: intel-gfx, dri-devel, linux-kernel, Pan Bian
Quoting Pan Bian (2021-01-22 01:56:40)
> Object out is not released on path that no VMA instance found. The root
> cause is jumping to an unexpected label on the error path.
Wouldn't the root cause be whatever caused the allocation to fail?
Language notwithstanding,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftest: Fix potential memory leak
@ 2021-01-22 9:29 ` Chris Wilson
0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2021-01-22 9:29 UTC (permalink / raw)
To: Andi Shyti, Daniel Vetter, David Airlie, Jani Nikula,
Joonas Lahtinen, Matthew Auld, Mika Kuoppala, Pan Bian,
Rodrigo Vivi
Cc: Pan Bian, intel-gfx, linux-kernel, dri-devel
Quoting Pan Bian (2021-01-22 01:56:40)
> Object out is not released on path that no VMA instance found. The root
> cause is jumping to an unexpected label on the error path.
Wouldn't the root cause be whatever caused the allocation to fail?
Language notwithstanding,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915/selftest: Fix potential memory leak
@ 2021-01-22 9:29 ` Chris Wilson
0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2021-01-22 9:29 UTC (permalink / raw)
To: Andi Shyti, Daniel Vetter, David Airlie, Jani Nikula,
Joonas Lahtinen, Matthew Auld, Mika Kuoppala, Pan Bian,
Rodrigo Vivi
Cc: Pan Bian, intel-gfx, linux-kernel, dri-devel
Quoting Pan Bian (2021-01-22 01:56:40)
> Object out is not released on path that no VMA instance found. The root
> cause is jumping to an unexpected label on the error path.
Wouldn't the root cause be whatever caused the allocation to fail?
Language notwithstanding,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftest: Fix potential memory leak
2021-01-22 1:56 ` Pan Bian
` (2 preceding siblings ...)
(?)
@ 2021-01-22 18:11 ` Patchwork
-1 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2021-01-22 18:11 UTC (permalink / raw)
To: Pan Bian; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 460 bytes --]
== Series Details ==
Series: drm/i915/selftest: Fix potential memory leak
URL : https://patchwork.freedesktop.org/series/86181/
State : failure
== Summary ==
Applying: drm/i915/selftest: Fix potential memory leak
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
No changes -- Patch already applied.
[-- Attachment #1.2: Type: text/html, Size: 960 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-01-22 18:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-22 1:56 [PATCH] drm/i915/selftest: Fix potential memory leak Pan Bian
2021-01-22 1:56 ` [Intel-gfx] " Pan Bian
2021-01-22 1:56 ` Pan Bian
2021-01-22 9:29 ` Chris Wilson
2021-01-22 9:29 ` [Intel-gfx] " Chris Wilson
2021-01-22 9:29 ` Chris Wilson
2021-01-22 18:11 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.