[freescale-fslc:pr/225 247/432] net/dsa/dsa2.c:127:17: sparse: sparse: symbol 'dsa_link_touch' was not declared. Should it be

[freescale-fslc:pr/225 247/432] net/dsa/dsa2.c:127:17: sparse: sparse: symbol 'dsa_link_touch' was not declared. Should it be

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

tree:   https://github.com/Freescale/linux-fslc pr/225
head:   ab134276e5fa0f228a300c61bed6c8b61a17393b
commit: 27f0edf01bae213fe59f0205154ff871ead4b0ca [247/432] net: dsa: list DSA links in the fabric
config: i386-randconfig-s002-20210122 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-208-g46a52ca4-dirty
        # https://github.com/Freescale/linux-fslc/commit/27f0edf01bae213fe59f0205154ff871ead4b0ca
        git remote add freescale-fslc https://github.com/Freescale/linux-fslc
        git fetch --no-tags freescale-fslc pr/225
        git checkout 27f0edf01bae213fe59f0205154ff871ead4b0ca
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> net/dsa/dsa2.c:127:17: sparse: sparse: symbol 'dsa_link_touch' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33458 bytes --]

[RFC PATCH freescale-fslc] net: dsa: dsa_link_touch() can be static

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]


Fixes: 27f0edf01bae ("net: dsa: list DSA links in the fabric")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 dsa2.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index 2cee876ce2f316f..e35142c142ea5f2 100644
--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c
@@ -124,7 +124,7 @@ static struct dsa_port *dsa_tree_find_port_by_node(struct dsa_switch_tree *dst,
 	return NULL;
 }
 
-struct dsa_link *dsa_link_touch(struct dsa_port *dp, struct dsa_port *link_dp)
+static struct dsa_link *dsa_link_touch(struct dsa_port *dp, struct dsa_port *link_dp)
 {
 	struct dsa_switch *ds = dp->ds;
 	struct dsa_switch_tree *dst;