All of lore.kernel.org
 help / color / mirror / Atom feed
* [virtio-comment] [PATCH] content: Fix driver/device wording on ISR bits
@ 2021-01-22 10:25 Felipe Franciosi
  2021-01-26 11:14 ` Stefan Hajnoczi
  0 siblings, 1 reply; 3+ messages in thread
From: Felipe Franciosi @ 2021-01-22 10:25 UTC (permalink / raw)
  To: virtio-comment; +Cc: mst, Felipe Franciosi

Section "ISR status capability" incorrectly worded that the bits part of
the register allows the device to distinguish between interrupt types.
It is the driver that needs access to that distinction, not the device.

Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
---
 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/content.tex b/content.tex
index 620c0e2..17f0540 100644
--- a/content.tex
+++ b/content.tex
@@ -1054,7 +1054,7 @@ \subsubsection{ISR status capability}\label{sec:Virtio Transport Options / Virti
 
 The \field{offset} for the \field{ISR status} has no alignment requirements.
 
-The ISR bits allow the device to distinguish between device-specific configuration
+The ISR bits allow the driver to distinguish between device-specific configuration
 change interrupts and normal virtqueue interrupts:
 
 \begin{tabular}{ |l||l|l|l| }
-- 
2.18.4


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [virtio-comment] [PATCH] content: Fix driver/device wording on ISR bits
  2021-01-22 10:25 [virtio-comment] [PATCH] content: Fix driver/device wording on ISR bits Felipe Franciosi
@ 2021-01-26 11:14 ` Stefan Hajnoczi
  2021-01-26 17:06   ` Cornelia Huck
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2021-01-26 11:14 UTC (permalink / raw)
  To: Felipe Franciosi; +Cc: virtio-comment, mst

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

On Fri, Jan 22, 2021 at 10:25:02AM +0000, Felipe Franciosi wrote:
> Section "ISR status capability" incorrectly worded that the bits part of
> the register allows the device to distinguish between interrupt types.
> It is the driver that needs access to that distinction, not the device.
> 
> Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
> ---
>  content.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I think this can be merged as a typo fix without a full vote from the
Technical Committee.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [virtio-comment] [PATCH] content: Fix driver/device wording on ISR bits
  2021-01-26 11:14 ` Stefan Hajnoczi
@ 2021-01-26 17:06   ` Cornelia Huck
  0 siblings, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2021-01-26 17:06 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: Felipe Franciosi, virtio-comment, mst

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

On Tue, 26 Jan 2021 11:14:31 +0000
Stefan Hajnoczi <stefanha@redhat.com> wrote:

> On Fri, Jan 22, 2021 at 10:25:02AM +0000, Felipe Franciosi wrote:
> > Section "ISR status capability" incorrectly worded that the bits part of
> > the register allows the device to distinguish between interrupt types.
> > It is the driver that needs access to that distinction, not the device.
> > 
> > Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
> > ---
> >  content.tex | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)  
> 
> I think this can be merged as a typo fix without a full vote from the
> Technical Committee.
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Indeed; pushed out.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-26 17:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-22 10:25 [virtio-comment] [PATCH] content: Fix driver/device wording on ISR bits Felipe Franciosi
2021-01-26 11:14 ` Stefan Hajnoczi
2021-01-26 17:06   ` Cornelia Huck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.