[PATCH] ALSA: bebob: remove an unnecessary condition in hwdep_read()

[PATCH] ALSA: bebob: remove an unnecessary condition in hwdep_read()

[Takashi Sakamoto]

Drivers in ALSA firewire stack supports eventing to userspace
applications via ALSA hwdep interface. All of the drivers supports stream
lock events. Some of them supports their unique events according to
specification of target device.

ALSA bebob driver supports the stream lock event only. In the case, it's
enough to check condition only in loop with process blocking. However,
current implementation check it again after breaking the loop.

This commit removes the redundant check.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/bebob/bebob_hwdep.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/sound/firewire/bebob/bebob_hwdep.c b/sound/firewire/bebob/bebob_hwdep.c
index 8677e3ec8d14..6f9331655d43 100644
--- a/sound/firewire/bebob/bebob_hwdep.c
+++ b/sound/firewire/bebob/bebob_hwdep.c
@@ -37,11 +37,9 @@ hwdep_read(struct snd_hwdep *hwdep, char __user *buf,  long count,
 
 	memset(&event, 0, sizeof(event));
 	count = min_t(long, count, sizeof(event.lock_status));
-	if (bebob->dev_lock_changed) {
-		event.lock_status.type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS;
-		event.lock_status.status = (bebob->dev_lock_count > 0);
-		bebob->dev_lock_changed = false;
-	}
+	event.lock_status.type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS;
+	event.lock_status.status = (bebob->dev_lock_count > 0);
+	bebob->dev_lock_changed = false;
 
 	spin_unlock_irq(&bebob->lock);
 
-- 
2.27.0

Re: [PATCH] ALSA: bebob: remove an unnecessary condition in hwdep_read()

[Takashi Iwai]

On Mon, 25 Jan 2021 15:02:08 +0100,
Takashi Sakamoto wrote:
> 
> Drivers in ALSA firewire stack supports eventing to userspace
> applications via ALSA hwdep interface. All of the drivers supports stream
> lock events. Some of them supports their unique events according to
> specification of target device.
> 
> ALSA bebob driver supports the stream lock event only. In the case, it's
> enough to check condition only in loop with process blocking. However,
> current implementation check it again after breaking the loop.
> 
> This commit removes the redundant check.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Thanks, applied now.


Takashi