From: Kalle Valo <kvalo@codeaurora.org>
To: Aditya Srivastava <yashsri421@gmail.com>
Cc: pkshih@realtek.com, yashsri421@gmail.com, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
kuba@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org,
davem@davemloft.net
Subject: Re: [Linux-kernel-mentees] [PATCH 1/5] rtlwifi: rtl_pci: fix bool comparison in expressions
Date: Mon, 25 Jan 2021 14:22:35 +0000 (UTC) [thread overview]
Message-ID: <20210125142235.2A63DC433CA@smtp.codeaurora.org> (raw)
In-Reply-To: <20210110121525.2407-2-yashsri421@gmail.com>
Aditya Srivastava <yashsri421@gmail.com> wrote:
> There are certain conditional expressions in rtl_pci, where a boolean
> variable is compared with true/false, in forms such as (foo == true) or
> (false != bar), which does not comply with checkpatch.pl (CHECK:
> BOOL_COMPARISON), according to which boolean variables should be
> themselves used in the condition, rather than comparing with true/false
>
> E.g., in drivers/net/wireless/realtek/rtlwifi/ps.c,
> "if (find_p2p_ie == true)" can be replaced with "if (find_p2p_ie)"
>
> Replace all such expressions with the bool variables appropriately
>
> Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
5 patches applied to wireless-drivers-next.git, thanks.
d8cbaa3de403 rtlwifi: rtl_pci: fix bool comparison in expressions
f7c76283fc5f rtlwifi: rtl8192c-common: fix bool comparison in expressions
64338f0dfd6a rtlwifi: rtl8188ee: fix bool comparison in expressions
33ae4623d544 rtlwifi: rtl8192se: fix bool comparison in expressions
9264cabc1204 rtlwifi: rtl8821ae: fix bool comparison in expressions
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210110121525.2407-2-yashsri421@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2021-01-25 14:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 15:32 [PATCH] drivers: net: wireless: rtlwifi: fix bool comparison in expressions Aditya Srivastava
2021-01-08 15:32 ` [Linux-kernel-mentees] " Aditya Srivastava
2021-01-08 19:41 ` Larry Finger
2021-01-08 19:41 ` [Linux-kernel-mentees] " Larry Finger
2021-01-10 12:15 ` [PATCH 0/5] " Aditya Srivastava
2021-01-10 12:15 ` [Linux-kernel-mentees] " Aditya Srivastava
2021-01-10 12:15 ` [PATCH 1/5] rtlwifi: rtl_pci: " Aditya Srivastava
2021-01-10 12:15 ` [Linux-kernel-mentees] " Aditya Srivastava
2021-01-25 14:22 ` Kalle Valo
2021-01-25 14:22 ` Kalle Valo [this message]
2021-01-10 12:15 ` [PATCH 2/5] rtlwifi: rtl8192c-common: " Aditya Srivastava
2021-01-10 12:15 ` [Linux-kernel-mentees] " Aditya Srivastava
2021-01-10 12:15 ` [PATCH 3/5] rtlwifi: rtl8188ee: " Aditya Srivastava
2021-01-10 12:15 ` [Linux-kernel-mentees] " Aditya Srivastava
2021-01-10 12:15 ` [PATCH 4/5] rtlwifi: rtl8192se: " Aditya Srivastava
2021-01-10 12:15 ` [Linux-kernel-mentees] " Aditya Srivastava
2021-01-10 12:15 ` [PATCH 5/5] rtlwifi: rtl8821ae: " Aditya Srivastava
2021-01-10 12:15 ` [Linux-kernel-mentees] " Aditya Srivastava
2021-01-13 17:11 ` [PATCH] drivers: net: wireless: rtlwifi: " Aditya
2021-01-13 17:11 ` [Linux-kernel-mentees] " Aditya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125142235.2A63DC433CA@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.