[PATCH 1/2] keytable: Add Dell RC 260 keymap

[PATCH 1/2] keytable: Add Dell RC 260 keymap

[Bastien Nocera]

Apparently used in the Dell Inspiron Zino HD 410 desktop:
http://web.archive.org/web/20180805000711/http://www.dell.com/ba/p/desktops/inspiron-zino-hd-410/pd

Manual linked in the remote definition itself.

Signed-off-by: Bastien Nocera <hadess@hadess.net>
---
 utils/keytable/rc_keymaps/dell_rc260.toml | 49 +++++++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 utils/keytable/rc_keymaps/dell_rc260.toml

diff --git a/utils/keytable/rc_keymaps/dell_rc260.toml b/utils/keytable/rc_keymaps/dell_rc260.toml
new file mode 100644
index 00000000..603d3a18
--- /dev/null
+++ b/utils/keytable/rc_keymaps/dell_rc260.toml
@@ -0,0 +1,49 @@
+[[protocols]]
+name = "dell_rc260"
+protocol = "rc6"
+variant = "rc6_mce"
+# https://archive.org/details/manualsonline-id-b1c9aa7c-e060-40b0-816a-918536a02fac/
+[protocols.scancodes]
+0x803404a9 = "KEY_HOMEPAGE"
+0x8034040c = "KEY_POWER"
+0x80340437 = "KEY_RECORD"
+0x80340430 = "KEY_PAUSE"
+0x80340431 = "KEY_STOP"
+0x80340429 = "KEY_REWIND"
+0x8034042c = "KEY_PLAY"
+0x80340428 = "KEY_FASTFORWARD"
+0x80340421 = "KEY_PREVIOUS"
+0x80340420 = "KEY_NEXT"
+0x80340483 = "KEY_BACK"
+0x803404cb = "KEY_INFO"
+0x8034045d = "KEY_LEFTMETA"
+0x80340458 = "KEY_UP"
+0x8034045a = "KEY_LEFT"
+0x8034045b = "KEY_RIGHT"
+0x80340459 = "KEY_DOWN"
+0x8034045c = "KEY_OK"
+0x80340410 = "KEY_VOLUMEUP"
+0x80340411 = "KEY_VOLUMEDOWN"
+0x8034041e = "KEY_CHANNELUP"
+0x8034041f = "KEY_CHANNELDOWN"
+0x8034040d = "KEY_MUTE"
+0x80340401 = "KEY_NUMERIC_1"
+0x80340402 = "KEY_NUMERIC_2"
+0x80340403 = "KEY_NUMERIC_3"
+0x80340404 = "KEY_NUMERIC_4"
+0x80340405 = "KEY_NUMERIC_5"
+0x80340406 = "KEY_NUMERIC_6"
+0x80340407 = "KEY_NUMERIC_7"
+0x80340408 = "KEY_NUMERIC_8"
+0x80340409 = "KEY_NUMERIC_9"
+0x80340400 = "KEY_NUMERIC_0"
+0x80340433 = "KEY_NUMERIC_STAR"
+0x80340432 = "KEY_NUMERIC_POUND"
+0x8034043a = "KEY_CLEAR"
+# Teletext key doesn't light the IR LED
+0x8034043e = "KEY_EPG"
+0x80340434 = "KEY_ENTER" # labelled Enter
+0x8034046d = "KEY_RED"
+0x8034046e = "KEY_GREEN"
+0x8034046f = "KEY_YELLOW"
+0x80340470 = "KEY_BLUE"
-- 
2.29.2

[PATCH 2/2] keytable: Add XBox 360 Universal Media Remote

[Bastien Nocera]

Signed-off-by: Bastien Nocera <hadess@hadess.net>
---
 utils/keytable/rc_keymaps/xbox_360.toml | 52 +++++++++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 utils/keytable/rc_keymaps/xbox_360.toml

diff --git a/utils/keytable/rc_keymaps/xbox_360.toml b/utils/keytable/rc_keymaps/xbox_360.toml
new file mode 100644
index 00000000..214ed6c3
--- /dev/null
+++ b/utils/keytable/rc_keymaps/xbox_360.toml
@@ -0,0 +1,52 @@
+[[protocols]]
+name = "xbox_360"
+protocol = "rc6"
+variant = "rc6_mce"
+[protocols.scancodes]
+# http://download.microsoft.com/download/b/c/e/bce76f3f-db51-4c98-b79d-b3d21e90ccc1/universalmediaremote_na_0609.pdf
+0x800f7428 = "KEY_EJECTCD"
+0x800f7464 = "KEY_HOMEPAGE"
+0x800f740c = "KEY_POWER"
+0x800f7419 = "KEY_STOP"
+0x800f7418 = "KEY_PAUSE"
+0x800f7415 = "KEY_REWIND"
+0x800f7414 = "KEY_FASTFORWARD"
+0x800f741b = "KEY_PREVIOUS"
+0x800f741a = "KEY_NEXT"
+0x800f7416 = "KEY_PLAY"
+0x800f744f = "KEY_PROPS" # Display
+0x800f7423 = "KEY_BACK"
+0x800f7424 = "KEY_MEDIA_TOP_MENU" # DVD Menu
+0x800f7451 = "KEY_ROOT_MENU" # Title
+0x800f740f = "KEY_INFO"
+0x800f741e = "KEY_UP"
+0x800f7420 = "KEY_LEFT"
+0x800f7421 = "KEY_RIGHT"
+0x800f741f = "KEY_DOWN"
+0x800f7422 = "KEY_OK"
+0x800f7426 = "KEY_YELLOW"
+0x800f7468 = "KEY_BLUE"
+0x800f7466 = "KEY_GREEN"
+0x800f7425 = "KEY_RED"
+0x800f7410 = "KEY_VOLUMEUP"
+0x800f7411 = "KEY_VOLUMEDOWN"
+# TV key doesn't light the IR LED
+0x800f740e = "KEY_MUTE"
+0x800f746c = "KEY_CHANNELUP"
+0x800f746d = "KEY_CHANNELDOWN"
+0x800f740d = "KEY_LEFTMETA"
+0x800f740b = "KEY_ENTER"
+0x800f7417 = "KEY_RECORD"
+0x800f740a = "KEY_CLEAR"
+0x800f7401 = "KEY_NUMERIC_1"
+0x800f7402 = "KEY_NUMERIC_2"
+0x800f7403 = "KEY_NUMERIC_3"
+0x800f7404 = "KEY_NUMERIC_4"
+0x800f7405 = "KEY_NUMERIC_5"
+0x800f7406 = "KEY_NUMERIC_6"
+0x800f7407 = "KEY_NUMERIC_7"
+0x800f7408 = "KEY_NUMERIC_8"
+0x800f7409 = "KEY_NUMERIC_9"
+0x800f7400 = "KEY_NUMERIC_0"
+0x800f741d = "KEY_102ND" # labeled 100
+0x800f741c = "KEY_CANCEL"
-- 
2.29.2

Re: [PATCH 1/2] keytable: Add Dell RC 260 keymap

[Sean Young]

Hi Bastien,

On Mon, Jan 25, 2021 at 06:35:30PM +0100, Bastien Nocera wrote:
> Apparently used in the Dell Inspiron Zino HD 410 desktop:
> http://web.archive.org/web/20180805000711/http://www.dell.com/ba/p/desktops/inspiron-zino-hd-410/pd
> 
> Manual linked in the remote definition itself.
> 
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
> ---
>  utils/keytable/rc_keymaps/dell_rc260.toml | 49 +++++++++++++++++++++++

These files are generated from the keymaps in the kernel tree. Those can
be found in drivers/media/rc/keymaps/rc-*.c.

A patch to create the keymap in the kernel tree would be better. This is
also true for your other patch for the Xbox 360 rc keymap.

The script which generates the toml file is in utils/keytable/gen_keytables.pl
in the v4l-utils repo.

Some keymaps are v4l-utils only; this is true for keymaps which can't be
loaded from the kernel (ones that use BPF decoders).

>  1 file changed, 49 insertions(+)
>  create mode 100644 utils/keytable/rc_keymaps/dell_rc260.toml
> 
> diff --git a/utils/keytable/rc_keymaps/dell_rc260.toml b/utils/keytable/rc_keymaps/dell_rc260.toml
> new file mode 100644
> index 00000000..603d3a18
> --- /dev/null
> +++ b/utils/keytable/rc_keymaps/dell_rc260.toml
> @@ -0,0 +1,49 @@
> +[[protocols]]
> +name = "dell_rc260"
> +protocol = "rc6"
> +variant = "rc6_mce"

The variant is rc-6-6a-32a for these scancodes.

> +# https://archive.org/details/manualsonline-id-b1c9aa7c-e060-40b0-816a-918536a02fac/
> +[protocols.scancodes]
> +0x803404a9 = "KEY_HOMEPAGE"
> +0x8034040c = "KEY_POWER"
> +0x80340437 = "KEY_RECORD"
> +0x80340430 = "KEY_PAUSE"
> +0x80340431 = "KEY_STOP"
> +0x80340429 = "KEY_REWIND"
> +0x8034042c = "KEY_PLAY"
> +0x80340428 = "KEY_FASTFORWARD"
> +0x80340421 = "KEY_PREVIOUS"
> +0x80340420 = "KEY_NEXT"
> +0x80340483 = "KEY_BACK"
> +0x803404cb = "KEY_INFO"
> +0x8034045d = "KEY_LEFTMETA"
> +0x80340458 = "KEY_UP"
> +0x8034045a = "KEY_LEFT"
> +0x8034045b = "KEY_RIGHT"
> +0x80340459 = "KEY_DOWN"
> +0x8034045c = "KEY_OK"
> +0x80340410 = "KEY_VOLUMEUP"
> +0x80340411 = "KEY_VOLUMEDOWN"
> +0x8034041e = "KEY_CHANNELUP"
> +0x8034041f = "KEY_CHANNELDOWN"
> +0x8034040d = "KEY_MUTE"
> +0x80340401 = "KEY_NUMERIC_1"
> +0x80340402 = "KEY_NUMERIC_2"
> +0x80340403 = "KEY_NUMERIC_3"
> +0x80340404 = "KEY_NUMERIC_4"
> +0x80340405 = "KEY_NUMERIC_5"
> +0x80340406 = "KEY_NUMERIC_6"
> +0x80340407 = "KEY_NUMERIC_7"
> +0x80340408 = "KEY_NUMERIC_8"
> +0x80340409 = "KEY_NUMERIC_9"
> +0x80340400 = "KEY_NUMERIC_0"
> +0x80340433 = "KEY_NUMERIC_STAR"
> +0x80340432 = "KEY_NUMERIC_POUND"
> +0x8034043a = "KEY_CLEAR"
> +# Teletext key doesn't light the IR LED
> +0x8034043e = "KEY_EPG"
> +0x80340434 = "KEY_ENTER" # labelled Enter
> +0x8034046d = "KEY_RED"
> +0x8034046e = "KEY_GREEN"
> +0x8034046f = "KEY_YELLOW"
> +0x80340470 = "KEY_BLUE"
> -- 
> 2.29.2

Re: [PATCH 1/2] keytable: Add Dell RC 260 keymap

[Bastien Nocera]

Hey Sean,

On Mon, 2021-01-25 at 18:02 +0000, Sean Young wrote:
> Hi Bastien,
> 
> On Mon, Jan 25, 2021 at 06:35:30PM +0100, Bastien Nocera wrote:
> > Apparently used in the Dell Inspiron Zino HD 410 desktop:
> > http://web.archive.org/web/20180805000711/http://www.dell.com/ba/p/desktops/inspiron-zino-hd-410/pd
> > 
> > Manual linked in the remote definition itself.
> > 
> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > ---
> >  utils/keytable/rc_keymaps/dell_rc260.toml | 49
> > +++++++++++++++++++++++
> 
> These files are generated from the keymaps in the kernel tree. Those
> can
> be found in drivers/media/rc/keymaps/rc-*.c.
> 
> A patch to create the keymap in the kernel tree would be better. This
> is
> also true for your other patch for the Xbox 360 rc keymap.
> 
> The script which generates the toml file is in
> utils/keytable/gen_keytables.pl
> in the v4l-utils repo.
> 
> Some keymaps are v4l-utils only; this is true for keymaps which can't
> be
> loaded from the kernel (ones that use BPF decoders).

Looks like that's the second time I make the mistake in 2 years. I
can't tell you how annoying that is. I sent patches to mark those files
as auto-generated, and I would really appreciate if you could
reconsider having those files' header marked as autogenerated.

Maybe explain that files in /usr/... are generated, and that if the
user wants to modify them that they should copy them to /etc/...

> >  1 file changed, 49 insertions(+)
> >  create mode 100644 utils/keytable/rc_keymaps/dell_rc260.toml
> > 
> > diff --git a/utils/keytable/rc_keymaps/dell_rc260.toml
> > b/utils/keytable/rc_keymaps/dell_rc260.toml
> > new file mode 100644
> > index 00000000..603d3a18
> > --- /dev/null
> > +++ b/utils/keytable/rc_keymaps/dell_rc260.toml
> > @@ -0,0 +1,49 @@
> > +[[protocols]]
> > +name = "dell_rc260"
> > +protocol = "rc6"
> > +variant = "rc6_mce"
> 
> The variant is rc-6-6a-32a for these scancodes.

OK, noted.

Cheers