* [PATCH v3 1/2] arm64: dts: mt8183: config dsi node @ 2021-01-13 6:28 ` Hsin-Yi Wang 0 siblings, 0 replies; 15+ messages in thread From: Hsin-Yi Wang @ 2021-01-13 6:28 UTC (permalink / raw) To: linux-arm-kernel, Matthias Brugger Cc: Rob Herring, Enric Balletbo i Serra, Nicolas Boichat, devicetree, linux-mediatek, linux-kernel Config dsi node for mt8183 kukui. Set panel and ports. Several kukui boards share the same panel property and only compatible is different. So compatible will be set in board dts for comparison convenience. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> --- .../mediatek/mt8183-kukui-krane-sku176.dts | 5 +++ .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 37 +++++++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts index 47113e275cb52..721d16f9c3b4f 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts @@ -16,3 +16,8 @@ / { model = "MediaTek krane sku176 board"; compatible = "google,krane-sku176", "google,krane", "mediatek,mt8183"; }; + +&panel { + status = "okay"; + compatible = "boe,tv101wum-nl6"; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index bf2ad1294dd30..c5f41b94f154e 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -249,6 +249,35 @@ &cpu7 { proc-supply = <&mt6358_vproc11_reg>; }; +&dsi0 { + status = "okay"; + #address-cells = <1>; + #size-cells = <0>; + panel: panel@0 { + /* compatible will be set in board dts */ + reg = <0>; + enable-gpios = <&pio 45 0>; + pinctrl-names = "default"; + pinctrl-0 = <&panel_pins_default>; + avdd-supply = <&ppvarn_lcd>; + avee-supply = <&ppvarp_lcd>; + pp1800-supply = <&pp1800_lcd>; + port { + panel_in: endpoint { + remote-endpoint = <&dsi_out>; + }; + }; + }; + + ports { + port { + dsi_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + }; +}; + &i2c0 { pinctrl-names = "default"; pinctrl-0 = <&i2c0_pins>; @@ -547,6 +576,14 @@ pins_clk { }; }; + panel_pins_default: panel_pins_default { + panel_reset { + pinmux = <PINMUX_GPIO45__FUNC_GPIO45>; + output-low; + bias-pull-up; + }; + }; + pwm0_pin_default: pwm0_pin_default { pins1 { pinmux = <PINMUX_GPIO176__FUNC_GPIO176>; -- 2.30.0.284.gd98b1dd5eaa7-goog ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 1/2] arm64: dts: mt8183: config dsi node @ 2021-01-13 6:28 ` Hsin-Yi Wang 0 siblings, 0 replies; 15+ messages in thread From: Hsin-Yi Wang @ 2021-01-13 6:28 UTC (permalink / raw) To: linux-arm-kernel, Matthias Brugger Cc: devicetree, Nicolas Boichat, linux-kernel, Rob Herring, linux-mediatek, Enric Balletbo i Serra Config dsi node for mt8183 kukui. Set panel and ports. Several kukui boards share the same panel property and only compatible is different. So compatible will be set in board dts for comparison convenience. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> --- .../mediatek/mt8183-kukui-krane-sku176.dts | 5 +++ .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 37 +++++++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts index 47113e275cb52..721d16f9c3b4f 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts @@ -16,3 +16,8 @@ / { model = "MediaTek krane sku176 board"; compatible = "google,krane-sku176", "google,krane", "mediatek,mt8183"; }; + +&panel { + status = "okay"; + compatible = "boe,tv101wum-nl6"; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index bf2ad1294dd30..c5f41b94f154e 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -249,6 +249,35 @@ &cpu7 { proc-supply = <&mt6358_vproc11_reg>; }; +&dsi0 { + status = "okay"; + #address-cells = <1>; + #size-cells = <0>; + panel: panel@0 { + /* compatible will be set in board dts */ + reg = <0>; + enable-gpios = <&pio 45 0>; + pinctrl-names = "default"; + pinctrl-0 = <&panel_pins_default>; + avdd-supply = <&ppvarn_lcd>; + avee-supply = <&ppvarp_lcd>; + pp1800-supply = <&pp1800_lcd>; + port { + panel_in: endpoint { + remote-endpoint = <&dsi_out>; + }; + }; + }; + + ports { + port { + dsi_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + }; +}; + &i2c0 { pinctrl-names = "default"; pinctrl-0 = <&i2c0_pins>; @@ -547,6 +576,14 @@ pins_clk { }; }; + panel_pins_default: panel_pins_default { + panel_reset { + pinmux = <PINMUX_GPIO45__FUNC_GPIO45>; + output-low; + bias-pull-up; + }; + }; + pwm0_pin_default: pwm0_pin_default { pins1 { pinmux = <PINMUX_GPIO176__FUNC_GPIO176>; -- 2.30.0.284.gd98b1dd5eaa7-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 1/2] arm64: dts: mt8183: config dsi node @ 2021-01-13 6:28 ` Hsin-Yi Wang 0 siblings, 0 replies; 15+ messages in thread From: Hsin-Yi Wang @ 2021-01-13 6:28 UTC (permalink / raw) To: linux-arm-kernel, Matthias Brugger Cc: devicetree, Nicolas Boichat, linux-kernel, Rob Herring, linux-mediatek, Enric Balletbo i Serra Config dsi node for mt8183 kukui. Set panel and ports. Several kukui boards share the same panel property and only compatible is different. So compatible will be set in board dts for comparison convenience. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> --- .../mediatek/mt8183-kukui-krane-sku176.dts | 5 +++ .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 37 +++++++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts index 47113e275cb52..721d16f9c3b4f 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts @@ -16,3 +16,8 @@ / { model = "MediaTek krane sku176 board"; compatible = "google,krane-sku176", "google,krane", "mediatek,mt8183"; }; + +&panel { + status = "okay"; + compatible = "boe,tv101wum-nl6"; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index bf2ad1294dd30..c5f41b94f154e 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -249,6 +249,35 @@ &cpu7 { proc-supply = <&mt6358_vproc11_reg>; }; +&dsi0 { + status = "okay"; + #address-cells = <1>; + #size-cells = <0>; + panel: panel@0 { + /* compatible will be set in board dts */ + reg = <0>; + enable-gpios = <&pio 45 0>; + pinctrl-names = "default"; + pinctrl-0 = <&panel_pins_default>; + avdd-supply = <&ppvarn_lcd>; + avee-supply = <&ppvarp_lcd>; + pp1800-supply = <&pp1800_lcd>; + port { + panel_in: endpoint { + remote-endpoint = <&dsi_out>; + }; + }; + }; + + ports { + port { + dsi_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + }; +}; + &i2c0 { pinctrl-names = "default"; pinctrl-0 = <&i2c0_pins>; @@ -547,6 +576,14 @@ pins_clk { }; }; + panel_pins_default: panel_pins_default { + panel_reset { + pinmux = <PINMUX_GPIO45__FUNC_GPIO45>; + output-low; + bias-pull-up; + }; + }; + pwm0_pin_default: pwm0_pin_default { pins1 { pinmux = <PINMUX_GPIO176__FUNC_GPIO176>; -- 2.30.0.284.gd98b1dd5eaa7-goog _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 2/2] arm64: dts: mt8183: Add krane-sku0 board. 2021-01-13 6:28 ` Hsin-Yi Wang (?) @ 2021-01-13 6:28 ` Hsin-Yi Wang -1 siblings, 0 replies; 15+ messages in thread From: Hsin-Yi Wang @ 2021-01-13 6:28 UTC (permalink / raw) To: linux-arm-kernel, Matthias Brugger Cc: Rob Herring, Enric Balletbo i Serra, Nicolas Boichat, devicetree, linux-mediatek, linux-kernel Similar to krane-sku176 but using a different panel source. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> --- change: v3: fix yaml --- .../devicetree/bindings/arm/mediatek.yaml | 4 +++- arch/arm64/boot/dts/mediatek/Makefile | 1 + .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ 3 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index 53f0d4e3ea982..93b3bdf6eaeb7 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -120,7 +120,9 @@ properties: - const: mediatek,mt8183 - description: Google Krane (Lenovo IdeaPad Duet, 10e,...) items: - - const: google,krane-sku176 + - enum: + - google,krane-sku0 + - google,krane-sku176 - const: google,krane - const: mediatek,mt8183 diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile index 18f7b46c4095b..deba27ab76574 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana-rev7.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts new file mode 100644 index 0000000000000..fb5ee91b6fe0e --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts @@ -0,0 +1,23 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2019 Google LLC + * + * Device-tree for Krane sku0. + * + * SKU is a 8-bit value (0x00 == 0): + * - Bits 7..4: Panel ID: 0x0 (AUO) + * - Bits 3..0: SKU ID: 0x0 (default) + */ + +/dts-v1/; +#include "mt8183-kukui-krane.dtsi" + +/ { + model = "MediaTek krane sku0 board"; + compatible = "google,krane-sku0", "google,krane", "mediatek,mt8183"; +}; + +&panel { + status = "okay"; + compatible = "auo,kd101n80-45na"; +}; -- 2.30.0.284.gd98b1dd5eaa7-goog ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 2/2] arm64: dts: mt8183: Add krane-sku0 board. @ 2021-01-13 6:28 ` Hsin-Yi Wang 0 siblings, 0 replies; 15+ messages in thread From: Hsin-Yi Wang @ 2021-01-13 6:28 UTC (permalink / raw) To: linux-arm-kernel, Matthias Brugger Cc: devicetree, Nicolas Boichat, linux-kernel, Rob Herring, linux-mediatek, Enric Balletbo i Serra Similar to krane-sku176 but using a different panel source. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> --- change: v3: fix yaml --- .../devicetree/bindings/arm/mediatek.yaml | 4 +++- arch/arm64/boot/dts/mediatek/Makefile | 1 + .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ 3 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index 53f0d4e3ea982..93b3bdf6eaeb7 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -120,7 +120,9 @@ properties: - const: mediatek,mt8183 - description: Google Krane (Lenovo IdeaPad Duet, 10e,...) items: - - const: google,krane-sku176 + - enum: + - google,krane-sku0 + - google,krane-sku176 - const: google,krane - const: mediatek,mt8183 diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile index 18f7b46c4095b..deba27ab76574 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana-rev7.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts new file mode 100644 index 0000000000000..fb5ee91b6fe0e --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts @@ -0,0 +1,23 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2019 Google LLC + * + * Device-tree for Krane sku0. + * + * SKU is a 8-bit value (0x00 == 0): + * - Bits 7..4: Panel ID: 0x0 (AUO) + * - Bits 3..0: SKU ID: 0x0 (default) + */ + +/dts-v1/; +#include "mt8183-kukui-krane.dtsi" + +/ { + model = "MediaTek krane sku0 board"; + compatible = "google,krane-sku0", "google,krane", "mediatek,mt8183"; +}; + +&panel { + status = "okay"; + compatible = "auo,kd101n80-45na"; +}; -- 2.30.0.284.gd98b1dd5eaa7-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 2/2] arm64: dts: mt8183: Add krane-sku0 board. @ 2021-01-13 6:28 ` Hsin-Yi Wang 0 siblings, 0 replies; 15+ messages in thread From: Hsin-Yi Wang @ 2021-01-13 6:28 UTC (permalink / raw) To: linux-arm-kernel, Matthias Brugger Cc: devicetree, Nicolas Boichat, linux-kernel, Rob Herring, linux-mediatek, Enric Balletbo i Serra Similar to krane-sku176 but using a different panel source. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> --- change: v3: fix yaml --- .../devicetree/bindings/arm/mediatek.yaml | 4 +++- arch/arm64/boot/dts/mediatek/Makefile | 1 + .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ 3 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index 53f0d4e3ea982..93b3bdf6eaeb7 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -120,7 +120,9 @@ properties: - const: mediatek,mt8183 - description: Google Krane (Lenovo IdeaPad Duet, 10e,...) items: - - const: google,krane-sku176 + - enum: + - google,krane-sku0 + - google,krane-sku176 - const: google,krane - const: mediatek,mt8183 diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile index 18f7b46c4095b..deba27ab76574 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana-rev7.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts new file mode 100644 index 0000000000000..fb5ee91b6fe0e --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts @@ -0,0 +1,23 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2019 Google LLC + * + * Device-tree for Krane sku0. + * + * SKU is a 8-bit value (0x00 == 0): + * - Bits 7..4: Panel ID: 0x0 (AUO) + * - Bits 3..0: SKU ID: 0x0 (default) + */ + +/dts-v1/; +#include "mt8183-kukui-krane.dtsi" + +/ { + model = "MediaTek krane sku0 board"; + compatible = "google,krane-sku0", "google,krane", "mediatek,mt8183"; +}; + +&panel { + status = "okay"; + compatible = "auo,kd101n80-45na"; +}; -- 2.30.0.284.gd98b1dd5eaa7-goog _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: mt8183: Add krane-sku0 board. 2021-01-13 6:28 ` Hsin-Yi Wang (?) @ 2021-01-13 10:35 ` Enric Balletbo i Serra -1 siblings, 0 replies; 15+ messages in thread From: Enric Balletbo i Serra @ 2021-01-13 10:35 UTC (permalink / raw) To: Hsin-Yi Wang, linux-arm-kernel, Matthias Brugger Cc: Rob Herring, Nicolas Boichat, devicetree, linux-mediatek, linux-kernel Hi Hsin-Yi, Thank you for your patch. On 13/1/21 7:28, Hsin-Yi Wang wrote: > Similar to krane-sku176 but using a different panel source. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > change: > v3: fix yaml > --- > .../devicetree/bindings/arm/mediatek.yaml | 4 +++- I think the binding should be a separate patch? (Rob to confirm). Other than that. Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ > 3 files changed, 27 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 53f0d4e3ea982..93b3bdf6eaeb7 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -120,7 +120,9 @@ properties: > - const: mediatek,mt8183 > - description: Google Krane (Lenovo IdeaPad Duet, 10e,...) > items: > - - const: google,krane-sku176 > + - enum: > + - google,krane-sku0 > + - google,krane-sku176 > - const: google,krane > - const: mediatek,mt8183 > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index 18f7b46c4095b..deba27ab76574 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana-rev7.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > new file mode 100644 > index 0000000000000..fb5ee91b6fe0e > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > @@ -0,0 +1,23 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright 2019 Google LLC > + * > + * Device-tree for Krane sku0. > + * > + * SKU is a 8-bit value (0x00 == 0): > + * - Bits 7..4: Panel ID: 0x0 (AUO) > + * - Bits 3..0: SKU ID: 0x0 (default) > + */ > + > +/dts-v1/; > +#include "mt8183-kukui-krane.dtsi" > + > +/ { > + model = "MediaTek krane sku0 board"; > + compatible = "google,krane-sku0", "google,krane", "mediatek,mt8183"; > +}; > + > +&panel { > + status = "okay"; > + compatible = "auo,kd101n80-45na"; > +}; > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: mt8183: Add krane-sku0 board. @ 2021-01-13 10:35 ` Enric Balletbo i Serra 0 siblings, 0 replies; 15+ messages in thread From: Enric Balletbo i Serra @ 2021-01-13 10:35 UTC (permalink / raw) To: Hsin-Yi Wang, linux-arm-kernel, Matthias Brugger Cc: Nicolas Boichat, Rob Herring, linux-mediatek, linux-kernel, devicetree Hi Hsin-Yi, Thank you for your patch. On 13/1/21 7:28, Hsin-Yi Wang wrote: > Similar to krane-sku176 but using a different panel source. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > change: > v3: fix yaml > --- > .../devicetree/bindings/arm/mediatek.yaml | 4 +++- I think the binding should be a separate patch? (Rob to confirm). Other than that. Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ > 3 files changed, 27 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 53f0d4e3ea982..93b3bdf6eaeb7 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -120,7 +120,9 @@ properties: > - const: mediatek,mt8183 > - description: Google Krane (Lenovo IdeaPad Duet, 10e,...) > items: > - - const: google,krane-sku176 > + - enum: > + - google,krane-sku0 > + - google,krane-sku176 > - const: google,krane > - const: mediatek,mt8183 > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index 18f7b46c4095b..deba27ab76574 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana-rev7.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > new file mode 100644 > index 0000000000000..fb5ee91b6fe0e > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > @@ -0,0 +1,23 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright 2019 Google LLC > + * > + * Device-tree for Krane sku0. > + * > + * SKU is a 8-bit value (0x00 == 0): > + * - Bits 7..4: Panel ID: 0x0 (AUO) > + * - Bits 3..0: SKU ID: 0x0 (default) > + */ > + > +/dts-v1/; > +#include "mt8183-kukui-krane.dtsi" > + > +/ { > + model = "MediaTek krane sku0 board"; > + compatible = "google,krane-sku0", "google,krane", "mediatek,mt8183"; > +}; > + > +&panel { > + status = "okay"; > + compatible = "auo,kd101n80-45na"; > +}; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: mt8183: Add krane-sku0 board. @ 2021-01-13 10:35 ` Enric Balletbo i Serra 0 siblings, 0 replies; 15+ messages in thread From: Enric Balletbo i Serra @ 2021-01-13 10:35 UTC (permalink / raw) To: Hsin-Yi Wang, linux-arm-kernel, Matthias Brugger Cc: Nicolas Boichat, Rob Herring, linux-mediatek, linux-kernel, devicetree Hi Hsin-Yi, Thank you for your patch. On 13/1/21 7:28, Hsin-Yi Wang wrote: > Similar to krane-sku176 but using a different panel source. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > change: > v3: fix yaml > --- > .../devicetree/bindings/arm/mediatek.yaml | 4 +++- I think the binding should be a separate patch? (Rob to confirm). Other than that. Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ > 3 files changed, 27 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 53f0d4e3ea982..93b3bdf6eaeb7 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -120,7 +120,9 @@ properties: > - const: mediatek,mt8183 > - description: Google Krane (Lenovo IdeaPad Duet, 10e,...) > items: > - - const: google,krane-sku176 > + - enum: > + - google,krane-sku0 > + - google,krane-sku176 > - const: google,krane > - const: mediatek,mt8183 > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index 18f7b46c4095b..deba27ab76574 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana-rev7.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > new file mode 100644 > index 0000000000000..fb5ee91b6fe0e > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > @@ -0,0 +1,23 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright 2019 Google LLC > + * > + * Device-tree for Krane sku0. > + * > + * SKU is a 8-bit value (0x00 == 0): > + * - Bits 7..4: Panel ID: 0x0 (AUO) > + * - Bits 3..0: SKU ID: 0x0 (default) > + */ > + > +/dts-v1/; > +#include "mt8183-kukui-krane.dtsi" > + > +/ { > + model = "MediaTek krane sku0 board"; > + compatible = "google,krane-sku0", "google,krane", "mediatek,mt8183"; > +}; > + > +&panel { > + status = "okay"; > + compatible = "auo,kd101n80-45na"; > +}; > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: mt8183: Add krane-sku0 board. 2021-01-13 6:28 ` Hsin-Yi Wang (?) @ 2021-01-25 19:28 ` Rob Herring -1 siblings, 0 replies; 15+ messages in thread From: Rob Herring @ 2021-01-25 19:28 UTC (permalink / raw) To: Hsin-Yi Wang Cc: linux-mediatek, devicetree, Nicolas Boichat, Matthias Brugger, linux-arm-kernel, linux-kernel, Enric Balletbo i Serra, Rob Herring On Wed, 13 Jan 2021 14:28:35 +0800, Hsin-Yi Wang wrote: > Similar to krane-sku176 but using a different panel source. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > change: > v3: fix yaml > --- > .../devicetree/bindings/arm/mediatek.yaml | 4 +++- > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ > 3 files changed, 27 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: mt8183: Add krane-sku0 board. @ 2021-01-25 19:28 ` Rob Herring 0 siblings, 0 replies; 15+ messages in thread From: Rob Herring @ 2021-01-25 19:28 UTC (permalink / raw) To: Hsin-Yi Wang Cc: devicetree, Nicolas Boichat, linux-kernel, Enric Balletbo i Serra, Rob Herring, linux-mediatek, Matthias Brugger, linux-arm-kernel On Wed, 13 Jan 2021 14:28:35 +0800, Hsin-Yi Wang wrote: > Similar to krane-sku176 but using a different panel source. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > change: > v3: fix yaml > --- > .../devicetree/bindings/arm/mediatek.yaml | 4 +++- > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ > 3 files changed, 27 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: mt8183: Add krane-sku0 board. @ 2021-01-25 19:28 ` Rob Herring 0 siblings, 0 replies; 15+ messages in thread From: Rob Herring @ 2021-01-25 19:28 UTC (permalink / raw) To: Hsin-Yi Wang Cc: devicetree, Nicolas Boichat, linux-kernel, Enric Balletbo i Serra, Rob Herring, linux-mediatek, Matthias Brugger, linux-arm-kernel On Wed, 13 Jan 2021 14:28:35 +0800, Hsin-Yi Wang wrote: > Similar to krane-sku176 but using a different panel source. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > change: > v3: fix yaml > --- > .../devicetree/bindings/arm/mediatek.yaml | 4 +++- > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ > 3 files changed, 27 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 1/2] arm64: dts: mt8183: config dsi node 2021-01-13 6:28 ` Hsin-Yi Wang (?) @ 2021-01-13 10:33 ` Enric Balletbo i Serra -1 siblings, 0 replies; 15+ messages in thread From: Enric Balletbo i Serra @ 2021-01-13 10:33 UTC (permalink / raw) To: Hsin-Yi Wang, linux-arm-kernel, Matthias Brugger Cc: Rob Herring, Nicolas Boichat, devicetree, linux-mediatek, linux-kernel Hi Hsin-Yi, Thank you for the patch. On 13/1/21 7:28, Hsin-Yi Wang wrote: > Config dsi node for mt8183 kukui. Set panel and ports. > > Several kukui boards share the same panel property and only compatible > is different. So compatible will be set in board dts for comparison > convenience. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> > --- > .../mediatek/mt8183-kukui-krane-sku176.dts | 5 +++ > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 37 +++++++++++++++++++ > 2 files changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts > index 47113e275cb52..721d16f9c3b4f 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts > @@ -16,3 +16,8 @@ / { > model = "MediaTek krane sku176 board"; > compatible = "google,krane-sku176", "google,krane", "mediatek,mt8183"; > }; > + > +&panel { > + status = "okay"; > + compatible = "boe,tv101wum-nl6"; > +}; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > index bf2ad1294dd30..c5f41b94f154e 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > @@ -249,6 +249,35 @@ &cpu7 { > proc-supply = <&mt6358_vproc11_reg>; > }; > > +&dsi0 { > + status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; > + panel: panel@0 { > + /* compatible will be set in board dts */ > + reg = <0>; > + enable-gpios = <&pio 45 0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&panel_pins_default>; > + avdd-supply = <&ppvarn_lcd>; > + avee-supply = <&ppvarp_lcd>; > + pp1800-supply = <&pp1800_lcd>; It'd make sense to add also the backlight here? + backlight = <&backlight_lcd0>; > + port { > + panel_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + }; > + > + ports { > + port { > + dsi_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > +}; > + I think you should enable the MIPI TX to have DSI and panel working? +&mipi_tx0 { + status = "okay"; +}; > &i2c0 { > pinctrl-names = "default"; > pinctrl-0 = <&i2c0_pins>; > @@ -547,6 +576,14 @@ pins_clk { > }; > }; > > + panel_pins_default: panel_pins_default { > + panel_reset { > + pinmux = <PINMUX_GPIO45__FUNC_GPIO45>; > + output-low; > + bias-pull-up; > + }; > + }; > + > pwm0_pin_default: pwm0_pin_default { > pins1 { > pinmux = <PINMUX_GPIO176__FUNC_GPIO176>; > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 1/2] arm64: dts: mt8183: config dsi node @ 2021-01-13 10:33 ` Enric Balletbo i Serra 0 siblings, 0 replies; 15+ messages in thread From: Enric Balletbo i Serra @ 2021-01-13 10:33 UTC (permalink / raw) To: Hsin-Yi Wang, linux-arm-kernel, Matthias Brugger Cc: Nicolas Boichat, Rob Herring, linux-mediatek, linux-kernel, devicetree Hi Hsin-Yi, Thank you for the patch. On 13/1/21 7:28, Hsin-Yi Wang wrote: > Config dsi node for mt8183 kukui. Set panel and ports. > > Several kukui boards share the same panel property and only compatible > is different. So compatible will be set in board dts for comparison > convenience. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> > --- > .../mediatek/mt8183-kukui-krane-sku176.dts | 5 +++ > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 37 +++++++++++++++++++ > 2 files changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts > index 47113e275cb52..721d16f9c3b4f 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts > @@ -16,3 +16,8 @@ / { > model = "MediaTek krane sku176 board"; > compatible = "google,krane-sku176", "google,krane", "mediatek,mt8183"; > }; > + > +&panel { > + status = "okay"; > + compatible = "boe,tv101wum-nl6"; > +}; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > index bf2ad1294dd30..c5f41b94f154e 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > @@ -249,6 +249,35 @@ &cpu7 { > proc-supply = <&mt6358_vproc11_reg>; > }; > > +&dsi0 { > + status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; > + panel: panel@0 { > + /* compatible will be set in board dts */ > + reg = <0>; > + enable-gpios = <&pio 45 0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&panel_pins_default>; > + avdd-supply = <&ppvarn_lcd>; > + avee-supply = <&ppvarp_lcd>; > + pp1800-supply = <&pp1800_lcd>; It'd make sense to add also the backlight here? + backlight = <&backlight_lcd0>; > + port { > + panel_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + }; > + > + ports { > + port { > + dsi_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > +}; > + I think you should enable the MIPI TX to have DSI and panel working? +&mipi_tx0 { + status = "okay"; +}; > &i2c0 { > pinctrl-names = "default"; > pinctrl-0 = <&i2c0_pins>; > @@ -547,6 +576,14 @@ pins_clk { > }; > }; > > + panel_pins_default: panel_pins_default { > + panel_reset { > + pinmux = <PINMUX_GPIO45__FUNC_GPIO45>; > + output-low; > + bias-pull-up; > + }; > + }; > + > pwm0_pin_default: pwm0_pin_default { > pins1 { > pinmux = <PINMUX_GPIO176__FUNC_GPIO176>; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 1/2] arm64: dts: mt8183: config dsi node @ 2021-01-13 10:33 ` Enric Balletbo i Serra 0 siblings, 0 replies; 15+ messages in thread From: Enric Balletbo i Serra @ 2021-01-13 10:33 UTC (permalink / raw) To: Hsin-Yi Wang, linux-arm-kernel, Matthias Brugger Cc: Nicolas Boichat, Rob Herring, linux-mediatek, linux-kernel, devicetree Hi Hsin-Yi, Thank you for the patch. On 13/1/21 7:28, Hsin-Yi Wang wrote: > Config dsi node for mt8183 kukui. Set panel and ports. > > Several kukui boards share the same panel property and only compatible > is different. So compatible will be set in board dts for comparison > convenience. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> > --- > .../mediatek/mt8183-kukui-krane-sku176.dts | 5 +++ > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 37 +++++++++++++++++++ > 2 files changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts > index 47113e275cb52..721d16f9c3b4f 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts > @@ -16,3 +16,8 @@ / { > model = "MediaTek krane sku176 board"; > compatible = "google,krane-sku176", "google,krane", "mediatek,mt8183"; > }; > + > +&panel { > + status = "okay"; > + compatible = "boe,tv101wum-nl6"; > +}; > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > index bf2ad1294dd30..c5f41b94f154e 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > @@ -249,6 +249,35 @@ &cpu7 { > proc-supply = <&mt6358_vproc11_reg>; > }; > > +&dsi0 { > + status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; > + panel: panel@0 { > + /* compatible will be set in board dts */ > + reg = <0>; > + enable-gpios = <&pio 45 0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&panel_pins_default>; > + avdd-supply = <&ppvarn_lcd>; > + avee-supply = <&ppvarp_lcd>; > + pp1800-supply = <&pp1800_lcd>; It'd make sense to add also the backlight here? + backlight = <&backlight_lcd0>; > + port { > + panel_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + }; > + > + ports { > + port { > + dsi_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > +}; > + I think you should enable the MIPI TX to have DSI and panel working? +&mipi_tx0 { + status = "okay"; +}; > &i2c0 { > pinctrl-names = "default"; > pinctrl-0 = <&i2c0_pins>; > @@ -547,6 +576,14 @@ pins_clk { > }; > }; > > + panel_pins_default: panel_pins_default { > + panel_reset { > + pinmux = <PINMUX_GPIO45__FUNC_GPIO45>; > + output-low; > + bias-pull-up; > + }; > + }; > + > pwm0_pin_default: pwm0_pin_default { > pins1 { > pinmux = <PINMUX_GPIO176__FUNC_GPIO176>; > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-01-26 10:17 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-01-13 6:28 [PATCH v3 1/2] arm64: dts: mt8183: config dsi node Hsin-Yi Wang 2021-01-13 6:28 ` Hsin-Yi Wang 2021-01-13 6:28 ` Hsin-Yi Wang 2021-01-13 6:28 ` [PATCH v3 2/2] arm64: dts: mt8183: Add krane-sku0 board Hsin-Yi Wang 2021-01-13 6:28 ` Hsin-Yi Wang 2021-01-13 6:28 ` Hsin-Yi Wang 2021-01-13 10:35 ` Enric Balletbo i Serra 2021-01-13 10:35 ` Enric Balletbo i Serra 2021-01-13 10:35 ` Enric Balletbo i Serra 2021-01-25 19:28 ` Rob Herring 2021-01-25 19:28 ` Rob Herring 2021-01-25 19:28 ` Rob Herring 2021-01-13 10:33 ` [PATCH v3 1/2] arm64: dts: mt8183: config dsi node Enric Balletbo i Serra 2021-01-13 10:33 ` Enric Balletbo i Serra 2021-01-13 10:33 ` Enric Balletbo i Serra
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.