* [PATCH v2] pinctrl: single: set function name when adding function
@ 2021-01-25 20:35 Drew Fustini
2021-01-26 7:13 ` Tony Lindgren
2021-02-12 8:00 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Drew Fustini @ 2021-01-25 20:35 UTC (permalink / raw)
To: linux-gpio
Cc: Drew Fustini, Jason Kridner, Robert Nelson, Linus Walleij, Tony Lindgren
pcs_add_function() fails to set the function name in struct pcs_function
when adding a new function. As a result this line in pcs_set_mux():
dev_dbg(pcs->dev, "enabling %s function%i\n",
func->name, fselector);
prints "(null)" for the function:
pinctrl-single 44e10800.pinmux: enabling (null) function0
pinctrl-single 44e10800.pinmux: enabling (null) function1
pinctrl-single 44e10800.pinmux: enabling (null) function2
pinctrl-single 44e10800.pinmux: enabling (null) function3
With this fix, the output is now:
pinctrl-single 44e10800.pinmux: enabling pinmux-uart0-pins function0
pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function1
pinctrl-single 44e10800.pinmux: enabling pinmux-i2c0-pins function2
pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function3
Cc: Jason Kridner <jkridner@beagleboard.org>
Cc: Robert Nelson <robertcnelson@beagleboard.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Drew Fustini <drew@beagleboard.org>
---
v2 change:
- correctly base on mainline, sorry for the noise in v1
drivers/pinctrl/pinctrl-single.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index f3cd7e296712..7771316dfffa 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -777,6 +777,7 @@ static int pcs_add_function(struct pcs_device *pcs,
function->vals = vals;
function->nvals = nvals;
+ function->name = name;
selector = pinmux_generic_add_function(pcs->pctl, name,
pgnames, npgnames,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] pinctrl: single: set function name when adding function
2021-01-25 20:35 [PATCH v2] pinctrl: single: set function name when adding function Drew Fustini
@ 2021-01-26 7:13 ` Tony Lindgren
2021-02-12 8:00 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2021-01-26 7:13 UTC (permalink / raw)
To: Drew Fustini; +Cc: linux-gpio, Jason Kridner, Robert Nelson, Linus Walleij
* Drew Fustini <drew@beagleboard.org> [210125 20:36]:
> pcs_add_function() fails to set the function name in struct pcs_function
> when adding a new function. As a result this line in pcs_set_mux():
>
> dev_dbg(pcs->dev, "enabling %s function%i\n",
> func->name, fselector);
>
> prints "(null)" for the function:
>
> pinctrl-single 44e10800.pinmux: enabling (null) function0
> pinctrl-single 44e10800.pinmux: enabling (null) function1
> pinctrl-single 44e10800.pinmux: enabling (null) function2
> pinctrl-single 44e10800.pinmux: enabling (null) function3
>
> With this fix, the output is now:
>
> pinctrl-single 44e10800.pinmux: enabling pinmux-uart0-pins function0
> pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function1
> pinctrl-single 44e10800.pinmux: enabling pinmux-i2c0-pins function2
> pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function3
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] pinctrl: single: set function name when adding function
2021-01-25 20:35 [PATCH v2] pinctrl: single: set function name when adding function Drew Fustini
2021-01-26 7:13 ` Tony Lindgren
@ 2021-02-12 8:00 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-02-12 8:00 UTC (permalink / raw)
To: Drew Fustini
Cc: open list:GPIO SUBSYSTEM, Jason Kridner, Robert Nelson, Tony Lindgren
On Mon, Jan 25, 2021 at 9:36 PM Drew Fustini <drew@beagleboard.org> wrote:
> pcs_add_function() fails to set the function name in struct pcs_function
> when adding a new function. As a result this line in pcs_set_mux():
>
> dev_dbg(pcs->dev, "enabling %s function%i\n",
> func->name, fselector);
>
> prints "(null)" for the function:
>
> pinctrl-single 44e10800.pinmux: enabling (null) function0
> pinctrl-single 44e10800.pinmux: enabling (null) function1
> pinctrl-single 44e10800.pinmux: enabling (null) function2
> pinctrl-single 44e10800.pinmux: enabling (null) function3
>
> With this fix, the output is now:
>
> pinctrl-single 44e10800.pinmux: enabling pinmux-uart0-pins function0
> pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function1
> pinctrl-single 44e10800.pinmux: enabling pinmux-i2c0-pins function2
> pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function3
>
> Cc: Jason Kridner <jkridner@beagleboard.org>
> Cc: Robert Nelson <robertcnelson@beagleboard.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> v2 change:
> - correctly base on mainline, sorry for the noise in v1
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-12 8:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 20:35 [PATCH v2] pinctrl: single: set function name when adding function Drew Fustini
2021-01-26 7:13 ` Tony Lindgren
2021-02-12 8:00 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.