[PATCH v2] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:

[PATCH v2] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:

[Geert Uytterhoeven]

  - Add missing reference for "idt,voltage-microvolt",
  - Add missing "additionalProperties: false" for subnodes, to catch
    typos in properties,
  - Fix property names in example.

Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0
    ('clk: vc5: Use "idt,voltage-microvolt" instead of
    "idt,voltage-microvolts"'),
  - Drop reference to clock.yaml, which is already applied
    unconditionally,
  - Drop removal of allOf around if condition, as it is unnecessary
    churn.
---
 .../devicetree/bindings/clock/idt,versaclock5.yaml       | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
index 2ac1131fd9222a86..70239f992d714ae0 100644
--- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
+++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
@@ -75,12 +75,15 @@ patternProperties:
         maximum: 6
       idt,voltage-microvolt:
         description: The output drive voltage.
+        $ref: /schemas/types.yaml#/definitions/uint32
         enum: [ 1800000, 2500000, 3300000 ]
       idt,slew-percent:
         description: The Slew rate control for CMOS single-ended.
         $ref: /schemas/types.yaml#/definitions/uint32
         enum: [ 80, 85, 90, 100 ]
 
+    additionalProperties: false
+
 required:
   - compatible
   - reg
@@ -135,13 +138,13 @@ examples:
             clock-names = "xin";
 
             OUT1 {
-                idt,drive-mode = <VC5_CMOSD>;
-                idt,voltage-microvolts = <1800000>;
+                idt,mode = <VC5_CMOSD>;
+                idt,voltage-microvolt = <1800000>;
                 idt,slew-percent = <80>;
             };
 
             OUT4 {
-                idt,drive-mode = <VC5_LVDS>;
+                idt,mode = <VC5_LVDS>;
             };
         };
     };
-- 
2.25.1

Re: [PATCH v2] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:

[Luca Ceresoli]

Hi Geert,

On 14/01/21 13:56, Geert Uytterhoeven wrote:
>   - Add missing reference for "idt,voltage-microvolt",
>   - Add missing "additionalProperties: false" for subnodes, to catch
>     typos in properties,
>   - Fix property names in example.
> 
> Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0
>     ('clk: vc5: Use "idt,voltage-microvolt" instead of
>     "idt,voltage-microvolts"'),
>   - Drop reference to clock.yaml, which is already applied
>     unconditionally,
>   - Drop removal of allOf around if condition, as it is unnecessary
>     churn.
> ---
>  .../devicetree/bindings/clock/idt,versaclock5.yaml       | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> index 2ac1131fd9222a86..70239f992d714ae0 100644
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> @@ -75,12 +75,15 @@ patternProperties:
>          maximum: 6
>        idt,voltage-microvolt:
>          description: The output drive voltage.
> +        $ref: /schemas/types.yaml#/definitions/uint32

"Vendor specific properties having a standard unit suffix don't need a
type." -- Documentation/devicetree/bindings/example-schema.yaml

The rest looks good.

-- 
Luca

Re: [PATCH v2] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:

[Geert Uytterhoeven]

Hi Luca,

On Wed, Jan 20, 2021 at 5:08 PM Luca Ceresoli <luca@lucaceresoli.net> wrote:
> On 14/01/21 13:56, Geert Uytterhoeven wrote:
> >   - Add missing reference for "idt,voltage-microvolt",
> >   - Add missing "additionalProperties: false" for subnodes, to catch
> >     typos in properties,
> >   - Fix property names in example.
> >
> > Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > v2:
> >   - Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0
> >     ('clk: vc5: Use "idt,voltage-microvolt" instead of
> >     "idt,voltage-microvolts"'),
> >   - Drop reference to clock.yaml, which is already applied
> >     unconditionally,
> >   - Drop removal of allOf around if condition, as it is unnecessary
> >     churn.
> > ---
> >  .../devicetree/bindings/clock/idt,versaclock5.yaml       | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > index 2ac1131fd9222a86..70239f992d714ae0 100644
> > --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > @@ -75,12 +75,15 @@ patternProperties:
> >          maximum: 6
> >        idt,voltage-microvolt:
> >          description: The output drive voltage.
> > +        $ref: /schemas/types.yaml#/definitions/uint32
>
> "Vendor specific properties having a standard unit suffix don't need a
> type." -- Documentation/devicetree/bindings/example-schema.yaml

Thanks, will fix in v3!

Rob: would this apply to idt,slew-percent, too?
I.e. should -percent be added to dt-schema/schemas/property-units.yaml?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:

[Rob Herring]

On Wed, Jan 20, 2021 at 05:29:54PM +0100, Geert Uytterhoeven wrote:
> Hi Luca,
> 
> On Wed, Jan 20, 2021 at 5:08 PM Luca Ceresoli <luca@lucaceresoli.net> wrote:
> > On 14/01/21 13:56, Geert Uytterhoeven wrote:
> > >   - Add missing reference for "idt,voltage-microvolt",
> > >   - Add missing "additionalProperties: false" for subnodes, to catch
> > >     typos in properties,
> > >   - Fix property names in example.
> > >
> > > Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > v2:
> > >   - Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0
> > >     ('clk: vc5: Use "idt,voltage-microvolt" instead of
> > >     "idt,voltage-microvolts"'),
> > >   - Drop reference to clock.yaml, which is already applied
> > >     unconditionally,
> > >   - Drop removal of allOf around if condition, as it is unnecessary
> > >     churn.
> > > ---
> > >  .../devicetree/bindings/clock/idt,versaclock5.yaml       | 9 ++++++---
> > >  1 file changed, 6 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > > index 2ac1131fd9222a86..70239f992d714ae0 100644
> > > --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > > +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > > @@ -75,12 +75,15 @@ patternProperties:
> > >          maximum: 6
> > >        idt,voltage-microvolt:
> > >          description: The output drive voltage.
> > > +        $ref: /schemas/types.yaml#/definitions/uint32
> >
> > "Vendor specific properties having a standard unit suffix don't need a
> > type." -- Documentation/devicetree/bindings/example-schema.yaml
> 
> Thanks, will fix in v3!
> 
> Rob: would this apply to idt,slew-percent, too?
> I.e. should -percent be added to dt-schema/schemas/property-units.yaml?

Yes.

Rob