From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/uboot-tools: env/script generation need BINARIES_DIR
Date: Mon, 25 Jan 2021 22:16:51 +0100 [thread overview]
Message-ID: <20210125221651.10112779@windsurf.home> (raw)
In-Reply-To: <20210125145742.42460-2-matthew.weber@rockwellcollins.com>
On Mon, 25 Jan 2021 08:57:42 -0600
Matt Weber <matthew.weber@rockwellcollins.com> wrote:
> From: Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>
>
> The host build of uboot-tools can occur early in the build process and may
> require the creation of BINARIES_DIR before generation of an enabled envimage
> and/or boot script binary.
>
> Signed-off-by: Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>
> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
Hum, while this works, I'm in fact not too happy with the proposed
solution. I would prefer that we move the mkenvimage/$(MKIMAGE)
invocations to a BUILD_CMDS step, that produces its results in $(@D),
and then INSTALL_CMDS does a $(INSTALL) ... of that file, which with
the -D option would create $(BINARIES_DIR).
I know it's a bit bike-shedding, but it feels a little bit better. What
do you think ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-01-25 21:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 14:57 [Buildroot] [PATCH 1/2] package/uboot-tools: resolve uboot env source file error Matt Weber
2021-01-25 14:57 ` [Buildroot] [PATCH 2/2] package/uboot-tools: env/script generation need BINARIES_DIR Matt Weber
2021-01-25 21:16 ` Thomas Petazzoni [this message]
2021-01-25 21:22 ` Matthew Weber
2021-01-25 21:42 ` Yann E. MORIN
2021-01-25 22:22 ` Thomas Petazzoni
2021-01-26 13:09 ` [Buildroot] [External] " Matthew Weber
2021-01-25 21:15 ` [Buildroot] [PATCH 1/2] package/uboot-tools: resolve uboot env source file error Thomas Petazzoni
2021-01-25 21:30 ` Matthew Weber
2021-01-25 21:37 ` Thomas Petazzoni
2021-01-28 18:32 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125221651.10112779@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.