* [PATCH] soundwire: bus: add better dev_dbg to track complete() calls
@ 2021-01-26 8:54 ` Bard Liao
0 siblings, 0 replies; 4+ messages in thread
From: Bard Liao @ 2021-01-26 8:54 UTC (permalink / raw)
To: alsa-devel, vkoul
Cc: vinod.koul, linux-kernel, gregkh, jank, srinivas.kandagatla,
rander.wang, ranjani.sridharan, hui.wang, pierre-louis.bossart,
sanyog.r.kale, bard.liao
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Add a dev_dbg() log for both enumeration and initialization completion
to better track suspend-resume issues.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Chao Song <chao.song@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
drivers/soundwire/bus.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 6e1c988f3845..82df088c9333 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -784,7 +784,7 @@ static void sdw_modify_slave_status(struct sdw_slave *slave,
if (status == SDW_SLAVE_UNATTACHED) {
dev_dbg(&slave->dev,
- "%s: initializing completion for Slave %d\n",
+ "%s: initializing enumeration and init completion for Slave %d\n",
__func__, slave->dev_num);
init_completion(&slave->enumeration_complete);
@@ -793,7 +793,7 @@ static void sdw_modify_slave_status(struct sdw_slave *slave,
} else if ((status == SDW_SLAVE_ATTACHED) &&
(slave->status == SDW_SLAVE_UNATTACHED)) {
dev_dbg(&slave->dev,
- "%s: signaling completion for Slave %d\n",
+ "%s: signaling enumeration completion for Slave %d\n",
__func__, slave->dev_num);
complete(&slave->enumeration_complete);
@@ -1758,8 +1758,13 @@ int sdw_handle_slave_status(struct sdw_bus *bus,
if (ret)
dev_err(slave->bus->dev,
"Update Slave status failed:%d\n", ret);
- if (attached_initializing)
+ if (attached_initializing) {
+ dev_dbg(&slave->dev,
+ "%s: signaling initialization completion for Slave %d\n",
+ __func__, slave->dev_num);
+
complete(&slave->initialization_complete);
+ }
}
return ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] soundwire: bus: add better dev_dbg to track complete() calls
@ 2021-01-26 8:54 ` Bard Liao
0 siblings, 0 replies; 4+ messages in thread
From: Bard Liao @ 2021-01-26 8:54 UTC (permalink / raw)
To: alsa-devel, vkoul
Cc: pierre-louis.bossart, vinod.koul, gregkh, linux-kernel,
ranjani.sridharan, hui.wang, srinivas.kandagatla, jank,
sanyog.r.kale, rander.wang, bard.liao
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Add a dev_dbg() log for both enumeration and initialization completion
to better track suspend-resume issues.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Chao Song <chao.song@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
drivers/soundwire/bus.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 6e1c988f3845..82df088c9333 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -784,7 +784,7 @@ static void sdw_modify_slave_status(struct sdw_slave *slave,
if (status == SDW_SLAVE_UNATTACHED) {
dev_dbg(&slave->dev,
- "%s: initializing completion for Slave %d\n",
+ "%s: initializing enumeration and init completion for Slave %d\n",
__func__, slave->dev_num);
init_completion(&slave->enumeration_complete);
@@ -793,7 +793,7 @@ static void sdw_modify_slave_status(struct sdw_slave *slave,
} else if ((status == SDW_SLAVE_ATTACHED) &&
(slave->status == SDW_SLAVE_UNATTACHED)) {
dev_dbg(&slave->dev,
- "%s: signaling completion for Slave %d\n",
+ "%s: signaling enumeration completion for Slave %d\n",
__func__, slave->dev_num);
complete(&slave->enumeration_complete);
@@ -1758,8 +1758,13 @@ int sdw_handle_slave_status(struct sdw_bus *bus,
if (ret)
dev_err(slave->bus->dev,
"Update Slave status failed:%d\n", ret);
- if (attached_initializing)
+ if (attached_initializing) {
+ dev_dbg(&slave->dev,
+ "%s: signaling initialization completion for Slave %d\n",
+ __func__, slave->dev_num);
+
complete(&slave->initialization_complete);
+ }
}
return ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] soundwire: bus: add better dev_dbg to track complete() calls
2021-01-26 8:54 ` Bard Liao
@ 2021-02-01 10:40 ` Vinod Koul
-1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-02-01 10:40 UTC (permalink / raw)
To: Bard Liao
Cc: alsa-devel, linux-kernel, gregkh, jank, srinivas.kandagatla,
rander.wang, ranjani.sridharan, hui.wang, pierre-louis.bossart,
sanyog.r.kale, bard.liao
On 26-01-21, 16:54, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> Add a dev_dbg() log for both enumeration and initialization completion
> to better track suspend-resume issues.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soundwire: bus: add better dev_dbg to track complete() calls
@ 2021-02-01 10:40 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-02-01 10:40 UTC (permalink / raw)
To: Bard Liao
Cc: pierre-louis.bossart, alsa-devel, gregkh, linux-kernel,
ranjani.sridharan, hui.wang, srinivas.kandagatla, jank,
sanyog.r.kale, rander.wang, bard.liao
On 26-01-21, 16:54, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> Add a dev_dbg() log for both enumeration and initialization completion
> to better track suspend-resume issues.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-01 10:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26 8:54 [PATCH] soundwire: bus: add better dev_dbg to track complete() calls Bard Liao
2021-01-26 8:54 ` Bard Liao
2021-02-01 10:40 ` Vinod Koul
2021-02-01 10:40 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.