* [PATCH 0/2] gitlab-ci: Test Fedora capstone package
@ 2021-01-26 11:36 Philippe Mathieu-Daudé
2021-01-26 11:36 ` [PATCH 1/2] docker: Install libcastone on Fedora Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-26 11:36 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Thomas Huth, Daniel P . Berrange, Alex Bennée,
Richard Henderson, Wainer dos Santos Moschetta,
Philippe Mathieu-Daudé
Add a job for a supported feature: capstone.
Philippe Mathieu-Daudé (2):
docker: Install libcastone on Fedora
gitlab-ci: Test Fedora capstone package
.gitlab-ci.yml | 7 +++++++
tests/docker/dockerfiles/fedora.docker | 1 +
2 files changed, 8 insertions(+)
--
2.26.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] docker: Install libcastone on Fedora
2021-01-26 11:36 [PATCH 0/2] gitlab-ci: Test Fedora capstone package Philippe Mathieu-Daudé
@ 2021-01-26 11:36 ` Philippe Mathieu-Daudé
2021-01-26 11:36 ` [PATCH 2/2] gitlab-ci: Test Fedora capstone package Philippe Mathieu-Daudé
2021-01-26 12:05 ` [PATCH 0/2] " Thomas Huth
2 siblings, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-26 11:36 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Thomas Huth, Daniel P . Berrange, Alex Bennée,
Richard Henderson, Wainer dos Santos Moschetta,
Philippe Mathieu-Daudé
As other packages might install the system capstone library,
we want to test it too in our CI.
By default QEMU clones libcapstone from git, but a developer
can force to use the system packaged library using:
$ ./configure --enable-capstone=system
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/docker/dockerfiles/fedora.docker | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 0b5053f2d09..a8d01c6703c 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -6,6 +6,7 @@ ENV PACKAGES \
brlapi-devel \
bzip2 \
bzip2-devel \
+ capstone-devel \
ccache \
clang \
cyrus-sasl-devel \
--
2.26.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] gitlab-ci: Test Fedora capstone package
2021-01-26 11:36 [PATCH 0/2] gitlab-ci: Test Fedora capstone package Philippe Mathieu-Daudé
2021-01-26 11:36 ` [PATCH 1/2] docker: Install libcastone on Fedora Philippe Mathieu-Daudé
@ 2021-01-26 11:36 ` Philippe Mathieu-Daudé
2021-01-26 11:39 ` Daniel P. Berrangé
2021-01-26 12:05 ` [PATCH 0/2] " Thomas Huth
2 siblings, 1 reply; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-26 11:36 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Thomas Huth, Daniel P . Berrange, Alex Bennée,
Richard Henderson, Wainer dos Santos Moschetta,
Philippe Mathieu-Daudé
Test building the 4 targets using the capstone disassembler
with the capstone package provided on Fedora.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
.gitlab-ci.yml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index de3a3d25b58..913940656de 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -493,6 +493,13 @@ build-tci:
- QTEST_QEMU_BINARY="./qemu-system-x86_64" ./tests/qtest/pxe-test
- QTEST_QEMU_BINARY="./qemu-system-s390x" ./tests/qtest/pxe-test -m slow
+build-capstone-distrib:
+ <<: *native_build_job_definition
+ variables:
+ IMAGE: fedora
+ CONFIGURE_ARGS: --enable-capstone=system --disable-tools --disable-docs
+ TARGETS: arm-softmmu ppc-softmmu x86_64-linux-user s390x-linux-user
+
# Alternate coroutines implementations are only really of interest to KVM users
# However we can't test against KVM on Gitlab-CI so we can only run unit tests
build-coroutine-ucontext:
--
2.26.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] gitlab-ci: Test Fedora capstone package
2021-01-26 11:36 ` [PATCH 2/2] gitlab-ci: Test Fedora capstone package Philippe Mathieu-Daudé
@ 2021-01-26 11:39 ` Daniel P. Berrangé
2021-01-26 12:04 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 7+ messages in thread
From: Daniel P. Berrangé @ 2021-01-26 11:39 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Thomas Huth, Richard Henderson, qemu-devel,
Wainer dos Santos Moschetta, Alex Bennée
On Tue, Jan 26, 2021 at 12:36:49PM +0100, Philippe Mathieu-Daudé wrote:
> Test building the 4 targets using the capstone disassembler
> with the capstone package provided on Fedora.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> .gitlab-ci.yml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index de3a3d25b58..913940656de 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -493,6 +493,13 @@ build-tci:
> - QTEST_QEMU_BINARY="./qemu-system-x86_64" ./tests/qtest/pxe-test
> - QTEST_QEMU_BINARY="./qemu-system-s390x" ./tests/qtest/pxe-test -m slow
>
> +build-capstone-distrib:
> + <<: *native_build_job_definition
> + variables:
> + IMAGE: fedora
> + CONFIGURE_ARGS: --enable-capstone=system --disable-tools --disable-docs
> + TARGETS: arm-softmmu ppc-softmmu x86_64-linux-user s390x-linux-user
Won't one of the existing jobs using Fedora automatically enable use
of the system capstone ? I don't think we want to keep adding jobs
for each new possible configure arg. Instead try to re-use existing
jobs whereever possible.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] gitlab-ci: Test Fedora capstone package
2021-01-26 11:39 ` Daniel P. Berrangé
@ 2021-01-26 12:04 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-26 12:04 UTC (permalink / raw)
To: Daniel P. Berrangé
Cc: Fam Zheng, Thomas Huth, Richard Henderson, qemu-devel,
Wainer dos Santos Moschetta, Alex Bennée
On 1/26/21 12:39 PM, Daniel P. Berrangé wrote:
> On Tue, Jan 26, 2021 at 12:36:49PM +0100, Philippe Mathieu-Daudé wrote:
>> Test building the 4 targets using the capstone disassembler
>> with the capstone package provided on Fedora.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> .gitlab-ci.yml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index de3a3d25b58..913940656de 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -493,6 +493,13 @@ build-tci:
>> - QTEST_QEMU_BINARY="./qemu-system-x86_64" ./tests/qtest/pxe-test
>> - QTEST_QEMU_BINARY="./qemu-system-s390x" ./tests/qtest/pxe-test -m slow
>>
>> +build-capstone-distrib:
>> + <<: *native_build_job_definition
>> + variables:
>> + IMAGE: fedora
>> + CONFIGURE_ARGS: --enable-capstone=system --disable-tools --disable-docs
>> + TARGETS: arm-softmmu ppc-softmmu x86_64-linux-user s390x-linux-user
>
> Won't one of the existing jobs using Fedora automatically enable use
> of the system capstone ? I don't think we want to keep adding jobs
> for each new possible configure arg. Instead try to re-use existing
> jobs whereever possible.
I looked but couldn't find one. Eventually the TCI job.
As this is unlikely to fail often, I'll see with Thomas the other
possible policies. Building this every month/release should be enough.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] gitlab-ci: Test Fedora capstone package
2021-01-26 11:36 [PATCH 0/2] gitlab-ci: Test Fedora capstone package Philippe Mathieu-Daudé
2021-01-26 11:36 ` [PATCH 1/2] docker: Install libcastone on Fedora Philippe Mathieu-Daudé
2021-01-26 11:36 ` [PATCH 2/2] gitlab-ci: Test Fedora capstone package Philippe Mathieu-Daudé
@ 2021-01-26 12:05 ` Thomas Huth
2021-01-26 12:07 ` Philippe Mathieu-Daudé
2 siblings, 1 reply; 7+ messages in thread
From: Thomas Huth @ 2021-01-26 12:05 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Fam Zheng, Alex Bennée, Richard Henderson,
Daniel P . Berrange, Wainer dos Santos Moschetta
On 26/01/2021 12.36, Philippe Mathieu-Daudé wrote:
> Add a job for a supported feature: capstone.
>
> Philippe Mathieu-Daudé (2):
> docker: Install libcastone on Fedora
> gitlab-ci: Test Fedora capstone package
>
> .gitlab-ci.yml | 7 +++++++
> tests/docker/dockerfiles/fedora.docker | 1 +
> 2 files changed, 8 insertions(+)
I've posted a patch for this a couple of days ago already:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg775255.html
Thomas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] gitlab-ci: Test Fedora capstone package
2021-01-26 12:05 ` [PATCH 0/2] " Thomas Huth
@ 2021-01-26 12:07 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-26 12:07 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: Fam Zheng, Alex Bennée, Richard Henderson,
Daniel P . Berrange, Wainer dos Santos Moschetta
On 1/26/21 1:05 PM, Thomas Huth wrote:
> On 26/01/2021 12.36, Philippe Mathieu-Daudé wrote:
>> Add a job for a supported feature: capstone.
>>
>> Philippe Mathieu-Daudé (2):
>> docker: Install libcastone on Fedora
>> gitlab-ci: Test Fedora capstone package
>>
>> .gitlab-ci.yml | 7 +++++++
>> tests/docker/dockerfiles/fedora.docker | 1 +
>> 2 files changed, 8 insertions(+)
>
> I've posted a patch for this a couple of days ago already:
>
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg775255.html
Oh I missed it, thanks.
>
> Thomas
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-01-26 12:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26 11:36 [PATCH 0/2] gitlab-ci: Test Fedora capstone package Philippe Mathieu-Daudé
2021-01-26 11:36 ` [PATCH 1/2] docker: Install libcastone on Fedora Philippe Mathieu-Daudé
2021-01-26 11:36 ` [PATCH 2/2] gitlab-ci: Test Fedora capstone package Philippe Mathieu-Daudé
2021-01-26 11:39 ` Daniel P. Berrangé
2021-01-26 12:04 ` Philippe Mathieu-Daudé
2021-01-26 12:05 ` [PATCH 0/2] " Thomas Huth
2021-01-26 12:07 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.