* [lee-linaro:tb-fix-w1-warnings 85/162] drivers/clk/ti/dpll3xxx.c:303: warning: expecting prototype for _omap3_noncore_dpll_program(). Prototype was for omap3_noncore_dpll_program() instead
@ 2021-01-26 20:57 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-01-26 20:57 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 14198 bytes --]
tree: https://git.linaro.org/people/lee.jones/linux.git tb-fix-w1-warnings
head: 9921f2e1970df1b38d80eb97300c47f93663898b
commit: b5d006752a0cfa09440572c1c50c8fdf122553f9 [85/162] clk: ti: dpll3xxx: Fix some kernel-doc headers and promote other worthy ones
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add lee-linaro https://git.linaro.org/people/lee.jones/linux.git
git fetch --no-tags lee-linaro tb-fix-w1-warnings
git checkout b5d006752a0cfa09440572c1c50c8fdf122553f9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/clk/ti/dpll3xxx.c:303: warning: expecting prototype for _omap3_noncore_dpll_program(). Prototype was for omap3_noncore_dpll_program() instead
drivers/clk/ti/dpll3xxx.c:853: warning: expecting prototype for omap3_non_core_dpll_save_context(). Prototype was for omap3_noncore_dpll_save_context() instead
drivers/clk/ti/dpll3xxx.c:882: warning: expecting prototype for omap3_core_dpll_restore_context(). Prototype was for omap3_noncore_dpll_restore_context() instead
vim +303 drivers/clk/ti/dpll3xxx.c
358965d7bab9c7 arch/arm/mach-omap2/dpll3xxx.c Richard Woodruff 2010-02-22 293
b5d006752a0cfa drivers/clk/ti/dpll3xxx.c Lee Jones 2021-01-19 294 /**
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 295 * _omap3_noncore_dpll_program - set non-core DPLL M,N values directly
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 296 * @clk: struct clk * of DPLL to set
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 297 * @freqsel: FREQSEL value to set
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 298 *
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 299 * Program the DPLL with the last M, N values calculated, and wait for
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 300 * the DPLL to lock. Returns -EINVAL upon error, or 0 upon success.
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 301 */
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 302 static int omap3_noncore_dpll_program(struct clk_hw_omap *clk, u16 freqsel)
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 @303 {
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 304 struct dpll_data *dd = clk->dpll_data;
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 305 u8 dco, sd_div, ai = 0;
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 306 u32 v;
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 307 bool errata_i810;
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 308
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 309 /* 3430 ES2 TRM: 4.7.6.9 DPLL Programming Sequence */
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 310 _omap3_noncore_dpll_bypass(clk);
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 311
5eb75f55784313 arch/arm/mach-omap2/dpll3xxx.c Vishwanath BS 2010-02-24 312 /*
ecf51648c19237 arch/arm/mach-omap2/dpll3xxx.c Rajendra Nayak 2013-01-29 313 * Set jitter correction. Jitter correction applicable for OMAP343X
ecf51648c19237 arch/arm/mach-omap2/dpll3xxx.c Rajendra Nayak 2013-01-29 314 * only since freqsel field is no longer present on other devices.
5eb75f55784313 arch/arm/mach-omap2/dpll3xxx.c Vishwanath BS 2010-02-24 315 */
f3b19aa5cab65f arch/arm/mach-omap2/dpll3xxx.c Tero Kristo 2015-02-27 316 if (ti_clk_get_features()->flags & TI_CLK_DPLL_HAS_FREQSEL) {
6c0afb503937a1 drivers/clk/ti/dpll3xxx.c Tero Kristo 2017-02-09 317 v = ti_clk_ll_ops->clk_readl(&dd->control_reg);
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 318 v &= ~dd->freqsel_mask;
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 319 v |= freqsel << __ffs(dd->freqsel_mask);
6c0afb503937a1 drivers/clk/ti/dpll3xxx.c Tero Kristo 2017-02-09 320 ti_clk_ll_ops->clk_writel(v, &dd->control_reg);
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 321 }
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 322
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 323 /* Set DPLL multiplier, divider */
6c0afb503937a1 drivers/clk/ti/dpll3xxx.c Tero Kristo 2017-02-09 324 v = ti_clk_ll_ops->clk_readl(&dd->mult_div1_reg);
ce369a545aac3d arch/arm/mach-omap2/dpll3xxx.c Andrii Tseglytskyi 2014-05-16 325
ce369a545aac3d arch/arm/mach-omap2/dpll3xxx.c Andrii Tseglytskyi 2014-05-16 326 /* Handle Duty Cycle Correction */
ce369a545aac3d arch/arm/mach-omap2/dpll3xxx.c Andrii Tseglytskyi 2014-05-16 327 if (dd->dcc_mask) {
ce369a545aac3d arch/arm/mach-omap2/dpll3xxx.c Andrii Tseglytskyi 2014-05-16 328 if (dd->last_rounded_rate >= dd->dcc_rate)
ce369a545aac3d arch/arm/mach-omap2/dpll3xxx.c Andrii Tseglytskyi 2014-05-16 329 v |= dd->dcc_mask; /* Enable DCC */
ce369a545aac3d arch/arm/mach-omap2/dpll3xxx.c Andrii Tseglytskyi 2014-05-16 330 else
ce369a545aac3d arch/arm/mach-omap2/dpll3xxx.c Andrii Tseglytskyi 2014-05-16 331 v &= ~dd->dcc_mask; /* Disable DCC */
ce369a545aac3d arch/arm/mach-omap2/dpll3xxx.c Andrii Tseglytskyi 2014-05-16 332 }
ce369a545aac3d arch/arm/mach-omap2/dpll3xxx.c Andrii Tseglytskyi 2014-05-16 333
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 334 v &= ~(dd->mult_mask | dd->div1_mask);
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 335 v |= dd->last_rounded_m << __ffs(dd->mult_mask);
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 336 v |= (dd->last_rounded_n - 1) << __ffs(dd->div1_mask);
358965d7bab9c7 arch/arm/mach-omap2/dpll3xxx.c Richard Woodruff 2010-02-22 337
a36795c1278112 arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2010-12-21 338 /* Configure dco and sd_div for dplls that have these fields */
a36795c1278112 arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2010-12-21 339 if (dd->dco_mask) {
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 340 _lookup_dco(clk, &dco, dd->last_rounded_m, dd->last_rounded_n);
a36795c1278112 arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2010-12-21 341 v &= ~(dd->dco_mask);
a36795c1278112 arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2010-12-21 342 v |= dco << __ffs(dd->dco_mask);
a36795c1278112 arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2010-12-21 343 }
a36795c1278112 arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2010-12-21 344 if (dd->sddiv_mask) {
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 345 _lookup_sddiv(clk, &sd_div, dd->last_rounded_m,
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 346 dd->last_rounded_n);
a36795c1278112 arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2010-12-21 347 v &= ~(dd->sddiv_mask);
a36795c1278112 arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2010-12-21 348 v |= sd_div << __ffs(dd->sddiv_mask);
358965d7bab9c7 arch/arm/mach-omap2/dpll3xxx.c Richard Woodruff 2010-02-22 349 }
358965d7bab9c7 arch/arm/mach-omap2/dpll3xxx.c Richard Woodruff 2010-02-22 350
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 351 /*
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 352 * Errata i810 - DPLL controller can get stuck while transitioning
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 353 * to a power saving state. Software must ensure the DPLL can not
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 354 * transition to a low power state while changing M/N values.
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 355 * Easiest way to accomplish this is to prevent DPLL autoidle
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 356 * before doing the M/N re-program.
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 357 */
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 358 errata_i810 = ti_clk_get_features()->flags & TI_CLK_ERRATA_I810;
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 359
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 360 if (errata_i810) {
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 361 ai = omap3_dpll_autoidle_read(clk);
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 362 if (ai) {
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 363 omap3_dpll_deny_idle(clk);
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 364
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 365 /* OCP barrier */
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 366 omap3_dpll_autoidle_read(clk);
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 367 }
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 368 }
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 369
6c0afb503937a1 drivers/clk/ti/dpll3xxx.c Tero Kristo 2017-02-09 370 ti_clk_ll_ops->clk_writel(v, &dd->mult_div1_reg);
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 371
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 372 /* Set 4X multiplier and low-power mode */
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 373 if (dd->m4xen_mask || dd->lpmode_mask) {
6c0afb503937a1 drivers/clk/ti/dpll3xxx.c Tero Kristo 2017-02-09 374 v = ti_clk_ll_ops->clk_readl(&dd->control_reg);
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 375
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 376 if (dd->m4xen_mask) {
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 377 if (dd->last_rounded_m4xen)
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 378 v |= dd->m4xen_mask;
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 379 else
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 380 v &= ~dd->m4xen_mask;
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 381 }
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 382
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 383 if (dd->lpmode_mask) {
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 384 if (dd->last_rounded_lpmode)
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 385 v |= dd->lpmode_mask;
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 386 else
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 387 v &= ~dd->lpmode_mask;
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 388 }
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 389
6c0afb503937a1 drivers/clk/ti/dpll3xxx.c Tero Kristo 2017-02-09 390 ti_clk_ll_ops->clk_writel(v, &dd->control_reg);
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 391 }
3ff51ed8287d3d arch/arm/mach-omap2/dpll3xxx.c Jon Hunter 2012-12-15 392
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 393 /* We let the clock framework set the other output dividers later */
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 394
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 395 /* REVISIT: Set ramp-up delay? */
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 396
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 397 _omap3_noncore_dpll_lock(clk);
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 398
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 399 if (errata_i810 && ai)
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 400 omap3_dpll_allow_idle(clk);
07ff73a932b725 drivers/clk/ti/dpll3xxx.c Tero Kristo 2015-11-30 401
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 402 return 0;
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 403 }
60c3f65191d077 arch/arm/mach-omap2/dpll3xxx.c Paul Walmsley 2010-01-26 404
:::::: The code at line 303 was first introduced by commit
:::::: 60c3f65191d077dc4f69fca8eca39fb47f72d8b0 OMAP3 DPLL: reorganize static functions
:::::: TO: Paul Walmsley <paul@pwsan.com>
:::::: CC: Paul Walmsley <paul@pwsan.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 54226 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-01-26 20:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26 20:57 [lee-linaro:tb-fix-w1-warnings 85/162] drivers/clk/ti/dpll3xxx.c:303: warning: expecting prototype for _omap3_noncore_dpll_program(). Prototype was for omap3_noncore_dpll_program() instead kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.