* [PATCH] tests: monitor: use correct $nft value in EXIT trap
@ 2021-01-27 14:02 Štěpán Němec
2021-01-27 22:51 ` Phil Sutter
0 siblings, 1 reply; 3+ messages in thread
From: Štěpán Němec @ 2021-01-27 14:02 UTC (permalink / raw)
To: netfilter-devel, Pablo Neira Ayuso
Cc: Phil Sutter, Tomáš Doležal
With double quotes, $nft was being expanded to the default value even
in presence of the -H option.
Signed-off-by: Štěpán Němec <snemec@redhat.com>
Helped-by: Tomáš Doležal <todoleza@redhat.com>
Acked-by: Phil Sutter <phil@nwl.cc>
---
tests/monitor/run-tests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/monitor/run-tests.sh b/tests/monitor/run-tests.sh
index 5a736fc6..1fe613c7 100755
--- a/tests/monitor/run-tests.sh
+++ b/tests/monitor/run-tests.sh
@@ -19,7 +19,7 @@ if [ ! -d $testdir ]; then
echo "Failed to create test directory" >&2
exit 1
fi
-trap "rm -rf $testdir; $nft flush ruleset" EXIT
+trap 'rm -rf $testdir; $nft flush ruleset' EXIT
command_file=$(mktemp -p $testdir)
output_file=$(mktemp -p $testdir)
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tests: monitor: use correct $nft value in EXIT trap
2021-01-27 14:02 [PATCH] tests: monitor: use correct $nft value in EXIT trap Štěpán Němec
@ 2021-01-27 22:51 ` Phil Sutter
2021-01-28 7:30 ` Štěpán Němec
0 siblings, 1 reply; 3+ messages in thread
From: Phil Sutter @ 2021-01-27 22:51 UTC (permalink / raw)
To: Štěpán Němec
Cc: netfilter-devel, Pablo Neira Ayuso, Tomáš Doležal
On Wed, Jan 27, 2021 at 03:02:03PM +0100, Štěpán Němec wrote:
> With double quotes, $nft was being expanded to the default value even
> in presence of the -H option.
>
> Signed-off-by: Štěpán Němec <snemec@redhat.com>
> Helped-by: Tomáš Doležal <todoleza@redhat.com>
> Acked-by: Phil Sutter <phil@nwl.cc>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests: monitor: use correct $nft value in EXIT trap
2021-01-27 22:51 ` Phil Sutter
@ 2021-01-28 7:30 ` Štěpán Němec
0 siblings, 0 replies; 3+ messages in thread
From: Štěpán Němec @ 2021-01-28 7:30 UTC (permalink / raw)
To: Phil Sutter
Cc: netfilter-devel, Pablo Neira Ayuso, Tomáš Doležal
On Wed, 27 Jan 2021 23:51:34 +0100
Phil Sutter wrote:
> Applied, thanks!
Thank you, and I apologize to everyone involved for the lack of proper
tag prefix in the Subject; I only realized too late I should have added
the "nft".
--
Štěpán
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-28 7:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-27 14:02 [PATCH] tests: monitor: use correct $nft value in EXIT trap Štěpán Němec
2021-01-27 22:51 ` Phil Sutter
2021-01-28 7:30 ` Štěpán Němec
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.