[PATCH 1/2] ARM: dts: sti: add the spinor controller node within stih407-family

[PATCH 1/2] ARM: dts: sti: add the spinor controller node within stih407-family

[Alain Volmat]

add the spinor controller node within stih407-family.

Signed-off-by: Alain Volmat <avolmat@me.com>
---
 arch/arm/boot/dts/stih407-family.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index 23a1746f3baa..21f3347a91d6 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -616,6 +616,21 @@
 			st,lpc-mode = <ST_LPC_MODE_CLKSRC>;
 		};
 
+		spifsm: spifsm@9022000{
+			compatible = "st,spi-fsm";
+			reg = <0x9022000 0x1000>;
+			reg-names = "spi-fsm";
+			clocks = <&clk_s_c0_flexgen CLK_FLASH_PROMIP>;
+			clock-names = "emi_clk";
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_fsm>;
+			st,syscfg = <&syscfg_core>;
+			st,boot-device-reg = <0x8c4>;
+			st,boot-device-spi = <0x68>;
+
+			status = "disabled";
+		};
+
 		sata0: sata@9b20000 {
 			compatible = "st,ahci";
 			reg = <0x9b20000 0x1000>;
-- 
2.17.1

[PATCH 1/2] ARM: dts: sti: add the spinor controller node within stih407-family

[Alain Volmat]

add the spinor controller node within stih407-family.

Signed-off-by: Alain Volmat <avolmat@me.com>
---
 arch/arm/boot/dts/stih407-family.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index 23a1746f3baa..21f3347a91d6 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -616,6 +616,21 @@
 			st,lpc-mode = <ST_LPC_MODE_CLKSRC>;
 		};
 
+		spifsm: spifsm@9022000{
+			compatible = "st,spi-fsm";
+			reg = <0x9022000 0x1000>;
+			reg-names = "spi-fsm";
+			clocks = <&clk_s_c0_flexgen CLK_FLASH_PROMIP>;
+			clock-names = "emi_clk";
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_fsm>;
+			st,syscfg = <&syscfg_core>;
+			st,boot-device-reg = <0x8c4>;
+			st,boot-device-spi = <0x68>;
+
+			status = "disabled";
+		};
+
 		sata0: sata@9b20000 {
 			compatible = "st,ahci";
 			reg = <0x9b20000 0x1000>;
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] ARM: dts: sti: add the spinor controller node within stih407-family

[Arnd Bergmann]

On Thu, Jan 28, 2021 at 8:58 AM Alain Volmat <avolmat@me.com> wrote:
>
> add the spinor controller node within stih407-family.
>
> Signed-off-by: Alain Volmat <avolmat@me.com>

dts changes look ok to me, but please resend considering:

- Add a proper changelog text, rather than repeating the subject in the
  body. I'm sure you can find something useful to say about this change:
  Why do you need this controller? Why was this not originally part
  of the .dtsi file?

- Address your patches to the correct recipients. I see you have eight
  addresses on 'To:' and only yourself on 'Cc'. Try to find out who would
  be the person to pick up the patches and send it only to them, with
  others in Cc. soc@kernel.org should not be in either list here, because
  that just means we get it in patchwork for the soc tree, but these should
  be picked up by the platform maintainer and forward to us from there.

         Arnd

Re: [PATCH 1/2] ARM: dts: sti: add the spinor controller node within stih407-family

[Arnd Bergmann]

On Thu, Jan 28, 2021 at 8:58 AM Alain Volmat <avolmat@me.com> wrote:
>
> add the spinor controller node within stih407-family.
>
> Signed-off-by: Alain Volmat <avolmat@me.com>

dts changes look ok to me, but please resend considering:

- Add a proper changelog text, rather than repeating the subject in the
  body. I'm sure you can find something useful to say about this change:
  Why do you need this controller? Why was this not originally part
  of the .dtsi file?

- Address your patches to the correct recipients. I see you have eight
  addresses on 'To:' and only yourself on 'Cc'. Try to find out who would
  be the person to pick up the patches and send it only to them, with
  others in Cc. soc@kernel.org should not be in either list here, because
  that just means we get it in patchwork for the soc tree, but these should
  be picked up by the platform maintainer and forward to us from there.

         Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel