* [PATCH v5 0/3] Add support for Boundary Nitrogen8M Mini SBC @ 2021-01-18 11:15 ` Adrien Grassein 0 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-18 11:15 UTC (permalink / raw) Cc: shawnguo, krzk, robh+dt, s.hauer, kernel, festevam, linux-imx, devicetree, linux-kernel, linux-arm-kernel, Adrien Grassein Hello, This patch set aims is to add the support of the Nitrogen8M Mini SBC from Boundary Devices. Thanks, Update in v2: - Rewrite the dts (Remove the unused wlan and audio); - Remove useless definition; - Take in account review. Update in v3: - Take in account review. Update in v4: - Reorder definition in pmic Update in v5: - Take in account review. - Remove useless i2c groups Adrien Grassein (3): dt-bindings: arm: imx: add imx8mm nitrogen support arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support arm64: defconfig: Enable PF8x00 as builtin .../devicetree/bindings/arm/fsl.yaml | 1 + arch/arm64/boot/dts/freescale/Makefile | 1 + .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++ arch/arm64/configs/defconfig | 1 + 4 files changed, 398 insertions(+) create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts -- 2.25.1 ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v5 0/3] Add support for Boundary Nitrogen8M Mini SBC @ 2021-01-18 11:15 ` Adrien Grassein 0 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-18 11:15 UTC (permalink / raw) Cc: devicetree, shawnguo, s.hauer, linux-kernel, krzk, robh+dt, linux-imx, kernel, festevam, linux-arm-kernel, Adrien Grassein Hello, This patch set aims is to add the support of the Nitrogen8M Mini SBC from Boundary Devices. Thanks, Update in v2: - Rewrite the dts (Remove the unused wlan and audio); - Remove useless definition; - Take in account review. Update in v3: - Take in account review. Update in v4: - Reorder definition in pmic Update in v5: - Take in account review. - Remove useless i2c groups Adrien Grassein (3): dt-bindings: arm: imx: add imx8mm nitrogen support arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support arm64: defconfig: Enable PF8x00 as builtin .../devicetree/bindings/arm/fsl.yaml | 1 + arch/arm64/boot/dts/freescale/Makefile | 1 + .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++ arch/arm64/configs/defconfig | 1 + 4 files changed, 398 insertions(+) create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v5 1/3] dt-bindings: arm: imx: add imx8mm nitrogen support 2021-01-18 11:15 ` Adrien Grassein @ 2021-01-18 11:15 ` Adrien Grassein -1 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-18 11:15 UTC (permalink / raw) Cc: shawnguo, krzk, robh+dt, s.hauer, kernel, festevam, linux-imx, devicetree, linux-kernel, linux-arm-kernel, Adrien Grassein The Nitrogen8M Mini is an ARM based single board computer (SBC). Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> --- Documentation/devicetree/bindings/arm/fsl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 2ae66407e2aa..30e126c421f2 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -674,6 +674,7 @@ properties: items: - enum: - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit + - boundary,imx8mm-nitrogen8mm # i.MX8MM Nitrogen Board - fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board - fsl,imx8mm-evk # i.MX8MM EVK Board - gw,imx8mm-gw71xx-0x # i.MX8MM Gateworks Development Kit -- 2.25.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v5 1/3] dt-bindings: arm: imx: add imx8mm nitrogen support @ 2021-01-18 11:15 ` Adrien Grassein 0 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-18 11:15 UTC (permalink / raw) Cc: devicetree, shawnguo, s.hauer, linux-kernel, krzk, robh+dt, linux-imx, kernel, festevam, linux-arm-kernel, Adrien Grassein The Nitrogen8M Mini is an ARM based single board computer (SBC). Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> --- Documentation/devicetree/bindings/arm/fsl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 2ae66407e2aa..30e126c421f2 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -674,6 +674,7 @@ properties: items: - enum: - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit + - boundary,imx8mm-nitrogen8mm # i.MX8MM Nitrogen Board - fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board - fsl,imx8mm-evk # i.MX8MM EVK Board - gw,imx8mm-gw71xx-0x # i.MX8MM Gateworks Development Kit -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support 2021-01-18 11:15 ` Adrien Grassein @ 2021-01-18 11:15 ` Adrien Grassein -1 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-18 11:15 UTC (permalink / raw) Cc: shawnguo, krzk, robh+dt, s.hauer, kernel, festevam, linux-imx, devicetree, linux-kernel, linux-arm-kernel, Adrien Grassein Tested with a basic Build Root configuration booting from sdcard. Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> --- arch/arm64/boot/dts/freescale/Makefile | 1 + .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++ 2 files changed, 396 insertions(+) create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile index 38559943c15d..398b5cb4f3e2 100644 --- a/arch/arm64/boot/dts/freescale/Makefile +++ b/arch/arm64/boot/dts/freescale/Makefile @@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mq-nitrogen.dtb +dtb-$(CONFIG_ARCH_MXC) += imx8mm-nitrogen8mm_rev2.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mq-phanbell.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file mode 100644 index 000000000000..755088387ea5 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts @@ -0,0 +1,395 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Device Tree file for Boundary Devices i.MX8MMini Nitrogen8MM Rev2 board. + * Adrien Grassein <adrien.grassein@gmail.com.com> + */ +/dts-v1/; +#include "imx8mm.dtsi" + +/ { + model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; + compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; +}; + +&A53_0 { + cpu-supply = <®_sw3>; +}; + +&A53_1 { + cpu-supply = <®_sw3>; +}; + +&A53_2 { + cpu-supply = <®_sw3>; +}; + +&A53_3 { + cpu-supply = <®_sw3>; +}; + +&fec1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_fec1>; + phy-mode = "rgmii-id"; + phy-handle = <ðphy0>; + fsl,magic-packet; + status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy0: ethernet-phy@4 { + compatible = "ethernet-phy-id004d.d072", + "ethernet-phy-ieee802.3-c22"; + reg = <4>; + interrupts-extended = <&gpio3 16 IRQ_TYPE_LEVEL_LOW>; + }; + }; +}; + +&i2c1 { + clock-frequency = <400000>; + pinctrl-names = "default", "gpio"; + pinctrl-0 = <&pinctrl_i2c1>; + status = "okay"; + + pmic@8 { + compatible = "nxp,pf8121a"; + reg = <0x8>; + + regulators { + reg_ldo1: ldo1 { + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <5000000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_ldo2: ldo2 { + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <5000000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_ldo3: ldo3 { + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <5000000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_ldo4: ldo4 { + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <5000000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_buck1: buck1 { + regulator-min-microvolt = <400000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_buck2: buck2 { + regulator-min-microvolt = <400000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_sw3: buck3 { + regulator-min-microvolt = <400000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_buck4: buck4 { + regulator-min-microvolt = <400000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_buck5: buck5 { + regulator-min-microvolt = <400000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_buck6: buck6 { + regulator-min-microvolt = <400000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_buck7: buck7 { + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_vsnvs: vsnvs { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + }; + }; +}; + +&i2c3 { + clock-frequency = <100000>; + pinctrl-names = "default", "gpio"; + pinctrl-0 = <&pinctrl_i2c3>; + status = "okay"; + + i2cmux@70 { + compatible = "nxp,pca9540"; + reg = <0x70>; + #address-cells = <1>; + #size-cells = <0>; + + i2c3 { + reg = <0>; + #address-cells = <1>; + #size-cells = <0>; + + rtc@68 { + compatible = "microcrystal,rv4162"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c3a_rv4162>; + reg = <0x68>; + interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>; + wakeup-source; + }; + }; + }; +}; + +/* console */ +&uart2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_uart2>; + assigned-clocks = <&clk IMX8MM_CLK_UART2>; + assigned-clock-parents = <&clk IMX8MM_CLK_24M>; + status = "okay"; +}; + +/* eMMC */ +&usdhc1 { + bus-width = <8>; + sdhci-caps-mask = <0x80000000 0x0>; + non-removable; + pinctrl-names = "default", "state_100mhz", "state_200mhz"; + pinctrl-0 = <&pinctrl_usdhc1>; + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; + status = "okay"; +}; + +/* sdcard */ +&usdhc2 { + bus-width = <4>; + cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>; + pinctrl-names = "default", "state_100mhz", "state_200mhz"; + pinctrl-0 = <&pinctrl_usdhc2>; + pinctrl-1 = <&pinctrl_usdhc2_100mhz>; + pinctrl-2 = <&pinctrl_usdhc2_200mhz>; + vqmmc-supply = <®_ldo2>; + status = "okay"; +}; + +&wdog1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_wdog>; + fsl,ext-reset-output; + status = "okay"; +}; + +&iomuxc { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_hog>; + + pinctrl_fec1: fec1grp { + fsl,pins = < + MX8MM_IOMUXC_ENET_MDC_ENET1_MDC 0x3 + MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO 0x3 + MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3 0x1f + MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2 0x1f + MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1 0x1f + MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0 0x1f + MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3 0x91 + MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2 0x91 + MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1 0x91 + MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0 0x91 + MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f + MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91 + MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91 + MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f + MX8MM_IOMUXC_NAND_READY_B_GPIO3_IO16 0x159 + >; + }; + + pinctrl_hog: hoggrp { + fsl,pins = < + MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x09 + MX8MM_IOMUXC_GPIO1_IO08_GPIO1_IO8 0x09 + >; + }; + + pinctrl_i2c1: i2c1grp { + fsl,pins = < + MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3 + MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3 + >; + }; + + pinctrl_i2c3: i2c3grp { + fsl,pins = < + MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3 + MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3 + >; + }; + + pinctrl_i2c3a_rv4162: i2c3a-rv4162grp { + fsl,pins = < + MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x1c0 + >; + }; + + pinctrl_uart2: uart2grp { + fsl,pins = < + MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140 + MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140 + >; + }; + + pinctrl_usdhc1: usdhc1grp { + fsl,pins = < + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x190 + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d0 + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d0 + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d0 + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d0 + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d0 + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d0 + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d0 + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d0 + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d0 + MX8MM_IOMUXC_SD1_RESET_B_GPIO2_IO10 0x141 + >; + }; + + pinctrl_usdhc1_100mhz: usdhc1-100mhz-grp { + fsl,pins = < + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x194 + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d4 + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d4 + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d4 + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d4 + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d4 + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d4 + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d4 + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d4 + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d4 + >; + }; + + pinctrl_usdhc1_200mhz: usdhc1-200mhz-grp { + fsl,pins = < + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x196 + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d6 + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d6 + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d6 + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d6 + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d6 + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d6 + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d6 + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d6 + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d6 + >; + }; + + pinctrl_usdhc2: usdhc2grp { + fsl,pins = < + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x190 + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d0 + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d0 + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d0 + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d0 + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d0 + MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12 0x1c4 + >; + }; + + pinctrl_usdhc2_100mhz: usdhc2-100mhz-grp { + fsl,pins = < + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x194 + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d4 + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d4 + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d4 + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d4 + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d4 + >; + }; + + pinctrl_usdhc2_200mhz: usdhc2-200mhz-grp { + fsl,pins = < + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x196 + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d6 + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d6 + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d6 + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d6 + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d6 + >; + }; + + pinctrl_usdhc3: usdhc3grp { + fsl,pins = < + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x190 + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d0 + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d0 + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d0 + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d0 + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d0 + MX8MM_IOMUXC_GPIO1_IO00_ANAMIX_REF_CLK_32K 0x03 + >; + }; + + pinctrl_usdhc3_100mhz: usdhc3-100mhz-grp { + fsl,pins = < + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x194 + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d4 + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d4 + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d4 + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d4 + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d4 + >; + }; + + pinctrl_usdhc3_200mhz: usdhc3-200mhz-grp { + fsl,pins = < + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x196 + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d6 + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d6 + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d6 + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d6 + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d6 + >; + }; + + pinctrl_wdog: wdoggrp { + fsl,pins = < + MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x140 + >; + }; +}; -- 2.25.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support @ 2021-01-18 11:15 ` Adrien Grassein 0 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-18 11:15 UTC (permalink / raw) Cc: devicetree, shawnguo, s.hauer, linux-kernel, krzk, robh+dt, linux-imx, kernel, festevam, linux-arm-kernel, Adrien Grassein Tested with a basic Build Root configuration booting from sdcard. Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> --- arch/arm64/boot/dts/freescale/Makefile | 1 + .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++ 2 files changed, 396 insertions(+) create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile index 38559943c15d..398b5cb4f3e2 100644 --- a/arch/arm64/boot/dts/freescale/Makefile +++ b/arch/arm64/boot/dts/freescale/Makefile @@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mq-nitrogen.dtb +dtb-$(CONFIG_ARCH_MXC) += imx8mm-nitrogen8mm_rev2.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mq-phanbell.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts new file mode 100644 index 000000000000..755088387ea5 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts @@ -0,0 +1,395 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Device Tree file for Boundary Devices i.MX8MMini Nitrogen8MM Rev2 board. + * Adrien Grassein <adrien.grassein@gmail.com.com> + */ +/dts-v1/; +#include "imx8mm.dtsi" + +/ { + model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; + compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; +}; + +&A53_0 { + cpu-supply = <®_sw3>; +}; + +&A53_1 { + cpu-supply = <®_sw3>; +}; + +&A53_2 { + cpu-supply = <®_sw3>; +}; + +&A53_3 { + cpu-supply = <®_sw3>; +}; + +&fec1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_fec1>; + phy-mode = "rgmii-id"; + phy-handle = <ðphy0>; + fsl,magic-packet; + status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy0: ethernet-phy@4 { + compatible = "ethernet-phy-id004d.d072", + "ethernet-phy-ieee802.3-c22"; + reg = <4>; + interrupts-extended = <&gpio3 16 IRQ_TYPE_LEVEL_LOW>; + }; + }; +}; + +&i2c1 { + clock-frequency = <400000>; + pinctrl-names = "default", "gpio"; + pinctrl-0 = <&pinctrl_i2c1>; + status = "okay"; + + pmic@8 { + compatible = "nxp,pf8121a"; + reg = <0x8>; + + regulators { + reg_ldo1: ldo1 { + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <5000000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_ldo2: ldo2 { + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <5000000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_ldo3: ldo3 { + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <5000000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_ldo4: ldo4 { + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <5000000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_buck1: buck1 { + regulator-min-microvolt = <400000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_buck2: buck2 { + regulator-min-microvolt = <400000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_sw3: buck3 { + regulator-min-microvolt = <400000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_buck4: buck4 { + regulator-min-microvolt = <400000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_buck5: buck5 { + regulator-min-microvolt = <400000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_buck6: buck6 { + regulator-min-microvolt = <400000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_buck7: buck7 { + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_vsnvs: vsnvs { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + }; + }; +}; + +&i2c3 { + clock-frequency = <100000>; + pinctrl-names = "default", "gpio"; + pinctrl-0 = <&pinctrl_i2c3>; + status = "okay"; + + i2cmux@70 { + compatible = "nxp,pca9540"; + reg = <0x70>; + #address-cells = <1>; + #size-cells = <0>; + + i2c3 { + reg = <0>; + #address-cells = <1>; + #size-cells = <0>; + + rtc@68 { + compatible = "microcrystal,rv4162"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c3a_rv4162>; + reg = <0x68>; + interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>; + wakeup-source; + }; + }; + }; +}; + +/* console */ +&uart2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_uart2>; + assigned-clocks = <&clk IMX8MM_CLK_UART2>; + assigned-clock-parents = <&clk IMX8MM_CLK_24M>; + status = "okay"; +}; + +/* eMMC */ +&usdhc1 { + bus-width = <8>; + sdhci-caps-mask = <0x80000000 0x0>; + non-removable; + pinctrl-names = "default", "state_100mhz", "state_200mhz"; + pinctrl-0 = <&pinctrl_usdhc1>; + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; + status = "okay"; +}; + +/* sdcard */ +&usdhc2 { + bus-width = <4>; + cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>; + pinctrl-names = "default", "state_100mhz", "state_200mhz"; + pinctrl-0 = <&pinctrl_usdhc2>; + pinctrl-1 = <&pinctrl_usdhc2_100mhz>; + pinctrl-2 = <&pinctrl_usdhc2_200mhz>; + vqmmc-supply = <®_ldo2>; + status = "okay"; +}; + +&wdog1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_wdog>; + fsl,ext-reset-output; + status = "okay"; +}; + +&iomuxc { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_hog>; + + pinctrl_fec1: fec1grp { + fsl,pins = < + MX8MM_IOMUXC_ENET_MDC_ENET1_MDC 0x3 + MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO 0x3 + MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3 0x1f + MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2 0x1f + MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1 0x1f + MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0 0x1f + MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3 0x91 + MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2 0x91 + MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1 0x91 + MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0 0x91 + MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f + MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91 + MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91 + MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f + MX8MM_IOMUXC_NAND_READY_B_GPIO3_IO16 0x159 + >; + }; + + pinctrl_hog: hoggrp { + fsl,pins = < + MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x09 + MX8MM_IOMUXC_GPIO1_IO08_GPIO1_IO8 0x09 + >; + }; + + pinctrl_i2c1: i2c1grp { + fsl,pins = < + MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3 + MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3 + >; + }; + + pinctrl_i2c3: i2c3grp { + fsl,pins = < + MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3 + MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3 + >; + }; + + pinctrl_i2c3a_rv4162: i2c3a-rv4162grp { + fsl,pins = < + MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x1c0 + >; + }; + + pinctrl_uart2: uart2grp { + fsl,pins = < + MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140 + MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140 + >; + }; + + pinctrl_usdhc1: usdhc1grp { + fsl,pins = < + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x190 + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d0 + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d0 + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d0 + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d0 + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d0 + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d0 + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d0 + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d0 + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d0 + MX8MM_IOMUXC_SD1_RESET_B_GPIO2_IO10 0x141 + >; + }; + + pinctrl_usdhc1_100mhz: usdhc1-100mhz-grp { + fsl,pins = < + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x194 + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d4 + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d4 + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d4 + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d4 + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d4 + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d4 + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d4 + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d4 + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d4 + >; + }; + + pinctrl_usdhc1_200mhz: usdhc1-200mhz-grp { + fsl,pins = < + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x196 + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d6 + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d6 + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d6 + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d6 + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d6 + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d6 + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d6 + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d6 + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d6 + >; + }; + + pinctrl_usdhc2: usdhc2grp { + fsl,pins = < + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x190 + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d0 + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d0 + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d0 + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d0 + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d0 + MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12 0x1c4 + >; + }; + + pinctrl_usdhc2_100mhz: usdhc2-100mhz-grp { + fsl,pins = < + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x194 + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d4 + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d4 + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d4 + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d4 + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d4 + >; + }; + + pinctrl_usdhc2_200mhz: usdhc2-200mhz-grp { + fsl,pins = < + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x196 + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d6 + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d6 + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d6 + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d6 + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d6 + >; + }; + + pinctrl_usdhc3: usdhc3grp { + fsl,pins = < + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x190 + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d0 + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d0 + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d0 + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d0 + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d0 + MX8MM_IOMUXC_GPIO1_IO00_ANAMIX_REF_CLK_32K 0x03 + >; + }; + + pinctrl_usdhc3_100mhz: usdhc3-100mhz-grp { + fsl,pins = < + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x194 + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d4 + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d4 + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d4 + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d4 + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d4 + >; + }; + + pinctrl_usdhc3_200mhz: usdhc3-200mhz-grp { + fsl,pins = < + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x196 + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d6 + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d6 + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d6 + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d6 + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d6 + >; + }; + + pinctrl_wdog: wdoggrp { + fsl,pins = < + MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x140 + >; + }; +}; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support 2021-01-18 11:15 ` Adrien Grassein @ 2021-01-28 16:18 ` Marco Felsch -1 siblings, 0 replies; 18+ messages in thread From: Marco Felsch @ 2021-01-28 16:18 UTC (permalink / raw) To: Adrien Grassein Cc: devicetree, shawnguo, s.hauer, linux-kernel, krzk, robh+dt, linux-imx, kernel, festevam, linux-arm-kernel Hi Adrien, thanks for the patch. I've made only a few comments inline. On 21-01-18 12:15, Adrien Grassein wrote: > Tested with a basic Build Root configuration booting from sdcard. > > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++ > 2 files changed, 396 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 38559943c15d..398b5cb4f3e2 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-nitrogen.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-nitrogen8mm_rev2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-phanbell.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > new file mode 100644 > index 000000000000..755088387ea5 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > @@ -0,0 +1,395 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Device Tree file for Boundary Devices i.MX8MMini Nitrogen8MM Rev2 board. > + * Adrien Grassein <adrien.grassein@gmail.com.com> > + */ > +/dts-v1/; > +#include "imx8mm.dtsi" > + > +/ { > + model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; > + compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; > +}; > + > +&A53_0 { > + cpu-supply = <®_sw3>; > +}; > + > +&A53_1 { > + cpu-supply = <®_sw3>; > +}; > + > +&A53_2 { > + cpu-supply = <®_sw3>; > +}; > + > +&A53_3 { > + cpu-supply = <®_sw3>; > +}; > + > +&fec1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_fec1>; > + phy-mode = "rgmii-id"; > + phy-handle = <ðphy0>; > + fsl,magic-packet; > + status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy0: ethernet-phy@4 { > + compatible = "ethernet-phy-id004d.d072", ^ Do we really need to add the id here? > + "ethernet-phy-ieee802.3-c22"; > + reg = <4>; > + interrupts-extended = <&gpio3 16 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +}; > + > +&i2c1 { > + clock-frequency = <400000>; ^ Is the i2c errata fixed on the imx8? > + pinctrl-names = "default", "gpio"; ^ no pinctrl for gpio. > + pinctrl-0 = <&pinctrl_i2c1>; > + status = "okay"; > + > + pmic@8 { > + compatible = "nxp,pf8121a"; > + reg = <0x8>; > + > + regulators { > + reg_ldo1: ldo1 { ^ alignment > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_ldo2: ldo2 { > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_ldo3: ldo3 { > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_ldo4: ldo4 { > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_buck1: buck1 { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_buck2: buck2 { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_sw3: buck3 { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_buck4: buck4 { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_buck5: buck5 { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_buck6: buck6 { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_buck7: buck7 { > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_vsnvs: vsnvs { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; Do we really need to have all regulators marked as always-on? > + }; > + }; > +}; > + > +&i2c3 { > + clock-frequency = <100000>; > + pinctrl-names = "default", "gpio"; > + pinctrl-0 = <&pinctrl_i2c3>; > + status = "okay"; > + > + i2cmux@70 { > + compatible = "nxp,pca9540"; > + reg = <0x70>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + i2c3 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@68 { > + compatible = "microcrystal,rv4162"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c3a_rv4162>; > + reg = <0x68>; reg should be the 2nd property, after the compatible. > + interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>; > + wakeup-source; > + }; > + }; > + }; > +}; > + > +/* console */ > +&uart2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart2>; > + assigned-clocks = <&clk IMX8MM_CLK_UART2>; > + assigned-clock-parents = <&clk IMX8MM_CLK_24M>; > + status = "okay"; > +}; > + > +/* eMMC */ > +&usdhc1 { > + bus-width = <8>; > + sdhci-caps-mask = <0x80000000 0x0>; ^ This is a SD host controller property according the doc. > + non-removable; > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > + pinctrl-0 = <&pinctrl_usdhc1>; > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; > + status = "okay"; > +}; > + > +/* sdcard */ > +&usdhc2 { > + bus-width = <4>; > + cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > + pinctrl-0 = <&pinctrl_usdhc2>; > + pinctrl-1 = <&pinctrl_usdhc2_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc2_200mhz>; > + vqmmc-supply = <®_ldo2>; > + status = "okay"; > +}; > + > +&wdog1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > + status = "okay"; > +}; > + > +&iomuxc { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_hog>; It would be nice to avoid such hog's. Instead those gpios should get configured by the device(s) using those. Regards, Marco > + > + pinctrl_fec1: fec1grp { > + fsl,pins = < > + MX8MM_IOMUXC_ENET_MDC_ENET1_MDC 0x3 > + MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO 0x3 > + MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3 0x1f > + MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2 0x1f > + MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1 0x1f > + MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0 0x1f > + MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3 0x91 > + MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2 0x91 > + MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1 0x91 > + MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0 0x91 > + MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f > + MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91 > + MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91 > + MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f > + MX8MM_IOMUXC_NAND_READY_B_GPIO3_IO16 0x159 > + >; > + }; > + > + pinctrl_hog: hoggrp { > + fsl,pins = < > + MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x09 > + MX8MM_IOMUXC_GPIO1_IO08_GPIO1_IO8 0x09 > + >; > + }; > + > + pinctrl_i2c1: i2c1grp { > + fsl,pins = < > + MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3 > + MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3 > + >; > + }; > + > + pinctrl_i2c3: i2c3grp { > + fsl,pins = < > + MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3 > + MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3 > + >; > + }; > + > + pinctrl_i2c3a_rv4162: i2c3a-rv4162grp { > + fsl,pins = < > + MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x1c0 > + >; > + }; > + > + pinctrl_uart2: uart2grp { > + fsl,pins = < > + MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140 > + MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140 > + >; > + }; > + > + pinctrl_usdhc1: usdhc1grp { > + fsl,pins = < > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x190 > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d0 > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d0 > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d0 > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d0 > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d0 > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d0 > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d0 > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d0 > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d0 > + MX8MM_IOMUXC_SD1_RESET_B_GPIO2_IO10 0x141 > + >; > + }; > + > + pinctrl_usdhc1_100mhz: usdhc1-100mhz-grp { > + fsl,pins = < > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x194 > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d4 > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d4 > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d4 > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d4 > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d4 > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d4 > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d4 > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d4 > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d4 > + >; > + }; > + > + pinctrl_usdhc1_200mhz: usdhc1-200mhz-grp { > + fsl,pins = < > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x196 > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d6 > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d6 > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d6 > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d6 > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d6 > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d6 > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d6 > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d6 > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d6 > + >; > + }; > + > + pinctrl_usdhc2: usdhc2grp { > + fsl,pins = < > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x190 > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d0 > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d0 > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d0 > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d0 > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d0 > + MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12 0x1c4 > + >; > + }; > + > + pinctrl_usdhc2_100mhz: usdhc2-100mhz-grp { > + fsl,pins = < > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x194 > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d4 > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d4 > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d4 > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d4 > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d4 > + >; > + }; > + > + pinctrl_usdhc2_200mhz: usdhc2-200mhz-grp { > + fsl,pins = < > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x196 > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d6 > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d6 > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d6 > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d6 > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d6 > + >; > + }; > + > + pinctrl_usdhc3: usdhc3grp { > + fsl,pins = < > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x190 > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d0 > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d0 > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d0 > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d0 > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d0 > + MX8MM_IOMUXC_GPIO1_IO00_ANAMIX_REF_CLK_32K 0x03 > + >; > + }; > + > + pinctrl_usdhc3_100mhz: usdhc3-100mhz-grp { > + fsl,pins = < > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x194 > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d4 > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d4 > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d4 > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d4 > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d4 > + >; > + }; > + > + pinctrl_usdhc3_200mhz: usdhc3-200mhz-grp { > + fsl,pins = < > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x196 > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d6 > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d6 > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d6 > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d6 > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d6 > + >; > + }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x140 > + >; > + }; > +}; > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support @ 2021-01-28 16:18 ` Marco Felsch 0 siblings, 0 replies; 18+ messages in thread From: Marco Felsch @ 2021-01-28 16:18 UTC (permalink / raw) To: Adrien Grassein Cc: devicetree, festevam, s.hauer, linux-kernel, krzk, robh+dt, linux-imx, kernel, shawnguo, linux-arm-kernel Hi Adrien, thanks for the patch. I've made only a few comments inline. On 21-01-18 12:15, Adrien Grassein wrote: > Tested with a basic Build Root configuration booting from sdcard. > > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++ > 2 files changed, 396 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 38559943c15d..398b5cb4f3e2 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-nitrogen.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-nitrogen8mm_rev2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-phanbell.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > new file mode 100644 > index 000000000000..755088387ea5 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > @@ -0,0 +1,395 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Device Tree file for Boundary Devices i.MX8MMini Nitrogen8MM Rev2 board. > + * Adrien Grassein <adrien.grassein@gmail.com.com> > + */ > +/dts-v1/; > +#include "imx8mm.dtsi" > + > +/ { > + model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; > + compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; > +}; > + > +&A53_0 { > + cpu-supply = <®_sw3>; > +}; > + > +&A53_1 { > + cpu-supply = <®_sw3>; > +}; > + > +&A53_2 { > + cpu-supply = <®_sw3>; > +}; > + > +&A53_3 { > + cpu-supply = <®_sw3>; > +}; > + > +&fec1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_fec1>; > + phy-mode = "rgmii-id"; > + phy-handle = <ðphy0>; > + fsl,magic-packet; > + status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy0: ethernet-phy@4 { > + compatible = "ethernet-phy-id004d.d072", ^ Do we really need to add the id here? > + "ethernet-phy-ieee802.3-c22"; > + reg = <4>; > + interrupts-extended = <&gpio3 16 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +}; > + > +&i2c1 { > + clock-frequency = <400000>; ^ Is the i2c errata fixed on the imx8? > + pinctrl-names = "default", "gpio"; ^ no pinctrl for gpio. > + pinctrl-0 = <&pinctrl_i2c1>; > + status = "okay"; > + > + pmic@8 { > + compatible = "nxp,pf8121a"; > + reg = <0x8>; > + > + regulators { > + reg_ldo1: ldo1 { ^ alignment > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_ldo2: ldo2 { > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_ldo3: ldo3 { > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_ldo4: ldo4 { > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_buck1: buck1 { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_buck2: buck2 { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_sw3: buck3 { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_buck4: buck4 { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_buck5: buck5 { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_buck6: buck6 { > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_buck7: buck7 { > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_vsnvs: vsnvs { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; Do we really need to have all regulators marked as always-on? > + }; > + }; > +}; > + > +&i2c3 { > + clock-frequency = <100000>; > + pinctrl-names = "default", "gpio"; > + pinctrl-0 = <&pinctrl_i2c3>; > + status = "okay"; > + > + i2cmux@70 { > + compatible = "nxp,pca9540"; > + reg = <0x70>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + i2c3 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@68 { > + compatible = "microcrystal,rv4162"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c3a_rv4162>; > + reg = <0x68>; reg should be the 2nd property, after the compatible. > + interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>; > + wakeup-source; > + }; > + }; > + }; > +}; > + > +/* console */ > +&uart2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart2>; > + assigned-clocks = <&clk IMX8MM_CLK_UART2>; > + assigned-clock-parents = <&clk IMX8MM_CLK_24M>; > + status = "okay"; > +}; > + > +/* eMMC */ > +&usdhc1 { > + bus-width = <8>; > + sdhci-caps-mask = <0x80000000 0x0>; ^ This is a SD host controller property according the doc. > + non-removable; > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > + pinctrl-0 = <&pinctrl_usdhc1>; > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; > + status = "okay"; > +}; > + > +/* sdcard */ > +&usdhc2 { > + bus-width = <4>; > + cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > + pinctrl-0 = <&pinctrl_usdhc2>; > + pinctrl-1 = <&pinctrl_usdhc2_100mhz>; > + pinctrl-2 = <&pinctrl_usdhc2_200mhz>; > + vqmmc-supply = <®_ldo2>; > + status = "okay"; > +}; > + > +&wdog1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > + status = "okay"; > +}; > + > +&iomuxc { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_hog>; It would be nice to avoid such hog's. Instead those gpios should get configured by the device(s) using those. Regards, Marco > + > + pinctrl_fec1: fec1grp { > + fsl,pins = < > + MX8MM_IOMUXC_ENET_MDC_ENET1_MDC 0x3 > + MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO 0x3 > + MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3 0x1f > + MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2 0x1f > + MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1 0x1f > + MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0 0x1f > + MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3 0x91 > + MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2 0x91 > + MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1 0x91 > + MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0 0x91 > + MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f > + MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91 > + MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91 > + MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f > + MX8MM_IOMUXC_NAND_READY_B_GPIO3_IO16 0x159 > + >; > + }; > + > + pinctrl_hog: hoggrp { > + fsl,pins = < > + MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x09 > + MX8MM_IOMUXC_GPIO1_IO08_GPIO1_IO8 0x09 > + >; > + }; > + > + pinctrl_i2c1: i2c1grp { > + fsl,pins = < > + MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3 > + MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3 > + >; > + }; > + > + pinctrl_i2c3: i2c3grp { > + fsl,pins = < > + MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3 > + MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3 > + >; > + }; > + > + pinctrl_i2c3a_rv4162: i2c3a-rv4162grp { > + fsl,pins = < > + MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x1c0 > + >; > + }; > + > + pinctrl_uart2: uart2grp { > + fsl,pins = < > + MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140 > + MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140 > + >; > + }; > + > + pinctrl_usdhc1: usdhc1grp { > + fsl,pins = < > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x190 > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d0 > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d0 > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d0 > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d0 > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d0 > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d0 > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d0 > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d0 > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d0 > + MX8MM_IOMUXC_SD1_RESET_B_GPIO2_IO10 0x141 > + >; > + }; > + > + pinctrl_usdhc1_100mhz: usdhc1-100mhz-grp { > + fsl,pins = < > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x194 > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d4 > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d4 > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d4 > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d4 > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d4 > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d4 > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d4 > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d4 > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d4 > + >; > + }; > + > + pinctrl_usdhc1_200mhz: usdhc1-200mhz-grp { > + fsl,pins = < > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x196 > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d6 > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d6 > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d6 > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d6 > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d6 > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d6 > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d6 > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d6 > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d6 > + >; > + }; > + > + pinctrl_usdhc2: usdhc2grp { > + fsl,pins = < > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x190 > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d0 > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d0 > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d0 > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d0 > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d0 > + MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12 0x1c4 > + >; > + }; > + > + pinctrl_usdhc2_100mhz: usdhc2-100mhz-grp { > + fsl,pins = < > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x194 > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d4 > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d4 > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d4 > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d4 > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d4 > + >; > + }; > + > + pinctrl_usdhc2_200mhz: usdhc2-200mhz-grp { > + fsl,pins = < > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x196 > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d6 > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d6 > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d6 > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d6 > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d6 > + >; > + }; > + > + pinctrl_usdhc3: usdhc3grp { > + fsl,pins = < > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x190 > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d0 > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d0 > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d0 > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d0 > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d0 > + MX8MM_IOMUXC_GPIO1_IO00_ANAMIX_REF_CLK_32K 0x03 > + >; > + }; > + > + pinctrl_usdhc3_100mhz: usdhc3-100mhz-grp { > + fsl,pins = < > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x194 > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d4 > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d4 > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d4 > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d4 > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d4 > + >; > + }; > + > + pinctrl_usdhc3_200mhz: usdhc3-200mhz-grp { > + fsl,pins = < > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x196 > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d6 > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d6 > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d6 > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d6 > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d6 > + >; > + }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x140 > + >; > + }; > +}; > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support 2021-01-28 16:18 ` Marco Felsch @ 2021-01-28 17:23 ` Adrien Grassein -1 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-28 17:23 UTC (permalink / raw) To: Marco Felsch Cc: DTML, Shawn Guo, Sascha Hauer, linux-kernel, Krzysztof Kozlowski, Rob Herring, dl-linux-imx, Sascha Hauer, Fabio Estevam, linux-arm-kernel Hi Marco, Thanks for your time. Le jeu. 28 janv. 2021 à 17:18, Marco Felsch <m.felsch@pengutronix.de> a écrit : > > Hi Adrien, > > thanks for the patch. I've made only a few comments inline. > > On 21-01-18 12:15, Adrien Grassein wrote: > > Tested with a basic Build Root configuration booting from sdcard. > > > > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++ > > 2 files changed, 396 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > index 38559943c15d..398b5cb4f3e2 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-nitrogen.dtb > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-nitrogen8mm_rev2.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-phanbell.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > new file mode 100644 > > index 000000000000..755088387ea5 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > @@ -0,0 +1,395 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Device Tree file for Boundary Devices i.MX8MMini Nitrogen8MM Rev2 board. > > + * Adrien Grassein <adrien.grassein@gmail.com.com> > > + */ > > +/dts-v1/; > > +#include "imx8mm.dtsi" > > + > > +/ { > > + model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; > > + compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; > > +}; > > + > > +&A53_0 { > > + cpu-supply = <®_sw3>; > > +}; > > + > > +&A53_1 { > > + cpu-supply = <®_sw3>; > > +}; > > + > > +&A53_2 { > > + cpu-supply = <®_sw3>; > > +}; > > + > > +&A53_3 { > > + cpu-supply = <®_sw3>; > > +}; > > + > > +&fec1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_fec1>; > > + phy-mode = "rgmii-id"; > > + phy-handle = <ðphy0>; > > + fsl,magic-packet; > > + status = "okay"; > > + > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ethphy0: ethernet-phy@4 { > > + compatible = "ethernet-phy-id004d.d072", > ^ > Do we really need to add the id here? Yes, I don't know why, but the chip it's not recognized via the mdio interface. I will do further tests but I think it's needed. > > + "ethernet-phy-ieee802.3-c22"; > > + reg = <4>; > > + interrupts-extended = <&gpio3 16 IRQ_TYPE_LEVEL_LOW>; > > + }; > > + }; > > +}; > > + > > +&i2c1 { > > + clock-frequency = <400000>; > ^ > Is the i2c errata fixed on the imx8? I don't know. What is this errata? Should I set a lower speed for the particular i2c? > > > + pinctrl-names = "default", "gpio"; > ^ > no pinctrl for gpio. Yes, it's a bug, thanks > > + pinctrl-0 = <&pinctrl_i2c1>; > > + status = "okay"; > > + > > + pmic@8 { > > + compatible = "nxp,pf8121a"; > > + reg = <0x8>; > > + > > + regulators { > > + reg_ldo1: ldo1 { > ^ > alignment OK > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <5000000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_ldo2: ldo2 { > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <5000000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_ldo3: ldo3 { > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <5000000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_ldo4: ldo4 { > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <5000000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_buck1: buck1 { > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_buck2: buck2 { > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_sw3: buck3 { > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_buck4: buck4 { > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_buck5: buck5 { > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_buck6: buck6 { > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_buck7: buck7 { > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_vsnvs: vsnvs { > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > Do we really need to have all regulators marked as always-on? > I used the definition present on the example. I will remove this (for the one I don't use). > > + }; > > + }; > > +}; > > + > > +&i2c3 { > > + clock-frequency = <100000>; > > + pinctrl-names = "default", "gpio"; > > + pinctrl-0 = <&pinctrl_i2c3>; > > + status = "okay"; > > + > > + i2cmux@70 { > > + compatible = "nxp,pca9540"; > > + reg = <0x70>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + i2c3 { > > + reg = <0>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + rtc@68 { > > + compatible = "microcrystal,rv4162"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_i2c3a_rv4162>; > > + reg = <0x68>; > > reg should be the 2nd property, after the compatible. > OK. > > + interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>; > > + wakeup-source; > > + }; > > + }; > > + }; > > +}; > > + > > +/* console */ > > +&uart2 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_uart2>; > > + assigned-clocks = <&clk IMX8MM_CLK_UART2>; > > + assigned-clock-parents = <&clk IMX8MM_CLK_24M>; > > + status = "okay"; > > +}; > > + > > +/* eMMC */ > > +&usdhc1 { > > + bus-width = <8>; > > + sdhci-caps-mask = <0x80000000 0x0>; > ^ > This is a SD host controller property according the doc. > Yes, I don't understand the point, sorry. This property is read by the host driver, but should be present here (like in some other dts). > > + non-removable; > > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > > + pinctrl-0 = <&pinctrl_usdhc1>; > > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; > > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; > > + status = "okay"; > > +}; > > + > > +/* sdcard */ > > +&usdhc2 { > > + bus-width = <4>; > > + cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>; > > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > > + pinctrl-0 = <&pinctrl_usdhc2>; > > + pinctrl-1 = <&pinctrl_usdhc2_100mhz>; > > + pinctrl-2 = <&pinctrl_usdhc2_200mhz>; > > + vqmmc-supply = <®_ldo2>; > > + status = "okay"; > > +}; > > + > > +&wdog1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_wdog>; > > + fsl,ext-reset-output; > > + status = "okay"; > > +}; > > + > > +&iomuxc { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_hog>; > > It would be nice to avoid such hog's. Instead those gpios should get > configured by the device(s) using those. > Once again (sorry), I don't understand the point. I did this like any other imx8 board (imx8mq-nitrogem for example). > Regards, > Marco > > > + > > + pinctrl_fec1: fec1grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_ENET_MDC_ENET1_MDC 0x3 > > + MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO 0x3 > > + MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3 0x1f > > + MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2 0x1f > > + MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1 0x1f > > + MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0 0x1f > > + MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3 0x91 > > + MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2 0x91 > > + MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1 0x91 > > + MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0 0x91 > > + MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f > > + MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91 > > + MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91 > > + MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f > > + MX8MM_IOMUXC_NAND_READY_B_GPIO3_IO16 0x159 > > + >; > > + }; > > + > > + pinctrl_hog: hoggrp { > > + fsl,pins = < > > + MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x09 > > + MX8MM_IOMUXC_GPIO1_IO08_GPIO1_IO8 0x09 > > + >; > > + }; > > + > > + pinctrl_i2c1: i2c1grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3 > > + MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3 > > + >; > > + }; > > + > > + pinctrl_i2c3: i2c3grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3 > > + MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3 > > + >; > > + }; > > + > > + pinctrl_i2c3a_rv4162: i2c3a-rv4162grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x1c0 > > + >; > > + }; > > + > > + pinctrl_uart2: uart2grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140 > > + MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140 > > + >; > > + }; > > + > > + pinctrl_usdhc1: usdhc1grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x190 > > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d0 > > + MX8MM_IOMUXC_SD1_RESET_B_GPIO2_IO10 0x141 > > + >; > > + }; > > + > > + pinctrl_usdhc1_100mhz: usdhc1-100mhz-grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x194 > > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d4 > > + >; > > + }; > > + > > + pinctrl_usdhc1_200mhz: usdhc1-200mhz-grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x196 > > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d6 > > + >; > > + }; > > + > > + pinctrl_usdhc2: usdhc2grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x190 > > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d0 > > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d0 > > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d0 > > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d0 > > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d0 > > + MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12 0x1c4 > > + >; > > + }; > > + > > + pinctrl_usdhc2_100mhz: usdhc2-100mhz-grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x194 > > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d4 > > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d4 > > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d4 > > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d4 > > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d4 > > + >; > > + }; > > + > > + pinctrl_usdhc2_200mhz: usdhc2-200mhz-grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x196 > > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d6 > > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d6 > > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d6 > > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d6 > > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d6 > > + >; > > + }; > > + > > + pinctrl_usdhc3: usdhc3grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x190 > > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d0 > > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d0 > > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d0 > > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d0 > > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d0 > > + MX8MM_IOMUXC_GPIO1_IO00_ANAMIX_REF_CLK_32K 0x03 > > + >; > > + }; > > + > > + pinctrl_usdhc3_100mhz: usdhc3-100mhz-grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x194 > > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d4 > > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d4 > > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d4 > > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d4 > > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d4 > > + >; > > + }; > > + > > + pinctrl_usdhc3_200mhz: usdhc3-200mhz-grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x196 > > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d6 > > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d6 > > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d6 > > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d6 > > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d6 > > + >; > > + }; > > + > > + pinctrl_wdog: wdoggrp { > > + fsl,pins = < > > + MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x140 > > + >; > > + }; > > +}; > > -- > > 2.25.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | Thanks, ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support @ 2021-01-28 17:23 ` Adrien Grassein 0 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-28 17:23 UTC (permalink / raw) To: Marco Felsch Cc: DTML, Fabio Estevam, Sascha Hauer, linux-kernel, Krzysztof Kozlowski, Rob Herring, dl-linux-imx, Sascha Hauer, Shawn Guo, linux-arm-kernel Hi Marco, Thanks for your time. Le jeu. 28 janv. 2021 à 17:18, Marco Felsch <m.felsch@pengutronix.de> a écrit : > > Hi Adrien, > > thanks for the patch. I've made only a few comments inline. > > On 21-01-18 12:15, Adrien Grassein wrote: > > Tested with a basic Build Root configuration booting from sdcard. > > > > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++ > > 2 files changed, 396 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > index 38559943c15d..398b5cb4f3e2 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-nitrogen.dtb > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-nitrogen8mm_rev2.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-phanbell.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > new file mode 100644 > > index 000000000000..755088387ea5 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > @@ -0,0 +1,395 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Device Tree file for Boundary Devices i.MX8MMini Nitrogen8MM Rev2 board. > > + * Adrien Grassein <adrien.grassein@gmail.com.com> > > + */ > > +/dts-v1/; > > +#include "imx8mm.dtsi" > > + > > +/ { > > + model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; > > + compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; > > +}; > > + > > +&A53_0 { > > + cpu-supply = <®_sw3>; > > +}; > > + > > +&A53_1 { > > + cpu-supply = <®_sw3>; > > +}; > > + > > +&A53_2 { > > + cpu-supply = <®_sw3>; > > +}; > > + > > +&A53_3 { > > + cpu-supply = <®_sw3>; > > +}; > > + > > +&fec1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_fec1>; > > + phy-mode = "rgmii-id"; > > + phy-handle = <ðphy0>; > > + fsl,magic-packet; > > + status = "okay"; > > + > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ethphy0: ethernet-phy@4 { > > + compatible = "ethernet-phy-id004d.d072", > ^ > Do we really need to add the id here? Yes, I don't know why, but the chip it's not recognized via the mdio interface. I will do further tests but I think it's needed. > > + "ethernet-phy-ieee802.3-c22"; > > + reg = <4>; > > + interrupts-extended = <&gpio3 16 IRQ_TYPE_LEVEL_LOW>; > > + }; > > + }; > > +}; > > + > > +&i2c1 { > > + clock-frequency = <400000>; > ^ > Is the i2c errata fixed on the imx8? I don't know. What is this errata? Should I set a lower speed for the particular i2c? > > > + pinctrl-names = "default", "gpio"; > ^ > no pinctrl for gpio. Yes, it's a bug, thanks > > + pinctrl-0 = <&pinctrl_i2c1>; > > + status = "okay"; > > + > > + pmic@8 { > > + compatible = "nxp,pf8121a"; > > + reg = <0x8>; > > + > > + regulators { > > + reg_ldo1: ldo1 { > ^ > alignment OK > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <5000000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_ldo2: ldo2 { > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <5000000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_ldo3: ldo3 { > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <5000000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_ldo4: ldo4 { > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <5000000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_buck1: buck1 { > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_buck2: buck2 { > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_sw3: buck3 { > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_buck4: buck4 { > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_buck5: buck5 { > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_buck6: buck6 { > > + regulator-min-microvolt = <400000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_buck7: buck7 { > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + reg_vsnvs: vsnvs { > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > Do we really need to have all regulators marked as always-on? > I used the definition present on the example. I will remove this (for the one I don't use). > > + }; > > + }; > > +}; > > + > > +&i2c3 { > > + clock-frequency = <100000>; > > + pinctrl-names = "default", "gpio"; > > + pinctrl-0 = <&pinctrl_i2c3>; > > + status = "okay"; > > + > > + i2cmux@70 { > > + compatible = "nxp,pca9540"; > > + reg = <0x70>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + i2c3 { > > + reg = <0>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + rtc@68 { > > + compatible = "microcrystal,rv4162"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_i2c3a_rv4162>; > > + reg = <0x68>; > > reg should be the 2nd property, after the compatible. > OK. > > + interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>; > > + wakeup-source; > > + }; > > + }; > > + }; > > +}; > > + > > +/* console */ > > +&uart2 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_uart2>; > > + assigned-clocks = <&clk IMX8MM_CLK_UART2>; > > + assigned-clock-parents = <&clk IMX8MM_CLK_24M>; > > + status = "okay"; > > +}; > > + > > +/* eMMC */ > > +&usdhc1 { > > + bus-width = <8>; > > + sdhci-caps-mask = <0x80000000 0x0>; > ^ > This is a SD host controller property according the doc. > Yes, I don't understand the point, sorry. This property is read by the host driver, but should be present here (like in some other dts). > > + non-removable; > > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > > + pinctrl-0 = <&pinctrl_usdhc1>; > > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; > > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; > > + status = "okay"; > > +}; > > + > > +/* sdcard */ > > +&usdhc2 { > > + bus-width = <4>; > > + cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>; > > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > > + pinctrl-0 = <&pinctrl_usdhc2>; > > + pinctrl-1 = <&pinctrl_usdhc2_100mhz>; > > + pinctrl-2 = <&pinctrl_usdhc2_200mhz>; > > + vqmmc-supply = <®_ldo2>; > > + status = "okay"; > > +}; > > + > > +&wdog1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_wdog>; > > + fsl,ext-reset-output; > > + status = "okay"; > > +}; > > + > > +&iomuxc { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_hog>; > > It would be nice to avoid such hog's. Instead those gpios should get > configured by the device(s) using those. > Once again (sorry), I don't understand the point. I did this like any other imx8 board (imx8mq-nitrogem for example). > Regards, > Marco > > > + > > + pinctrl_fec1: fec1grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_ENET_MDC_ENET1_MDC 0x3 > > + MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO 0x3 > > + MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3 0x1f > > + MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2 0x1f > > + MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1 0x1f > > + MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0 0x1f > > + MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3 0x91 > > + MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2 0x91 > > + MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1 0x91 > > + MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0 0x91 > > + MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f > > + MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91 > > + MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91 > > + MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f > > + MX8MM_IOMUXC_NAND_READY_B_GPIO3_IO16 0x159 > > + >; > > + }; > > + > > + pinctrl_hog: hoggrp { > > + fsl,pins = < > > + MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x09 > > + MX8MM_IOMUXC_GPIO1_IO08_GPIO1_IO8 0x09 > > + >; > > + }; > > + > > + pinctrl_i2c1: i2c1grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3 > > + MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3 > > + >; > > + }; > > + > > + pinctrl_i2c3: i2c3grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3 > > + MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3 > > + >; > > + }; > > + > > + pinctrl_i2c3a_rv4162: i2c3a-rv4162grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x1c0 > > + >; > > + }; > > + > > + pinctrl_uart2: uart2grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140 > > + MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140 > > + >; > > + }; > > + > > + pinctrl_usdhc1: usdhc1grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x190 > > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d0 > > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d0 > > + MX8MM_IOMUXC_SD1_RESET_B_GPIO2_IO10 0x141 > > + >; > > + }; > > + > > + pinctrl_usdhc1_100mhz: usdhc1-100mhz-grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x194 > > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d4 > > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d4 > > + >; > > + }; > > + > > + pinctrl_usdhc1_200mhz: usdhc1-200mhz-grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x196 > > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d6 > > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d6 > > + >; > > + }; > > + > > + pinctrl_usdhc2: usdhc2grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x190 > > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d0 > > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d0 > > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d0 > > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d0 > > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d0 > > + MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12 0x1c4 > > + >; > > + }; > > + > > + pinctrl_usdhc2_100mhz: usdhc2-100mhz-grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x194 > > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d4 > > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d4 > > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d4 > > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d4 > > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d4 > > + >; > > + }; > > + > > + pinctrl_usdhc2_200mhz: usdhc2-200mhz-grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x196 > > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d6 > > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d6 > > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d6 > > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d6 > > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d6 > > + >; > > + }; > > + > > + pinctrl_usdhc3: usdhc3grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x190 > > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d0 > > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d0 > > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d0 > > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d0 > > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d0 > > + MX8MM_IOMUXC_GPIO1_IO00_ANAMIX_REF_CLK_32K 0x03 > > + >; > > + }; > > + > > + pinctrl_usdhc3_100mhz: usdhc3-100mhz-grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x194 > > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d4 > > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d4 > > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d4 > > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d4 > > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d4 > > + >; > > + }; > > + > > + pinctrl_usdhc3_200mhz: usdhc3-200mhz-grp { > > + fsl,pins = < > > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x196 > > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d6 > > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d6 > > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d6 > > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d6 > > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d6 > > + >; > > + }; > > + > > + pinctrl_wdog: wdoggrp { > > + fsl,pins = < > > + MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x140 > > + >; > > + }; > > +}; > > -- > > 2.25.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | Thanks, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support 2021-01-28 17:23 ` Adrien Grassein (?) @ 2021-01-28 18:16 ` Adrien Grassein -1 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-28 18:16 UTC (permalink / raw) To: Marco Felsch Cc: DTML, Fabio Estevam, Sascha Hauer, linux-kernel, Krzysztof Kozlowski, Rob Herring, dl-linux-imx, Sascha Hauer, Shawn Guo, linux-arm-kernel Here are some additional answers: Le jeu. 28 janv. 2021 à 18:23, Adrien Grassein <adrien.grassein@gmail.com> a écrit : > > Hi Marco, > > Thanks for your time. > > Le jeu. 28 janv. 2021 à 17:18, Marco Felsch <m.felsch@pengutronix.de> a écrit : > > > > Hi Adrien, > > > > thanks for the patch. I've made only a few comments inline. > > > > On 21-01-18 12:15, Adrien Grassein wrote: > > > Tested with a basic Build Root configuration booting from sdcard. > > > > > > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> > > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > > > --- > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++ > > > 2 files changed, 396 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > index 38559943c15d..398b5cb4f3e2 100644 > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > @@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-nitrogen.dtb > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-nitrogen8mm_rev2.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-phanbell.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > > new file mode 100644 > > > index 000000000000..755088387ea5 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > > @@ -0,0 +1,395 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Device Tree file for Boundary Devices i.MX8MMini Nitrogen8MM Rev2 board. > > > + * Adrien Grassein <adrien.grassein@gmail.com.com> > > > + */ > > > +/dts-v1/; > > > +#include "imx8mm.dtsi" > > > + > > > +/ { > > > + model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; > > > + compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; > > > +}; > > > + > > > +&A53_0 { > > > + cpu-supply = <®_sw3>; > > > +}; > > > + > > > +&A53_1 { > > > + cpu-supply = <®_sw3>; > > > +}; > > > + > > > +&A53_2 { > > > + cpu-supply = <®_sw3>; > > > +}; > > > + > > > +&A53_3 { > > > + cpu-supply = <®_sw3>; > > > +}; > > > + > > > +&fec1 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_fec1>; > > > + phy-mode = "rgmii-id"; > > > + phy-handle = <ðphy0>; > > > + fsl,magic-packet; > > > + status = "okay"; > > > + > > > + mdio { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + ethphy0: ethernet-phy@4 { > > > + compatible = "ethernet-phy-id004d.d072", > > ^ > > Do we really need to add the id here? > > Yes, I don't know why, but the chip it's not recognized via the mdio interface. > I will do further tests but I think it's needed. > Not needed anymore. > > > + "ethernet-phy-ieee802.3-c22"; > > > + reg = <4>; > > > + interrupts-extended = <&gpio3 16 IRQ_TYPE_LEVEL_LOW>; > > > + }; > > > + }; > > > +}; > > > + > > > +&i2c1 { > > > + clock-frequency = <400000>; > > ^ > > Is the i2c errata fixed on the imx8? > > I don't know. What is this errata? > Should I set a lower speed for the particular i2c? > > > > > > + pinctrl-names = "default", "gpio"; > > ^ > > no pinctrl for gpio. > > Yes, it's a bug, thanks > > > > + pinctrl-0 = <&pinctrl_i2c1>; > > > + status = "okay"; > > > + > > > + pmic@8 { > > > + compatible = "nxp,pf8121a"; > > > + reg = <0x8>; > > > + > > > + regulators { > > > + reg_ldo1: ldo1 { > > ^ > > alignment > > OK > > > > + regulator-min-microvolt = <1500000>; > > > + regulator-max-microvolt = <5000000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_ldo2: ldo2 { > > > + regulator-min-microvolt = <1500000>; > > > + regulator-max-microvolt = <5000000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_ldo3: ldo3 { > > > + regulator-min-microvolt = <1500000>; > > > + regulator-max-microvolt = <5000000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_ldo4: ldo4 { > > > + regulator-min-microvolt = <1500000>; > > > + regulator-max-microvolt = <5000000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck1: buck1 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck2: buck2 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_sw3: buck3 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck4: buck4 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck5: buck5 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck6: buck6 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck7: buck7 { > > > + regulator-min-microvolt = <3300000>; > > > + regulator-max-microvolt = <3300000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_vsnvs: vsnvs { > > > + regulator-min-microvolt = <1800000>; > > > + regulator-max-microvolt = <3300000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > > Do we really need to have all regulators marked as always-on? > > > I used the definition present on the example. > I will remove this (for the one I don't use). Yes it's needed. In fact the only one not needed is the reg_vsnvs one. Disabling any of ldo or buck will disable all others. > > > + }; > > > + }; > > > +}; > > > + > > > +&i2c3 { > > > + clock-frequency = <100000>; > > > + pinctrl-names = "default", "gpio"; > > > + pinctrl-0 = <&pinctrl_i2c3>; > > > + status = "okay"; > > > + > > > + i2cmux@70 { > > > + compatible = "nxp,pca9540"; > > > + reg = <0x70>; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + i2c3 { > > > + reg = <0>; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + rtc@68 { > > > + compatible = "microcrystal,rv4162"; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_i2c3a_rv4162>; > > > + reg = <0x68>; > > > > reg should be the 2nd property, after the compatible. > > > OK. > > > > + interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>; > > > + wakeup-source; > > > + }; > > > + }; > > > + }; > > > +}; > > > + > > > +/* console */ > > > +&uart2 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_uart2>; > > > + assigned-clocks = <&clk IMX8MM_CLK_UART2>; > > > + assigned-clock-parents = <&clk IMX8MM_CLK_24M>; > > > + status = "okay"; > > > +}; > > > + > > > +/* eMMC */ > > > +&usdhc1 { > > > + bus-width = <8>; > > > + sdhci-caps-mask = <0x80000000 0x0>; > > ^ > > This is a SD host controller property according the doc. > > > Yes, I don't understand the point, sorry. > This property is read by the host driver, but should be present here > (like in some other dts). > > > > + non-removable; > > > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > > > + pinctrl-0 = <&pinctrl_usdhc1>; > > > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; > > > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; > > > + status = "okay"; > > > +}; > > > + > > > +/* sdcard */ > > > +&usdhc2 { > > > + bus-width = <4>; > > > + cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>; > > > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > > > + pinctrl-0 = <&pinctrl_usdhc2>; > > > + pinctrl-1 = <&pinctrl_usdhc2_100mhz>; > > > + pinctrl-2 = <&pinctrl_usdhc2_200mhz>; > > > + vqmmc-supply = <®_ldo2>; > > > + status = "okay"; > > > +}; > > > + > > > +&wdog1 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_wdog>; > > > + fsl,ext-reset-output; > > > + status = "okay"; > > > +}; > > > + > > > +&iomuxc { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_hog>; > > > > It would be nice to avoid such hog's. Instead those gpios should get > > configured by the device(s) using those. > > > Once again (sorry), I don't understand the point. > I did this like any other imx8 board (imx8mq-nitrogem for example). > > > Regards, > > Marco > > > > > + > > > + pinctrl_fec1: fec1grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_ENET_MDC_ENET1_MDC 0x3 > > > + MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO 0x3 > > > + MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3 0x1f > > > + MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2 0x1f > > > + MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1 0x1f > > > + MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0 0x1f > > > + MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3 0x91 > > > + MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2 0x91 > > > + MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1 0x91 > > > + MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0 0x91 > > > + MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f > > > + MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91 > > > + MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91 > > > + MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f > > > + MX8MM_IOMUXC_NAND_READY_B_GPIO3_IO16 0x159 > > > + >; > > > + }; > > > + > > > + pinctrl_hog: hoggrp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x09 > > > + MX8MM_IOMUXC_GPIO1_IO08_GPIO1_IO8 0x09 > > > + >; > > > + }; > > > + > > > + pinctrl_i2c1: i2c1grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3 > > > + MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3 > > > + >; > > > + }; > > > + > > > + pinctrl_i2c3: i2c3grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3 > > > + MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3 > > > + >; > > > + }; > > > + > > > + pinctrl_i2c3a_rv4162: i2c3a-rv4162grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x1c0 > > > + >; > > > + }; > > > + > > > + pinctrl_uart2: uart2grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140 > > > + MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX 0x140 > > > + >; > > > + }; > > > + > > > + pinctrl_usdhc1: usdhc1grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x190 > > > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d0 > > > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d0 > > > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d0 > > > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d0 > > > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d0 > > > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d0 > > > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d0 > > > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d0 > > > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d0 > > > + MX8MM_IOMUXC_SD1_RESET_B_GPIO2_IO10 0x141 > > > + >; > > > + }; > > > + > > > + pinctrl_usdhc1_100mhz: usdhc1-100mhz-grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x194 > > > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d4 > > > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d4 > > > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d4 > > > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d4 > > > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d4 > > > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d4 > > > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d4 > > > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d4 > > > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d4 > > > + >; > > > + }; > > > + > > > + pinctrl_usdhc1_200mhz: usdhc1-200mhz-grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK 0x196 > > > + MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD 0x1d6 > > > + MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0 0x1d6 > > > + MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1 0x1d6 > > > + MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2 0x1d6 > > > + MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3 0x1d6 > > > + MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4 0x1d6 > > > + MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5 0x1d6 > > > + MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6 0x1d6 > > > + MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7 0x1d6 > > > + >; > > > + }; > > > + > > > + pinctrl_usdhc2: usdhc2grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x190 > > > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d0 > > > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d0 > > > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d0 > > > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d0 > > > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d0 > > > + MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12 0x1c4 > > > + >; > > > + }; > > > + > > > + pinctrl_usdhc2_100mhz: usdhc2-100mhz-grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x194 > > > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d4 > > > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d4 > > > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d4 > > > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d4 > > > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d4 > > > + >; > > > + }; > > > + > > > + pinctrl_usdhc2_200mhz: usdhc2-200mhz-grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK 0x196 > > > + MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d6 > > > + MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0 0x1d6 > > > + MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1 0x1d6 > > > + MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2 0x1d6 > > > + MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3 0x1d6 > > > + >; > > > + }; > > > + > > > + pinctrl_usdhc3: usdhc3grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x190 > > > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d0 > > > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d0 > > > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d0 > > > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d0 > > > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d0 > > > + MX8MM_IOMUXC_GPIO1_IO00_ANAMIX_REF_CLK_32K 0x03 > > > + >; > > > + }; > > > + > > > + pinctrl_usdhc3_100mhz: usdhc3-100mhz-grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x194 > > > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d4 > > > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d4 > > > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d4 > > > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d4 > > > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d4 > > > + >; > > > + }; > > > + > > > + pinctrl_usdhc3_200mhz: usdhc3-200mhz-grp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_NAND_WE_B_USDHC3_CLK 0x196 > > > + MX8MM_IOMUXC_NAND_WP_B_USDHC3_CMD 0x1d6 > > > + MX8MM_IOMUXC_NAND_DATA04_USDHC3_DATA0 0x1d6 > > > + MX8MM_IOMUXC_NAND_DATA05_USDHC3_DATA1 0x1d6 > > > + MX8MM_IOMUXC_NAND_DATA06_USDHC3_DATA2 0x1d6 > > > + MX8MM_IOMUXC_NAND_DATA07_USDHC3_DATA3 0x1d6 > > > + >; > > > + }; > > > + > > > + pinctrl_wdog: wdoggrp { > > > + fsl,pins = < > > > + MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x140 > > > + >; > > > + }; > > > +}; > > > -- > > > 2.25.1 > > > > > > > > > _______________________________________________ > > > linux-arm-kernel mailing list > > > linux-arm-kernel@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > > > > > -- > > Pengutronix e.K. | | > > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > Thanks, Thanks again. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support 2021-01-28 17:23 ` Adrien Grassein @ 2021-01-29 9:22 ` Marco Felsch -1 siblings, 0 replies; 18+ messages in thread From: Marco Felsch @ 2021-01-29 9:22 UTC (permalink / raw) To: Adrien Grassein Cc: DTML, Fabio Estevam, Sascha Hauer, linux-kernel, Krzysztof Kozlowski, Rob Herring, dl-linux-imx, Sascha Hauer, Shawn Guo, linux-arm-kernel Hi Adrien, On 21-01-28 18:23, Adrien Grassein wrote: > > > +&i2c1 { > > > + clock-frequency = <400000>; > > ^ > > Is the i2c errata fixed on the imx8? > > I don't know. What is this errata? > Should I set a lower speed for the particular i2c? The max. clock on iMX6 is 375kHz due to errate ERR007805 https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf > > > > > + pinctrl-names = "default", "gpio"; > > ^ > > no pinctrl for gpio. > > Yes, it's a bug, thanks > > > > + pinctrl-0 = <&pinctrl_i2c1>; > > > + status = "okay"; > > > + > > > + pmic@8 { > > > + compatible = "nxp,pf8121a"; > > > + reg = <0x8>; > > > + > > > + regulators { > > > + reg_ldo1: ldo1 { > > ^ > > alignment > > OK > > > > + regulator-min-microvolt = <1500000>; > > > + regulator-max-microvolt = <5000000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_ldo2: ldo2 { > > > + regulator-min-microvolt = <1500000>; > > > + regulator-max-microvolt = <5000000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_ldo3: ldo3 { > > > + regulator-min-microvolt = <1500000>; > > > + regulator-max-microvolt = <5000000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_ldo4: ldo4 { > > > + regulator-min-microvolt = <1500000>; > > > + regulator-max-microvolt = <5000000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck1: buck1 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck2: buck2 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_sw3: buck3 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck4: buck4 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck5: buck5 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck6: buck6 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck7: buck7 { > > > + regulator-min-microvolt = <3300000>; > > > + regulator-max-microvolt = <3300000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_vsnvs: vsnvs { > > > + regulator-min-microvolt = <1800000>; > > > + regulator-max-microvolt = <3300000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > > Do we really need to have all regulators marked as always-on? > > > I used the definition present on the example. > I will remove this (for the one I don't use). Can you test to remove all always-on except for those really needed e.g. the vddr-ref. Regulators are obtained on demand by the devices. This allows us to save power e.g. in suspend-to-ram case. > > > + }; > > > + }; > > > +}; > > > + > > > +&i2c3 { > > > + clock-frequency = <100000>; > > > + pinctrl-names = "default", "gpio"; > > > + pinctrl-0 = <&pinctrl_i2c3>; > > > + status = "okay"; > > > + > > > + i2cmux@70 { > > > + compatible = "nxp,pca9540"; > > > + reg = <0x70>; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + i2c3 { > > > + reg = <0>; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + rtc@68 { > > > + compatible = "microcrystal,rv4162"; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_i2c3a_rv4162>; > > > + reg = <0x68>; > > > > reg should be the 2nd property, after the compatible. > > > OK. > > > > + interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>; > > > + wakeup-source; > > > + }; > > > + }; > > > + }; > > > +}; > > > + > > > +/* console */ > > > +&uart2 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_uart2>; > > > + assigned-clocks = <&clk IMX8MM_CLK_UART2>; > > > + assigned-clock-parents = <&clk IMX8MM_CLK_24M>; > > > + status = "okay"; > > > +}; > > > + > > > +/* eMMC */ > > > +&usdhc1 { > > > + bus-width = <8>; > > > + sdhci-caps-mask = <0x80000000 0x0>; > > ^ > > This is a SD host controller property according the doc. > > > Yes, I don't understand the point, sorry. > This property is read by the host driver, but should be present here > (like in some other dts). I've never seen this property. I said "This is a SD host controller" because your comment says that this usdhc controller is used for eMMC which is not an SD controller. > > > + non-removable; > > > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > > > + pinctrl-0 = <&pinctrl_usdhc1>; > > > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; > > > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; > > > + status = "okay"; > > > +}; > > > + > > > +/* sdcard */ > > > +&usdhc2 { > > > + bus-width = <4>; > > > + cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>; > > > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > > > + pinctrl-0 = <&pinctrl_usdhc2>; > > > + pinctrl-1 = <&pinctrl_usdhc2_100mhz>; > > > + pinctrl-2 = <&pinctrl_usdhc2_200mhz>; > > > + vqmmc-supply = <®_ldo2>; > > > + status = "okay"; > > > +}; > > > + > > > +&wdog1 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_wdog>; > > > + fsl,ext-reset-output; > > > + status = "okay"; > > > +}; > > > + > > > +&iomuxc { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_hog>; > > > > It would be nice to avoid such hog's. Instead those gpios should get > > configured by the device(s) using those. > > > Once again (sorry), I don't understand the point. > I did this like any other imx8 board (imx8mq-nitrogem for example). Question is where are those pins used and for what purpose. It is common to specify the muxing within the device nodes like you did for the wdog1 device. This mechanism here is something like: "Oh I don't wanna setup the muxing on the correct places, so let's mux it here in glob". Your hog group isn't really large but it would be nice to avoid it since day one. Regards, Marco ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support @ 2021-01-29 9:22 ` Marco Felsch 0 siblings, 0 replies; 18+ messages in thread From: Marco Felsch @ 2021-01-29 9:22 UTC (permalink / raw) To: Adrien Grassein Cc: DTML, Shawn Guo, Sascha Hauer, linux-kernel, Krzysztof Kozlowski, Rob Herring, dl-linux-imx, Sascha Hauer, Fabio Estevam, linux-arm-kernel Hi Adrien, On 21-01-28 18:23, Adrien Grassein wrote: > > > +&i2c1 { > > > + clock-frequency = <400000>; > > ^ > > Is the i2c errata fixed on the imx8? > > I don't know. What is this errata? > Should I set a lower speed for the particular i2c? The max. clock on iMX6 is 375kHz due to errate ERR007805 https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf > > > > > + pinctrl-names = "default", "gpio"; > > ^ > > no pinctrl for gpio. > > Yes, it's a bug, thanks > > > > + pinctrl-0 = <&pinctrl_i2c1>; > > > + status = "okay"; > > > + > > > + pmic@8 { > > > + compatible = "nxp,pf8121a"; > > > + reg = <0x8>; > > > + > > > + regulators { > > > + reg_ldo1: ldo1 { > > ^ > > alignment > > OK > > > > + regulator-min-microvolt = <1500000>; > > > + regulator-max-microvolt = <5000000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_ldo2: ldo2 { > > > + regulator-min-microvolt = <1500000>; > > > + regulator-max-microvolt = <5000000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_ldo3: ldo3 { > > > + regulator-min-microvolt = <1500000>; > > > + regulator-max-microvolt = <5000000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_ldo4: ldo4 { > > > + regulator-min-microvolt = <1500000>; > > > + regulator-max-microvolt = <5000000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck1: buck1 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck2: buck2 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_sw3: buck3 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck4: buck4 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck5: buck5 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck6: buck6 { > > > + regulator-min-microvolt = <400000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_buck7: buck7 { > > > + regulator-min-microvolt = <3300000>; > > > + regulator-max-microvolt = <3300000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_vsnvs: vsnvs { > > > + regulator-min-microvolt = <1800000>; > > > + regulator-max-microvolt = <3300000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > > Do we really need to have all regulators marked as always-on? > > > I used the definition present on the example. > I will remove this (for the one I don't use). Can you test to remove all always-on except for those really needed e.g. the vddr-ref. Regulators are obtained on demand by the devices. This allows us to save power e.g. in suspend-to-ram case. > > > + }; > > > + }; > > > +}; > > > + > > > +&i2c3 { > > > + clock-frequency = <100000>; > > > + pinctrl-names = "default", "gpio"; > > > + pinctrl-0 = <&pinctrl_i2c3>; > > > + status = "okay"; > > > + > > > + i2cmux@70 { > > > + compatible = "nxp,pca9540"; > > > + reg = <0x70>; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + i2c3 { > > > + reg = <0>; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + rtc@68 { > > > + compatible = "microcrystal,rv4162"; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_i2c3a_rv4162>; > > > + reg = <0x68>; > > > > reg should be the 2nd property, after the compatible. > > > OK. > > > > + interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>; > > > + wakeup-source; > > > + }; > > > + }; > > > + }; > > > +}; > > > + > > > +/* console */ > > > +&uart2 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_uart2>; > > > + assigned-clocks = <&clk IMX8MM_CLK_UART2>; > > > + assigned-clock-parents = <&clk IMX8MM_CLK_24M>; > > > + status = "okay"; > > > +}; > > > + > > > +/* eMMC */ > > > +&usdhc1 { > > > + bus-width = <8>; > > > + sdhci-caps-mask = <0x80000000 0x0>; > > ^ > > This is a SD host controller property according the doc. > > > Yes, I don't understand the point, sorry. > This property is read by the host driver, but should be present here > (like in some other dts). I've never seen this property. I said "This is a SD host controller" because your comment says that this usdhc controller is used for eMMC which is not an SD controller. > > > + non-removable; > > > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > > > + pinctrl-0 = <&pinctrl_usdhc1>; > > > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; > > > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; > > > + status = "okay"; > > > +}; > > > + > > > +/* sdcard */ > > > +&usdhc2 { > > > + bus-width = <4>; > > > + cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>; > > > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > > > + pinctrl-0 = <&pinctrl_usdhc2>; > > > + pinctrl-1 = <&pinctrl_usdhc2_100mhz>; > > > + pinctrl-2 = <&pinctrl_usdhc2_200mhz>; > > > + vqmmc-supply = <®_ldo2>; > > > + status = "okay"; > > > +}; > > > + > > > +&wdog1 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_wdog>; > > > + fsl,ext-reset-output; > > > + status = "okay"; > > > +}; > > > + > > > +&iomuxc { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_hog>; > > > > It would be nice to avoid such hog's. Instead those gpios should get > > configured by the device(s) using those. > > > Once again (sorry), I don't understand the point. > I did this like any other imx8 board (imx8mq-nitrogem for example). Question is where are those pins used and for what purpose. It is common to specify the muxing within the device nodes like you did for the wdog1 device. This mechanism here is something like: "Oh I don't wanna setup the muxing on the correct places, so let's mux it here in glob". Your hog group isn't really large but it would be nice to avoid it since day one. Regards, Marco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support 2021-01-29 9:22 ` Marco Felsch (?) @ 2021-01-29 9:49 ` Adrien Grassein -1 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-29 9:49 UTC (permalink / raw) To: Marco Felsch Cc: DTML, Shawn Guo, Sascha Hauer, linux-kernel, Krzysztof Kozlowski, Rob Herring, dl-linux-imx, Sascha Hauer, Fabio Estevam, linux-arm-kernel Hi Marco, Le ven. 29 janv. 2021 à 10:22, Marco Felsch <m.felsch@pengutronix.de> a écrit : > > Hi Adrien, > > On 21-01-28 18:23, Adrien Grassein wrote: > > > > > +&i2c1 { > > > > + clock-frequency = <400000>; > > > ^ > > > Is the i2c errata fixed on the imx8? > > > > I don't know. What is this errata? > > Should I set a lower speed for the particular i2c? > > The max. clock on iMX6 is 375kHz due to errate ERR007805 > https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf > It's an imx8. So I guess that this errata will not affect my board. > > > > > > > + pinctrl-names = "default", "gpio"; > > > ^ > > > no pinctrl for gpio. > > > > Yes, it's a bug, thanks > > > > > > + pinctrl-0 = <&pinctrl_i2c1>; > > > > + status = "okay"; > > > > + > > > > + pmic@8 { > > > > + compatible = "nxp,pf8121a"; > > > > + reg = <0x8>; > > > > + > > > > + regulators { > > > > + reg_ldo1: ldo1 { > > > ^ > > > alignment > > > > OK > > > > > > + regulator-min-microvolt = <1500000>; > > > > + regulator-max-microvolt = <5000000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > + }; > > > > + > > > > + reg_ldo2: ldo2 { > > > > + regulator-min-microvolt = <1500000>; > > > > + regulator-max-microvolt = <5000000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > + }; > > > > + > > > > + reg_ldo3: ldo3 { > > > > + regulator-min-microvolt = <1500000>; > > > > + regulator-max-microvolt = <5000000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > + }; > > > > + > > > > + reg_ldo4: ldo4 { > > > > + regulator-min-microvolt = <1500000>; > > > > + regulator-max-microvolt = <5000000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > + }; > > > > + > > > > + reg_buck1: buck1 { > > > > + regulator-min-microvolt = <400000>; > > > > + regulator-max-microvolt = <1800000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > + }; > > > > + > > > > + reg_buck2: buck2 { > > > > + regulator-min-microvolt = <400000>; > > > > + regulator-max-microvolt = <1800000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > + }; > > > > + > > > > + reg_sw3: buck3 { > > > > + regulator-min-microvolt = <400000>; > > > > + regulator-max-microvolt = <1800000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > + }; > > > > + > > > > + reg_buck4: buck4 { > > > > + regulator-min-microvolt = <400000>; > > > > + regulator-max-microvolt = <1800000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > + }; > > > > + > > > > + reg_buck5: buck5 { > > > > + regulator-min-microvolt = <400000>; > > > > + regulator-max-microvolt = <1800000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > + }; > > > > + > > > > + reg_buck6: buck6 { > > > > + regulator-min-microvolt = <400000>; > > > > + regulator-max-microvolt = <1800000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > + }; > > > > + > > > > + reg_buck7: buck7 { > > > > + regulator-min-microvolt = <3300000>; > > > > + regulator-max-microvolt = <3300000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > + }; > > > > + > > > > + reg_vsnvs: vsnvs { > > > > + regulator-min-microvolt = <1800000>; > > > > + regulator-max-microvolt = <3300000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > + }; > > > > > > Do we really need to have all regulators marked as always-on? > > > > > I used the definition present on the example. > > I will remove this (for the one I don't use). > > Can you test to remove all always-on except for those really needed e.g. > the vddr-ref. Regulators are obtained on demand by the devices. This > allows us to save power e.g. in suspend-to-ram case. > Ok, thanks, > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&i2c3 { > > > > + clock-frequency = <100000>; > > > > + pinctrl-names = "default", "gpio"; > > > > + pinctrl-0 = <&pinctrl_i2c3>; > > > > + status = "okay"; > > > > + > > > > + i2cmux@70 { > > > > + compatible = "nxp,pca9540"; > > > > + reg = <0x70>; > > > > + #address-cells = <1>; > > > > + #size-cells = <0>; > > > > + > > > > + i2c3 { > > > > + reg = <0>; > > > > + #address-cells = <1>; > > > > + #size-cells = <0>; > > > > + > > > > + rtc@68 { > > > > + compatible = "microcrystal,rv4162"; > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_i2c3a_rv4162>; > > > > + reg = <0x68>; > > > > > > reg should be the 2nd property, after the compatible. > > > > > OK. > > > > > > + interrupts-extended = <&gpio4 22 IRQ_TYPE_LEVEL_LOW>; > > > > + wakeup-source; > > > > + }; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +/* console */ > > > > +&uart2 { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_uart2>; > > > > + assigned-clocks = <&clk IMX8MM_CLK_UART2>; > > > > + assigned-clock-parents = <&clk IMX8MM_CLK_24M>; > > > > + status = "okay"; > > > > +}; > > > > + > > > > +/* eMMC */ > > > > +&usdhc1 { > > > > + bus-width = <8>; > > > > + sdhci-caps-mask = <0x80000000 0x0>; > > > ^ > > > This is a SD host controller property according the doc. > > > > > Yes, I don't understand the point, sorry. > > This property is read by the host driver, but should be present here > > (like in some other dts). > > I've never seen this property. I said "This is a SD host controller" > because your comment says that this usdhc controller is used for eMMC > which is not an SD controller. > The eMMC is connected to this controller. Without this, my eMMC is not recognized by the kernel. > > > > + non-removable; > > > > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > > > > + pinctrl-0 = <&pinctrl_usdhc1>; > > > > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; > > > > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; > > > > + status = "okay"; > > > > +}; > > > > + > > > > +/* sdcard */ > > > > +&usdhc2 { > > > > + bus-width = <4>; > > > > + cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>; > > > > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > > > > + pinctrl-0 = <&pinctrl_usdhc2>; > > > > + pinctrl-1 = <&pinctrl_usdhc2_100mhz>; > > > > + pinctrl-2 = <&pinctrl_usdhc2_200mhz>; > > > > + vqmmc-supply = <®_ldo2>; > > > > + status = "okay"; > > > > +}; > > > > + > > > > +&wdog1 { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_wdog>; > > > > + fsl,ext-reset-output; > > > > + status = "okay"; > > > > +}; > > > > + > > > > +&iomuxc { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_hog>; > > > > > > It would be nice to avoid such hog's. Instead those gpios should get > > > configured by the device(s) using those. > > > > > Once again (sorry), I don't understand the point. > > I did this like any other imx8 board (imx8mq-nitrogem for example). > > Question is where are those pins used and for what purpose. It is common > to specify the muxing within the device nodes like you did for the wdog1 > device. This mechanism here is something like: "Oh I don't wanna setup > the muxing on the correct places, so let's mux it here in glob". Your > hog group isn't really large but it would be nice to avoid it since day > one. > Ok, no problem with this, but how can I do this? Do you have an example? > Regards, > Marco Moreover, yesterday I did another version of this patchset taking in account mot of your review exept: - errata; - SD Host property; - hog group. Thanks again, Adrien _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v5 3/3] arm64: defconfig: Enable PF8x00 as builtin 2021-01-18 11:15 ` Adrien Grassein @ 2021-01-18 11:15 ` Adrien Grassein -1 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-18 11:15 UTC (permalink / raw) Cc: shawnguo, krzk, robh+dt, s.hauer, kernel, festevam, linux-imx, devicetree, linux-kernel, linux-arm-kernel, Adrien Grassein This driver is mandatory for the nitrogen8m mini board when booting from the sdcard slot. Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 15fe99544c67..fe7f82ceba9d 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -607,6 +607,7 @@ CONFIG_REGULATOR_MAX77620=y CONFIG_REGULATOR_MAX8973=y CONFIG_REGULATOR_MP8859=y CONFIG_REGULATOR_PCA9450=y +CONFIG_REGULATOR_PF8X00=y CONFIG_REGULATOR_PFUZE100=y CONFIG_REGULATOR_PWM=y CONFIG_REGULATOR_QCOM_RPMH=y -- 2.25.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v5 3/3] arm64: defconfig: Enable PF8x00 as builtin @ 2021-01-18 11:15 ` Adrien Grassein 0 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-18 11:15 UTC (permalink / raw) Cc: devicetree, shawnguo, s.hauer, linux-kernel, krzk, robh+dt, linux-imx, kernel, festevam, linux-arm-kernel, Adrien Grassein This driver is mandatory for the nitrogen8m mini board when booting from the sdcard slot. Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 15fe99544c67..fe7f82ceba9d 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -607,6 +607,7 @@ CONFIG_REGULATOR_MAX77620=y CONFIG_REGULATOR_MAX8973=y CONFIG_REGULATOR_MP8859=y CONFIG_REGULATOR_PCA9450=y +CONFIG_REGULATOR_PF8X00=y CONFIG_REGULATOR_PFUZE100=y CONFIG_REGULATOR_PWM=y CONFIG_REGULATOR_QCOM_RPMH=y -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v5 0/3] Add support for Boundary Nitrogen8M Mini SBC 2021-01-18 11:15 ` Adrien Grassein @ 2021-01-27 17:45 ` Adrien Grassein -1 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-27 17:45 UTC (permalink / raw) Cc: Shawn Guo, Krzysztof Kozlowski, Rob Herring, Sascha Hauer, Sascha Hauer, Fabio Estevam, dl-linux-imx, DTML, linux-kernel, linux-arm-kernel Hello Shawn, Could you please have a look at the new patch set made after your commentaries? Thank a lot for your time, Thanks, Le lun. 18 janv. 2021 à 12:15, Adrien Grassein <adrien.grassein@gmail.com> a écrit : > > Hello, > > This patch set aims is to add the support of the Nitrogen8M Mini SBC > from Boundary Devices. > > Thanks, > > Update in v2: > - Rewrite the dts (Remove the unused wlan and audio); > - Remove useless definition; > - Take in account review. > > Update in v3: > - Take in account review. > > Update in v4: > - Reorder definition in pmic > > Update in v5: > - Take in account review. > - Remove useless i2c groups > > Adrien Grassein (3): > dt-bindings: arm: imx: add imx8mm nitrogen support > arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support > arm64: defconfig: Enable PF8x00 as builtin > > .../devicetree/bindings/arm/fsl.yaml | 1 + > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++ > arch/arm64/configs/defconfig | 1 + > 4 files changed, 398 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > -- > 2.25.1 > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v5 0/3] Add support for Boundary Nitrogen8M Mini SBC @ 2021-01-27 17:45 ` Adrien Grassein 0 siblings, 0 replies; 18+ messages in thread From: Adrien Grassein @ 2021-01-27 17:45 UTC (permalink / raw) Cc: DTML, Shawn Guo, Sascha Hauer, linux-kernel, Krzysztof Kozlowski, Rob Herring, dl-linux-imx, Sascha Hauer, Fabio Estevam, linux-arm-kernel Hello Shawn, Could you please have a look at the new patch set made after your commentaries? Thank a lot for your time, Thanks, Le lun. 18 janv. 2021 à 12:15, Adrien Grassein <adrien.grassein@gmail.com> a écrit : > > Hello, > > This patch set aims is to add the support of the Nitrogen8M Mini SBC > from Boundary Devices. > > Thanks, > > Update in v2: > - Rewrite the dts (Remove the unused wlan and audio); > - Remove useless definition; > - Take in account review. > > Update in v3: > - Take in account review. > > Update in v4: > - Reorder definition in pmic > > Update in v5: > - Take in account review. > - Remove useless i2c groups > > Adrien Grassein (3): > dt-bindings: arm: imx: add imx8mm nitrogen support > arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support > arm64: defconfig: Enable PF8x00 as builtin > > .../devicetree/bindings/arm/fsl.yaml | 1 + > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../dts/freescale/imx8mm-nitrogen8mm_rev2.dts | 395 ++++++++++++++++++ > arch/arm64/configs/defconfig | 1 + > 4 files changed, 398 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-nitrogen8mm_rev2.dts > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2021-01-29 11:54 UTC | newest] Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-01-18 11:15 [PATCH v5 0/3] Add support for Boundary Nitrogen8M Mini SBC Adrien Grassein 2021-01-18 11:15 ` Adrien Grassein 2021-01-18 11:15 ` [PATCH v5 1/3] dt-bindings: arm: imx: add imx8mm nitrogen support Adrien Grassein 2021-01-18 11:15 ` Adrien Grassein 2021-01-18 11:15 ` [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support Adrien Grassein 2021-01-18 11:15 ` Adrien Grassein 2021-01-28 16:18 ` Marco Felsch 2021-01-28 16:18 ` Marco Felsch 2021-01-28 17:23 ` Adrien Grassein 2021-01-28 17:23 ` Adrien Grassein 2021-01-28 18:16 ` Adrien Grassein 2021-01-29 9:22 ` Marco Felsch 2021-01-29 9:22 ` Marco Felsch 2021-01-29 9:49 ` Adrien Grassein 2021-01-18 11:15 ` [PATCH v5 3/3] arm64: defconfig: Enable PF8x00 as builtin Adrien Grassein 2021-01-18 11:15 ` Adrien Grassein 2021-01-27 17:45 ` [PATCH v5 0/3] Add support for Boundary Nitrogen8M Mini SBC Adrien Grassein 2021-01-27 17:45 ` Adrien Grassein
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.