* [PATCH] cmd: misc: Fix return value for the sleep command
[not found] <CGME20210122112739eucas1p1ae7fa48eea75d2bf85f132f05eeb229b@eucas1p1.samsung.com>
@ 2021-01-22 11:27 ` Marek Szyprowski
2021-01-24 2:03 ` Simon Glass
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marek Szyprowski @ 2021-01-22 11:27 UTC (permalink / raw)
To: u-boot
If sleeping has been interrupted, return CMD_RET_FAILURE instead of -1
(CMD_RET_USAGE).
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
cmd/sleep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/sleep.c b/cmd/sleep.c
index f0c78a8efb..1fff400c79 100644
--- a/cmd/sleep.c
+++ b/cmd/sleep.c
@@ -40,7 +40,7 @@ static int do_sleep(struct cmd_tbl *cmdtp, int flag, int argc,
while (get_timer(start) < delay) {
if (ctrlc())
- return (-1);
+ return CMD_RET_FAILURE;
udelay(100);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] cmd: misc: Fix return value for the sleep command
2021-01-22 11:27 ` [PATCH] cmd: misc: Fix return value for the sleep command Marek Szyprowski
@ 2021-01-24 2:03 ` Simon Glass
2021-01-26 23:51 ` Jaehoon Chung
2021-01-28 23:59 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2021-01-24 2:03 UTC (permalink / raw)
To: u-boot
On Fri, 22 Jan 2021 at 04:27, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
> If sleeping has been interrupted, return CMD_RET_FAILURE instead of -1
> (CMD_RET_USAGE).
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> cmd/sleep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] cmd: misc: Fix return value for the sleep command
2021-01-22 11:27 ` [PATCH] cmd: misc: Fix return value for the sleep command Marek Szyprowski
2021-01-24 2:03 ` Simon Glass
@ 2021-01-26 23:51 ` Jaehoon Chung
2021-01-28 23:59 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Jaehoon Chung @ 2021-01-26 23:51 UTC (permalink / raw)
To: u-boot
On 1/22/21 8:27 PM, Marek Szyprowski wrote:
> If sleeping has been interrupted, return CMD_RET_FAILURE instead of -1
> (CMD_RET_USAGE).
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
> cmd/sleep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/sleep.c b/cmd/sleep.c
> index f0c78a8efb..1fff400c79 100644
> --- a/cmd/sleep.c
> +++ b/cmd/sleep.c
> @@ -40,7 +40,7 @@ static int do_sleep(struct cmd_tbl *cmdtp, int flag, int argc,
>
> while (get_timer(start) < delay) {
> if (ctrlc())
> - return (-1);
> + return CMD_RET_FAILURE;
>
> udelay(100);
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] cmd: misc: Fix return value for the sleep command
2021-01-22 11:27 ` [PATCH] cmd: misc: Fix return value for the sleep command Marek Szyprowski
2021-01-24 2:03 ` Simon Glass
2021-01-26 23:51 ` Jaehoon Chung
@ 2021-01-28 23:59 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2021-01-28 23:59 UTC (permalink / raw)
To: u-boot
On Fri, Jan 22, 2021 at 12:27:31PM +0100, Marek Szyprowski wrote:
> If sleeping has been interrupted, return CMD_RET_FAILURE instead of -1
> (CMD_RET_USAGE).
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210128/066193f3/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-28 23:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210122112739eucas1p1ae7fa48eea75d2bf85f132f05eeb229b@eucas1p1.samsung.com>
2021-01-22 11:27 ` [PATCH] cmd: misc: Fix return value for the sleep command Marek Szyprowski
2021-01-24 2:03 ` Simon Glass
2021-01-26 23:51 ` Jaehoon Chung
2021-01-28 23:59 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.