All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mat Martineau <mathew.j.martineau at linux.intel.com>
To: mptcp at lists.01.org
Subject: [MPTCP] [PATCH net-next 08/16] mptcp: drop unused skb in subflow_token_join_request
Date: Thu, 28 Jan 2021 17:11:07 -0800	[thread overview]
Message-ID: <20210129011115.133953-9-mathew.j.martineau@linux.intel.com> (raw)
In-Reply-To: 20210129011115.133953-1-mathew.j.martineau@linux.intel.com

[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]

From: Geliang Tang <geliangtang(a)gmail.com>

This patch drops the unused parameter skb in subflow_token_join_request.

Signed-off-by: Geliang Tang <geliangtang(a)gmail.com>
Signed-off-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
---
 net/mptcp/subflow.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index 50a01546ac34..2dcc0fb5a69e 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -64,8 +64,7 @@ static bool mptcp_can_accept_new_subflow(const struct mptcp_sock *msk)
 }
 
 /* validate received token and create truncated hmac and nonce for SYN-ACK */
-static struct mptcp_sock *subflow_token_join_request(struct request_sock *req,
-						     const struct sk_buff *skb)
+static struct mptcp_sock *subflow_token_join_request(struct request_sock *req)
 {
 	struct mptcp_subflow_request_sock *subflow_req = mptcp_subflow_rsk(req);
 	u8 hmac[SHA256_DIGEST_SIZE];
@@ -181,7 +180,7 @@ static int subflow_init_req(struct request_sock *req,
 		subflow_req->remote_id = mp_opt.join_id;
 		subflow_req->token = mp_opt.token;
 		subflow_req->remote_nonce = mp_opt.nonce;
-		subflow_req->msk = subflow_token_join_request(req, skb);
+		subflow_req->msk = subflow_token_join_request(req);
 
 		/* Can't fall back to TCP in this case. */
 		if (!subflow_req->msk)
-- 
2.30.0

WARNING: multiple messages have this Message-ID (diff)
From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: netdev@vger.kernel.org
Cc: Geliang Tang <geliangtang@gmail.com>,
	davem@davemloft.net, kuba@kernel.org, mptcp@lists.01.org,
	Mat Martineau <mathew.j.martineau@linux.intel.com>
Subject: [PATCH net-next 08/16] mptcp: drop unused skb in subflow_token_join_request
Date: Thu, 28 Jan 2021 17:11:07 -0800	[thread overview]
Message-ID: <20210129011115.133953-9-mathew.j.martineau@linux.intel.com> (raw)
In-Reply-To: <20210129011115.133953-1-mathew.j.martineau@linux.intel.com>

From: Geliang Tang <geliangtang@gmail.com>

This patch drops the unused parameter skb in subflow_token_join_request.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
---
 net/mptcp/subflow.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index 50a01546ac34..2dcc0fb5a69e 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -64,8 +64,7 @@ static bool mptcp_can_accept_new_subflow(const struct mptcp_sock *msk)
 }
 
 /* validate received token and create truncated hmac and nonce for SYN-ACK */
-static struct mptcp_sock *subflow_token_join_request(struct request_sock *req,
-						     const struct sk_buff *skb)
+static struct mptcp_sock *subflow_token_join_request(struct request_sock *req)
 {
 	struct mptcp_subflow_request_sock *subflow_req = mptcp_subflow_rsk(req);
 	u8 hmac[SHA256_DIGEST_SIZE];
@@ -181,7 +180,7 @@ static int subflow_init_req(struct request_sock *req,
 		subflow_req->remote_id = mp_opt.join_id;
 		subflow_req->token = mp_opt.token;
 		subflow_req->remote_nonce = mp_opt.nonce;
-		subflow_req->msk = subflow_token_join_request(req, skb);
+		subflow_req->msk = subflow_token_join_request(req);
 
 		/* Can't fall back to TCP in this case. */
 		if (!subflow_req->msk)
-- 
2.30.0


             reply	other threads:[~2021-01-29  1:11 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29  1:11 Mat Martineau [this message]
2021-01-29  1:11 ` [PATCH net-next 08/16] mptcp: drop unused skb in subflow_token_join_request Mat Martineau
  -- strict thread matches above, loose matches on Subject: below --
2021-01-30  5:55 [MPTCP] Re: [PATCH net-next 01/16] mptcp: use WRITE_ONCE/READ_ONCE for the pernet *_max Jakub Kicinski
2021-01-30  5:55 ` Jakub Kicinski
2021-01-30  5:54 [MPTCP] " Jakub Kicinski
2021-01-30  5:54 ` Jakub Kicinski
2021-01-29  1:11 [MPTCP] [PATCH net-next 16/16] selftests: mptcp: add command line arguments for mptcp_join.sh Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 15/16] selftests: mptcp: add testcases for ADD_ADDR with port Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 14/16] mptcp: add the mibs " Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 13/16] selftests: mptcp: add port argument for pm_nl_ctl Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 12/16] mptcp: deal with MPTCP_PM_ADDR_ATTR_PORT in PM netlink Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 11/16] mptcp: enable use_port when invoke addresses_equal Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 10/16] mptcp: add port number check for MP_JOIN Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 09/16] mptcp: add a new helper subflow_req_create_thmac Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 07/16] mptcp: create the listening socket for new port Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 06/16] selftests: mptcp: add testcases for newly added addresses Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 05/16] selftests: mptcp: use minus values for removing address numbers Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 04/16] mptcp: send ack for every add_addr Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 03/16] mptcp: create subflow or signal addr for newly added address Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 02/16] mptcp: drop *_max fields in mptcp_pm_data Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:11 [MPTCP] [PATCH net-next 01/16] mptcp: use WRITE_ONCE/READ_ONCE for the pernet *_max Mat Martineau
2021-01-29  1:11 ` Mat Martineau
2021-01-29  1:10 [MPTCP] [PATCH net-next 00/16] mptcp: ADD_ADDR enhancements Mat Martineau
2021-01-29  1:10 ` Mat Martineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210129011115.133953-9-mathew.j.martineau@linux.intel.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.