* [PATCH] platform/x86: thinkpad_acpi: rectify length of title underline
@ 2021-01-29 4:08 ` Lukas Bulwahn
0 siblings, 0 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2021-01-29 4:08 UTC (permalink / raw)
To: Nitin Joshi, Hans de Goede, platform-driver-x86
Cc: Andy Shevchenko, Jonathan Corbet, Mauro Carvalho Chehab,
linux-doc, kernel-janitors, linux-kernel, Lukas Bulwahn
Commit d7cbe2773aed ("platform/x86: thinkpad_acpi: set keyboard language")
adds information on keyboard setting to the thinkpad documentation, but
made the subsection title underline too short.
Hence, make htmldocs warns:
Documentation/admin-guide/laptops/thinkpad-acpi.rst:1472: \
WARNING: Title underline too short.
Rectify length of subsection title underline.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
applies cleanly on next-20210128
Nitin, please ack.
Hans, please pick this minor fixup for your platform/x86 -next tree.
Documentation/admin-guide/laptops/thinkpad-acpi.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/admin-guide/laptops/thinkpad-acpi.rst b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
index b1188f05a99a..0e4c5bb7fb70 100644
--- a/Documentation/admin-guide/laptops/thinkpad-acpi.rst
+++ b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
@@ -1469,7 +1469,7 @@ Sysfs notes
Setting keyboard language
--------------------
+-------------------------
sysfs: keyboard_lang
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] platform/x86: thinkpad_acpi: rectify length of title underline
@ 2021-01-29 4:08 ` Lukas Bulwahn
0 siblings, 0 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2021-01-29 4:08 UTC (permalink / raw)
To: Nitin Joshi, Hans de Goede, platform-driver-x86
Cc: Andy Shevchenko, Jonathan Corbet, Mauro Carvalho Chehab,
linux-doc, kernel-janitors, linux-kernel, Lukas Bulwahn
Commit d7cbe2773aed ("platform/x86: thinkpad_acpi: set keyboard language")
adds information on keyboard setting to the thinkpad documentation, but
made the subsection title underline too short.
Hence, make htmldocs warns:
Documentation/admin-guide/laptops/thinkpad-acpi.rst:1472: \
WARNING: Title underline too short.
Rectify length of subsection title underline.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
applies cleanly on next-20210128
Nitin, please ack.
Hans, please pick this minor fixup for your platform/x86 -next tree.
Documentation/admin-guide/laptops/thinkpad-acpi.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/admin-guide/laptops/thinkpad-acpi.rst b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
index b1188f05a99a..0e4c5bb7fb70 100644
--- a/Documentation/admin-guide/laptops/thinkpad-acpi.rst
+++ b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
@@ -1469,7 +1469,7 @@ Sysfs notes
Setting keyboard language
--------------------
+-------------------------
sysfs: keyboard_lang
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] platform/x86: thinkpad_acpi: rectify length of title underline
2021-01-29 4:08 ` Lukas Bulwahn
@ 2021-02-02 14:05 ` Hans de Goede
-1 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2021-02-02 14:05 UTC (permalink / raw)
To: Lukas Bulwahn, Nitin Joshi, platform-driver-x86
Cc: Andy Shevchenko, Jonathan Corbet, Mauro Carvalho Chehab,
linux-doc, kernel-janitors, linux-kernel
Hi,
On 1/29/21 5:08 AM, Lukas Bulwahn wrote:
> Commit d7cbe2773aed ("platform/x86: thinkpad_acpi: set keyboard language")
> adds information on keyboard setting to the thinkpad documentation, but
> made the subsection title underline too short.
>
> Hence, make htmldocs warns:
>
> Documentation/admin-guide/laptops/thinkpad-acpi.rst:1472: \
> WARNING: Title underline too short.
>
> Rectify length of subsection title underline.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> applies cleanly on next-20210128
>
> Nitin, please ack.
>
> Hans, please pick this minor fixup for your platform/x86 -next tree.
>
> Documentation/admin-guide/laptops/thinkpad-acpi.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/laptops/thinkpad-acpi.rst b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
> index b1188f05a99a..0e4c5bb7fb70 100644
> --- a/Documentation/admin-guide/laptops/thinkpad-acpi.rst
> +++ b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
> @@ -1469,7 +1469,7 @@ Sysfs notes
>
>
> Setting keyboard language
> --------------------
> +-------------------------
>
> sysfs: keyboard_lang
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] platform/x86: thinkpad_acpi: rectify length of title underline
@ 2021-02-02 14:05 ` Hans de Goede
0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2021-02-02 14:05 UTC (permalink / raw)
To: Lukas Bulwahn, Nitin Joshi, platform-driver-x86
Cc: Andy Shevchenko, Jonathan Corbet, Mauro Carvalho Chehab,
linux-doc, kernel-janitors, linux-kernel
Hi,
On 1/29/21 5:08 AM, Lukas Bulwahn wrote:
> Commit d7cbe2773aed ("platform/x86: thinkpad_acpi: set keyboard language")
> adds information on keyboard setting to the thinkpad documentation, but
> made the subsection title underline too short.
>
> Hence, make htmldocs warns:
>
> Documentation/admin-guide/laptops/thinkpad-acpi.rst:1472: \
> WARNING: Title underline too short.
>
> Rectify length of subsection title underline.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> applies cleanly on next-20210128
>
> Nitin, please ack.
>
> Hans, please pick this minor fixup for your platform/x86 -next tree.
>
> Documentation/admin-guide/laptops/thinkpad-acpi.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/laptops/thinkpad-acpi.rst b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
> index b1188f05a99a..0e4c5bb7fb70 100644
> --- a/Documentation/admin-guide/laptops/thinkpad-acpi.rst
> +++ b/Documentation/admin-guide/laptops/thinkpad-acpi.rst
> @@ -1469,7 +1469,7 @@ Sysfs notes
>
>
> Setting keyboard language
> --------------------
> +-------------------------
>
> sysfs: keyboard_lang
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-02 18:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-29 4:08 [PATCH] platform/x86: thinkpad_acpi: rectify length of title underline Lukas Bulwahn
2021-01-29 4:08 ` Lukas Bulwahn
2021-02-02 14:05 ` Hans de Goede
2021-02-02 14:05 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.