All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Zhou <chenzhou10@huawei.com>
To: <mingo@redhat.com>, <tglx@linutronix.de>, <rppt@kernel.org>,
	<dyoung@redhat.com>, <bhe@redhat.com>, <catalin.marinas@arm.com>,
	<will@kernel.org>, <nsaenzjulienne@suse.de>, <corbet@lwn.net>,
	<John.P.donnelly@oracle.com>, <bhsharma@redhat.com>,
	<prabhakar.pkin@gmail.com>
Cc: <horms@verge.net.au>, <robh+dt@kernel.org>, <arnd@arndb.de>,
	<james.morse@arm.com>, <xiexiuqi@huawei.com>,
	<guohanjun@huawei.com>, <huawei.libin@huawei.com>,
	<wangkefeng.wang@huawei.com>, <chenzhou10@huawei.com>,
	<linux-doc@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <kexec@lists.infradead.org>,
	John Donnelly <John.p.donnelly@oracle.com>
Subject: [PATCH v14 03/11] x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions reserve_crashkernel()
Date: Sat, 30 Jan 2021 15:10:17 +0800	[thread overview]
Message-ID: <20210130071025.65258-4-chenzhou10@huawei.com> (raw)
In-Reply-To: <20210130071025.65258-1-chenzhou10@huawei.com>

To make the functions reserve_crashkernel() as generic,
replace some hard-coded numbers with macro CRASH_ADDR_LOW_MAX.

Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Tested-by: John Donnelly <John.p.donnelly@oracle.com>
---
 arch/x86/kernel/setup.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 27470479e4a3..086a04235be4 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -487,8 +487,9 @@ static void __init reserve_crashkernel(void)
 	if (!crash_base) {
 		/*
 		 * Set CRASH_ADDR_LOW_MAX upper bound for crash memory,
-		 * crashkernel=x,high reserves memory over 4G, also allocates
-		 * 256M extra low memory for DMA buffers and swiotlb.
+		 * crashkernel=x,high reserves memory over CRASH_ADDR_LOW_MAX,
+		 * also allocates 256M extra low memory for DMA buffers
+		 * and swiotlb.
 		 * But the extra memory is not required for all machines.
 		 * So try low memory first and fall back to high memory
 		 * unless "crashkernel=size[KMG],high" is specified.
@@ -516,7 +517,7 @@ static void __init reserve_crashkernel(void)
 		}
 	}
 
-	if (crash_base >= (1ULL << 32) && reserve_crashkernel_low()) {
+	if (crash_base >= CRASH_ADDR_LOW_MAX && reserve_crashkernel_low()) {
 		memblock_free(crash_base, crash_size);
 		return;
 	}
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Chen Zhou <chenzhou10@huawei.com>
To: <mingo@redhat.com>, <tglx@linutronix.de>, <rppt@kernel.org>,
	<dyoung@redhat.com>, <bhe@redhat.com>, <catalin.marinas@arm.com>,
	<will@kernel.org>, <nsaenzjulienne@suse.de>, <corbet@lwn.net>,
	<John.P.donnelly@oracle.com>, <bhsharma@redhat.com>,
	<prabhakar.pkin@gmail.com>
Cc: John Donnelly <John.p.donnelly@oracle.com>,
	wangkefeng.wang@huawei.com, arnd@arndb.de, xiexiuqi@huawei.com,
	chenzhou10@huawei.com, linux-doc@vger.kernel.org,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, horms@verge.net.au, james.morse@arm.com,
	huawei.libin@huawei.com, guohanjun@huawei.com,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v14 03/11] x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions reserve_crashkernel()
Date: Sat, 30 Jan 2021 15:10:17 +0800	[thread overview]
Message-ID: <20210130071025.65258-4-chenzhou10@huawei.com> (raw)
In-Reply-To: <20210130071025.65258-1-chenzhou10@huawei.com>

To make the functions reserve_crashkernel() as generic,
replace some hard-coded numbers with macro CRASH_ADDR_LOW_MAX.

Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Tested-by: John Donnelly <John.p.donnelly@oracle.com>
---
 arch/x86/kernel/setup.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 27470479e4a3..086a04235be4 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -487,8 +487,9 @@ static void __init reserve_crashkernel(void)
 	if (!crash_base) {
 		/*
 		 * Set CRASH_ADDR_LOW_MAX upper bound for crash memory,
-		 * crashkernel=x,high reserves memory over 4G, also allocates
-		 * 256M extra low memory for DMA buffers and swiotlb.
+		 * crashkernel=x,high reserves memory over CRASH_ADDR_LOW_MAX,
+		 * also allocates 256M extra low memory for DMA buffers
+		 * and swiotlb.
 		 * But the extra memory is not required for all machines.
 		 * So try low memory first and fall back to high memory
 		 * unless "crashkernel=size[KMG],high" is specified.
@@ -516,7 +517,7 @@ static void __init reserve_crashkernel(void)
 		}
 	}
 
-	if (crash_base >= (1ULL << 32) && reserve_crashkernel_low()) {
+	if (crash_base >= CRASH_ADDR_LOW_MAX && reserve_crashkernel_low()) {
 		memblock_free(crash_base, crash_size);
 		return;
 	}
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Chen Zhou <chenzhou10@huawei.com>
To: mingo@redhat.com, tglx@linutronix.de, rppt@kernel.org,
	dyoung@redhat.com, bhe@redhat.com, catalin.marinas@arm.com,
	will@kernel.org, nsaenzjulienne@suse.de, corbet@lwn.net,
	John.P.donnelly@oracle.com, bhsharma@redhat.com,
	prabhakar.pkin@gmail.com
Cc: John Donnelly <John.p.donnelly@oracle.com>,
	wangkefeng.wang@huawei.com, arnd@arndb.de, xiexiuqi@huawei.com,
	chenzhou10@huawei.com, linux-doc@vger.kernel.org,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, horms@verge.net.au, james.morse@arm.com,
	huawei.libin@huawei.com, guohanjun@huawei.com,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v14 03/11] x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions reserve_crashkernel()
Date: Sat, 30 Jan 2021 15:10:17 +0800	[thread overview]
Message-ID: <20210130071025.65258-4-chenzhou10@huawei.com> (raw)
In-Reply-To: <20210130071025.65258-1-chenzhou10@huawei.com>

To make the functions reserve_crashkernel() as generic,
replace some hard-coded numbers with macro CRASH_ADDR_LOW_MAX.

Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Tested-by: John Donnelly <John.p.donnelly@oracle.com>
---
 arch/x86/kernel/setup.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 27470479e4a3..086a04235be4 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -487,8 +487,9 @@ static void __init reserve_crashkernel(void)
 	if (!crash_base) {
 		/*
 		 * Set CRASH_ADDR_LOW_MAX upper bound for crash memory,
-		 * crashkernel=x,high reserves memory over 4G, also allocates
-		 * 256M extra low memory for DMA buffers and swiotlb.
+		 * crashkernel=x,high reserves memory over CRASH_ADDR_LOW_MAX,
+		 * also allocates 256M extra low memory for DMA buffers
+		 * and swiotlb.
 		 * But the extra memory is not required for all machines.
 		 * So try low memory first and fall back to high memory
 		 * unless "crashkernel=size[KMG],high" is specified.
@@ -516,7 +517,7 @@ static void __init reserve_crashkernel(void)
 		}
 	}
 
-	if (crash_base >= (1ULL << 32) && reserve_crashkernel_low()) {
+	if (crash_base >= CRASH_ADDR_LOW_MAX && reserve_crashkernel_low()) {
 		memblock_free(crash_base, crash_size);
 		return;
 	}
-- 
2.20.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2021-01-30  9:15 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-30  7:10 [PATCH v14 00/11] support reserving crashkernel above 4G on arm64 kdump Chen Zhou
2021-01-30  7:10 ` Chen Zhou
2021-01-30  7:10 ` Chen Zhou
2021-01-30  7:10 ` [PATCH v14 01/11] x86: kdump: replace the hard-coded alignment with macro CRASH_ALIGN Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-02-18  3:29   ` Baoquan He
2021-02-18  3:29     ` Baoquan He
2021-02-24 14:19   ` Catalin Marinas
2021-02-24 14:19     ` Catalin Marinas
2021-02-24 14:19     ` Catalin Marinas
2021-02-25  7:25     ` Baoquan He
2021-02-25  7:25       ` Baoquan He
2021-02-25  7:25       ` Baoquan He
2021-02-26  6:45       ` chenzhou
2021-02-26  6:45         ` chenzhou
2021-02-26  6:45         ` chenzhou
2021-02-26 15:38         ` Eric W. Biederman
2021-02-26 15:38           ` Eric W. Biederman
2021-02-26 15:38           ` Eric W. Biederman
2021-03-02  7:43           ` Baoquan He
2021-03-02  7:43             ` Baoquan He
2021-03-02  7:43             ` Baoquan He
2021-03-29  2:34             ` chenzhou
2021-03-29  2:34               ` chenzhou
2021-03-29  2:34               ` chenzhou
2021-01-30  7:10 ` [PATCH v14 02/11] x86: kdump: make the lower bound of crash kernel reservation consistent Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-02-18  3:33   ` Baoquan He
2021-02-18  3:33     ` Baoquan He
2021-02-24 14:35   ` Catalin Marinas
2021-02-24 14:35     ` Catalin Marinas
2021-02-24 14:35     ` Catalin Marinas
2021-02-25  7:08     ` Baoquan He
2021-02-25  7:08       ` Baoquan He
2021-02-25  7:08       ` Baoquan He
2021-02-25 14:42       ` Catalin Marinas
2021-02-25 14:42         ` Catalin Marinas
2021-02-25 14:42         ` Catalin Marinas
2021-02-25 15:44         ` Baoquan He
2021-02-25 15:44           ` Baoquan He
2021-02-25 15:44           ` Baoquan He
2021-02-26  7:32           ` chenzhou
2021-02-26  7:32             ` chenzhou
2021-02-26  7:32             ` chenzhou
2021-01-30  7:10 ` Chen Zhou [this message]
2021-01-30  7:10   ` [PATCH v14 03/11] x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions reserve_crashkernel() Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-02-18  8:23   ` Baoquan He
2021-02-18  8:23     ` Baoquan He
2021-02-18  8:23     ` Baoquan He
2021-01-30  7:10 ` [PATCH v14 04/11] x86: kdump: move xen_pv_domain() check and insert_resource() to setup_arch() Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-02-18  4:14   ` Baoquan He
2021-02-18  4:14     ` Baoquan He
2021-01-30  7:10 ` [PATCH v14 05/11] x86: kdump: move reserve_crashkernel[_low]() into crash_core.c Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-01-30  7:10 ` [PATCH v14 06/11] x86/elf: Move vmcore_elf_check_arch_cross to arch/x86/include/asm/elf.h Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-02-18  6:31   ` Baoquan He
2021-02-18  6:31     ` Baoquan He
2021-02-18  6:31     ` Baoquan He
2021-02-18  7:05     ` chenzhou
2021-02-18  7:05       ` chenzhou
2021-02-18  7:05       ` chenzhou
2021-01-30  7:10 ` [PATCH v14 07/11] arm64: kdump: introduce some macroes for crash kernel reservation Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-02-04 16:20   ` Nicolas Saenz Julienne
2021-02-04 16:20     ` Nicolas Saenz Julienne
2021-02-04 16:20     ` Nicolas Saenz Julienne
2021-02-04 16:27     ` Nicolas Saenz Julienne
2021-02-04 16:27       ` Nicolas Saenz Julienne
2021-02-04 16:27       ` Nicolas Saenz Julienne
2021-01-30  7:10 ` [PATCH v14 08/11] arm64: kdump: reimplement crashkernel=X Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-02-24 16:04   ` Catalin Marinas
2021-02-24 16:04     ` Catalin Marinas
2021-02-24 16:04     ` Catalin Marinas
2021-02-26 10:31     ` chenzhou
2021-02-26 10:31       ` chenzhou
2021-02-26 10:31       ` chenzhou
2021-02-26 10:43       ` chenzhou
2021-02-26 10:43         ` chenzhou
2021-02-26 10:43         ` chenzhou
2021-01-30  7:10 ` [PATCH v14 09/11] x86, arm64: Add ARCH_WANT_RESERVE_CRASH_KERNEL config Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-02-18  7:31   ` Baoquan He
2021-02-18  7:31     ` Baoquan He
2021-02-18  7:31     ` Baoquan He
2021-02-18  7:40     ` Baoquan He
2021-02-18  7:40       ` Baoquan He
2021-02-18  7:40       ` Baoquan He
2021-02-18  8:35   ` Baoquan He
2021-02-18  8:35     ` Baoquan He
2021-02-18  8:35     ` Baoquan He
2021-02-20  3:22     ` chenzhou
2021-02-20  3:22       ` chenzhou
2021-02-20  3:22       ` chenzhou
2021-01-30  7:10 ` [PATCH v14 10/11] arm64: kdump: add memory for devices by DT property linux,usable-memory-range Chen Zhou
2021-01-30  7:10   ` [PATCH v14 10/11] arm64: kdump: add memory for devices by DT property linux, usable-memory-range Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-01-30  7:10 ` [PATCH v14 11/11] kdump: update Documentation about crashkernel Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-01-30  7:10   ` Chen Zhou
2021-01-30 17:53   ` Randy Dunlap
2021-01-30 17:53     ` Randy Dunlap
2021-01-30 17:53     ` Randy Dunlap
2021-02-04  1:53     ` chenzhou
2021-02-04  1:53       ` chenzhou
2021-02-04  1:53       ` chenzhou
2021-02-18  8:40   ` Baoquan He
2021-02-18  8:40     ` Baoquan He
2021-02-18  8:40     ` Baoquan He
2021-02-20  3:25     ` chenzhou
2021-02-20  3:25       ` chenzhou
2021-02-20  3:25       ` chenzhou
2021-02-08  6:46 ` [PATCH v14 00/11] support reserving crashkernel above 4G on arm64 kdump chenzhou
2021-02-08  6:46   ` chenzhou
2021-02-08  6:46   ` chenzhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210130071025.65258-4-chenzhou10@huawei.com \
    --to=chenzhou10@huawei.com \
    --cc=John.P.donnelly@oracle.com \
    --cc=arnd@arndb.de \
    --cc=bhe@redhat.com \
    --cc=bhsharma@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=dyoung@redhat.com \
    --cc=guohanjun@huawei.com \
    --cc=horms@verge.net.au \
    --cc=huawei.libin@huawei.com \
    --cc=james.morse@arm.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nsaenzjulienne@suse.de \
    --cc=prabhakar.pkin@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=rppt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.