From: Matthew Wilcox <willy@infradead.org> To: Alexander Lobakin <alobakin@pm.me> Cc: "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, John Hubbard <jhubbard@nvidia.com>, David Rientjes <rientjes@google.com>, Yisen Zhuang <yisen.zhuang@huawei.com>, Salil Mehta <salil.mehta@huawei.com>, Jesse Brandeburg <jesse.brandeburg@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com>, Saeed Mahameed <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Jesper Dangaard Brouer <brouer@redhat.com>, Ilias Apalodimas <ilias.apalodimas@linaro.org>, Jonathan Lemon <jonathan.lemon@gmail.com>, Willem de Bruijn <willemb@google.com>, Randy Dunlap <rdunlap@infradead.org>, Pablo Neira Ayuso <pablo@netfilter.org>, Dexuan Cui <decui@microsoft.com>, Jakub Sitnicki <jakub@cloudflare.com>, Marco Elver <elver@google.com>, Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 net-next 3/5] net: introduce common dev_page_is_reusable() Date: Sun, 31 Jan 2021 12:22:05 +0000 [thread overview] Message-ID: <20210131122205.GL308988@casper.infradead.org> (raw) In-Reply-To: <20210131120844.7529-4-alobakin@pm.me> On Sun, Jan 31, 2021 at 12:11:52PM +0000, Alexander Lobakin wrote: > A bunch of drivers test the page before reusing/recycling for two > common conditions: > - if a page was allocated under memory pressure (pfmemalloc page); > - if a page was allocated at a distant memory node (to exclude > slowdowns). > > Introduce a new common inline for doing this, with likely() already > folded inside to make driver code a bit simpler. I don't see the need for the 'dev_' prefix. That actually confuses me because it makes me think this is tied to ZONE_DEVICE or some such. So how about calling it just 'page_is_reusable' and putting it in mm.h with page_is_pfmemalloc() and making the comment a little less network-centric? Or call it something like skb_page_is_recyclable() since it's only used by networking today. But I bet it could/should be used more widely. > +/** > + * dev_page_is_reusable - check whether a page can be reused for network Rx > + * @page: the page to test > + * > + * A page shouldn't be considered for reusing/recycling if it was allocated > + * under memory pressure or at a distant memory node. > + * > + * Returns false if this page should be returned to page allocator, true > + * otherwise. > + */ > +static inline bool dev_page_is_reusable(const struct page *page) > +{ > + return likely(page_to_nid(page) == numa_mem_id() && > + !page_is_pfmemalloc(page)); > +} > +
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH v3 net-next 3/5] net: introduce common dev_page_is_reusable() Date: Sun, 31 Jan 2021 12:22:05 +0000 [thread overview] Message-ID: <20210131122205.GL308988@casper.infradead.org> (raw) In-Reply-To: <20210131120844.7529-4-alobakin@pm.me> On Sun, Jan 31, 2021 at 12:11:52PM +0000, Alexander Lobakin wrote: > A bunch of drivers test the page before reusing/recycling for two > common conditions: > - if a page was allocated under memory pressure (pfmemalloc page); > - if a page was allocated at a distant memory node (to exclude > slowdowns). > > Introduce a new common inline for doing this, with likely() already > folded inside to make driver code a bit simpler. I don't see the need for the 'dev_' prefix. That actually confuses me because it makes me think this is tied to ZONE_DEVICE or some such. So how about calling it just 'page_is_reusable' and putting it in mm.h with page_is_pfmemalloc() and making the comment a little less network-centric? Or call it something like skb_page_is_recyclable() since it's only used by networking today. But I bet it could/should be used more widely. > +/** > + * dev_page_is_reusable - check whether a page can be reused for network Rx > + * @page: the page to test > + * > + * A page shouldn't be considered for reusing/recycling if it was allocated > + * under memory pressure or at a distant memory node. > + * > + * Returns false if this page should be returned to page allocator, true > + * otherwise. > + */ > +static inline bool dev_page_is_reusable(const struct page *page) > +{ > + return likely(page_to_nid(page) == numa_mem_id() && > + !page_is_pfmemalloc(page)); > +} > +
next prev parent reply other threads:[~2021-01-31 15:38 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-31 12:11 [PATCH v3 net-next 0/5] net: consolidate page_is_pfmemalloc() usage Alexander Lobakin 2021-01-31 12:11 ` [Intel-wired-lan] " Alexander Lobakin 2021-01-31 12:11 ` [PATCH v3 net-next 1/5] mm: constify page_is_pfmemalloc() argument Alexander Lobakin 2021-01-31 12:11 ` [Intel-wired-lan] " Alexander Lobakin 2021-01-31 12:17 ` Matthew Wilcox 2021-01-31 12:17 ` [Intel-wired-lan] " Matthew Wilcox 2021-01-31 12:11 ` [Intel-wired-lan] [PATCH v3 net-next 2/5] skbuff: constify skb_propagate_pfmemalloc() "page" argument Alexander Lobakin 2021-01-31 12:11 ` [PATCH v3 net-next 3/5] net: introduce common dev_page_is_reusable() Alexander Lobakin 2021-01-31 12:11 ` [Intel-wired-lan] " Alexander Lobakin 2021-01-31 12:22 ` Matthew Wilcox [this message] 2021-01-31 12:22 ` Matthew Wilcox 2021-01-31 12:57 ` Alexander Lobakin 2021-01-31 12:57 ` [Intel-wired-lan] " Alexander Lobakin 2021-01-31 12:12 ` [PATCH v3 net-next 4/5] net: use the new dev_page_is_reusable() instead of private versions Alexander Lobakin 2021-01-31 12:12 ` [Intel-wired-lan] " Alexander Lobakin 2021-01-31 12:12 ` [Intel-wired-lan] [PATCH v3 net-next 5/5] net: page_pool: simplify page recycling condition tests Alexander Lobakin 2021-01-31 12:23 ` Matthew Wilcox 2021-01-31 12:23 ` [Intel-wired-lan] " Matthew Wilcox 2021-01-31 12:48 ` Alexander Lobakin 2021-01-31 12:48 ` [Intel-wired-lan] " Alexander Lobakin 2021-02-02 1:18 ` [PATCH v3 net-next 0/5] net: consolidate page_is_pfmemalloc() usage Jakub Kicinski 2021-02-02 1:18 ` [Intel-wired-lan] " Jakub Kicinski 2021-02-02 13:13 ` Alexander Lobakin 2021-02-02 13:13 ` [Intel-wired-lan] " Alexander Lobakin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210131122205.GL308988@casper.infradead.org \ --to=willy@infradead.org \ --cc=akpm@linux-foundation.org \ --cc=alobakin@pm.me \ --cc=anthony.l.nguyen@intel.com \ --cc=brouer@redhat.com \ --cc=davem@davemloft.net \ --cc=decui@microsoft.com \ --cc=elver@google.com \ --cc=ilias.apalodimas@linaro.org \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jakub@cloudflare.com \ --cc=jesse.brandeburg@intel.com \ --cc=jhubbard@nvidia.com \ --cc=jonathan.lemon@gmail.com \ --cc=kuba@kernel.org \ --cc=leon@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-rdma@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=pablo@netfilter.org \ --cc=rdunlap@infradead.org \ --cc=rientjes@google.com \ --cc=saeedm@nvidia.com \ --cc=salil.mehta@huawei.com \ --cc=willemb@google.com \ --cc=yisen.zhuang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.