From: Stafford Horne <shorne@gmail.com>
To: Jan Henrik Weinstock <jan.weinstock@rwth-aachen.de>
Cc: geert@linux-m68k.org, jonas@southpole.se,
stefan.kristiansson@saunalahti.fi, openrisc@lists.librecores.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] openrisc: use device tree to determine present cpus
Date: Mon, 1 Feb 2021 06:27:52 +0900 [thread overview]
Message-ID: <20210131212752.GG2002709@lianli.shorne-pla.net> (raw)
In-Reply-To: <d9f4aafc-4d65-38b0-dde0-5e155836aee1@rwth-aachen.de>
On Sun, Jan 31, 2021 at 09:22:31AM +0100, Jan Henrik Weinstock wrote:
> On 31/01/2021 00:03, Stafford Horne wrote:
>
> > This looks good, one small comment below. Can you send the next patch as a v2?
> >
> > Using 'git format-patch -v2 ...'
>
> Sorry, was not aware of that, will do better next time!
>
> > Should we warn on the else case?
>
> I think it is fine for the kernel to have room for more CPUs than are
> actually present (i.e. NR_CPUs > present_cpus is OK). Other Archs do not
> show a warning in this case either, therefore I also omitted it.
Fair enough.
Reviewed-by: Stafford Horne <shorne@gmail.com>
I can queue this for 5.12 when you send v2.
-Stafford
WARNING: multiple messages have this Message-ID (diff)
From: Stafford Horne <shorne@gmail.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH] openrisc: use device tree to determine present cpus
Date: Mon, 1 Feb 2021 06:27:52 +0900 [thread overview]
Message-ID: <20210131212752.GG2002709@lianli.shorne-pla.net> (raw)
In-Reply-To: <d9f4aafc-4d65-38b0-dde0-5e155836aee1@rwth-aachen.de>
On Sun, Jan 31, 2021 at 09:22:31AM +0100, Jan Henrik Weinstock wrote:
> On 31/01/2021 00:03, Stafford Horne wrote:
>
> > This looks good, one small comment below. Can you send the next patch as a v2?
> >
> > Using 'git format-patch -v2 ...'
>
> Sorry, was not aware of that, will do better next time!
>
> > Should we warn on the else case?
>
> I think it is fine for the kernel to have room for more CPUs than are
> actually present (i.e. NR_CPUs > present_cpus is OK). Other Archs do not
> show a warning in this case either, therefore I also omitted it.
Fair enough.
Reviewed-by: Stafford Horne <shorne@gmail.com>
I can queue this for 5.12 when you send v2.
-Stafford
next prev parent reply other threads:[~2021-01-31 21:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 18:29 [PATCH] openrisc: use device tree to determine present cpus Jan Henrik Weinstock
2021-01-29 18:29 ` [OpenRISC] " Jan Henrik Weinstock
2021-01-29 22:16 ` Stafford Horne
2021-01-29 22:16 ` [OpenRISC] " Stafford Horne
2021-01-30 11:00 ` Jan Henrik Weinstock
2021-01-30 11:00 ` [OpenRISC] " Jan Henrik Weinstock
2021-01-30 23:03 ` Stafford Horne
2021-01-30 23:03 ` [OpenRISC] " Stafford Horne
2021-01-30 23:11 ` Stafford Horne
2021-01-30 23:11 ` [OpenRISC] " Stafford Horne
2021-01-31 8:22 ` Jan Henrik Weinstock
2021-01-31 8:22 ` [OpenRISC] " Jan Henrik Weinstock
2021-01-31 21:27 ` Stafford Horne [this message]
2021-01-31 21:27 ` Stafford Horne
2021-02-01 11:49 ` [PATCH v2] " Jan Henrik Weinstock
2021-02-01 11:49 ` [OpenRISC] " Jan Henrik Weinstock
2021-02-05 14:43 ` Stafford Horne
2021-02-05 14:43 ` [OpenRISC] " Stafford Horne
2021-02-05 16:07 ` Geert Uytterhoeven
2021-02-05 16:07 ` [OpenRISC] " Geert Uytterhoeven
2021-02-05 22:36 ` Stafford Horne
2021-02-05 22:36 ` [OpenRISC] " Stafford Horne
2021-02-06 9:33 ` Geert Uytterhoeven
2021-02-06 9:33 ` [OpenRISC] " Geert Uytterhoeven
2021-02-08 12:16 ` Stafford Horne
2021-02-08 12:22 ` Geert Uytterhoeven
2021-02-08 12:22 ` [OpenRISC] " Geert Uytterhoeven
2021-01-30 10:37 ` [PATCH] " Geert Uytterhoeven
2021-01-30 10:37 ` [OpenRISC] " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210131212752.GG2002709@lianli.shorne-pla.net \
--to=shorne@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jan.weinstock@rwth-aachen.de \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=openrisc@lists.librecores.org \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.