From: Chao Leng <lengchao@huawei.com> To: <linux-nvme@lists.infradead.org> Cc: <kbusch@kernel.org>, <axboe@fb.com>, <hch@lst.de>, <sagi@grimberg.me>, <linux-block@vger.kernel.org>, <axboe@kernel.dk> Subject: [PATCH v5 0/3] avoid double request completion and IO error Date: Mon, 1 Feb 2021 11:49:37 +0800 [thread overview] Message-ID: <20210201034940.18891-1-lengchao@huawei.com> (raw) First, avoid double request completion for nvmf_fail_nonready_command if the request is freed asynchronously. Second, avoid IO error. If work with nvme native multipath, rdma HBA drivers may failed due to failed hardware, queue_rq should failed the request instead of returning error to block layer, So upper layer can failover the request if another path is available. Need set the state of request to MQ_RQ_COMPLETE when queue_rq directly complete the request. So introduce blk_mq_set_request_complete. V5: - add comment for blk_mq_set_request_complete. - fail the request just for -EIO returned by rdma HBA drivers. - delete the helper: nvme_complete_failed_req. V4: - add status parameter for nvme_complete_failed_req. - export nvme_complete_failed_req instead of inline function. V3: - complete the request just for HBA driver path related error. V2: - use "switch" instead "if" to check return status. Chao Leng (3): blk-mq: introduce blk_mq_set_request_complete nvme-fabrics: avoid double request completion for nvmf_fail_nonready_command nvme-rdma: avoid IO error for nvme native multipath drivers/nvme/host/fabrics.c | 2 +- drivers/nvme/host/rdma.c | 13 ++++++++++++- include/linux/blk-mq.h | 9 +++++++++ 3 files changed, 22 insertions(+), 2 deletions(-) -- 2.16.4
WARNING: multiple messages have this Message-ID (diff)
From: Chao Leng <lengchao@huawei.com> To: <linux-nvme@lists.infradead.org> Cc: axboe@kernel.dk, linux-block@vger.kernel.org, sagi@grimberg.me, axboe@fb.com, kbusch@kernel.org, hch@lst.de Subject: [PATCH v5 0/3] avoid double request completion and IO error Date: Mon, 1 Feb 2021 11:49:37 +0800 [thread overview] Message-ID: <20210201034940.18891-1-lengchao@huawei.com> (raw) First, avoid double request completion for nvmf_fail_nonready_command if the request is freed asynchronously. Second, avoid IO error. If work with nvme native multipath, rdma HBA drivers may failed due to failed hardware, queue_rq should failed the request instead of returning error to block layer, So upper layer can failover the request if another path is available. Need set the state of request to MQ_RQ_COMPLETE when queue_rq directly complete the request. So introduce blk_mq_set_request_complete. V5: - add comment for blk_mq_set_request_complete. - fail the request just for -EIO returned by rdma HBA drivers. - delete the helper: nvme_complete_failed_req. V4: - add status parameter for nvme_complete_failed_req. - export nvme_complete_failed_req instead of inline function. V3: - complete the request just for HBA driver path related error. V2: - use "switch" instead "if" to check return status. Chao Leng (3): blk-mq: introduce blk_mq_set_request_complete nvme-fabrics: avoid double request completion for nvmf_fail_nonready_command nvme-rdma: avoid IO error for nvme native multipath drivers/nvme/host/fabrics.c | 2 +- drivers/nvme/host/rdma.c | 13 ++++++++++++- include/linux/blk-mq.h | 9 +++++++++ 3 files changed, 22 insertions(+), 2 deletions(-) -- 2.16.4 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2021-02-01 3:50 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-01 3:49 Chao Leng [this message] 2021-02-01 3:49 ` [PATCH v5 0/3] avoid double request completion and IO error Chao Leng 2021-02-01 3:49 ` [PATCH v5 1/3] blk-mq: introduce blk_mq_set_request_complete Chao Leng 2021-02-01 3:49 ` Chao Leng 2021-02-04 15:27 ` Jens Axboe 2021-02-04 15:27 ` Jens Axboe 2021-02-04 15:30 ` Christoph Hellwig 2021-02-04 15:30 ` Christoph Hellwig 2021-02-04 15:32 ` Jens Axboe 2021-02-04 15:32 ` Jens Axboe 2021-02-04 15:36 ` Christoph Hellwig 2021-02-04 15:36 ` Christoph Hellwig 2021-02-04 15:41 ` Jens Axboe 2021-02-04 15:41 ` Jens Axboe 2021-02-01 3:49 ` [PATCH v5 2/3] nvme-fabrics: avoid double request completion for nvmf_fail_nonready_command Chao Leng 2021-02-01 3:49 ` Chao Leng 2021-02-01 3:49 ` [PATCH v5 3/3] nvme-rdma: avoid IO error for nvme native multipath Chao Leng 2021-02-01 3:49 ` Chao Leng 2021-02-03 16:14 ` [PATCH v5 0/3] avoid double request completion and IO error Christoph Hellwig 2021-02-03 16:14 ` Christoph Hellwig 2021-02-03 22:22 ` Sagi Grimberg 2021-02-03 22:22 ` Sagi Grimberg 2021-02-04 5:56 ` Chao Leng 2021-02-04 5:56 ` Chao Leng 2021-02-04 8:04 ` Christoph Hellwig 2021-02-04 8:04 ` Christoph Hellwig 2021-02-05 2:02 ` Chao Leng 2021-02-05 2:02 ` Chao Leng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210201034940.18891-1-lengchao@huawei.com \ --to=lengchao@huawei.com \ --cc=axboe@fb.com \ --cc=axboe@kernel.dk \ --cc=hch@lst.de \ --cc=kbusch@kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.