All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Edwin Peer <edwin.peer@broadcom.com>
Cc: Danielle Ratson <danieller@nvidia.com>,
	Michal Kubecek <mkubecek@suse.cz>,
	netdev <netdev@vger.kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Jiri Pirko <jiri@nvidia.com>, Andrew Lunn <andrew@lunn.ch>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	mlxsw <mlxsw@nvidia.com>, Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net-next v3 2/7] ethtool: Get link mode in use instead of speed and duplex parameters
Date: Mon, 1 Feb 2021 17:08:06 -0800	[thread overview]
Message-ID: <20210201170806.1861e49a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAKOOJTzRs5xLwGHFDvCAhK8v88stoPhzrbg-hPBte9c+ia0yxg@mail.gmail.com>

On Mon, 1 Feb 2021 16:14:05 -0800 Edwin Peer wrote:
> > > Yes, there would be multiple link modes that map to the same speed and
> > > lane combination, but that doesn't mean you need to accept them if the
> > > media doesn't match what's plugged in also. In the above scenario, the
> > > supported mask should not list SR because CR is physically plugged in.
> > > That way, the user knows what options are legal and the kernel knows
> > > what it can reject.  
> >
> > If the modes depend on what's plugged in - what happens if cable gets
> > removed? We (you, Danielle, I) can agree what we think is best, but
> > history teaches us that doesn't matter in long run. We had a similar
> > conversation when it comes to FEC. There simply is no way for upstream
> > developers to review the behavior is correct.  
> 
> Given that supported is only defined in the context of autoneg today,
> once could still specify. But again, you raise a fair concern.
> 
> The asymmetry in interface is still ugly though, you get to decide
> which ugly is worse. :P

Let's move with this series as is. We can see how prevalent the use of
link_mode is on get side first.

  reply	other threads:[~2021-02-02  1:09 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  9:37 [PATCH net-next v3 0/7] Support setting lanes via ethtool Danielle Ratson
2021-01-20  9:37 ` [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI with lanes Danielle Ratson
2021-01-20 22:35   ` Edwin Peer
2021-02-02 18:08     ` Danielle Ratson
2021-01-22  3:44   ` Jakub Kicinski
2021-01-25 15:53     ` Danielle Ratson
2021-01-25 19:02       ` Jakub Kicinski
2021-01-20  9:37 ` [PATCH net-next v3 2/7] ethtool: Get link mode in use instead of speed and duplex parameters Danielle Ratson
2021-01-20 23:39   ` Edwin Peer
2021-01-24  8:36     ` Danielle Ratson
2021-01-25 18:03       ` Edwin Peer
2021-01-26 17:06         ` Danielle Ratson
2021-01-26 17:14           ` Edwin Peer
2021-01-27 13:22             ` Danielle Ratson
2021-01-28 20:26               ` Michal Kubecek
2021-01-31 15:33                 ` Danielle Ratson
2021-01-31 17:39                   ` Edwin Peer
2021-02-01 13:49                     ` Danielle Ratson
2021-02-01 18:14                       ` Edwin Peer
2021-02-01 20:29                         ` Jakub Kicinski
2021-02-01 21:05                           ` Edwin Peer
2021-02-01 21:41                             ` Jakub Kicinski
2021-02-01 21:59                               ` Edwin Peer
2021-02-01 22:20                                 ` Jakub Kicinski
2021-02-02  0:14                                   ` Edwin Peer
2021-02-02  1:08                                     ` Jakub Kicinski [this message]
2021-01-20  9:37 ` [PATCH net-next v3 3/7] ethtool: Expose the number of lanes in use Danielle Ratson
2021-01-20  9:37 ` [PATCH net-next v3 4/7] mlxsw: ethtool: Remove max lanes filtering Danielle Ratson
2021-01-20  9:37 ` [PATCH net-next v3 5/7] mlxsw: ethtool: Add support for setting lanes when autoneg is off Danielle Ratson
2021-01-20  9:37 ` [PATCH net-next v3 6/7] mlxsw: ethtool: Pass link mode in use to ethtool Danielle Ratson
2021-01-20  9:37 ` [PATCH net-next v3 7/7] net: selftests: Add lanes setting test Danielle Ratson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210201170806.1861e49a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=danieller@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edwin.peer@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@nvidia.com \
    --cc=jiri@nvidia.com \
    --cc=mkubecek@suse.cz \
    --cc=mlxsw@nvidia.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.