From: Danielle Ratson <danieller@nvidia.com>
To: Edwin Peer <edwin.peer@broadcom.com>
Cc: netdev <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@nvidia.com>,
Andrew Lunn <andrew@lunn.ch>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"Michal Kubecek" <mkubecek@suse.cz>, mlxsw <mlxsw@nvidia.com>,
Ido Schimmel <idosch@nvidia.com>
Subject: RE: [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI with lanes
Date: Tue, 2 Feb 2021 18:08:34 +0000 [thread overview]
Message-ID: <DM6PR12MB4516A65A5F8E42089D7D3AACD8B59@DM6PR12MB4516.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAKOOJTxG2_fV3kSuTpeVLOwSXBug==zaEzQVnn6O3Tsy=Hh9AQ@mail.gmail.com>
> -----Original Message-----
> From: Edwin Peer <edwin.peer@broadcom.com>
> Sent: Thursday, January 21, 2021 12:36 AM
> To: Danielle Ratson <danieller@nvidia.com>
> Cc: netdev <netdev@vger.kernel.org>; David S . Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Jiri Pirko
> <jiri@nvidia.com>; Andrew Lunn <andrew@lunn.ch>; f.fainelli@gmail.com; Michal Kubecek <mkubecek@suse.cz>; mlxsw
> <mlxsw@nvidia.com>; Ido Schimmel <idosch@nvidia.com>
> Subject: Re: [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI with lanes
>
> On Wed, Jan 20, 2021 at 3:21 AM Danielle Ratson <danieller@nvidia.com> wrote:
>
> > -#define __DEFINE_LINK_MODE_PARAMS(_speed, _type, _duplex) \
> > +#define __DEFINE_LINK_MODE_PARAMS(_speed, _type, _lanes, _duplex) \
> > [ETHTOOL_LINK_MODE(_speed, _type, _duplex)] = { \
> > .speed = SPEED_ ## _speed, \
> > + .lanes = _lanes, \
> > .duplex = __DUPLEX_ ## _duplex \
> > }
>
> What about:
>
> #define __DECLARE_LINK_MODE_LANES(_type, _lanes) \
> static const u32 __LINK_MODE_LANES_ ## _type = _lanes;
>
> #define __DECLARE_LINK_MODE_LANES_ALL(_type) \
> __DECLARE_LINK_MODE_LANES(_type, 1) \
> __DECLARE_LINK_MODE_LANES(_type ## 2, 2) \
> __DECLARE_LINK_MODE_LANES(_type ## 4, 4) \
> __DECLARE_LINK_MODE_LANES(_type ## 8, 8)
>
> __DECLARE_LINK_MODE_LANES_ALL(CR)
> __DECLARE_LINK_MODE_LANES_ALL(DR)
> __DECLARE_LINK_MODE_LANES_ALL(ER)
> __DECLARE_LINK_MODE_LANES_ALL(KR)
> __DECLARE_LINK_MODE_LANES(KX, 1)
> __DECLARE_LINK_MODE_LANES(KX4, 4)
> __DECLARE_LINK_MODE_LANES_ALL(LR)
> __DECLARE_LINK_MODE_LANES(LR_ER_FR, 1)
> __DECLARE_LINK_MODE_LANES(LR2_ER2_FR2, 2)
> __DECLARE_LINK_MODE_LANES(LR4_ER4_FR4, 4)
> __DECLARE_LINK_MODE_LANES(LR8_ER8_FR8, 8)
> __DECLARE_LINK_MODE_LANES(LRM, 1)
> __DECLARE_LINK_MODE_LANES(MLD2, 2);
> __DECLARE_LINK_MODE_LANES_ALL(SR);
> __DECLARE_LINK_MODE_LANES(T, 1)
> __DECLARE_LINK_MODE_LANES(X, 1)
>
> #define __DEFINE_LINK_MODE_PARAMS(_speed, _type, _duplex)
> [ETHTOOL_LINK_MODE(_speed, _type, _duplex)] = { \
> .speed = SPEED_ ## _speed, \
> .lanes = __LINK_MODE_LANES ## _type, \
>
> instead of specifying lanes for each link mode defined below?
>
> Regards,
> Edwin Peer
Thanks for the advice, due to some checkpatch issues, I used your suggestion with a small change.
Danielle
>
> > static const struct link_mode_info link_mode_params[] = {
> > - __DEFINE_LINK_MODE_PARAMS(10, T, Half),
> > - __DEFINE_LINK_MODE_PARAMS(10, T, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100, T, Half),
> > - __DEFINE_LINK_MODE_PARAMS(100, T, Full),
> > - __DEFINE_LINK_MODE_PARAMS(1000, T, Half),
> > - __DEFINE_LINK_MODE_PARAMS(1000, T, Full),
> > + __DEFINE_LINK_MODE_PARAMS(10, T, 1, Half),
> > + __DEFINE_LINK_MODE_PARAMS(10, T, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100, T, 1, Half),
> > + __DEFINE_LINK_MODE_PARAMS(100, T, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(1000, T, 1, Half),
> > + __DEFINE_LINK_MODE_PARAMS(1000, T, 1, Full),
> > __DEFINE_SPECIAL_MODE_PARAMS(Autoneg),
> > __DEFINE_SPECIAL_MODE_PARAMS(TP),
> > __DEFINE_SPECIAL_MODE_PARAMS(AUI),
> > __DEFINE_SPECIAL_MODE_PARAMS(MII),
> > __DEFINE_SPECIAL_MODE_PARAMS(FIBRE),
> > __DEFINE_SPECIAL_MODE_PARAMS(BNC),
> > - __DEFINE_LINK_MODE_PARAMS(10000, T, Full),
> > + __DEFINE_LINK_MODE_PARAMS(10000, T, 1, Full),
> > __DEFINE_SPECIAL_MODE_PARAMS(Pause),
> > __DEFINE_SPECIAL_MODE_PARAMS(Asym_Pause),
> > - __DEFINE_LINK_MODE_PARAMS(2500, X, Full),
> > + __DEFINE_LINK_MODE_PARAMS(2500, X, 1, Full),
> > __DEFINE_SPECIAL_MODE_PARAMS(Backplane),
> > - __DEFINE_LINK_MODE_PARAMS(1000, KX, Full),
> > - __DEFINE_LINK_MODE_PARAMS(10000, KX4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(10000, KR, Full),
> > + __DEFINE_LINK_MODE_PARAMS(1000, KX, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(10000, KX4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(10000, KR, 1, Full),
> > [ETHTOOL_LINK_MODE_10000baseR_FEC_BIT] = {
> > .speed = SPEED_10000,
> > .duplex = DUPLEX_FULL,
> > },
> > - __DEFINE_LINK_MODE_PARAMS(20000, MLD2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(20000, KR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(40000, KR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(40000, CR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(40000, SR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(40000, LR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(56000, KR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(56000, CR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(56000, SR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(56000, LR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(25000, CR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(25000, KR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(25000, SR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(50000, CR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(50000, KR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100000, KR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100000, SR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100000, CR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100000, LR4_ER4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(50000, SR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(1000, X, Full),
> > - __DEFINE_LINK_MODE_PARAMS(10000, CR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(10000, SR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(10000, LR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(10000, LRM, Full),
> > - __DEFINE_LINK_MODE_PARAMS(10000, ER, Full),
> > - __DEFINE_LINK_MODE_PARAMS(2500, T, Full),
> > - __DEFINE_LINK_MODE_PARAMS(5000, T, Full),
> > + __DEFINE_LINK_MODE_PARAMS(20000, MLD2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(20000, KR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(40000, KR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(40000, CR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(40000, SR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(40000, LR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(56000, KR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(56000, CR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(56000, SR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(56000, LR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(25000, CR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(25000, KR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(25000, SR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(50000, CR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(50000, KR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, KR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, SR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, CR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, LR4_ER4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(50000, SR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(1000, X, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(10000, CR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(10000, SR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(10000, LR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(10000, LRM, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(10000, ER, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(2500, T, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(5000, T, 1, Full),
> > __DEFINE_SPECIAL_MODE_PARAMS(FEC_NONE),
> > __DEFINE_SPECIAL_MODE_PARAMS(FEC_RS),
> > __DEFINE_SPECIAL_MODE_PARAMS(FEC_BASER),
> > - __DEFINE_LINK_MODE_PARAMS(50000, KR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(50000, SR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(50000, CR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(50000, LR_ER_FR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(50000, DR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100000, KR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100000, SR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100000, CR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100000, LR2_ER2_FR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100000, DR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(200000, KR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(200000, SR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(200000, LR4_ER4_FR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(200000, DR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(200000, CR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100, T1, Full),
> > - __DEFINE_LINK_MODE_PARAMS(1000, T1, Full),
> > - __DEFINE_LINK_MODE_PARAMS(400000, KR8, Full),
> > - __DEFINE_LINK_MODE_PARAMS(400000, SR8, Full),
> > - __DEFINE_LINK_MODE_PARAMS(400000, LR8_ER8_FR8, Full),
> > - __DEFINE_LINK_MODE_PARAMS(400000, DR8, Full),
> > - __DEFINE_LINK_MODE_PARAMS(400000, CR8, Full),
> > + __DEFINE_LINK_MODE_PARAMS(50000, KR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(50000, SR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(50000, CR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(50000, LR_ER_FR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(50000, DR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, KR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, SR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, CR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, LR2_ER2_FR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, DR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(200000, KR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(200000, SR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(200000, LR4_ER4_FR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(200000, DR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(200000, CR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100, T1, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(1000, T1, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(400000, KR8, 8, Full),
> > + __DEFINE_LINK_MODE_PARAMS(400000, SR8, 8, Full),
> > + __DEFINE_LINK_MODE_PARAMS(400000, LR8_ER8_FR8, 8, Full),
> > + __DEFINE_LINK_MODE_PARAMS(400000, DR8, 8, Full),
> > + __DEFINE_LINK_MODE_PARAMS(400000, CR8, 8, Full),
> > __DEFINE_SPECIAL_MODE_PARAMS(FEC_LLRS),
> > - __DEFINE_LINK_MODE_PARAMS(100000, KR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100000, SR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100000, LR_ER_FR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100000, DR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100000, CR, Full),
> > - __DEFINE_LINK_MODE_PARAMS(200000, KR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(200000, SR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(200000, LR2_ER2_FR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(200000, DR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(200000, CR2, Full),
> > - __DEFINE_LINK_MODE_PARAMS(400000, KR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(400000, SR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(400000, LR4_ER4_FR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(400000, DR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(400000, CR4, Full),
> > - __DEFINE_LINK_MODE_PARAMS(100, FX, Half),
> > - __DEFINE_LINK_MODE_PARAMS(100, FX, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, KR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, SR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, LR_ER_FR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, DR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100000, CR, 1, Full),
> > + __DEFINE_LINK_MODE_PARAMS(200000, KR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(200000, SR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(200000, LR2_ER2_FR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(200000, DR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(200000, CR2, 2, Full),
> > + __DEFINE_LINK_MODE_PARAMS(400000, KR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(400000, SR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(400000, LR4_ER4_FR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(400000, DR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(400000, CR4, 4, Full),
> > + __DEFINE_LINK_MODE_PARAMS(100, FX, 1, Half),
> > + __DEFINE_LINK_MODE_PARAMS(100, FX, 1, Full),
> > };
next prev parent reply other threads:[~2021-02-02 18:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 9:37 [PATCH net-next v3 0/7] Support setting lanes via ethtool Danielle Ratson
2021-01-20 9:37 ` [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI with lanes Danielle Ratson
2021-01-20 22:35 ` Edwin Peer
2021-02-02 18:08 ` Danielle Ratson [this message]
2021-01-22 3:44 ` Jakub Kicinski
2021-01-25 15:53 ` Danielle Ratson
2021-01-25 19:02 ` Jakub Kicinski
2021-01-20 9:37 ` [PATCH net-next v3 2/7] ethtool: Get link mode in use instead of speed and duplex parameters Danielle Ratson
2021-01-20 23:39 ` Edwin Peer
2021-01-24 8:36 ` Danielle Ratson
2021-01-25 18:03 ` Edwin Peer
2021-01-26 17:06 ` Danielle Ratson
2021-01-26 17:14 ` Edwin Peer
2021-01-27 13:22 ` Danielle Ratson
2021-01-28 20:26 ` Michal Kubecek
2021-01-31 15:33 ` Danielle Ratson
2021-01-31 17:39 ` Edwin Peer
2021-02-01 13:49 ` Danielle Ratson
2021-02-01 18:14 ` Edwin Peer
2021-02-01 20:29 ` Jakub Kicinski
2021-02-01 21:05 ` Edwin Peer
2021-02-01 21:41 ` Jakub Kicinski
2021-02-01 21:59 ` Edwin Peer
2021-02-01 22:20 ` Jakub Kicinski
2021-02-02 0:14 ` Edwin Peer
2021-02-02 1:08 ` Jakub Kicinski
2021-01-20 9:37 ` [PATCH net-next v3 3/7] ethtool: Expose the number of lanes in use Danielle Ratson
2021-01-20 9:37 ` [PATCH net-next v3 4/7] mlxsw: ethtool: Remove max lanes filtering Danielle Ratson
2021-01-20 9:37 ` [PATCH net-next v3 5/7] mlxsw: ethtool: Add support for setting lanes when autoneg is off Danielle Ratson
2021-01-20 9:37 ` [PATCH net-next v3 6/7] mlxsw: ethtool: Pass link mode in use to ethtool Danielle Ratson
2021-01-20 9:37 ` [PATCH net-next v3 7/7] net: selftests: Add lanes setting test Danielle Ratson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB4516A65A5F8E42089D7D3AACD8B59@DM6PR12MB4516.namprd12.prod.outlook.com \
--to=danieller@nvidia.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edwin.peer@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.