Re: [PATCH v3] KVM: kvmclock: Fix vCPUs > 64 can't be online/hotpluged

From: kernel test robot <lkp@intel.com>
To: Wanpeng Li <kernellwp@gmail.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: kbuild-all@lists.01.org, Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
	Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH v3] KVM: kvmclock: Fix vCPUs > 64 can't be online/hotpluged
Date: Mon, 1 Feb 2021 19:21:25 +0800	[thread overview]
Message-ID: <202102011952.5r7hdiEm-lkp@intel.com> (raw)
In-Reply-To: <1612168596-3782-1-git-send-email-wanpengli@tencent.com>

[-- Attachment #1: Type: text/plain, Size: 3115 bytes --]

Hi Wanpeng,

I love your patch! Perhaps something to improve:

[auto build test WARNING on kvm/linux-next]
[also build test WARNING on linux/master vhost/linux-next next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Wanpeng-Li/KVM-kvmclock-Fix-vCPUs-64-can-t-be-online-hotpluged/20210201-163927
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/132ae1cea476666dff619b5a7c5675011edd7fe7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Wanpeng-Li/KVM-kvmclock-Fix-vCPUs-64-can-t-be-online-hotpluged/20210201-163927
        git checkout 132ae1cea476666dff619b5a7c5675011edd7fe7
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   arch/x86/kernel/kvmclock.c: In function 'kvm_setup_vsyscall_timeinfo':
>> arch/x86/kernel/kvmclock.c:274:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     274 |  u8 flags;
         |  ^~

vim +274 arch/x86/kernel/kvmclock.c

6a1cac56f41f9e Brijesh Singh   2018-09-14  268  
e499a9b6dc488a Thomas Gleixner 2018-07-19  269  static int __init kvm_setup_vsyscall_timeinfo(void)
e499a9b6dc488a Thomas Gleixner 2018-07-19  270  {
132ae1cea47666 Wanpeng Li      2021-02-01  271  	kvmclock_init_mem();
132ae1cea47666 Wanpeng Li      2021-02-01  272  
e499a9b6dc488a Thomas Gleixner 2018-07-19  273  #ifdef CONFIG_X86_64
e499a9b6dc488a Thomas Gleixner 2018-07-19 @274  	u8 flags;
e499a9b6dc488a Thomas Gleixner 2018-07-19  275  
95a3d4454bb1cf Thomas Gleixner 2018-07-19  276  	if (!per_cpu(hv_clock_per_cpu, 0) || !kvmclock_vsyscall)
e499a9b6dc488a Thomas Gleixner 2018-07-19  277  		return 0;
e499a9b6dc488a Thomas Gleixner 2018-07-19  278  
95a3d4454bb1cf Thomas Gleixner 2018-07-19  279  	flags = pvclock_read_flags(&hv_clock_boot[0].pvti);
e499a9b6dc488a Thomas Gleixner 2018-07-19  280  	if (!(flags & PVCLOCK_TSC_STABLE_BIT))
95a3d4454bb1cf Thomas Gleixner 2018-07-19  281  		return 0;
e499a9b6dc488a Thomas Gleixner 2018-07-19  282  
b95a8a27c300d1 Thomas Gleixner 2020-02-07  283  	kvm_clock.vdso_clock_mode = VDSO_CLOCKMODE_PVCLOCK;
e499a9b6dc488a Thomas Gleixner 2018-07-19  284  #endif
6a1cac56f41f9e Brijesh Singh   2018-09-14  285  
e499a9b6dc488a Thomas Gleixner 2018-07-19  286  	return 0;
e499a9b6dc488a Thomas Gleixner 2018-07-19  287  }
e499a9b6dc488a Thomas Gleixner 2018-07-19  288  early_initcall(kvm_setup_vsyscall_timeinfo);
e499a9b6dc488a Thomas Gleixner 2018-07-19  289  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64347 bytes --]