All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Erik Rosen <erik.rosen@metormote.com>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH 1/2] Clear sensor data after chip write
Date: Mon, 1 Feb 2021 16:24:56 -0800	[thread overview]
Message-ID: <20210202002456.GA117432@roeck-us.net> (raw)
In-Reply-To: <20210201195929.1200-2-erik.rosen@metormote.com>

On Mon, Feb 01, 2021 at 08:59:28PM +0100, Erik Rosen wrote:
> Set the sensor->data field to -ENODATA to force a chip access next time
> the sensor value is read.
> 
> Signed-off-by: Erik Rosen <erik.rosen@metormote.com>

Applied. Please remember to add subsystem and driver to future patches.
In this case, I added:

hwmon: (pmbus) ...

Thanks,
Guenter

> ---
>  drivers/hwmon/pmbus/pmbus_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> index 192442b3b7a2..e27f23eee1e3 100644
> --- a/drivers/hwmon/pmbus/pmbus_core.c
> +++ b/drivers/hwmon/pmbus/pmbus_core.c
> @@ -974,7 +974,7 @@ static ssize_t pmbus_set_sensor(struct device *dev,
>  	if (ret < 0)
>  		rv = ret;
>  	else
> -		sensor->data = regval;
> +		sensor->data = -ENODATA;
>  	mutex_unlock(&data->update_lock);
>  	return rv;
>  }

  reply	other threads:[~2021-02-02  0:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 19:59 [PATCH 0/2] Set sensor->data to -ENODATA after write Erik Rosen
2021-02-01 19:59 ` [PATCH 1/2] Clear sensor data after chip write Erik Rosen
2021-02-02  0:24   ` Guenter Roeck [this message]
2021-02-01 19:59 ` [PATCH 2/2] Remove unnecessary pmbus_clear_cache function call Erik Rosen
2021-02-02  0:26   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210202002456.GA117432@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=erik.rosen@metormote.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.