From: Guenter Roeck <linux@roeck-us.net>
To: Erik Rosen <erik.rosen@metormote.com>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH 2/2] Remove unnecessary pmbus_clear_cache function call
Date: Mon, 1 Feb 2021 16:26:41 -0800 [thread overview]
Message-ID: <20210202002641.GA117591@roeck-us.net> (raw)
In-Reply-To: <20210201195929.1200-3-erik.rosen@metormote.com>
On Mon, Feb 01, 2021 at 08:59:29PM +0100, Erik Rosen wrote:
> It is no longer necessary to clear the cache to update the sensor value
> from the chip.
>
> Signed-off-by: Erik Rosen <erik.rosen@metormote.com>
Applied, after prepending subject with "hwmon: (pmbus/lm25066)".
Thanks,
Guenter
> ---
> drivers/hwmon/pmbus/lm25066.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/lm25066.c b/drivers/hwmon/pmbus/lm25066.c
> index c75a6bf39641..e9a66fd9e144 100644
> --- a/drivers/hwmon/pmbus/lm25066.c
> +++ b/drivers/hwmon/pmbus/lm25066.c
> @@ -371,21 +371,18 @@ static int lm25066_write_word_data(struct i2c_client *client, int page, int reg,
> case PMBUS_VIN_OV_WARN_LIMIT:
> word = ((s16)word < 0) ? 0 : clamp_val(word, 0, data->rlimit);
> ret = pmbus_write_word_data(client, 0, reg, word);
> - pmbus_clear_cache(client);
> break;
> case PMBUS_IIN_OC_WARN_LIMIT:
> word = ((s16)word < 0) ? 0 : clamp_val(word, 0, data->rlimit);
> ret = pmbus_write_word_data(client, 0,
> LM25066_MFR_IIN_OC_WARN_LIMIT,
> word);
> - pmbus_clear_cache(client);
> break;
> case PMBUS_PIN_OP_WARN_LIMIT:
> word = ((s16)word < 0) ? 0 : clamp_val(word, 0, data->rlimit);
> ret = pmbus_write_word_data(client, 0,
> LM25066_MFR_PIN_OP_WARN_LIMIT,
> word);
> - pmbus_clear_cache(client);
> break;
> case PMBUS_VIRT_VMON_UV_WARN_LIMIT:
> /* Adjust from VIN coefficients (for LM25056) */
> @@ -393,7 +390,6 @@ static int lm25066_write_word_data(struct i2c_client *client, int page, int reg,
> word = ((s16)word < 0) ? 0 : clamp_val(word, 0, data->rlimit);
> ret = pmbus_write_word_data(client, 0,
> LM25056_VAUX_UV_WARN_LIMIT, word);
> - pmbus_clear_cache(client);
> break;
> case PMBUS_VIRT_VMON_OV_WARN_LIMIT:
> /* Adjust from VIN coefficients (for LM25056) */
> @@ -401,7 +397,6 @@ static int lm25066_write_word_data(struct i2c_client *client, int page, int reg,
> word = ((s16)word < 0) ? 0 : clamp_val(word, 0, data->rlimit);
> ret = pmbus_write_word_data(client, 0,
> LM25056_VAUX_OV_WARN_LIMIT, word);
> - pmbus_clear_cache(client);
> break;
> case PMBUS_VIRT_RESET_PIN_HISTORY:
> ret = pmbus_write_byte(client, 0, LM25066_CLEAR_PIN_PEAK);
prev parent reply other threads:[~2021-02-02 0:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 19:59 [PATCH 0/2] Set sensor->data to -ENODATA after write Erik Rosen
2021-02-01 19:59 ` [PATCH 1/2] Clear sensor data after chip write Erik Rosen
2021-02-02 0:24 ` Guenter Roeck
2021-02-01 19:59 ` [PATCH 2/2] Remove unnecessary pmbus_clear_cache function call Erik Rosen
2021-02-02 0:26 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202002641.GA117591@roeck-us.net \
--to=linux@roeck-us.net \
--cc=erik.rosen@metormote.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.