From: Lu Baolu <baolu.lu@linux.intel.com> To: iommu@lists.linux-foundation.org Cc: Yian Chen <yian.chen@intel.com>, Joerg Roedel <joro@8bytes.org>, Ashok Raj <ashok.raj@intel.com>, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] iommu/vt-d: Apply SATC policy Date: Tue, 2 Feb 2021 12:40:57 +0800 [thread overview] Message-ID: <20210202044057.615277-4-baolu.lu@linux.intel.com> (raw) In-Reply-To: <20210202044057.615277-1-baolu.lu@linux.intel.com> From: Yian Chen <yian.chen@intel.com> Starting from Intel VT-d v3.2, Intel platform BIOS can provide a new SATC table structure. SATC table lists a set of SoC integrated devices that require ATC to work (VT-d specification v3.2, section 8.8). Furthermore, the new version of IOMMU supports SoC device ATS in both its Scalable mode and legacy mode. When IOMMU is working in scalable mode, software must enable device ATS support. On the other hand, when IOMMU is in legacy mode for whatever reason, the hardware managed ATS will automatically take effect and the SATC required devices can work transparently to the software. As the result, software shouldn't enable ATS on that device, otherwise duplicate device TLB invalidations will occur. Signed-off-by: Yian Chen <yian.chen@intel.com> --- drivers/iommu/intel/iommu.c | 72 ++++++++++++++++++++++++++++++++++--- 1 file changed, 68 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c index b20fd305fc60..131fac718a4b 100644 --- a/drivers/iommu/intel/iommu.c +++ b/drivers/iommu/intel/iommu.c @@ -872,6 +872,59 @@ static bool iommu_is_dummy(struct intel_iommu *iommu, struct device *dev) return false; } +static bool iommu_support_ats(struct intel_iommu *iommu) +{ + return ecap_dev_iotlb_support(iommu->ecap); +} + +static bool device_support_ats(struct pci_dev *dev) +{ + return pci_ats_supported(dev) && dmar_find_matched_atsr_unit(dev); +} + +static int segment_atc_required(u16 segment) +{ + struct acpi_dmar_satc *satc; + struct dmar_satc_unit *satcu; + int ret = 1; + + rcu_read_lock(); + list_for_each_entry_rcu(satcu, &dmar_satc_units, list) { + satc = container_of(satcu->hdr, struct acpi_dmar_satc, header); + if (satcu->atc_required && + satcu->devices_cnt && + satc->segment == segment) + goto out; + } + ret = 0; +out: + rcu_read_unlock(); + return ret; +} + +static int device_atc_required(struct pci_dev *dev) +{ + struct dmar_satc_unit *satcu; + struct acpi_dmar_satc *satc; + struct device *tmp; + int i, ret = 1; + + dev = pci_physfn(dev); + rcu_read_lock(); + list_for_each_entry_rcu(satcu, &dmar_satc_units, list) { + satc = container_of(satcu->hdr, struct acpi_dmar_satc, header); + if (satc->segment == pci_domain_nr(dev->bus) && satcu->atc_required) { + for_each_dev_scope(satcu->devices, satcu->devices_cnt, i, tmp) + if (to_pci_dev(tmp) == dev) + goto out; + } + } + ret = 0; +out: + rcu_read_unlock(); + return ret; +} + struct intel_iommu *device_to_iommu(struct device *dev, u8 *bus, u8 *devfn) { struct dmar_drhd_unit *drhd = NULL; @@ -2575,10 +2628,16 @@ static struct dmar_domain *dmar_insert_one_dev_info(struct intel_iommu *iommu, if (dev && dev_is_pci(dev)) { struct pci_dev *pdev = to_pci_dev(info->dev); - if (ecap_dev_iotlb_support(iommu->ecap) && - pci_ats_supported(pdev) && - dmar_find_matched_atsr_unit(pdev)) - info->ats_supported = 1; + /* + * Support ATS by default if it's supported by both IOMMU and + * client sides, except that the device's ATS is required by + * ACPI/SATC but the IOMMU scalable mode is disabled. In that + * case the hardware managed ATS will be automatically used. + */ + if (iommu_support_ats(iommu) && device_support_ats(pdev)) { + if (!device_atc_required(pdev) || sm_supported(iommu)) + info->ats_supported = 1; + } if (sm_supported(iommu)) { if (pasid_supported(iommu)) { @@ -3175,6 +3234,11 @@ static int __init init_dmars(void) * endfor */ for_each_drhd_unit(drhd) { + if (pci_ats_disabled() && segment_atc_required(drhd->segment)) { + pr_warn("Scalable mode disabled -- Use hardware managed ATS because PCIe ATS is disabled but some devices in PCIe segment 0x%x require it.", + drhd->segment); + intel_iommu_sm = 0; + } /* * lock not needed as this is only incremented in the single * threaded kernel __init code path all other access are read -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com> To: iommu@lists.linux-foundation.org Cc: Ashok Raj <ashok.raj@intel.com>, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] iommu/vt-d: Apply SATC policy Date: Tue, 2 Feb 2021 12:40:57 +0800 [thread overview] Message-ID: <20210202044057.615277-4-baolu.lu@linux.intel.com> (raw) In-Reply-To: <20210202044057.615277-1-baolu.lu@linux.intel.com> From: Yian Chen <yian.chen@intel.com> Starting from Intel VT-d v3.2, Intel platform BIOS can provide a new SATC table structure. SATC table lists a set of SoC integrated devices that require ATC to work (VT-d specification v3.2, section 8.8). Furthermore, the new version of IOMMU supports SoC device ATS in both its Scalable mode and legacy mode. When IOMMU is working in scalable mode, software must enable device ATS support. On the other hand, when IOMMU is in legacy mode for whatever reason, the hardware managed ATS will automatically take effect and the SATC required devices can work transparently to the software. As the result, software shouldn't enable ATS on that device, otherwise duplicate device TLB invalidations will occur. Signed-off-by: Yian Chen <yian.chen@intel.com> --- drivers/iommu/intel/iommu.c | 72 ++++++++++++++++++++++++++++++++++--- 1 file changed, 68 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c index b20fd305fc60..131fac718a4b 100644 --- a/drivers/iommu/intel/iommu.c +++ b/drivers/iommu/intel/iommu.c @@ -872,6 +872,59 @@ static bool iommu_is_dummy(struct intel_iommu *iommu, struct device *dev) return false; } +static bool iommu_support_ats(struct intel_iommu *iommu) +{ + return ecap_dev_iotlb_support(iommu->ecap); +} + +static bool device_support_ats(struct pci_dev *dev) +{ + return pci_ats_supported(dev) && dmar_find_matched_atsr_unit(dev); +} + +static int segment_atc_required(u16 segment) +{ + struct acpi_dmar_satc *satc; + struct dmar_satc_unit *satcu; + int ret = 1; + + rcu_read_lock(); + list_for_each_entry_rcu(satcu, &dmar_satc_units, list) { + satc = container_of(satcu->hdr, struct acpi_dmar_satc, header); + if (satcu->atc_required && + satcu->devices_cnt && + satc->segment == segment) + goto out; + } + ret = 0; +out: + rcu_read_unlock(); + return ret; +} + +static int device_atc_required(struct pci_dev *dev) +{ + struct dmar_satc_unit *satcu; + struct acpi_dmar_satc *satc; + struct device *tmp; + int i, ret = 1; + + dev = pci_physfn(dev); + rcu_read_lock(); + list_for_each_entry_rcu(satcu, &dmar_satc_units, list) { + satc = container_of(satcu->hdr, struct acpi_dmar_satc, header); + if (satc->segment == pci_domain_nr(dev->bus) && satcu->atc_required) { + for_each_dev_scope(satcu->devices, satcu->devices_cnt, i, tmp) + if (to_pci_dev(tmp) == dev) + goto out; + } + } + ret = 0; +out: + rcu_read_unlock(); + return ret; +} + struct intel_iommu *device_to_iommu(struct device *dev, u8 *bus, u8 *devfn) { struct dmar_drhd_unit *drhd = NULL; @@ -2575,10 +2628,16 @@ static struct dmar_domain *dmar_insert_one_dev_info(struct intel_iommu *iommu, if (dev && dev_is_pci(dev)) { struct pci_dev *pdev = to_pci_dev(info->dev); - if (ecap_dev_iotlb_support(iommu->ecap) && - pci_ats_supported(pdev) && - dmar_find_matched_atsr_unit(pdev)) - info->ats_supported = 1; + /* + * Support ATS by default if it's supported by both IOMMU and + * client sides, except that the device's ATS is required by + * ACPI/SATC but the IOMMU scalable mode is disabled. In that + * case the hardware managed ATS will be automatically used. + */ + if (iommu_support_ats(iommu) && device_support_ats(pdev)) { + if (!device_atc_required(pdev) || sm_supported(iommu)) + info->ats_supported = 1; + } if (sm_supported(iommu)) { if (pasid_supported(iommu)) { @@ -3175,6 +3234,11 @@ static int __init init_dmars(void) * endfor */ for_each_drhd_unit(drhd) { + if (pci_ats_disabled() && segment_atc_required(drhd->segment)) { + pr_warn("Scalable mode disabled -- Use hardware managed ATS because PCIe ATS is disabled but some devices in PCIe segment 0x%x require it.", + drhd->segment); + intel_iommu_sm = 0; + } /* * lock not needed as this is only incremented in the single * threaded kernel __init code path all other access are read -- 2.25.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-02-02 4:54 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-02 4:40 [PATCH 0/3] iommu/vt-d: Add support for ACPI/SATC table Lu Baolu 2021-02-02 4:40 ` Lu Baolu 2021-02-02 4:40 ` [PATCH 1/3] iommu/vt-d: Add new enum value and structure for SATC Lu Baolu 2021-02-02 4:40 ` Lu Baolu 2021-02-02 13:51 ` Joerg Roedel 2021-02-02 13:51 ` Joerg Roedel 2021-02-03 0:11 ` Lu Baolu 2021-02-03 0:11 ` Lu Baolu 2021-02-02 16:02 ` Raj, Ashok 2021-02-02 16:02 ` Raj, Ashok 2021-02-03 0:15 ` Lu Baolu 2021-02-03 0:15 ` Lu Baolu 2021-02-02 4:40 ` [PATCH 2/3] iommu/vt-d: Parse SATC reporting structure Lu Baolu 2021-02-02 4:40 ` Lu Baolu 2021-02-02 13:53 ` Joerg Roedel 2021-02-02 13:53 ` Joerg Roedel 2021-02-03 0:26 ` Lu Baolu 2021-02-03 0:26 ` Lu Baolu 2021-02-02 16:41 ` Raj, Ashok 2021-02-02 16:41 ` Raj, Ashok 2021-02-03 0:29 ` Lu Baolu 2021-02-03 0:29 ` Lu Baolu 2021-02-02 4:40 ` Lu Baolu [this message] 2021-02-02 4:40 ` [PATCH 3/3] iommu/vt-d: Apply SATC policy Lu Baolu 2021-02-02 13:55 ` Joerg Roedel 2021-02-02 13:55 ` Joerg Roedel 2021-02-03 0:33 ` Lu Baolu 2021-02-03 0:33 ` Lu Baolu 2021-02-03 8:41 ` [PATCH 0/3] iommu/vt-d: Add support for ACPI/SATC table Christoph Hellwig 2021-02-03 8:41 ` Christoph Hellwig 2021-02-03 9:29 ` Lu Baolu 2021-02-03 9:29 ` Lu Baolu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210202044057.615277-4-baolu.lu@linux.intel.com \ --to=baolu.lu@linux.intel.com \ --cc=ashok.raj@intel.com \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=yian.chen@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.