* [to-be-updated] ocfs2-fix-a-use-after-free-on-error.patch removed from -mm tree
@ 2021-02-02 19:39 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2021-02-02 19:39 UTC (permalink / raw)
To: dan.carpenter, gechangwei, ghe, jiangqi903, jlbec, junxiao.bi,
mark, mm-commits, piaojun
The patch titled
Subject: ocfs2: fix a use after free on error
has been removed from the -mm tree. Its filename was
ocfs2-fix-a-use-after-free-on-error.patch
This patch was dropped because an updated version will be merged
------------------------------------------------------
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: ocfs2: fix a use after free on error
The error handling in this function frees "reg" but it is still on the
"o2hb_all_regions" list so it will lead to a use after free. The fix for
this is to only add it to the list after everything has succeeded.
Link: https://lkml.kernel.org/r/YBfzR7AbZZ4Pp6sq@mwanda
Fixes: 1cf257f51191 ("ocfs2: fix memory leak")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mark Fasheh <mark@fasheh.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Joseph Qi <jiangqi903@gmail.com>
Cc: Changwei Ge <gechangwei@live.cn>
Cc: Gang He <ghe@suse.com>
Cc: Jun Piao <piaojun@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/ocfs2/cluster/heartbeat.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- a/fs/ocfs2/cluster/heartbeat.c~ocfs2-fix-a-use-after-free-on-error
+++ a/fs/ocfs2/cluster/heartbeat.c
@@ -2025,7 +2025,6 @@ static struct config_item *o2hb_heartbea
}
set_bit(reg->hr_region_num, o2hb_region_bitmap);
}
- list_add_tail(®->hr_all_item, &o2hb_all_regions);
spin_unlock(&o2hb_live_lock);
config_item_init_type_name(®->hr_item, name, &o2hb_region_type);
@@ -2053,6 +2052,10 @@ static struct config_item *o2hb_heartbea
o2hb_debug_region_init(reg, o2hb_debug_dir);
+ spin_lock(&o2hb_live_lock);
+ list_add_tail(®->hr_all_item, &o2hb_all_regions);
+ spin_unlock(&o2hb_live_lock);
+
return ®->hr_item;
unregister_handler:
_
Patches currently in -mm which might be from dan.carpenter@oracle.com are
ocfs2-fix-a-use-after-free-on-error-v2.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-02 19:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02 19:39 [to-be-updated] ocfs2-fix-a-use-after-free-on-error.patch removed from -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.