* [PATCH 1/2] leds: lp50xx: remove unused regulator
@ 2021-02-03 8:33 Sven Schuchmann
2021-02-05 18:03 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Sven Schuchmann @ 2021-02-03 8:33 UTC (permalink / raw)
To: schuchmann
Cc: Pavel Machek, Dan Murphy, Rob Herring, linux-leds, devicetree,
linux-kernel
The regulator for vled-supply is unused in the driver.
It is just assigned from DT and disabled in lp50xx_remove.
So the code can be removed from the driver.
Part 1 updates the documentation
Part 2 removes the code
Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>
---
Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
index c192b5feadc7..c20a81d13bfd 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
@@ -43,9 +43,6 @@ properties:
maxItems: 1
description: GPIO pin to enable/disable the device.
- vled-supply:
- description: LED supply.
-
'#address-cells':
const: 1
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] leds: lp50xx: remove unused regulator
2021-02-03 8:33 [PATCH 1/2] leds: lp50xx: remove unused regulator Sven Schuchmann
@ 2021-02-05 18:03 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2021-02-05 18:03 UTC (permalink / raw)
To: Sven Schuchmann
Cc: Pavel Machek, Dan Murphy, linux-leds, devicetree, linux-kernel
On Wed, Feb 03, 2021 at 08:33:05AM +0000, Sven Schuchmann wrote:
> The regulator for vled-supply is unused in the driver.
> It is just assigned from DT and disabled in lp50xx_remove.
> So the code can be removed from the driver.
The binding is not a driver. Does the h/w have a 'vled' supply? If so,
then it should remain in the binding.
>
> Part 1 updates the documentation
> Part 2 removes the code
>
> Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>
>
> ---
> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> index c192b5feadc7..c20a81d13bfd 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> @@ -43,9 +43,6 @@ properties:
> maxItems: 1
> description: GPIO pin to enable/disable the device.
>
> - vled-supply:
> - description: LED supply.
> -
> '#address-cells':
> const: 1
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-05 18:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 8:33 [PATCH 1/2] leds: lp50xx: remove unused regulator Sven Schuchmann
2021-02-05 18:03 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.