All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ayush <ayush@disroot.org>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, kuba@kernel.org, ayush@disroot.org,
	arnd@arndb.de
Subject: [PATCH] staging: wimax/i2400m: fix coding style issues
Date: Wed,  3 Feb 2021 17:17:20 +0530	[thread overview]
Message-ID: <20210203114720.263651-1-ayush@disroot.org> (raw)

- fix "multiple blank lines" issues.
- fix a couple of parenthesis alignment issues.
- fix no space before parenthesis issue.
- fix no blank line after declaration.

compile tested only (on next-20210202).

Signed-off-by: Ayush <ayush@disroot.org>
---
 drivers/staging/wimax/i2400m/debugfs.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/wimax/i2400m/debugfs.c b/drivers/staging/wimax/i2400m/debugfs.c
index 1c640b41ea4c..80a6f833d1c2 100644
--- a/drivers/staging/wimax/i2400m/debugfs.c
+++ b/drivers/staging/wimax/i2400m/debugfs.c
@@ -15,7 +15,6 @@
 #include <linux/export.h>
 #include "i2400m.h"
 
-
 #define D_SUBMODULE debugfs
 #include "debug-levels.h"
 
@@ -27,8 +26,8 @@ int debugfs_netdev_queue_stopped_get(void *data, u64 *val)
 	return 0;
 }
 DEFINE_DEBUGFS_ATTRIBUTE(fops_netdev_queue_stopped,
-			debugfs_netdev_queue_stopped_get,
-			NULL, "%llu\n");
+			 debugfs_netdev_queue_stopped_get,
+			 NULL, "%llu\n");
 
 /*
  * We don't allow partial reads of this file, as then the reader would
@@ -59,7 +58,6 @@ ssize_t i2400m_rx_stats_read(struct file *filp, char __user *buffer,
 	return simple_read_from_buffer(buffer, count, ppos, buf, strlen(buf));
 }
 
-
 /* Any write clears the stats */
 static
 ssize_t i2400m_rx_stats_write(struct file *filp, const char __user *buffer,
@@ -89,7 +87,6 @@ const struct file_operations i2400m_rx_stats_fops = {
 	.llseek =	default_llseek,
 };
 
-
 /* See i2400m_rx_stats_read() */
 static
 ssize_t i2400m_tx_stats_read(struct file *filp, char __user *buffer,
@@ -142,21 +139,21 @@ const struct file_operations i2400m_tx_stats_fops = {
 	.llseek =	default_llseek,
 };
 
-
 /* Write 1 to ask the device to go into suspend */
 static
 int debugfs_i2400m_suspend_set(void *data, u64 val)
 {
 	int result;
 	struct i2400m *i2400m = data;
+
 	result = i2400m_cmd_enter_powersave(i2400m);
 	if (result >= 0)
 		result = 0;
 	return result;
 }
 DEFINE_DEBUGFS_ATTRIBUTE(fops_i2400m_suspend,
-			NULL, debugfs_i2400m_suspend_set,
-			"%llu\n");
+			 NULL, debugfs_i2400m_suspend_set,
+			 "%llu\n");
 
 /*
  * Reset the device
@@ -170,7 +167,8 @@ int debugfs_i2400m_reset_set(void *data, u64 val)
 	int result;
 	struct i2400m *i2400m = data;
 	enum i2400m_reset_type rt = val;
-	switch(rt) {
+
+	switch (rt) {
 	case I2400M_RT_WARM:
 	case I2400M_RT_COLD:
 	case I2400M_RT_BUS:
@@ -184,8 +182,8 @@ int debugfs_i2400m_reset_set(void *data, u64 val)
 	return result;
 }
 DEFINE_DEBUGFS_ATTRIBUTE(fops_i2400m_reset,
-			NULL, debugfs_i2400m_reset_set,
-			"%llu\n");
+			 NULL, debugfs_i2400m_reset_set,
+			 "%llu\n");
 
 void i2400m_debugfs_add(struct i2400m *i2400m)
 {
-- 
2.30.0

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

             reply	other threads:[~2021-02-03 11:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 11:47 Ayush [this message]
2021-02-03 12:25 ` [PATCH] staging: wimax/i2400m: fix coding style issues Greg KH
2021-02-03 13:11 ` Dan Carpenter
2021-02-03 15:40 ` Ayush
2021-02-03 15:46   ` Greg KH
2021-02-03 15:43 ` Ayush

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210203114720.263651-1-ayush@disroot.org \
    --to=ayush@disroot.org \
    --cc=arnd@arndb.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.