All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org
Subject: [PATCH v5 28/31] linux-user/aarch64: Signal SEGV_MTEAERR for async tag check error
Date: Wed,  3 Feb 2021 09:00:07 -1000	[thread overview]
Message-ID: <20210203190010.759771-29-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210203190010.759771-1-richard.henderson@linaro.org>

The real kernel collects _TIF_MTE_ASYNC_FAULT into the current thread's
state on any kernel entry (interrupt, exception etc), and then delivers
the signal in advance of resuming the thread.

This means that while the signal won't be delivered immediately, it will
not be delayed forever -- at minimum it will be delivered after the next
clock interrupt.

We don't have a clock interrupt in linux-user, so we issue a cpu_kick
to signal a return to the main loop at the end of the current TB.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/aarch64/target_signal.h |  1 +
 linux-user/aarch64/cpu_loop.c      | 11 +++++++++++
 target/arm/mte_helper.c            | 10 ++++++++++
 3 files changed, 22 insertions(+)

diff --git a/linux-user/aarch64/target_signal.h b/linux-user/aarch64/target_signal.h
index 777fb667fe..18013e1b23 100644
--- a/linux-user/aarch64/target_signal.h
+++ b/linux-user/aarch64/target_signal.h
@@ -21,6 +21,7 @@ typedef struct target_sigaltstack {
 
 #include "../generic/signal.h"
 
+#define TARGET_SEGV_MTEAERR  8  /* Asynchronous ARM MTE error */
 #define TARGET_SEGV_MTESERR  9  /* Synchronous ARM MTE exception */
 
 #define TARGET_ARCH_HAS_SETUP_FRAME
diff --git a/linux-user/aarch64/cpu_loop.c b/linux-user/aarch64/cpu_loop.c
index b6a2e65593..7c42f65706 100644
--- a/linux-user/aarch64/cpu_loop.c
+++ b/linux-user/aarch64/cpu_loop.c
@@ -164,6 +164,17 @@ void cpu_loop(CPUARMState *env)
             EXCP_DUMP(env, "qemu: unhandled CPU exception 0x%x - aborting\n", trapnr);
             abort();
         }
+
+        /* Check for MTE asynchronous faults */
+        if (unlikely(env->cp15.tfsr_el[0])) {
+            env->cp15.tfsr_el[0] = 0;
+            info.si_signo = TARGET_SIGSEGV;
+            info.si_errno = 0;
+            info._sifields._sigfault._addr = 0;
+            info.si_code = TARGET_SEGV_MTEAERR;
+            queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
+        }
+
         process_pending_signals(env);
         /* Exception return on AArch64 always clears the exclusive monitor,
          * so any return to running guest code implies this.
diff --git a/target/arm/mte_helper.c b/target/arm/mte_helper.c
index 153bd1e9df..d55f8d1e1e 100644
--- a/target/arm/mte_helper.c
+++ b/target/arm/mte_helper.c
@@ -565,6 +565,16 @@ static void mte_check_fail(CPUARMState *env, uint32_t desc,
             select = 0;
         }
         env->cp15.tfsr_el[el] |= 1 << select;
+#ifdef CONFIG_USER_ONLY
+        /*
+         * Stand in for a timer irq, setting _TIF_MTE_ASYNC_FAULT,
+         * which then sends a SIGSEGV when the thread is next scheduled.
+         * This cpu will return to the main loop at the end of the TB,
+         * which is rather sooner than "normal".  But the alternative
+         * is waiting until the next syscall.
+         */
+        qemu_cpu_kick(env_cpu(env));
+#endif
         break;
 
     default:
-- 
2.25.1



  parent reply	other threads:[~2021-02-03 19:36 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 18:59 [PATCH v5 00/31] target-arm: Implement ARMv8.5-MemTag, user mode Richard Henderson
2021-02-03 18:59 ` [PATCH v5 01/31] tcg: Introduce target-specific page data for user-only Richard Henderson
2021-02-03 18:59 ` [PATCH v5 02/31] linux-user: Introduce PAGE_ANON Richard Henderson
2021-02-03 18:59 ` [PATCH v5 03/31] exec: Use uintptr_t for guest_base Richard Henderson
2021-02-03 19:08   ` Philippe Mathieu-Daudé
2021-02-03 19:10     ` Richard Henderson
2021-02-03 19:20       ` Philippe Mathieu-Daudé
2021-02-03 18:59 ` [PATCH v5 04/31] exec: Use uintptr_t in cpu_ldst.h Richard Henderson
2021-02-03 18:59 ` [PATCH v5 05/31] exec: Improve types for guest_addr_valid Richard Henderson
2021-02-03 18:59 ` [PATCH v5 06/31] linux-user: Check for overflow in access_ok Richard Henderson
2021-02-03 18:59 ` [PATCH v5 07/31] linux-user: Tidy VERIFY_READ/VERIFY_WRITE Richard Henderson
2021-02-03 18:59 ` [PATCH v5 08/31] bsd-user: " Richard Henderson
2021-02-03 18:59 ` [PATCH v5 09/31] linux-user: Do not use guest_addr_valid for h2g_valid Richard Henderson
2021-02-03 18:59 ` [PATCH v5 10/31] linux-user: Fix guest_addr_valid vs reserved_va Richard Henderson
2021-02-03 18:59 ` [PATCH v5 11/31] exec: Introduce cpu_untagged_addr Richard Henderson
2021-02-08 13:34   ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 12/31] exec: Use cpu_untagged_addr in g2h; split out g2h_untagged Richard Henderson
2021-02-08 13:39   ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 13/31] linux-user: Explicitly untag memory management syscalls Richard Henderson
2021-02-08 14:10   ` Peter Maydell
2021-02-08 16:33     ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 14/31] linux-user: Use guest_range_valid in access_ok Richard Henderson
2021-02-08 13:47   ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 15/31] exec: Rename guest_{addr,range}_valid to *_untagged Richard Henderson
2021-02-08 13:48   ` [PATCH v5 15/31] exec: Rename guest_{addr, range}_valid " Peter Maydell
2021-02-03 18:59 ` [PATCH v5 16/31] linux-user: Use cpu_untagged_addr in access_ok; split out *_untagged Richard Henderson
2021-02-08 13:50   ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 17/31] linux-user: Move lock_user et al out of line Richard Henderson
2021-02-08 13:50   ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 18/31] linux-user: Fix types in uaccess.c Richard Henderson
2021-02-08 13:53   ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 19/31] linux-user: Handle tags in lock_user/unlock_user Richard Henderson
2021-02-08 13:57   ` Peter Maydell
2021-02-08 17:32     ` Richard Henderson
2021-02-03 18:59 ` [PATCH v5 20/31] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE Richard Henderson
2021-02-03 19:00 ` [PATCH v5 21/31] target/arm: Improve gen_top_byte_ignore Richard Henderson
2021-02-03 19:00 ` [PATCH v5 22/31] target/arm: Use the proper TBI settings for linux-user Richard Henderson
2021-02-03 19:00 ` [PATCH v5 23/31] linux-user/aarch64: Implement PR_MTE_TCF and PR_MTE_TAG Richard Henderson
2021-02-03 19:00 ` [PATCH v5 24/31] linux-user/aarch64: Implement PROT_MTE Richard Henderson
2021-02-03 19:00 ` [PATCH v5 25/31] target/arm: Split out syndrome.h from internals.h Richard Henderson
2021-02-03 19:00 ` [PATCH v5 26/31] linux-user/aarch64: Pass syndrome to EXC_*_ABORT Richard Henderson
2021-02-03 19:00 ` [PATCH v5 27/31] linux-user/aarch64: Signal SEGV_MTESERR for sync tag check fault Richard Henderson
2021-02-03 19:00 ` Richard Henderson [this message]
2021-02-03 19:00 ` [PATCH v5 29/31] target/arm: Add allocation tag storage for user mode Richard Henderson
2021-02-03 19:00 ` [PATCH v5 30/31] target/arm: Enable MTE for user-only Richard Henderson
2021-02-03 19:00 ` [PATCH v5 31/31] tests/tcg/aarch64: Add mte smoke tests Richard Henderson
2021-02-03 19:57 ` [PATCH v5 00/31] target-arm: Implement ARMv8.5-MemTag, user mode no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210203190010.759771-29-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.