All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v5 03/31] exec: Use uintptr_t for guest_base
Date: Wed, 3 Feb 2021 20:20:36 +0100	[thread overview]
Message-ID: <CAAdtpL4=ndPPrfV61ZKMcH9SL2qEjZa-WTLGFYC-ewz_0p9EMg@mail.gmail.com> (raw)
In-Reply-To: <f51c9b7a-c9b5-29b6-9f88-b6d774be5da9@linaro.org>

On Wed, Feb 3, 2021 at 8:10 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
> On 2/3/21 9:08 AM, Philippe Mathieu-Daudé wrote:
> > On 2/3/21 7:59 PM, Richard Henderson wrote:
> >> This is more descriptive than 'unsigned long'.
> >> No functional change, since these match on all linux+bsd hosts.
> >>
> >> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> >> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> >> ---
> >>  include/exec/cpu-all.h | 2 +-
> >>  bsd-user/main.c        | 4 ++--
> >>  linux-user/elfload.c   | 4 ++--
> >>  linux-user/main.c      | 4 ++--
> >>  4 files changed, 7 insertions(+), 7 deletions(-)
> >>
> >> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
> >> index c23c77589b..c52180e8e6 100644
> >> --- a/include/exec/cpu-all.h
> >> +++ b/include/exec/cpu-all.h
> >> @@ -158,7 +158,7 @@ static inline void tswap64s(uint64_t *s)
> >>  /* On some host systems the guest address space is reserved on the host.
> >>   * This allows the guest address space to be offset to a convenient location.
> >>   */
> >> -extern unsigned long guest_base;
> >> +extern uintptr_t guest_base;
> >>  extern bool have_guest_base;
> >>  extern unsigned long reserved_va;
> >>
> >> diff --git a/bsd-user/main.c b/bsd-user/main.c
> >> index 65163e1396..c09d74d788 100644
> >> --- a/bsd-user/main.c
> >> +++ b/bsd-user/main.c
> >> @@ -41,7 +41,7 @@
> >>
> >>  int singlestep;
> >>  unsigned long mmap_min_addr;
> >> -unsigned long guest_base;
> >> +uintptr_t guest_base;
> >>  bool have_guest_base;
> >>  unsigned long reserved_va;
> >>
> >> @@ -965,7 +965,7 @@ int main(int argc, char **argv)
> >>      g_free(target_environ);
> >>
> >>      if (qemu_loglevel_mask(CPU_LOG_PAGE)) {
> >> -        qemu_log("guest_base  0x%lx\n", guest_base);
> >> +        qemu_log("guest_base  %p\n", (void *)guest_base);
> >
> > Why not use PRIxPTR?
>
> Didn't think of it.  Worth a respin?

No, I was simply curious if it weren't possible for some reason.

> >
> > Otherwise:
> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >
>


  reply	other threads:[~2021-02-03 19:50 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 18:59 [PATCH v5 00/31] target-arm: Implement ARMv8.5-MemTag, user mode Richard Henderson
2021-02-03 18:59 ` [PATCH v5 01/31] tcg: Introduce target-specific page data for user-only Richard Henderson
2021-02-03 18:59 ` [PATCH v5 02/31] linux-user: Introduce PAGE_ANON Richard Henderson
2021-02-03 18:59 ` [PATCH v5 03/31] exec: Use uintptr_t for guest_base Richard Henderson
2021-02-03 19:08   ` Philippe Mathieu-Daudé
2021-02-03 19:10     ` Richard Henderson
2021-02-03 19:20       ` Philippe Mathieu-Daudé [this message]
2021-02-03 18:59 ` [PATCH v5 04/31] exec: Use uintptr_t in cpu_ldst.h Richard Henderson
2021-02-03 18:59 ` [PATCH v5 05/31] exec: Improve types for guest_addr_valid Richard Henderson
2021-02-03 18:59 ` [PATCH v5 06/31] linux-user: Check for overflow in access_ok Richard Henderson
2021-02-03 18:59 ` [PATCH v5 07/31] linux-user: Tidy VERIFY_READ/VERIFY_WRITE Richard Henderson
2021-02-03 18:59 ` [PATCH v5 08/31] bsd-user: " Richard Henderson
2021-02-03 18:59 ` [PATCH v5 09/31] linux-user: Do not use guest_addr_valid for h2g_valid Richard Henderson
2021-02-03 18:59 ` [PATCH v5 10/31] linux-user: Fix guest_addr_valid vs reserved_va Richard Henderson
2021-02-03 18:59 ` [PATCH v5 11/31] exec: Introduce cpu_untagged_addr Richard Henderson
2021-02-08 13:34   ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 12/31] exec: Use cpu_untagged_addr in g2h; split out g2h_untagged Richard Henderson
2021-02-08 13:39   ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 13/31] linux-user: Explicitly untag memory management syscalls Richard Henderson
2021-02-08 14:10   ` Peter Maydell
2021-02-08 16:33     ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 14/31] linux-user: Use guest_range_valid in access_ok Richard Henderson
2021-02-08 13:47   ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 15/31] exec: Rename guest_{addr,range}_valid to *_untagged Richard Henderson
2021-02-08 13:48   ` [PATCH v5 15/31] exec: Rename guest_{addr, range}_valid " Peter Maydell
2021-02-03 18:59 ` [PATCH v5 16/31] linux-user: Use cpu_untagged_addr in access_ok; split out *_untagged Richard Henderson
2021-02-08 13:50   ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 17/31] linux-user: Move lock_user et al out of line Richard Henderson
2021-02-08 13:50   ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 18/31] linux-user: Fix types in uaccess.c Richard Henderson
2021-02-08 13:53   ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 19/31] linux-user: Handle tags in lock_user/unlock_user Richard Henderson
2021-02-08 13:57   ` Peter Maydell
2021-02-08 17:32     ` Richard Henderson
2021-02-03 18:59 ` [PATCH v5 20/31] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE Richard Henderson
2021-02-03 19:00 ` [PATCH v5 21/31] target/arm: Improve gen_top_byte_ignore Richard Henderson
2021-02-03 19:00 ` [PATCH v5 22/31] target/arm: Use the proper TBI settings for linux-user Richard Henderson
2021-02-03 19:00 ` [PATCH v5 23/31] linux-user/aarch64: Implement PR_MTE_TCF and PR_MTE_TAG Richard Henderson
2021-02-03 19:00 ` [PATCH v5 24/31] linux-user/aarch64: Implement PROT_MTE Richard Henderson
2021-02-03 19:00 ` [PATCH v5 25/31] target/arm: Split out syndrome.h from internals.h Richard Henderson
2021-02-03 19:00 ` [PATCH v5 26/31] linux-user/aarch64: Pass syndrome to EXC_*_ABORT Richard Henderson
2021-02-03 19:00 ` [PATCH v5 27/31] linux-user/aarch64: Signal SEGV_MTESERR for sync tag check fault Richard Henderson
2021-02-03 19:00 ` [PATCH v5 28/31] linux-user/aarch64: Signal SEGV_MTEAERR for async tag check error Richard Henderson
2021-02-03 19:00 ` [PATCH v5 29/31] target/arm: Add allocation tag storage for user mode Richard Henderson
2021-02-03 19:00 ` [PATCH v5 30/31] target/arm: Enable MTE for user-only Richard Henderson
2021-02-03 19:00 ` [PATCH v5 31/31] tests/tcg/aarch64: Add mte smoke tests Richard Henderson
2021-02-03 19:57 ` [PATCH v5 00/31] target-arm: Implement ARMv8.5-MemTag, user mode no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAdtpL4=ndPPrfV61ZKMcH9SL2qEjZa-WTLGFYC-ewz_0p9EMg@mail.gmail.com' \
    --to=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.