All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers: soc: atmel: fix type for same7
@ 2021-02-04 15:49 ` Arnd Bergmann
  0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2021-02-04 15:49 UTC (permalink / raw)
  To: Nicolas Ferre, Alexandre Belloni, Ludovic Desroches, Claudiu Beznea
  Cc: Arnd Bergmann, Sudeep Holla, Kai Stuhlemmer, linux-arm-kernel,
	linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

A missing comma caused a build failure:

drivers/soc/atmel/soc.c:196:24: error: too few arguments provided to function-like macro invocation

Fixes: af3a10513cd6 ("drivers: soc: atmel: add per soc id and version match masks")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
It is broken in the soc tree at the moment, I can pick up
the fix directly if I get an Ack
---
 drivers/soc/atmel/soc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
index a2967846809f..a490ad7e090f 100644
--- a/drivers/soc/atmel/soc.c
+++ b/drivers/soc/atmel/soc.c
@@ -191,7 +191,7 @@ static const struct at91_soc socs[] __initconst = {
 	AT91_SOC(SAME70Q20_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
 		 AT91_CIDR_VERSION_MASK, SAME70Q20_EXID_MATCH,
 		 "same70q20", "same7"),
-	AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK
+	AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
 		 AT91_CIDR_VERSION_MASK, SAME70Q19_EXID_MATCH,
 		 "same70q19", "same7"),
 	AT91_SOC(SAMS70Q21_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] drivers: soc: atmel: fix type for same7
@ 2021-02-04 15:49 ` Arnd Bergmann
  0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2021-02-04 15:49 UTC (permalink / raw)
  To: Nicolas Ferre, Alexandre Belloni, Ludovic Desroches, Claudiu Beznea
  Cc: linux-arm-kernel, linux-kernel, Kai Stuhlemmer, Arnd Bergmann,
	Sudeep Holla

From: Arnd Bergmann <arnd@arndb.de>

A missing comma caused a build failure:

drivers/soc/atmel/soc.c:196:24: error: too few arguments provided to function-like macro invocation

Fixes: af3a10513cd6 ("drivers: soc: atmel: add per soc id and version match masks")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
It is broken in the soc tree at the moment, I can pick up
the fix directly if I get an Ack
---
 drivers/soc/atmel/soc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
index a2967846809f..a490ad7e090f 100644
--- a/drivers/soc/atmel/soc.c
+++ b/drivers/soc/atmel/soc.c
@@ -191,7 +191,7 @@ static const struct at91_soc socs[] __initconst = {
 	AT91_SOC(SAME70Q20_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
 		 AT91_CIDR_VERSION_MASK, SAME70Q20_EXID_MATCH,
 		 "same70q20", "same7"),
-	AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK
+	AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
 		 AT91_CIDR_VERSION_MASK, SAME70Q19_EXID_MATCH,
 		 "same70q19", "same7"),
 	AT91_SOC(SAMS70Q21_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
-- 
2.29.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: soc: atmel: fix type for same7
  2021-02-04 15:49 ` Arnd Bergmann
@ 2021-02-04 15:52   ` Alexandre Belloni
  -1 siblings, 0 replies; 8+ messages in thread
From: Alexandre Belloni @ 2021-02-04 15:52 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Nicolas Ferre, Ludovic Desroches, Claudiu Beznea, Arnd Bergmann,
	Sudeep Holla, Kai Stuhlemmer, linux-arm-kernel, linux-kernel

On 04/02/2021 16:49:25+0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> A missing comma caused a build failure:
> 
> drivers/soc/atmel/soc.c:196:24: error: too few arguments provided to function-like macro invocation
> 
> Fixes: af3a10513cd6 ("drivers: soc: atmel: add per soc id and version match masks")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
> It is broken in the soc tree at the moment, I can pick up
> the fix directly if I get an Ack
> ---
>  drivers/soc/atmel/soc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
> index a2967846809f..a490ad7e090f 100644
> --- a/drivers/soc/atmel/soc.c
> +++ b/drivers/soc/atmel/soc.c
> @@ -191,7 +191,7 @@ static const struct at91_soc socs[] __initconst = {
>  	AT91_SOC(SAME70Q20_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
>  		 AT91_CIDR_VERSION_MASK, SAME70Q20_EXID_MATCH,
>  		 "same70q20", "same7"),
> -	AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK
> +	AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
>  		 AT91_CIDR_VERSION_MASK, SAME70Q19_EXID_MATCH,
>  		 "same70q19", "same7"),
>  	AT91_SOC(SAMS70Q21_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> -- 
> 2.29.2
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: soc: atmel: fix type for same7
@ 2021-02-04 15:52   ` Alexandre Belloni
  0 siblings, 0 replies; 8+ messages in thread
From: Alexandre Belloni @ 2021-02-04 15:52 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Kai Stuhlemmer, Arnd Bergmann, linux-kernel, Ludovic Desroches,
	Sudeep Holla, Claudiu Beznea, linux-arm-kernel

On 04/02/2021 16:49:25+0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> A missing comma caused a build failure:
> 
> drivers/soc/atmel/soc.c:196:24: error: too few arguments provided to function-like macro invocation
> 
> Fixes: af3a10513cd6 ("drivers: soc: atmel: add per soc id and version match masks")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
> It is broken in the soc tree at the moment, I can pick up
> the fix directly if I get an Ack
> ---
>  drivers/soc/atmel/soc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
> index a2967846809f..a490ad7e090f 100644
> --- a/drivers/soc/atmel/soc.c
> +++ b/drivers/soc/atmel/soc.c
> @@ -191,7 +191,7 @@ static const struct at91_soc socs[] __initconst = {
>  	AT91_SOC(SAME70Q20_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
>  		 AT91_CIDR_VERSION_MASK, SAME70Q20_EXID_MATCH,
>  		 "same70q20", "same7"),
> -	AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK
> +	AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
>  		 AT91_CIDR_VERSION_MASK, SAME70Q19_EXID_MATCH,
>  		 "same70q19", "same7"),
>  	AT91_SOC(SAMS70Q21_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> -- 
> 2.29.2
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: soc: atmel: fix type for same7
  2021-02-04 15:52   ` Alexandre Belloni
@ 2021-02-04 18:00     ` Nicolas Ferre
  -1 siblings, 0 replies; 8+ messages in thread
From: Nicolas Ferre @ 2021-02-04 18:00 UTC (permalink / raw)
  To: Alexandre Belloni, Arnd Bergmann
  Cc: Ludovic Desroches, Claudiu Beznea, Arnd Bergmann, Sudeep Holla,
	Kai Stuhlemmer, linux-arm-kernel, linux-kernel

On 04/02/2021 at 16:52, Alexandre Belloni wrote:
> On 04/02/2021 16:49:25+0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> A missing comma caused a build failure:
>>
>> drivers/soc/atmel/soc.c:196:24: error: too few arguments provided to function-like macro invocation
>>
>> Fixes: af3a10513cd6 ("drivers: soc: atmel: add per soc id and version match masks")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

Thanks Arnd, thanks Alexandre.

As you realized, we didn't compiled with MMU-less types of configuration 
(CONFIG_SOC_SAMV7), sorry about that!

Best regards,
   Nicolas

>> ---
>> It is broken in the soc tree at the moment, I can pick up
>> the fix directly if I get an Ack
>> ---
>>   drivers/soc/atmel/soc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
>> index a2967846809f..a490ad7e090f 100644
>> --- a/drivers/soc/atmel/soc.c
>> +++ b/drivers/soc/atmel/soc.c
>> @@ -191,7 +191,7 @@ static const struct at91_soc socs[] __initconst = {
>>        AT91_SOC(SAME70Q20_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
>>                 AT91_CIDR_VERSION_MASK, SAME70Q20_EXID_MATCH,
>>                 "same70q20", "same7"),
>> -     AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK
>> +     AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
>>                 AT91_CIDR_VERSION_MASK, SAME70Q19_EXID_MATCH,
>>                 "same70q19", "same7"),
>>        AT91_SOC(SAMS70Q21_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
>> --
>> 2.29.2
>>
> 
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: soc: atmel: fix type for same7
@ 2021-02-04 18:00     ` Nicolas Ferre
  0 siblings, 0 replies; 8+ messages in thread
From: Nicolas Ferre @ 2021-02-04 18:00 UTC (permalink / raw)
  To: Alexandre Belloni, Arnd Bergmann
  Cc: Kai Stuhlemmer, Arnd Bergmann, linux-kernel, Ludovic Desroches,
	Sudeep Holla, Claudiu Beznea, linux-arm-kernel

On 04/02/2021 at 16:52, Alexandre Belloni wrote:
> On 04/02/2021 16:49:25+0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> A missing comma caused a build failure:
>>
>> drivers/soc/atmel/soc.c:196:24: error: too few arguments provided to function-like macro invocation
>>
>> Fixes: af3a10513cd6 ("drivers: soc: atmel: add per soc id and version match masks")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

Thanks Arnd, thanks Alexandre.

As you realized, we didn't compiled with MMU-less types of configuration 
(CONFIG_SOC_SAMV7), sorry about that!

Best regards,
   Nicolas

>> ---
>> It is broken in the soc tree at the moment, I can pick up
>> the fix directly if I get an Ack
>> ---
>>   drivers/soc/atmel/soc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
>> index a2967846809f..a490ad7e090f 100644
>> --- a/drivers/soc/atmel/soc.c
>> +++ b/drivers/soc/atmel/soc.c
>> @@ -191,7 +191,7 @@ static const struct at91_soc socs[] __initconst = {
>>        AT91_SOC(SAME70Q20_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
>>                 AT91_CIDR_VERSION_MASK, SAME70Q20_EXID_MATCH,
>>                 "same70q20", "same7"),
>> -     AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK
>> +     AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
>>                 AT91_CIDR_VERSION_MASK, SAME70Q19_EXID_MATCH,
>>                 "same70q19", "same7"),
>>        AT91_SOC(SAMS70Q21_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
>> --
>> 2.29.2
>>
> 
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> 


-- 
Nicolas Ferre

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: soc: atmel: fix type for same7
  2021-02-04 15:49 ` Arnd Bergmann
@ 2021-02-09 23:19   ` Arnd Bergmann
  -1 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2021-02-09 23:19 UTC (permalink / raw)
  To: Arnd Bergmann, Nicolas Ferre, Ludovic Desroches, Claudiu Beznea,
	Alexandre Belloni
  Cc: Arnd Bergmann, linux-kernel, Sudeep Holla, Kai Stuhlemmer,
	linux-arm-kernel

From: Arnd Bergmann <arnd@arndb.de>

On Thu, 4 Feb 2021 16:49:25 +0100, Arnd Bergmann wrote:
> A missing comma caused a build failure:
> 
> drivers/soc/atmel/soc.c:196:24: error: too few arguments provided to function-like macro invocation

Applied to arm/drivers, thanks!

[1/1] drivers: soc: atmel: fix type for same7
      commit: 7deff441f53cc148cbf18381bd252a754b0d7d4e

       Arnd

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: soc: atmel: fix type for same7
@ 2021-02-09 23:19   ` Arnd Bergmann
  0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2021-02-09 23:19 UTC (permalink / raw)
  To: Arnd Bergmann, Nicolas Ferre, Ludovic Desroches, Claudiu Beznea,
	Alexandre Belloni
  Cc: Kai Stuhlemmer, linux-arm-kernel, linux-kernel, Arnd Bergmann,
	Sudeep Holla

From: Arnd Bergmann <arnd@arndb.de>

On Thu, 4 Feb 2021 16:49:25 +0100, Arnd Bergmann wrote:
> A missing comma caused a build failure:
> 
> drivers/soc/atmel/soc.c:196:24: error: too few arguments provided to function-like macro invocation

Applied to arm/drivers, thanks!

[1/1] drivers: soc: atmel: fix type for same7
      commit: 7deff441f53cc148cbf18381bd252a754b0d7d4e

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-02-10  1:33 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 15:49 [PATCH] drivers: soc: atmel: fix type for same7 Arnd Bergmann
2021-02-04 15:49 ` Arnd Bergmann
2021-02-04 15:52 ` Alexandre Belloni
2021-02-04 15:52   ` Alexandre Belloni
2021-02-04 18:00   ` Nicolas Ferre
2021-02-04 18:00     ` Nicolas Ferre
2021-02-09 23:19 ` Arnd Bergmann
2021-02-09 23:19   ` Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.