From: Christoph Hellwig <hch@lst.de> To: jxgao@google.com, gregkh@linuxfoundation.org Cc: saravanak@google.com, konrad.wilk@oracle.com, marcorr@google.com, linux-nvme@lists.infradead.org, kbusch@kernel.org, iommu@lists.linux-foundation.org, erdemaktas@google.com, robin.murphy@arm.com, m.szyprowski@samsung.com Subject: [PATCH 1/8] driver core: add a min_align_mask field to struct device_dma_parameters Date: Thu, 4 Feb 2021 20:30:28 +0100 [thread overview] Message-ID: <20210204193035.2606838-2-hch@lst.de> (raw) In-Reply-To: <20210204193035.2606838-1-hch@lst.de> From: Jianxiong Gao <jxgao@google.com> Some devices rely on the address offset in a page to function correctly (NVMe driver as an example). These devices may use a different page size than the Linux kernel. The address offset has to be preserved upon mapping, and in order to do so, we need to record the page_offset_mask first. Signed-off-by: Jianxiong Gao <jxgao@google.com> Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/device.h | 1 + include/linux/dma-mapping.h | 16 ++++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/include/linux/device.h b/include/linux/device.h index 1779f90eeb4cb4..7960bf516dd7fe 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -291,6 +291,7 @@ struct device_dma_parameters { * sg limitations. */ unsigned int max_segment_size; + unsigned int min_align_mask; unsigned long segment_boundary_mask; }; diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 2e49996a8f391a..9c26225754e719 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -500,6 +500,22 @@ static inline int dma_set_seg_boundary(struct device *dev, unsigned long mask) return -EIO; } +static inline unsigned int dma_get_min_align_mask(struct device *dev) +{ + if (dev->dma_parms) + return dev->dma_parms->min_align_mask; + return 0; +} + +static inline int dma_set_min_align_mask(struct device *dev, + unsigned int min_align_mask) +{ + if (WARN_ON_ONCE(!dev->dma_parms)) + return -EIO; + dev->dma_parms->min_align_mask = min_align_mask; + return 0; +} + static inline int dma_get_cache_alignment(void) { #ifdef ARCH_DMA_MINALIGN -- 2.29.2 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: jxgao@google.com, gregkh@linuxfoundation.org Cc: saravanak@google.com, konrad.wilk@oracle.com, marcorr@google.com, linux-nvme@lists.infradead.org, kbusch@kernel.org, iommu@lists.linux-foundation.org, robin.murphy@arm.com Subject: [PATCH 1/8] driver core: add a min_align_mask field to struct device_dma_parameters Date: Thu, 4 Feb 2021 20:30:28 +0100 [thread overview] Message-ID: <20210204193035.2606838-2-hch@lst.de> (raw) In-Reply-To: <20210204193035.2606838-1-hch@lst.de> From: Jianxiong Gao <jxgao@google.com> Some devices rely on the address offset in a page to function correctly (NVMe driver as an example). These devices may use a different page size than the Linux kernel. The address offset has to be preserved upon mapping, and in order to do so, we need to record the page_offset_mask first. Signed-off-by: Jianxiong Gao <jxgao@google.com> Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/device.h | 1 + include/linux/dma-mapping.h | 16 ++++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/include/linux/device.h b/include/linux/device.h index 1779f90eeb4cb4..7960bf516dd7fe 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -291,6 +291,7 @@ struct device_dma_parameters { * sg limitations. */ unsigned int max_segment_size; + unsigned int min_align_mask; unsigned long segment_boundary_mask; }; diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 2e49996a8f391a..9c26225754e719 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -500,6 +500,22 @@ static inline int dma_set_seg_boundary(struct device *dev, unsigned long mask) return -EIO; } +static inline unsigned int dma_get_min_align_mask(struct device *dev) +{ + if (dev->dma_parms) + return dev->dma_parms->min_align_mask; + return 0; +} + +static inline int dma_set_min_align_mask(struct device *dev, + unsigned int min_align_mask) +{ + if (WARN_ON_ONCE(!dev->dma_parms)) + return -EIO; + dev->dma_parms->min_align_mask = min_align_mask; + return 0; +} + static inline int dma_get_cache_alignment(void) { #ifdef ARCH_DMA_MINALIGN -- 2.29.2 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-02-04 19:30 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-04 19:30 preserve DMA offsets when using swiotlb Christoph Hellwig 2021-02-04 19:30 ` Christoph Hellwig 2021-02-04 19:30 ` Christoph Hellwig [this message] 2021-02-04 19:30 ` [PATCH 1/8] driver core: add a min_align_mask field to struct device_dma_parameters Christoph Hellwig 2021-02-04 19:44 ` Greg KH 2021-02-04 19:44 ` Greg KH 2021-02-04 19:30 ` [PATCH 2/8] swiotlb: add a io_tlb_offset helper Christoph Hellwig 2021-02-04 19:30 ` Christoph Hellwig 2021-02-04 19:30 ` [PATCH 3/8] swiotlb: factor out a nr_slots helper Christoph Hellwig 2021-02-04 19:30 ` Christoph Hellwig 2021-02-04 22:09 ` Robin Murphy 2021-02-04 22:09 ` Robin Murphy 2021-02-05 9:45 ` Christoph Hellwig 2021-02-05 9:45 ` Christoph Hellwig 2021-02-04 19:30 ` [PATCH 4/8] swiotlb: clean up swiotlb_tbl_unmap_single Christoph Hellwig 2021-02-04 19:30 ` Christoph Hellwig 2021-02-04 19:30 ` [PATCH 5/8] swiotlb: refactor swiotlb_tbl_map_single Christoph Hellwig 2021-02-04 19:30 ` Christoph Hellwig 2021-02-04 22:12 ` Robin Murphy 2021-02-04 22:12 ` Robin Murphy 2021-02-05 9:45 ` Christoph Hellwig 2021-02-05 9:45 ` Christoph Hellwig 2021-02-04 19:30 ` [PATCH 6/8] swiotlb: don't modify orig_addr in swiotlb_tbl_sync_single Christoph Hellwig 2021-02-04 19:30 ` Christoph Hellwig 2021-02-04 19:30 ` [PATCH 7/8] swiotlb: respect min_align_mask Christoph Hellwig 2021-02-04 19:30 ` Christoph Hellwig 2021-02-04 23:13 ` Robin Murphy 2021-02-04 23:13 ` Robin Murphy 2021-02-05 10:34 ` Christoph Hellwig 2021-02-05 10:34 ` Christoph Hellwig 2021-02-04 19:30 ` [PATCH 8/8] nvme-pci: set min_align_mask Christoph Hellwig 2021-02-04 19:30 ` Christoph Hellwig 2021-02-04 19:32 ` Christoph Hellwig 2021-02-04 19:32 ` Christoph Hellwig 2021-02-05 11:50 ` preserve DMA offsets when using swiotlb Christoph Hellwig 2021-02-05 11:50 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210204193035.2606838-2-hch@lst.de \ --to=hch@lst.de \ --cc=erdemaktas@google.com \ --cc=gregkh@linuxfoundation.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jxgao@google.com \ --cc=kbusch@kernel.org \ --cc=konrad.wilk@oracle.com \ --cc=linux-nvme@lists.infradead.org \ --cc=m.szyprowski@samsung.com \ --cc=marcorr@google.com \ --cc=robin.murphy@arm.com \ --cc=saravanak@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.