* [PATCH] lib: crc-itu-t: Fix comment in typo
@ 2021-02-05 0:47 David Mosberger-Tang
2021-02-05 0:57 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: David Mosberger-Tang @ 2021-02-05 0:47 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-kernel, David Mosberger-Tang
Signed-off-by: David Mosberger-Tang <davidm@egauge.net>
---
lib/crc-itu-t.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/crc-itu-t.c b/lib/crc-itu-t.c
index 1974b355c148..56e6e0d63d1e 100644
--- a/lib/crc-itu-t.c
+++ b/lib/crc-itu-t.c
@@ -7,7 +7,7 @@
#include <linux/module.h>
#include <linux/crc-itu-t.h>
-/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^15 + 1) */
+/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^5 + 1) */
const u16 crc_itu_t_table[256] = {
0x0000, 0x1021, 0x2042, 0x3063, 0x4084, 0x50a5, 0x60c6, 0x70e7,
0x8108, 0x9129, 0xa14a, 0xb16b, 0xc18c, 0xd1ad, 0xe1ce, 0xf1ef,
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] lib: crc-itu-t: Fix comment in typo
2021-02-05 0:47 [PATCH] lib: crc-itu-t: Fix comment in typo David Mosberger-Tang
@ 2021-02-05 0:57 ` Randy Dunlap
2021-02-05 1:02 ` [PATCH] lib: crc-itu-t: Fix typo in comment David Mosberger-Tang
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-02-05 0:57 UTC (permalink / raw)
To: David Mosberger-Tang, Jiri Kosina; +Cc: linux-kernel
On 2/4/21 4:47 PM, David Mosberger-Tang wrote:
> Signed-off-by: David Mosberger-Tang <davidm@egauge.net>
> ---
> lib/crc-itu-t.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/crc-itu-t.c b/lib/crc-itu-t.c
> index 1974b355c148..56e6e0d63d1e 100644
> --- a/lib/crc-itu-t.c
> +++ b/lib/crc-itu-t.c
> @@ -7,7 +7,7 @@
> #include <linux/module.h>
> #include <linux/crc-itu-t.h>
>
> -/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^15 + 1) */
> +/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^5 + 1) */
This comment should not be indicated as kernel-doc:
please use /* instead of /**.
> const u16 crc_itu_t_table[256] = {
> 0x0000, 0x1021, 0x2042, 0x3063, 0x4084, 0x50a5, 0x60c6, 0x70e7,
> 0x8108, 0x9129, 0xa14a, 0xb16b, 0xc18c, 0xd1ad, 0xe1ce, 0xf1ef,
>
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] lib: crc-itu-t: Fix typo in comment
2021-02-05 0:57 ` Randy Dunlap
@ 2021-02-05 1:02 ` David Mosberger-Tang
2021-02-05 1:17 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: David Mosberger-Tang @ 2021-02-05 1:02 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-kernel, David Mosberger-Tang
Signed-off-by: David Mosberger-Tang <davidm@egauge.net>
---
lib/crc-itu-t.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/crc-itu-t.c b/lib/crc-itu-t.c
index 1974b355c148..1d26a1647da5 100644
--- a/lib/crc-itu-t.c
+++ b/lib/crc-itu-t.c
@@ -7,7 +7,7 @@
#include <linux/module.h>
#include <linux/crc-itu-t.h>
-/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^15 + 1) */
+/* CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^5 + 1) */
const u16 crc_itu_t_table[256] = {
0x0000, 0x1021, 0x2042, 0x3063, 0x4084, 0x50a5, 0x60c6, 0x70e7,
0x8108, 0x9129, 0xa14a, 0xb16b, 0xc18c, 0xd1ad, 0xe1ce, 0xf1ef,
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] lib: crc-itu-t: Fix typo in comment
2021-02-05 1:02 ` [PATCH] lib: crc-itu-t: Fix typo in comment David Mosberger-Tang
@ 2021-02-05 1:17 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-02-05 1:17 UTC (permalink / raw)
To: David Mosberger-Tang, Jiri Kosina; +Cc: linux-kernel
On 2/4/21 5:02 PM, David Mosberger-Tang wrote:
> Signed-off-by: David Mosberger-Tang <davidm@egauge.net>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> lib/crc-itu-t.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/crc-itu-t.c b/lib/crc-itu-t.c
> index 1974b355c148..1d26a1647da5 100644
> --- a/lib/crc-itu-t.c
> +++ b/lib/crc-itu-t.c
> @@ -7,7 +7,7 @@
> #include <linux/module.h>
> #include <linux/crc-itu-t.h>
>
> -/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^15 + 1) */
> +/* CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^5 + 1) */
> const u16 crc_itu_t_table[256] = {
> 0x0000, 0x1021, 0x2042, 0x3063, 0x4084, 0x50a5, 0x60c6, 0x70e7,
> 0x8108, 0x9129, 0xa14a, 0xb16b, 0xc18c, 0xd1ad, 0xe1ce, 0xf1ef,
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-05 1:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 0:47 [PATCH] lib: crc-itu-t: Fix comment in typo David Mosberger-Tang
2021-02-05 0:57 ` Randy Dunlap
2021-02-05 1:02 ` [PATCH] lib: crc-itu-t: Fix typo in comment David Mosberger-Tang
2021-02-05 1:17 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.