* [PATCH] nvmetcli: fixup ana groupid setting for namespaces
@ 2021-02-05 9:56 Hannes Reinecke
2021-07-13 9:20 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Reinecke @ 2021-02-05 9:56 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Chaitanya Kulkarni, linux-nvme, Sagi Grimberg, Keith Busch,
Hannes Reinecke
The ANA group of a namespace is displayed, but can't be set.
So add a new attribute group 'ana' to the namespace such that
it can be set via 'set ana grpid'.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
nvmet/nvme.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nvmet/nvme.py b/nvmet/nvme.py
index 83fd75b..d170204 100644
--- a/nvmet/nvme.py
+++ b/nvmet/nvme.py
@@ -567,7 +567,7 @@ class Namespace(CFSNode):
if nsid < 1 or nsid > self.MAX_NSID:
raise CFSError("NSID must be 1 to %d" % self.MAX_NSID)
- self.attr_groups = ['device']
+ self.attr_groups = ['device', 'ana']
self._subsystem = subsystem
self._nsid = nsid
self._path = "%s/namespaces/%d" % (self.subsystem.path, self.nsid)
--
2.29.2
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nvmetcli: fixup ana groupid setting for namespaces
2021-02-05 9:56 [PATCH] nvmetcli: fixup ana groupid setting for namespaces Hannes Reinecke
@ 2021-07-13 9:20 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2021-07-13 9:20 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Christoph Hellwig, Sagi Grimberg, Keith Busch,
Chaitanya Kulkarni, linux-nvme
Thanks, applied.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-13 9:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 9:56 [PATCH] nvmetcli: fixup ana groupid setting for namespaces Hannes Reinecke
2021-07-13 9:20 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.