From: Mark Brown <broonie@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com,
festevam@gmail.com, linuxppc-dev@lists.ozlabs.org,
robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg
Date: Fri, 5 Feb 2021 14:02:51 +0000 [thread overview]
Message-ID: <20210205140251.GB4720@sirena.org.uk> (raw)
In-Reply-To: <1612508250-10586-3-git-send-email-shengjiu.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
On Fri, Feb 05, 2021 at 02:57:25PM +0800, Shengjiu Wang wrote:
> This is a dummy cpu dai driver for rpmsg audio use case,
> which is mainly used for getting the user's configuration
This is actually doing stuff, it's not a dummy driver.
> +static int fsl_rpmsg_remove(struct platform_device *pdev)
> +{
> + return 0;
> +}
If this isn't needed just remove it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
timur@kernel.org, lgirdwood@gmail.com,
linuxppc-dev@lists.ozlabs.org, Xiubo.Lee@gmail.com,
linux-kernel@vger.kernel.org, tiwai@suse.com,
nicoleotsuka@gmail.com, robh+dt@kernel.org, festevam@gmail.com
Subject: Re: [PATCH 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg
Date: Fri, 5 Feb 2021 14:02:51 +0000 [thread overview]
Message-ID: <20210205140251.GB4720@sirena.org.uk> (raw)
In-Reply-To: <1612508250-10586-3-git-send-email-shengjiu.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
On Fri, Feb 05, 2021 at 02:57:25PM +0800, Shengjiu Wang wrote:
> This is a dummy cpu dai driver for rpmsg audio use case,
> which is mainly used for getting the user's configuration
This is actually doing stuff, it's not a dummy driver.
> +static int fsl_rpmsg_remove(struct platform_device *pdev)
> +{
> + return 0;
> +}
If this isn't needed just remove it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
timur@kernel.org, lgirdwood@gmail.com,
linuxppc-dev@lists.ozlabs.org, Xiubo.Lee@gmail.com,
linux-kernel@vger.kernel.org, tiwai@suse.com,
nicoleotsuka@gmail.com, robh+dt@kernel.org, perex@perex.cz,
festevam@gmail.com
Subject: Re: [PATCH 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg
Date: Fri, 5 Feb 2021 14:02:51 +0000 [thread overview]
Message-ID: <20210205140251.GB4720@sirena.org.uk> (raw)
In-Reply-To: <1612508250-10586-3-git-send-email-shengjiu.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
On Fri, Feb 05, 2021 at 02:57:25PM +0800, Shengjiu Wang wrote:
> This is a dummy cpu dai driver for rpmsg audio use case,
> which is mainly used for getting the user's configuration
This is actually doing stuff, it's not a dummy driver.
> +static int fsl_rpmsg_remove(struct platform_device *pdev)
> +{
> + return 0;
> +}
If this isn't needed just remove it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-05 17:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 6:57 [PATCH 0/7] Add audio driver base on rpmsg on i.MX platform Shengjiu Wang
2021-02-05 6:57 ` [PATCH 1/7] ASoC: soc-component: Add snd_soc_pcm_component_ack Shengjiu Wang
2021-02-05 6:57 ` [PATCH 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg Shengjiu Wang
2021-02-05 14:02 ` Mark Brown [this message]
2021-02-05 14:02 ` Mark Brown
2021-02-05 14:02 ` Mark Brown
2021-02-07 9:49 ` Shengjiu Wang
2021-02-07 9:49 ` Shengjiu Wang
2021-02-05 6:57 ` [PATCH 3/7] ASoC: dt-bindings: fsl_rpmsg: Add binding doc for rpmsg cpu dai driver Shengjiu Wang
2021-02-05 6:57 ` [PATCH 4/7] ASoC: imx-audio-rpmsg: Add rpmsg_driver for audio channel Shengjiu Wang
2021-02-05 14:25 ` Mark Brown
2021-02-05 14:25 ` Mark Brown
2021-02-05 14:25 ` Mark Brown
2021-02-07 9:49 ` Shengjiu Wang
2021-02-07 9:49 ` Shengjiu Wang
2021-02-05 6:57 ` [PATCH 5/7] ASoC: imx-pcm-rpmsg: Add platform driver for audio base on rpmsg Shengjiu Wang
2021-02-05 14:58 ` Mark Brown
2021-02-05 14:58 ` Mark Brown
2021-02-05 14:58 ` Mark Brown
2021-02-07 9:50 ` Shengjiu Wang
2021-02-07 9:50 ` Shengjiu Wang
2021-02-05 6:57 ` [PATCH 6/7] ASoC: imx-rpmsg: Add machine " Shengjiu Wang
2021-02-05 6:57 ` [PATCH 7/7] ASoC: dt-bindings: imx-rpmsg: Add binding doc for rpmsg machine driver Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205140251.GB4720@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.