From: kernel test robot <lkp@intel.com> To: "Rafał Miłecki" <zajec5@gmail.com>, "David S . Miller" <davem@davemloft.net>, "Jakub Kicinski" <kuba@kernel.org>, "Rob Herring" <robh+dt@kernel.org> Cc: kbuild-all@lists.01.org, "Florian Fainelli" <f.fainelli@gmail.com>, "Randy Dunlap" <rdunlap@infradead.org>, "Masahiro Yamada" <masahiroy@kernel.org>, netdev@vger.kernel.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, "Rafał Miłecki" <rafal@milecki.pl> Subject: Re: [PATCH net-next 2/2] net: broadcom: bcm4908enet: add BCM4908 controller driver Date: Sat, 6 Feb 2021 07:47:40 +0800 [thread overview] Message-ID: <202102060704.EXN0bQ73-lkp@intel.com> (raw) In-Reply-To: <20210205214417.11178-2-zajec5@gmail.com> [-- Attachment #1: Type: text/plain, Size: 4788 bytes --] Hi "Rafał, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/dt-bindings-net-document-BCM4908-Ethernet-controller/20210206-055343 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 6626a0266566c5aea16178c5e6cd7fc4db3f2f56 config: i386-randconfig-s001-20210205 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-215-g0fb77bb6-dirty # https://github.com/0day-ci/linux/commit/53a9af8e34620fcfd9a75ccc9c89862b5c96598d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Rafa-Mi-ecki/dt-bindings-net-document-BCM4908-Ethernet-controller/20210206-055343 git checkout 53a9af8e34620fcfd9a75ccc9c89862b5c96598d # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> "sparse warnings: (new ones prefixed by >>)" >> drivers/net/ethernet/broadcom/bcm4908enet.c:274:23: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] ctl @@ got unsigned int [assigned] [usertype] tmp @@ drivers/net/ethernet/broadcom/bcm4908enet.c:274:23: sparse: expected restricted __le32 [usertype] ctl drivers/net/ethernet/broadcom/bcm4908enet.c:274:23: sparse: got unsigned int [assigned] [usertype] tmp >> drivers/net/ethernet/broadcom/bcm4908enet.c:275:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] addr @@ got unsigned int [usertype] dma_addr @@ drivers/net/ethernet/broadcom/bcm4908enet.c:275:24: sparse: expected restricted __le32 [usertype] addr drivers/net/ethernet/broadcom/bcm4908enet.c:275:24: sparse: got unsigned int [usertype] dma_addr >> drivers/net/ethernet/broadcom/bcm4908enet.c:485:29: sparse: sparse: restricted __le32 degrades to integer drivers/net/ethernet/broadcom/bcm4908enet.c:505:13: sparse: sparse: restricted __le32 degrades to integer >> drivers/net/ethernet/broadcom/bcm4908enet.c:525:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] addr @@ got unsigned int [usertype] @@ drivers/net/ethernet/broadcom/bcm4908enet.c:525:24: sparse: expected restricted __le32 [usertype] addr drivers/net/ethernet/broadcom/bcm4908enet.c:525:24: sparse: got unsigned int [usertype] drivers/net/ethernet/broadcom/bcm4908enet.c:526:23: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] ctl @@ got unsigned int [assigned] [usertype] tmp @@ drivers/net/ethernet/broadcom/bcm4908enet.c:526:23: sparse: expected restricted __le32 [usertype] ctl drivers/net/ethernet/broadcom/bcm4908enet.c:526:23: sparse: got unsigned int [assigned] [usertype] tmp drivers/net/ethernet/broadcom/bcm4908enet.c:551:29: sparse: sparse: restricted __le32 degrades to integer drivers/net/ethernet/broadcom/bcm4908enet.c:564:32: sparse: sparse: restricted __le32 degrades to integer drivers/net/ethernet/broadcom/bcm4908enet.c:567:30: sparse: sparse: restricted __le32 degrades to integer vim +274 drivers/net/ethernet/broadcom/bcm4908enet.c 246 247 static int bcm4908enet_dma_alloc_rx_buf(struct bcm4908enet *enet, unsigned int idx) 248 { 249 struct bcm4908enet_dma_ring_bd *buf_desc = &enet->rx_ring.buf_desc[idx]; 250 struct bcm4908enet_dma_ring_slot *slot = &enet->rx_ring.slots[idx]; 251 struct device *dev = enet->dev; 252 u32 tmp; 253 int err; 254 255 slot->len = ENET_MTU_MAX + ENET_MTU_MAX_EXTRA_SIZE; 256 257 slot->skb = netdev_alloc_skb(enet->netdev, slot->len); 258 if (!slot->skb) 259 return -ENOMEM; 260 261 slot->dma_addr = dma_map_single(dev, slot->skb->data, slot->len, DMA_FROM_DEVICE); 262 err = dma_mapping_error(dev, slot->dma_addr); 263 if (err) { 264 dev_err(dev, "Failed to map DMA buffer: %d\n", err); 265 kfree_skb(slot->skb); 266 slot->skb = NULL; 267 return err; 268 } 269 270 tmp = slot->len << DMA_CTL_LEN_DESC_BUFLENGTH_SHIFT; 271 tmp |= DMA_CTL_STATUS_OWN; 272 if (idx == enet->rx_ring.length - 1) 273 tmp |= DMA_CTL_STATUS_WRAP; > 274 buf_desc->ctl = tmp; > 275 buf_desc->addr = slot->dma_addr; 276 277 return 0; 278 } 279 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 28596 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH net-next 2/2] net: broadcom: bcm4908enet: add BCM4908 controller driver Date: Sat, 06 Feb 2021 07:47:40 +0800 [thread overview] Message-ID: <202102060704.EXN0bQ73-lkp@intel.com> (raw) In-Reply-To: <20210205214417.11178-2-zajec5@gmail.com> [-- Attachment #1: Type: text/plain, Size: 4873 bytes --] Hi "Rafał, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/dt-bindings-net-document-BCM4908-Ethernet-controller/20210206-055343 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 6626a0266566c5aea16178c5e6cd7fc4db3f2f56 config: i386-randconfig-s001-20210205 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-215-g0fb77bb6-dirty # https://github.com/0day-ci/linux/commit/53a9af8e34620fcfd9a75ccc9c89862b5c96598d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Rafa-Mi-ecki/dt-bindings-net-document-BCM4908-Ethernet-controller/20210206-055343 git checkout 53a9af8e34620fcfd9a75ccc9c89862b5c96598d # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> "sparse warnings: (new ones prefixed by >>)" >> drivers/net/ethernet/broadcom/bcm4908enet.c:274:23: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] ctl @@ got unsigned int [assigned] [usertype] tmp @@ drivers/net/ethernet/broadcom/bcm4908enet.c:274:23: sparse: expected restricted __le32 [usertype] ctl drivers/net/ethernet/broadcom/bcm4908enet.c:274:23: sparse: got unsigned int [assigned] [usertype] tmp >> drivers/net/ethernet/broadcom/bcm4908enet.c:275:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] addr @@ got unsigned int [usertype] dma_addr @@ drivers/net/ethernet/broadcom/bcm4908enet.c:275:24: sparse: expected restricted __le32 [usertype] addr drivers/net/ethernet/broadcom/bcm4908enet.c:275:24: sparse: got unsigned int [usertype] dma_addr >> drivers/net/ethernet/broadcom/bcm4908enet.c:485:29: sparse: sparse: restricted __le32 degrades to integer drivers/net/ethernet/broadcom/bcm4908enet.c:505:13: sparse: sparse: restricted __le32 degrades to integer >> drivers/net/ethernet/broadcom/bcm4908enet.c:525:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] addr @@ got unsigned int [usertype] @@ drivers/net/ethernet/broadcom/bcm4908enet.c:525:24: sparse: expected restricted __le32 [usertype] addr drivers/net/ethernet/broadcom/bcm4908enet.c:525:24: sparse: got unsigned int [usertype] drivers/net/ethernet/broadcom/bcm4908enet.c:526:23: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] ctl @@ got unsigned int [assigned] [usertype] tmp @@ drivers/net/ethernet/broadcom/bcm4908enet.c:526:23: sparse: expected restricted __le32 [usertype] ctl drivers/net/ethernet/broadcom/bcm4908enet.c:526:23: sparse: got unsigned int [assigned] [usertype] tmp drivers/net/ethernet/broadcom/bcm4908enet.c:551:29: sparse: sparse: restricted __le32 degrades to integer drivers/net/ethernet/broadcom/bcm4908enet.c:564:32: sparse: sparse: restricted __le32 degrades to integer drivers/net/ethernet/broadcom/bcm4908enet.c:567:30: sparse: sparse: restricted __le32 degrades to integer vim +274 drivers/net/ethernet/broadcom/bcm4908enet.c 246 247 static int bcm4908enet_dma_alloc_rx_buf(struct bcm4908enet *enet, unsigned int idx) 248 { 249 struct bcm4908enet_dma_ring_bd *buf_desc = &enet->rx_ring.buf_desc[idx]; 250 struct bcm4908enet_dma_ring_slot *slot = &enet->rx_ring.slots[idx]; 251 struct device *dev = enet->dev; 252 u32 tmp; 253 int err; 254 255 slot->len = ENET_MTU_MAX + ENET_MTU_MAX_EXTRA_SIZE; 256 257 slot->skb = netdev_alloc_skb(enet->netdev, slot->len); 258 if (!slot->skb) 259 return -ENOMEM; 260 261 slot->dma_addr = dma_map_single(dev, slot->skb->data, slot->len, DMA_FROM_DEVICE); 262 err = dma_mapping_error(dev, slot->dma_addr); 263 if (err) { 264 dev_err(dev, "Failed to map DMA buffer: %d\n", err); 265 kfree_skb(slot->skb); 266 slot->skb = NULL; 267 return err; 268 } 269 270 tmp = slot->len << DMA_CTL_LEN_DESC_BUFLENGTH_SHIFT; 271 tmp |= DMA_CTL_STATUS_OWN; 272 if (idx == enet->rx_ring.length - 1) 273 tmp |= DMA_CTL_STATUS_WRAP; > 274 buf_desc->ctl = tmp; > 275 buf_desc->addr = slot->dma_addr; 276 277 return 0; 278 } 279 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 28596 bytes --]
next prev parent reply other threads:[~2021-02-06 3:17 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-05 21:44 [PATCH net-next 1/2] dt-bindings: net: document BCM4908 Ethernet controller Rafał Miłecki 2021-02-05 21:44 ` [PATCH net-next 2/2] net: broadcom: bcm4908enet: add BCM4908 controller driver Rafał Miłecki 2021-02-05 23:47 ` kernel test robot [this message] 2021-02-05 23:47 ` kernel test robot 2021-02-07 22:26 ` [PATCH V2 net-next 1/2] dt-bindings: net: document BCM4908 Ethernet controller Rafał Miłecki 2021-02-07 22:26 ` [PATCH V2 net-next 2/2] net: broadcom: bcm4908enet: add BCM4908 controller driver Rafał Miłecki 2021-02-09 23:01 ` [PATCH V3 net-next 1/2] dt-bindings: net: document BCM4908 Ethernet controller Rafał Miłecki 2021-02-09 23:01 ` [PATCH V3 net-next 2/2] net: broadcom: bcm4908_enet: add BCM4908 controller driver Rafał Miłecki 2021-02-10 2:39 ` Andrew Lunn 2021-02-10 7:57 ` Rafał Miłecki 2021-02-10 9:47 ` [PATCH V4 net-next 1/2] dt-bindings: net: document BCM4908 Ethernet controller Rafał Miłecki 2021-02-10 9:47 ` [PATCH V4 net-next 2/2] net: broadcom: bcm4908_enet: add BCM4908 controller driver Rafał Miłecki 2021-02-11 0:44 ` Andrew Lunn 2021-02-11 12:12 ` [PATCH net-next 5.12 0/8] bcm4908_enet: post-review fixes Rafał Miłecki 2021-02-11 12:12 ` [PATCH net-next 5.12 1/8] dt-bindings: net: rename BCM4908 Ethernet binding Rafał Miłecki 2021-02-11 17:44 ` Florian Fainelli 2021-02-11 12:12 ` [PATCH net-next 5.12 2/8] dt-bindings: net: bcm4908-enet: include ethernet-controller.yaml Rafał Miłecki 2021-02-11 17:44 ` Florian Fainelli 2021-02-11 12:12 ` [PATCH net-next 5.12 3/8] net: broadcom: rename BCM4908 driver & update DT binding Rafał Miłecki 2021-02-11 17:44 ` Florian Fainelli 2021-02-11 12:12 ` [PATCH net-next 5.12 4/8] net: broadcom: bcm4908_enet: drop unneeded memset() Rafał Miłecki 2021-02-11 17:45 ` Florian Fainelli 2021-02-11 12:12 ` [PATCH net-next 5.12 5/8] net: broadcom: bcm4908_enet: drop "inline" from C functions Rafał Miłecki 2021-02-11 17:45 ` Florian Fainelli 2021-02-11 12:12 ` [PATCH net-next 5.12 6/8] net: broadcom: bcm4908_enet: fix minor typos Rafał Miłecki 2021-02-11 17:46 ` Florian Fainelli 2021-02-11 12:12 ` [PATCH net-next 5.12 7/8] net: broadcom: bcm4908_enet: fix received skb length Rafał Miłecki 2021-02-11 17:46 ` Florian Fainelli 2021-02-11 12:12 ` [PATCH net-next 5.12 8/8] net: broadcom: bcm4908_enet: fix endianness in xmit code Rafał Miłecki 2021-02-11 17:46 ` Florian Fainelli 2021-02-11 23:10 ` [PATCH net-next 5.12 0/8] bcm4908_enet: post-review fixes patchwork-bot+netdevbpf 2021-02-09 21:43 ` [PATCH V2 net-next 1/2] dt-bindings: net: document BCM4908 Ethernet controller Rob Herring 2021-02-09 22:07 ` Rafał Miłecki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202102060704.EXN0bQ73-lkp@intel.com \ --to=lkp@intel.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=kbuild-all@lists.01.org \ --cc=kuba@kernel.org \ --cc=masahiroy@kernel.org \ --cc=netdev@vger.kernel.org \ --cc=rafal@milecki.pl \ --cc=rdunlap@infradead.org \ --cc=robh+dt@kernel.org \ --cc=zajec5@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.