* [kbuild] [linux-next:master 3854/6048] drivers/net/ethernet/mscc/ocelot_vsc7514.c:1318 mscc_ocelot_probe() warn: missing error code 'err'
@ 2021-02-08 11:17 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-02-08 11:17 UTC (permalink / raw)
To: kbuild, Vladimir Oltean
Cc: lkp, kbuild-all, Linux Memory Management List, Jakub Kicinski,
Florian Fainelli
[-- Attachment #1: Type: text/plain, Size: 18571 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 59fa6a163ffabc1bf25c5e0e33899e268a96d3cc
commit: 6c30384eb1dec96b678ff9c01c15134b1a0e81f4 [3854/6048] net: mscc: ocelot: register devlink ports
config: x86_64-randconfig-m001-20210206 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/ethernet/mscc/ocelot_vsc7514.c:1318 mscc_ocelot_probe() warn: missing error code 'err'
vim +/err +1318 drivers/net/ethernet/mscc/ocelot_vsc7514.c
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1245 static int mscc_ocelot_probe(struct platform_device *pdev)
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1246 {
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1247 struct device_node *np = pdev->dev.of_node;
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1248 int err, irq_xtr, irq_ptp_rdy;
7c411799e1b3e0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1249 struct device_node *ports;
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1250 struct devlink *devlink;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1251 struct ocelot *ocelot;
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1252 struct regmap *hsio;
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1253 unsigned int i;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1254
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1255 struct {
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1256 enum ocelot_target id;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1257 char *name;
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1258 u8 optional:1;
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1259 } io_target[] = {
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1260 { SYS, "sys" },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1261 { REW, "rew" },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1262 { QSYS, "qsys" },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1263 { ANA, "ana" },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1264 { QS, "qs" },
e3aea296d86f0f drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-30 1265 { S0, "s0" },
a61e365d7c183c drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-30 1266 { S1, "s1" },
b596229448dd2a drivers/net/ethernet/mscc/ocelot_board.c Horatiu Vultur 2019-05-31 1267 { S2, "s2" },
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1268 { PTP, "ptp", 1 },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1269 };
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1270
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1271 if (!np && !pdev->dev.platform_data)
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1272 return -ENODEV;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1273
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1274 devlink = devlink_alloc(&ocelot_devlink_ops, sizeof(*ocelot));
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1275 if (!devlink)
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1276 return -ENOMEM;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1277
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1278 ocelot = devlink_priv(devlink);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1279 ocelot->devlink = priv_to_devlink(ocelot);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1280 platform_set_drvdata(pdev, ocelot);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1281 ocelot->dev = &pdev->dev;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1282
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1283 for (i = 0; i < ARRAY_SIZE(io_target); i++) {
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1284 struct regmap *target;
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1285 struct resource *res;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1286
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1287 res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1288 io_target[i].name);
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1289
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1290 target = ocelot_regmap_init(ocelot, res);
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1291 if (IS_ERR(target)) {
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1292 if (io_target[i].optional) {
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1293 ocelot->targets[io_target[i].id] = NULL;
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1294 continue;
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1295 }
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1296 err = PTR_ERR(target);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1297 goto out_free_devlink;
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1298 }
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1299
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1300 ocelot->targets[io_target[i].id] = target;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1301 }
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1302
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1303 hsio = syscon_regmap_lookup_by_compatible("mscc,ocelot-hsio");
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1304 if (IS_ERR(hsio)) {
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1305 dev_err(&pdev->dev, "missing hsio syscon\n");
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1306 err = PTR_ERR(hsio);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1307 goto out_free_devlink;
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1308 }
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1309
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1310 ocelot->targets[HSIO] = hsio;
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1311
dc3de2a294eab8 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1312 err = ocelot_chip_init(ocelot, &ocelot_ops);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1313 if (err)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1314 goto out_free_devlink;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1315
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1316 irq_xtr = platform_get_irq_byname(pdev, "xtr");
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1317 if (irq_xtr < 0)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 @1318 goto out_free_devlink;
Yep. Missing an error code.
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1319
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1320 err = devm_request_threaded_irq(&pdev->dev, irq_xtr, NULL,
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1321 ocelot_xtr_irq_handler, IRQF_ONESHOT,
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1322 "frame extraction", ocelot);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1323 if (err)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1324 goto out_free_devlink;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1325
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1326 irq_ptp_rdy = platform_get_irq_byname(pdev, "ptp_rdy");
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1327 if (irq_ptp_rdy > 0 && ocelot->targets[PTP]) {
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1328 err = devm_request_threaded_irq(&pdev->dev, irq_ptp_rdy, NULL,
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1329 ocelot_ptp_rdy_irq_handler,
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1330 IRQF_ONESHOT, "ptp ready",
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1331 ocelot);
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1332 if (err)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1333 goto out_free_devlink;
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1334
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1335 /* Both the PTP interrupt and the PTP bank are available */
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1336 ocelot->ptp = 1;
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1337 }
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1338
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1339 ports = of_get_child_by_name(np, "ethernet-ports");
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1340 if (!ports) {
7c411799e1b3e0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1341 dev_err(ocelot->dev, "no ethernet-ports child node found\n");
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1342 err = -ENODEV;
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1343 goto out_free_devlink;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1344 }
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1345
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1346 ocelot->num_phys_ports = of_get_child_count(ports);
edd2410b165e2e drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-12-04 1347 ocelot->num_flooding_pgids = 1;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1348
8551cdeb2ad171 drivers/net/ethernet/mscc/ocelot_board.c Vladimir Oltean 2020-02-29 1349 ocelot->vcap = vsc7514_vcap_props;
2d44b097bbb9d0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-26 1350 ocelot->inj_prefix = OCELOT_TAG_PREFIX_NONE;
2d44b097bbb9d0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-26 1351 ocelot->xtr_prefix = OCELOT_TAG_PREFIX_NONE;
2d44b097bbb9d0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-26 1352 ocelot->npi = -1;
e0632940bc4c98 drivers/net/ethernet/mscc/ocelot_board.c Vladimir Oltean 2020-02-29 1353
d1cc0e932039cc drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1354 err = ocelot_init(ocelot);
d1cc0e932039cc drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1355 if (err)
d1cc0e932039cc drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1356 goto out_put_ports;
d1cc0e932039cc drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1357
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1358 err = devlink_register(devlink, ocelot->dev);
7c411799e1b3e0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1359 if (err)
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1360 goto out_ocelot_deinit;
7c411799e1b3e0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1361
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1362 err = mscc_ocelot_init_ports(pdev, ports);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1363 if (err)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1364 goto out_ocelot_devlink_unregister;
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1365
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1366 if (ocelot->ptp) {
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1367 err = ocelot_init_timestamp(ocelot, &ocelot_ptp_clock_info);
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1368 if (err) {
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1369 dev_err(ocelot->dev,
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1370 "Timestamp initialization failed\n");
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1371 ocelot->ptp = 0;
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1372 }
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1373 }
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1374
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1375 register_netdevice_notifier(&ocelot_netdevice_nb);
56da64bc003bb9 drivers/net/ethernet/mscc/ocelot_board.c Florian Fainelli 2019-02-27 1376 register_switchdev_notifier(&ocelot_switchdev_nb);
0e332c854f4118 drivers/net/ethernet/mscc/ocelot_board.c Petr Machata 2018-11-22 1377 register_switchdev_blocking_notifier(&ocelot_switchdev_blocking_nb);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1378
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1379 of_node_put(ports);
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1380
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1381 dev_info(&pdev->dev, "Ocelot switch probed\n");
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1382
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1383 return 0;
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1384
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1385 out_ocelot_devlink_unregister:
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1386 devlink_unregister(devlink);
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1387 out_ocelot_deinit:
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1388 ocelot_deinit(ocelot);
d2c50b1cd94528 drivers/net/ethernet/mscc/ocelot_board.c Wen Yang 2019-09-29 1389 out_put_ports:
d2c50b1cd94528 drivers/net/ethernet/mscc/ocelot_board.c Wen Yang 2019-09-29 1390 of_node_put(ports);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1391 out_free_devlink:
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1392 devlink_free(devlink);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1393 return err;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1394 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34499 bytes --]
[-- Attachment #3: Type: text/plain, Size: 149 bytes --]
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* [linux-next:master 3854/6048] drivers/net/ethernet/mscc/ocelot_vsc7514.c:1318 mscc_ocelot_probe() warn: missing error code 'err'
@ 2021-02-08 11:17 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-02-08 11:17 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 18903 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 59fa6a163ffabc1bf25c5e0e33899e268a96d3cc
commit: 6c30384eb1dec96b678ff9c01c15134b1a0e81f4 [3854/6048] net: mscc: ocelot: register devlink ports
config: x86_64-randconfig-m001-20210206 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/ethernet/mscc/ocelot_vsc7514.c:1318 mscc_ocelot_probe() warn: missing error code 'err'
vim +/err +1318 drivers/net/ethernet/mscc/ocelot_vsc7514.c
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1245 static int mscc_ocelot_probe(struct platform_device *pdev)
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1246 {
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1247 struct device_node *np = pdev->dev.of_node;
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1248 int err, irq_xtr, irq_ptp_rdy;
7c411799e1b3e0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1249 struct device_node *ports;
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1250 struct devlink *devlink;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1251 struct ocelot *ocelot;
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1252 struct regmap *hsio;
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1253 unsigned int i;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1254
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1255 struct {
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1256 enum ocelot_target id;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1257 char *name;
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1258 u8 optional:1;
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1259 } io_target[] = {
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1260 { SYS, "sys" },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1261 { REW, "rew" },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1262 { QSYS, "qsys" },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1263 { ANA, "ana" },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1264 { QS, "qs" },
e3aea296d86f0f drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-30 1265 { S0, "s0" },
a61e365d7c183c drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-30 1266 { S1, "s1" },
b596229448dd2a drivers/net/ethernet/mscc/ocelot_board.c Horatiu Vultur 2019-05-31 1267 { S2, "s2" },
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1268 { PTP, "ptp", 1 },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1269 };
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1270
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1271 if (!np && !pdev->dev.platform_data)
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1272 return -ENODEV;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1273
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1274 devlink = devlink_alloc(&ocelot_devlink_ops, sizeof(*ocelot));
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1275 if (!devlink)
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1276 return -ENOMEM;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1277
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1278 ocelot = devlink_priv(devlink);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1279 ocelot->devlink = priv_to_devlink(ocelot);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1280 platform_set_drvdata(pdev, ocelot);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1281 ocelot->dev = &pdev->dev;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1282
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1283 for (i = 0; i < ARRAY_SIZE(io_target); i++) {
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1284 struct regmap *target;
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1285 struct resource *res;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1286
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1287 res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1288 io_target[i].name);
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1289
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1290 target = ocelot_regmap_init(ocelot, res);
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1291 if (IS_ERR(target)) {
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1292 if (io_target[i].optional) {
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1293 ocelot->targets[io_target[i].id] = NULL;
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1294 continue;
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1295 }
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1296 err = PTR_ERR(target);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1297 goto out_free_devlink;
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1298 }
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1299
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1300 ocelot->targets[io_target[i].id] = target;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1301 }
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1302
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1303 hsio = syscon_regmap_lookup_by_compatible("mscc,ocelot-hsio");
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1304 if (IS_ERR(hsio)) {
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1305 dev_err(&pdev->dev, "missing hsio syscon\n");
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1306 err = PTR_ERR(hsio);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1307 goto out_free_devlink;
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1308 }
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1309
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1310 ocelot->targets[HSIO] = hsio;
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1311
dc3de2a294eab8 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1312 err = ocelot_chip_init(ocelot, &ocelot_ops);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1313 if (err)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1314 goto out_free_devlink;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1315
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1316 irq_xtr = platform_get_irq_byname(pdev, "xtr");
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1317 if (irq_xtr < 0)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 @1318 goto out_free_devlink;
Yep. Missing an error code.
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1319
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1320 err = devm_request_threaded_irq(&pdev->dev, irq_xtr, NULL,
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1321 ocelot_xtr_irq_handler, IRQF_ONESHOT,
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1322 "frame extraction", ocelot);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1323 if (err)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1324 goto out_free_devlink;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1325
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1326 irq_ptp_rdy = platform_get_irq_byname(pdev, "ptp_rdy");
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1327 if (irq_ptp_rdy > 0 && ocelot->targets[PTP]) {
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1328 err = devm_request_threaded_irq(&pdev->dev, irq_ptp_rdy, NULL,
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1329 ocelot_ptp_rdy_irq_handler,
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1330 IRQF_ONESHOT, "ptp ready",
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1331 ocelot);
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1332 if (err)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1333 goto out_free_devlink;
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1334
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1335 /* Both the PTP interrupt and the PTP bank are available */
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1336 ocelot->ptp = 1;
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1337 }
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1338
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1339 ports = of_get_child_by_name(np, "ethernet-ports");
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1340 if (!ports) {
7c411799e1b3e0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1341 dev_err(ocelot->dev, "no ethernet-ports child node found\n");
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1342 err = -ENODEV;
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1343 goto out_free_devlink;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1344 }
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1345
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1346 ocelot->num_phys_ports = of_get_child_count(ports);
edd2410b165e2e drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-12-04 1347 ocelot->num_flooding_pgids = 1;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1348
8551cdeb2ad171 drivers/net/ethernet/mscc/ocelot_board.c Vladimir Oltean 2020-02-29 1349 ocelot->vcap = vsc7514_vcap_props;
2d44b097bbb9d0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-26 1350 ocelot->inj_prefix = OCELOT_TAG_PREFIX_NONE;
2d44b097bbb9d0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-26 1351 ocelot->xtr_prefix = OCELOT_TAG_PREFIX_NONE;
2d44b097bbb9d0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-26 1352 ocelot->npi = -1;
e0632940bc4c98 drivers/net/ethernet/mscc/ocelot_board.c Vladimir Oltean 2020-02-29 1353
d1cc0e932039cc drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1354 err = ocelot_init(ocelot);
d1cc0e932039cc drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1355 if (err)
d1cc0e932039cc drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1356 goto out_put_ports;
d1cc0e932039cc drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1357
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1358 err = devlink_register(devlink, ocelot->dev);
7c411799e1b3e0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1359 if (err)
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1360 goto out_ocelot_deinit;
7c411799e1b3e0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1361
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1362 err = mscc_ocelot_init_ports(pdev, ports);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1363 if (err)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1364 goto out_ocelot_devlink_unregister;
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1365
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1366 if (ocelot->ptp) {
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1367 err = ocelot_init_timestamp(ocelot, &ocelot_ptp_clock_info);
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1368 if (err) {
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1369 dev_err(ocelot->dev,
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1370 "Timestamp initialization failed\n");
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1371 ocelot->ptp = 0;
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1372 }
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1373 }
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1374
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1375 register_netdevice_notifier(&ocelot_netdevice_nb);
56da64bc003bb9 drivers/net/ethernet/mscc/ocelot_board.c Florian Fainelli 2019-02-27 1376 register_switchdev_notifier(&ocelot_switchdev_nb);
0e332c854f4118 drivers/net/ethernet/mscc/ocelot_board.c Petr Machata 2018-11-22 1377 register_switchdev_blocking_notifier(&ocelot_switchdev_blocking_nb);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1378
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1379 of_node_put(ports);
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1380
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1381 dev_info(&pdev->dev, "Ocelot switch probed\n");
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1382
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1383 return 0;
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1384
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1385 out_ocelot_devlink_unregister:
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1386 devlink_unregister(devlink);
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1387 out_ocelot_deinit:
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1388 ocelot_deinit(ocelot);
d2c50b1cd94528 drivers/net/ethernet/mscc/ocelot_board.c Wen Yang 2019-09-29 1389 out_put_ports:
d2c50b1cd94528 drivers/net/ethernet/mscc/ocelot_board.c Wen Yang 2019-09-29 1390 of_node_put(ports);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1391 out_free_devlink:
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1392 devlink_free(devlink);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1393 return err;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1394 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34499 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [kbuild] [linux-next:master 3854/6048] drivers/net/ethernet/mscc/ocelot_vsc7514.c:1318 mscc_ocelot_probe() warn: missing error code 'err'
@ 2021-02-08 11:17 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-02-08 11:17 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 18903 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 59fa6a163ffabc1bf25c5e0e33899e268a96d3cc
commit: 6c30384eb1dec96b678ff9c01c15134b1a0e81f4 [3854/6048] net: mscc: ocelot: register devlink ports
config: x86_64-randconfig-m001-20210206 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/ethernet/mscc/ocelot_vsc7514.c:1318 mscc_ocelot_probe() warn: missing error code 'err'
vim +/err +1318 drivers/net/ethernet/mscc/ocelot_vsc7514.c
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1245 static int mscc_ocelot_probe(struct platform_device *pdev)
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1246 {
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1247 struct device_node *np = pdev->dev.of_node;
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1248 int err, irq_xtr, irq_ptp_rdy;
7c411799e1b3e0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1249 struct device_node *ports;
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1250 struct devlink *devlink;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1251 struct ocelot *ocelot;
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1252 struct regmap *hsio;
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1253 unsigned int i;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1254
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1255 struct {
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1256 enum ocelot_target id;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1257 char *name;
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1258 u8 optional:1;
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1259 } io_target[] = {
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1260 { SYS, "sys" },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1261 { REW, "rew" },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1262 { QSYS, "qsys" },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1263 { ANA, "ana" },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1264 { QS, "qs" },
e3aea296d86f0f drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-30 1265 { S0, "s0" },
a61e365d7c183c drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-30 1266 { S1, "s1" },
b596229448dd2a drivers/net/ethernet/mscc/ocelot_board.c Horatiu Vultur 2019-05-31 1267 { S2, "s2" },
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1268 { PTP, "ptp", 1 },
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1269 };
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1270
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1271 if (!np && !pdev->dev.platform_data)
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1272 return -ENODEV;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1273
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1274 devlink = devlink_alloc(&ocelot_devlink_ops, sizeof(*ocelot));
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1275 if (!devlink)
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1276 return -ENOMEM;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1277
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1278 ocelot = devlink_priv(devlink);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1279 ocelot->devlink = priv_to_devlink(ocelot);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1280 platform_set_drvdata(pdev, ocelot);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1281 ocelot->dev = &pdev->dev;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1282
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1283 for (i = 0; i < ARRAY_SIZE(io_target); i++) {
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1284 struct regmap *target;
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1285 struct resource *res;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1286
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1287 res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1288 io_target[i].name);
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1289
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1290 target = ocelot_regmap_init(ocelot, res);
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1291 if (IS_ERR(target)) {
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1292 if (io_target[i].optional) {
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1293 ocelot->targets[io_target[i].id] = NULL;
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1294 continue;
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1295 }
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1296 err = PTR_ERR(target);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1297 goto out_free_devlink;
45bce1719cbd1a drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1298 }
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1299
259630e08c2135 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1300 ocelot->targets[io_target[i].id] = target;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1301 }
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1302
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1303 hsio = syscon_regmap_lookup_by_compatible("mscc,ocelot-hsio");
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1304 if (IS_ERR(hsio)) {
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1305 dev_err(&pdev->dev, "missing hsio syscon\n");
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1306 err = PTR_ERR(hsio);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1307 goto out_free_devlink;
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1308 }
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1309
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1310 ocelot->targets[HSIO] = hsio;
19aedfbe658326 drivers/net/ethernet/mscc/ocelot_board.c Quentin Schulz 2018-10-04 1311
dc3de2a294eab8 drivers/net/ethernet/mscc/ocelot_board.c Claudiu Manoil 2019-11-14 1312 err = ocelot_chip_init(ocelot, &ocelot_ops);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1313 if (err)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1314 goto out_free_devlink;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1315
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1316 irq_xtr = platform_get_irq_byname(pdev, "xtr");
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1317 if (irq_xtr < 0)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 @1318 goto out_free_devlink;
Yep. Missing an error code.
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1319
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1320 err = devm_request_threaded_irq(&pdev->dev, irq_xtr, NULL,
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1321 ocelot_xtr_irq_handler, IRQF_ONESHOT,
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1322 "frame extraction", ocelot);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1323 if (err)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1324 goto out_free_devlink;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1325
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1326 irq_ptp_rdy = platform_get_irq_byname(pdev, "ptp_rdy");
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1327 if (irq_ptp_rdy > 0 && ocelot->targets[PTP]) {
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1328 err = devm_request_threaded_irq(&pdev->dev, irq_ptp_rdy, NULL,
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1329 ocelot_ptp_rdy_irq_handler,
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1330 IRQF_ONESHOT, "ptp ready",
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1331 ocelot);
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1332 if (err)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1333 goto out_free_devlink;
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1334
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1335 /* Both the PTP interrupt and the PTP bank are available */
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1336 ocelot->ptp = 1;
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1337 }
4e3b0468e6d7f3 drivers/net/ethernet/mscc/ocelot_board.c Antoine Tenart 2019-08-12 1338
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1339 ports = of_get_child_by_name(np, "ethernet-ports");
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1340 if (!ports) {
7c411799e1b3e0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1341 dev_err(ocelot->dev, "no ethernet-ports child node found\n");
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1342 err = -ENODEV;
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1343 goto out_free_devlink;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1344 }
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1345
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1346 ocelot->num_phys_ports = of_get_child_count(ports);
edd2410b165e2e drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-12-04 1347 ocelot->num_flooding_pgids = 1;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1348
8551cdeb2ad171 drivers/net/ethernet/mscc/ocelot_board.c Vladimir Oltean 2020-02-29 1349 ocelot->vcap = vsc7514_vcap_props;
2d44b097bbb9d0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-26 1350 ocelot->inj_prefix = OCELOT_TAG_PREFIX_NONE;
2d44b097bbb9d0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-26 1351 ocelot->xtr_prefix = OCELOT_TAG_PREFIX_NONE;
2d44b097bbb9d0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-26 1352 ocelot->npi = -1;
e0632940bc4c98 drivers/net/ethernet/mscc/ocelot_board.c Vladimir Oltean 2020-02-29 1353
d1cc0e932039cc drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1354 err = ocelot_init(ocelot);
d1cc0e932039cc drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1355 if (err)
d1cc0e932039cc drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1356 goto out_put_ports;
d1cc0e932039cc drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1357
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1358 err = devlink_register(devlink, ocelot->dev);
7c411799e1b3e0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1359 if (err)
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1360 goto out_ocelot_deinit;
7c411799e1b3e0 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2020-09-18 1361
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1362 err = mscc_ocelot_init_ports(pdev, ports);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1363 if (err)
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1364 goto out_ocelot_devlink_unregister;
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1365
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1366 if (ocelot->ptp) {
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1367 err = ocelot_init_timestamp(ocelot, &ocelot_ptp_clock_info);
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1368 if (err) {
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1369 dev_err(ocelot->dev,
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1370 "Timestamp initialization failed\n");
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1371 ocelot->ptp = 0;
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1372 }
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1373 }
2b49d128b3f8d8 drivers/net/ethernet/mscc/ocelot_board.c Yangbo Lu 2020-04-20 1374
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1375 register_netdevice_notifier(&ocelot_netdevice_nb);
56da64bc003bb9 drivers/net/ethernet/mscc/ocelot_board.c Florian Fainelli 2019-02-27 1376 register_switchdev_notifier(&ocelot_switchdev_nb);
0e332c854f4118 drivers/net/ethernet/mscc/ocelot_board.c Petr Machata 2018-11-22 1377 register_switchdev_blocking_notifier(&ocelot_switchdev_blocking_nb);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1378
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1379 of_node_put(ports);
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1380
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1381 dev_info(&pdev->dev, "Ocelot switch probed\n");
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1382
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1383 return 0;
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1384
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1385 out_ocelot_devlink_unregister:
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1386 devlink_unregister(devlink);
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1387 out_ocelot_deinit:
f87675b836b324 drivers/net/ethernet/mscc/ocelot_vsc7514.c Christophe JAILLET 2020-12-13 1388 ocelot_deinit(ocelot);
d2c50b1cd94528 drivers/net/ethernet/mscc/ocelot_board.c Wen Yang 2019-09-29 1389 out_put_ports:
d2c50b1cd94528 drivers/net/ethernet/mscc/ocelot_board.c Wen Yang 2019-09-29 1390 of_node_put(ports);
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1391 out_free_devlink:
6c30384eb1dec9 drivers/net/ethernet/mscc/ocelot_vsc7514.c Vladimir Oltean 2021-01-15 1392 devlink_free(devlink);
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1393 return err;
a556c76adc052c drivers/net/ethernet/mscc/ocelot_board.c Alexandre Belloni 2018-05-14 1394 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34499 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-08 11:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08 11:17 [kbuild] [linux-next:master 3854/6048] drivers/net/ethernet/mscc/ocelot_vsc7514.c:1318 mscc_ocelot_probe() warn: missing error code 'err' Dan Carpenter
2021-02-08 11:17 ` Dan Carpenter
2021-02-08 11:17 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.