All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	f.fainelli@gmail.com, andrew@lunn.ch, davem@davemloft.net,
	chris.packham@alliedtelesis.co.nz, gregkh@linuxfoundation.org
Subject: Re: [PATCH] staging: octeon: remove braces from single-line block
Date: Mon, 8 Feb 2021 11:49:14 +0000	[thread overview]
Message-ID: <20210208114914.GA115411@kernelvm> (raw)
In-Reply-To: <51bab7d2-2f37-b4de-71b5-47cfe8857f02@nokia.com>

On Mon, Feb 08, 2021 at 08:14:02AM +0100, Alexander Sverdlin wrote:
> Hi!
> 
> On 06/02/2021 21:17, Phillip Potter wrote:
> > This removes the braces from the if statement that checks the
> > physical node return value in cvm_oct_phy_setup_device, as this
> > block contains only one statement. Fixes a style warning.
> > 
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> 
> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> 

Thank you Alexander.

> > ---
> >  drivers/staging/octeon/ethernet-mdio.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c
> > index 0bf545849b11..b0fd083a5bf2 100644
> > --- a/drivers/staging/octeon/ethernet-mdio.c
> > +++ b/drivers/staging/octeon/ethernet-mdio.c
> > @@ -146,9 +146,8 @@ int cvm_oct_phy_setup_device(struct net_device *dev)
> >  		goto no_phy;
> >  
> >  	phy_node = of_parse_phandle(priv->of_node, "phy-handle", 0);
> > -	if (!phy_node && of_phy_is_fixed_link(priv->of_node)) {
> > +	if (!phy_node && of_phy_is_fixed_link(priv->of_node))
> >  		phy_node = of_node_get(priv->of_node);
> > -	}
> >  	if (!phy_node)
> >  		goto no_phy;
> >  
> 
> -- 
> Best regards,
> Alexander Sverdlin.

Regards,
Phil Potter

WARNING: multiple messages have this Message-ID (diff)
From: Phillip Potter <phil@philpotter.co.uk>
To: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: devel@driverdev.osuosl.org, andrew@lunn.ch, f.fainelli@gmail.com,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	chris.packham@alliedtelesis.co.nz, davem@davemloft.net
Subject: Re: [PATCH] staging: octeon: remove braces from single-line block
Date: Mon, 8 Feb 2021 11:49:14 +0000	[thread overview]
Message-ID: <20210208114914.GA115411@kernelvm> (raw)
In-Reply-To: <51bab7d2-2f37-b4de-71b5-47cfe8857f02@nokia.com>

On Mon, Feb 08, 2021 at 08:14:02AM +0100, Alexander Sverdlin wrote:
> Hi!
> 
> On 06/02/2021 21:17, Phillip Potter wrote:
> > This removes the braces from the if statement that checks the
> > physical node return value in cvm_oct_phy_setup_device, as this
> > block contains only one statement. Fixes a style warning.
> > 
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> 
> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> 

Thank you Alexander.

> > ---
> >  drivers/staging/octeon/ethernet-mdio.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c
> > index 0bf545849b11..b0fd083a5bf2 100644
> > --- a/drivers/staging/octeon/ethernet-mdio.c
> > +++ b/drivers/staging/octeon/ethernet-mdio.c
> > @@ -146,9 +146,8 @@ int cvm_oct_phy_setup_device(struct net_device *dev)
> >  		goto no_phy;
> >  
> >  	phy_node = of_parse_phandle(priv->of_node, "phy-handle", 0);
> > -	if (!phy_node && of_phy_is_fixed_link(priv->of_node)) {
> > +	if (!phy_node && of_phy_is_fixed_link(priv->of_node))
> >  		phy_node = of_node_get(priv->of_node);
> > -	}
> >  	if (!phy_node)
> >  		goto no_phy;
> >  
> 
> -- 
> Best regards,
> Alexander Sverdlin.

Regards,
Phil Potter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2021-02-08 12:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-06 20:17 [PATCH] staging: octeon: remove braces from single-line block Phillip Potter
2021-02-06 20:17 ` Phillip Potter
2021-02-08  7:14 ` Alexander Sverdlin
2021-02-08  7:14   ` Alexander Sverdlin
2021-02-08 11:49   ` Phillip Potter [this message]
2021-02-08 11:49     ` Phillip Potter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210208114914.GA115411@kernelvm \
    --to=phil@philpotter.co.uk \
    --cc=alexander.sverdlin@nokia.com \
    --cc=andrew@lunn.ch \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.