* [meta-oe][PATCH] libhugetlbfs: improve reproducibility
@ 2021-02-08 15:44 Oleksiy Obitotskyy
2021-02-08 16:40 ` [OE-core] " Khem Raj
0 siblings, 1 reply; 3+ messages in thread
From: Oleksiy Obitotskyy @ 2021-02-08 15:44 UTC (permalink / raw)
To: openembedded-core; +Cc: Oleksiy Obitotskyy
CPPFLAGS was overrided for tests, so we
missing DEBUG_PREFIX_MAP and got absolute
path in binary.
Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
---
...Append-CPPFLAGS-rather-then-override.patch | 31 +++++++++++++++++++
.../libhugetlbfs/libhugetlbfs_git.bb | 1 +
2 files changed, 32 insertions(+)
create mode 100644 meta-oe/recipes-benchmark/libhugetlbfs/files/0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch
diff --git a/meta-oe/recipes-benchmark/libhugetlbfs/files/0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch b/meta-oe/recipes-benchmark/libhugetlbfs/files/0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch
new file mode 100644
index 000000000..78a4cb0fc
--- /dev/null
+++ b/meta-oe/recipes-benchmark/libhugetlbfs/files/0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch
@@ -0,0 +1,31 @@
+From b6dba773491bbb7b4664dacdd87a12af860f1bd8 Mon Sep 17 00:00:00 2001
+From: Oleksiy Obitotskyy <oobitots@cisco.com>
+Date: Thu, 28 Jan 2021 05:43:33 -0800
+Subject: [PATCH] tests/makefile: Append CPPFLAGS rather then override
+
+CPPFLAGS overrided and we could miss some options needed.
+
+Upstream-Status: Submitted
+Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
+---
+ tests/Makefile | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/tests/Makefile b/tests/Makefile
+index 0ca3716..d262932 100644
+--- a/tests/Makefile
++++ b/tests/Makefile
+@@ -33,8 +33,8 @@ HELPERS = get_hugetlbfs_path compare_kvers
+ HELPER_LIBS = libheapshrink.so
+ BADTOOLCHAIN = bad-toolchain.sh
+
+-CFLAGS = -O2 -Wall -g
+-CPPFLAGS = -I..
++CFLAGS += -O2 -Wall -g
++CPPFLAGS += -I..
+ STATIC_LIBHUGE = -Wl,--whole-archive -lhugetlbfs -Wl,--no-whole-archive
+ STATIC_LDLIBS = -Wl,--no-as-needed -lpthread
+ LDLIBS = $(STATIC_LDLIBS) -ldl -lhugetlbfs_privutils
+--
+2.26.2.Cisco
+
diff --git a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
index 2f07c938b..fa63316b0 100644
--- a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
+++ b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
@@ -26,6 +26,7 @@ SRC_URI = " \
file://0006-include-limits.h-for-PATH_MAX.patch \
file://0001-huge_page_setup_helper-use-python3-interpreter.patch \
file://0001-Revert-ld.hugetlbfs-fix-Ttext-segment-argument-on-AA.patch \
+ file://0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch \
"
UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+(\.\d+)+)"
--
2.26.2.Cisco
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [OE-core] [meta-oe][PATCH] libhugetlbfs: improve reproducibility
2021-02-08 15:44 [meta-oe][PATCH] libhugetlbfs: improve reproducibility Oleksiy Obitotskyy
@ 2021-02-08 16:40 ` Khem Raj
0 siblings, 0 replies; 3+ messages in thread
From: Khem Raj @ 2021-02-08 16:40 UTC (permalink / raw)
To: oobitots, openembedded-core
Hi Oleksiy
oe-core ml is only for oe-core repo patches. For meta-openembedded
layers patches they should be sent to oe-devel mailing list.
On 2/8/21 7:44 AM, Oleksiy Obitotskyy via lists.openembedded.org wrote:
> CPPFLAGS was overrided for tests, so we
> missing DEBUG_PREFIX_MAP and got absolute
> path in binary.
>
> Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
> ---
> ...Append-CPPFLAGS-rather-then-override.patch | 31 +++++++++++++++++++
> .../libhugetlbfs/libhugetlbfs_git.bb | 1 +
> 2 files changed, 32 insertions(+)
> create mode 100644 meta-oe/recipes-benchmark/libhugetlbfs/files/0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch
>
> diff --git a/meta-oe/recipes-benchmark/libhugetlbfs/files/0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch b/meta-oe/recipes-benchmark/libhugetlbfs/files/0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch
> new file mode 100644
> index 000000000..78a4cb0fc
> --- /dev/null
> +++ b/meta-oe/recipes-benchmark/libhugetlbfs/files/0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch
> @@ -0,0 +1,31 @@
> +From b6dba773491bbb7b4664dacdd87a12af860f1bd8 Mon Sep 17 00:00:00 2001
> +From: Oleksiy Obitotskyy <oobitots@cisco.com>
> +Date: Thu, 28 Jan 2021 05:43:33 -0800
> +Subject: [PATCH] tests/makefile: Append CPPFLAGS rather then override
> +
> +CPPFLAGS overrided and we could miss some options needed.
> +
> +Upstream-Status: Submitted
> +Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
> +---
> + tests/Makefile | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/tests/Makefile b/tests/Makefile
> +index 0ca3716..d262932 100644
> +--- a/tests/Makefile
> ++++ b/tests/Makefile
> +@@ -33,8 +33,8 @@ HELPERS = get_hugetlbfs_path compare_kvers
> + HELPER_LIBS = libheapshrink.so
> + BADTOOLCHAIN = bad-toolchain.sh
> +
> +-CFLAGS = -O2 -Wall -g
> +-CPPFLAGS = -I..
> ++CFLAGS += -O2 -Wall -g
> ++CPPFLAGS += -I..
> + STATIC_LIBHUGE = -Wl,--whole-archive -lhugetlbfs -Wl,--no-whole-archive
> + STATIC_LDLIBS = -Wl,--no-as-needed -lpthread
> + LDLIBS = $(STATIC_LDLIBS) -ldl -lhugetlbfs_privutils
> +--
> +2.26.2.Cisco
> +
> diff --git a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> index 2f07c938b..fa63316b0 100644
> --- a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> +++ b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
> @@ -26,6 +26,7 @@ SRC_URI = " \
> file://0006-include-limits.h-for-PATH_MAX.patch \
> file://0001-huge_page_setup_helper-use-python3-interpreter.patch \
> file://0001-Revert-ld.hugetlbfs-fix-Ttext-segment-argument-on-AA.patch \
> + file://0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch \
> "
>
> UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+(\.\d+)+)"
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [meta-oe][PATCH] libhugetlbfs: improve reproducibility
@ 2021-02-08 17:08 Oleksiy Obitotskyy
0 siblings, 0 replies; 3+ messages in thread
From: Oleksiy Obitotskyy @ 2021-02-08 17:08 UTC (permalink / raw)
To: openembedded-devel; +Cc: Oleksiy Obitotskyy
CPPFLAGS was overrided for tests, so we
missing DEBUG_PREFIX_MAP and got absolute
path in binary.
Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
---
...Append-CPPFLAGS-rather-then-override.patch | 31 +++++++++++++++++++
.../libhugetlbfs/libhugetlbfs_git.bb | 1 +
2 files changed, 32 insertions(+)
create mode 100644 meta-oe/recipes-benchmark/libhugetlbfs/files/0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch
diff --git a/meta-oe/recipes-benchmark/libhugetlbfs/files/0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch b/meta-oe/recipes-benchmark/libhugetlbfs/files/0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch
new file mode 100644
index 000000000..78a4cb0fc
--- /dev/null
+++ b/meta-oe/recipes-benchmark/libhugetlbfs/files/0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch
@@ -0,0 +1,31 @@
+From b6dba773491bbb7b4664dacdd87a12af860f1bd8 Mon Sep 17 00:00:00 2001
+From: Oleksiy Obitotskyy <oobitots@cisco.com>
+Date: Thu, 28 Jan 2021 05:43:33 -0800
+Subject: [PATCH] tests/makefile: Append CPPFLAGS rather then override
+
+CPPFLAGS overrided and we could miss some options needed.
+
+Upstream-Status: Submitted
+Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
+---
+ tests/Makefile | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/tests/Makefile b/tests/Makefile
+index 0ca3716..d262932 100644
+--- a/tests/Makefile
++++ b/tests/Makefile
+@@ -33,8 +33,8 @@ HELPERS = get_hugetlbfs_path compare_kvers
+ HELPER_LIBS = libheapshrink.so
+ BADTOOLCHAIN = bad-toolchain.sh
+
+-CFLAGS = -O2 -Wall -g
+-CPPFLAGS = -I..
++CFLAGS += -O2 -Wall -g
++CPPFLAGS += -I..
+ STATIC_LIBHUGE = -Wl,--whole-archive -lhugetlbfs -Wl,--no-whole-archive
+ STATIC_LDLIBS = -Wl,--no-as-needed -lpthread
+ LDLIBS = $(STATIC_LDLIBS) -ldl -lhugetlbfs_privutils
+--
+2.26.2.Cisco
+
diff --git a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
index 2f07c938b..fa63316b0 100644
--- a/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
+++ b/meta-oe/recipes-benchmark/libhugetlbfs/libhugetlbfs_git.bb
@@ -26,6 +26,7 @@ SRC_URI = " \
file://0006-include-limits.h-for-PATH_MAX.patch \
file://0001-huge_page_setup_helper-use-python3-interpreter.patch \
file://0001-Revert-ld.hugetlbfs-fix-Ttext-segment-argument-on-AA.patch \
+ file://0001-tests-makefile-Append-CPPFLAGS-rather-then-override.patch \
"
UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+(\.\d+)+)"
--
2.26.2.Cisco
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-08 17:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08 15:44 [meta-oe][PATCH] libhugetlbfs: improve reproducibility Oleksiy Obitotskyy
2021-02-08 16:40 ` [OE-core] " Khem Raj
2021-02-08 17:08 Oleksiy Obitotskyy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.