From: Eli Cohen <elic@nvidia.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: <virtualization@lists.linux-foundation.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Parav Pandit <parav@nvidia.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()
Date: Tue, 9 Feb 2021 07:43:02 +0200 [thread overview]
Message-ID: <20210209054302.GA210455@mtl-vdi-166.wap.labs.mlnx> (raw)
In-Reply-To: <20210208161741.104939-1-sgarzare@redhat.com>
On Mon, Feb 08, 2021 at 05:17:41PM +0100, Stefano Garzarella wrote:
> It's legal to have 'offset + len' equal to
> sizeof(struct virtio_net_config), since 'ndev->config' is a
> 'struct virtio_net_config', so we can safely copy its content under
> this condition.
>
> Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
> Cc: stable@vger.kernel.org
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Eli Cohen <elic@nvidia.com>
BTW, same error in vdpa_sim you may want to fix.
> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index dc88559a8d49..10e9b09932eb 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -1820,7 +1820,7 @@ static void mlx5_vdpa_get_config(struct vdpa_device *vdev, unsigned int offset,
> struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev);
> struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);
>
> - if (offset + len < sizeof(struct virtio_net_config))
> + if (offset + len <= sizeof(struct virtio_net_config))
> memcpy(buf, (u8 *)&ndev->config + offset, len);
> }
>
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-02-09 5:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 16:17 [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config() Stefano Garzarella
2021-02-08 16:17 ` Stefano Garzarella
2021-02-08 18:38 ` Michael S. Tsirkin
2021-02-08 18:38 ` Michael S. Tsirkin
2021-02-09 3:24 ` Jason Wang
2021-02-09 3:24 ` Jason Wang
2021-02-09 8:58 ` Stefano Garzarella
2021-02-09 8:58 ` Stefano Garzarella
2021-02-09 9:31 ` Michael S. Tsirkin
2021-02-09 9:31 ` Michael S. Tsirkin
2021-02-10 10:08 ` Stefano Garzarella
2021-02-10 10:08 ` Stefano Garzarella
2021-02-18 5:47 ` Jason Wang
2021-02-18 5:47 ` Jason Wang
2021-02-09 3:21 ` Jason Wang
2021-02-09 3:21 ` Jason Wang
2021-02-09 5:43 ` Eli Cohen [this message]
2021-02-09 9:00 ` Stefano Garzarella
2021-02-09 9:00 ` Stefano Garzarella
2021-02-10 4:17 ` Jason Wang
2021-02-10 4:17 ` Jason Wang
2021-02-10 12:12 ` Michael S. Tsirkin
2021-02-10 12:12 ` Michael S. Tsirkin
2021-02-11 15:39 ` Stefano Garzarella
2021-02-11 15:39 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209054302.GA210455@mtl-vdi-166.wap.labs.mlnx \
--to=elic@nvidia.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.