All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>, Eli Cohen <elic@nvidia.com>
Cc: virtualization@lists.linux-foundation.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Parav Pandit <parav@nvidia.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()
Date: Wed, 10 Feb 2021 12:17:19 +0800	[thread overview]
Message-ID: <cdd75885-3610-8685-14f3-5467a8ef1501@redhat.com> (raw)
In-Reply-To: <20210209090014.xolf5kxri3xdmacz@steredhat>


On 2021/2/9 下午5:00, Stefano Garzarella wrote:
> On Tue, Feb 09, 2021 at 07:43:02AM +0200, Eli Cohen wrote:
>> On Mon, Feb 08, 2021 at 05:17:41PM +0100, Stefano Garzarella wrote:
>>> It's legal to have 'offset + len' equal to
>>> sizeof(struct virtio_net_config), since 'ndev->config' is a
>>> 'struct virtio_net_config', so we can safely copy its content under
>>> this condition.
>>>
>>> Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 
>>> devices")
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
>>
>> Acked-by: Eli Cohen <elic@nvidia.com>
>>
>> BTW, same error in vdpa_sim you may want to fix.
>>
>
> Commit 65b709586e22 ("vdpa_sim: add get_config callback in 
> vdpasim_dev_attr") unintentionally solved it.
>
> Since it's a simulator, maybe we can avoid solving it in the stable 
> branches. Or does it matter?


I think not, since the module depends on RUNTIME_TESTING_MENU.

Thanks




>
> Thanks,
> Stefano 


WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>, Eli Cohen <elic@nvidia.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()
Date: Wed, 10 Feb 2021 12:17:19 +0800	[thread overview]
Message-ID: <cdd75885-3610-8685-14f3-5467a8ef1501@redhat.com> (raw)
In-Reply-To: <20210209090014.xolf5kxri3xdmacz@steredhat>


On 2021/2/9 下午5:00, Stefano Garzarella wrote:
> On Tue, Feb 09, 2021 at 07:43:02AM +0200, Eli Cohen wrote:
>> On Mon, Feb 08, 2021 at 05:17:41PM +0100, Stefano Garzarella wrote:
>>> It's legal to have 'offset + len' equal to
>>> sizeof(struct virtio_net_config), since 'ndev->config' is a
>>> 'struct virtio_net_config', so we can safely copy its content under
>>> this condition.
>>>
>>> Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 
>>> devices")
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
>>
>> Acked-by: Eli Cohen <elic@nvidia.com>
>>
>> BTW, same error in vdpa_sim you may want to fix.
>>
>
> Commit 65b709586e22 ("vdpa_sim: add get_config callback in 
> vdpasim_dev_attr") unintentionally solved it.
>
> Since it's a simulator, maybe we can avoid solving it in the stable 
> branches. Or does it matter?


I think not, since the module depends on RUNTIME_TESTING_MENU.

Thanks




>
> Thanks,
> Stefano 

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2021-02-10  4:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08 16:17 [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config() Stefano Garzarella
2021-02-08 16:17 ` Stefano Garzarella
2021-02-08 18:38 ` Michael S. Tsirkin
2021-02-08 18:38   ` Michael S. Tsirkin
2021-02-09  3:24   ` Jason Wang
2021-02-09  3:24     ` Jason Wang
2021-02-09  8:58     ` Stefano Garzarella
2021-02-09  8:58       ` Stefano Garzarella
2021-02-09  9:31     ` Michael S. Tsirkin
2021-02-09  9:31       ` Michael S. Tsirkin
2021-02-10 10:08       ` Stefano Garzarella
2021-02-10 10:08         ` Stefano Garzarella
2021-02-18  5:47         ` Jason Wang
2021-02-18  5:47           ` Jason Wang
2021-02-09  3:21 ` Jason Wang
2021-02-09  3:21   ` Jason Wang
2021-02-09  5:43 ` Eli Cohen
2021-02-09  9:00   ` Stefano Garzarella
2021-02-09  9:00     ` Stefano Garzarella
2021-02-10  4:17     ` Jason Wang [this message]
2021-02-10  4:17       ` Jason Wang
2021-02-10 12:12       ` Michael S. Tsirkin
2021-02-10 12:12         ` Michael S. Tsirkin
2021-02-11 15:39         ` Stefano Garzarella
2021-02-11 15:39           ` Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdd75885-3610-8685-14f3-5467a8ef1501@redhat.com \
    --to=jasowang@redhat.com \
    --cc=elic@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.