* [PATCH] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings
@ 2021-02-08 14:21 Fabio Estevam
2021-02-09 9:21 ` Oleksij Rempel
2021-03-07 1:31 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2021-02-08 14:21 UTC (permalink / raw)
To: shawnguo; +Cc: o.rempel, Fabio Estevam, linux-arm-kernel, david
Remove the unnecessary #address-cells/#size-cells and rename the node
names to fix the following W=1 dtc warnings:
arch/arm/boot/dts/imx6dl-plybas.dts:26.13-30.5: Warning (unit_address_vs_reg): /gpio_keys/button@20: node has a unit name, but no reg or ranges property
arch/arm/boot/dts/imx6dl-plybas.dts:32.13-36.5: Warning (unit_address_vs_reg): /gpio_keys/button@21: node has a unit name, but no reg or ranges property
arch/arm/boot/dts/imx6dl-plybas.dts:20.12-37.4: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6dl-plybas.dts | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/imx6dl-plybas.dts b/arch/arm/boot/dts/imx6dl-plybas.dts
index 333c306aa946..e6e9721ceea2 100644
--- a/arch/arm/boot/dts/imx6dl-plybas.dts
+++ b/arch/arm/boot/dts/imx6dl-plybas.dts
@@ -19,17 +19,15 @@ chosen {
gpio_keys {
compatible = "gpio-keys";
- #address-cells = <1>;
- #size-cells = <0>;
autorepeat;
- button@20 {
+ start-button {
label = "START";
linux,code = <31>;
gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;
};
- button@21 {
+ clean-button {
label = "CLEAN";
linux,code = <46>;
gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings
2021-02-08 14:21 [PATCH] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings Fabio Estevam
@ 2021-02-09 9:21 ` Oleksij Rempel
2021-03-05 11:07 ` Fabio Estevam
2021-03-07 1:31 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Oleksij Rempel @ 2021-02-09 9:21 UTC (permalink / raw)
To: Fabio Estevam; +Cc: shawnguo, linux-arm-kernel, david
On Mon, Feb 08, 2021 at 11:21:23AM -0300, Fabio Estevam wrote:
> Remove the unnecessary #address-cells/#size-cells and rename the node
> names to fix the following W=1 dtc warnings:
>
> arch/arm/boot/dts/imx6dl-plybas.dts:26.13-30.5: Warning (unit_address_vs_reg): /gpio_keys/button@20: node has a unit name, but no reg or ranges property
> arch/arm/boot/dts/imx6dl-plybas.dts:32.13-36.5: Warning (unit_address_vs_reg): /gpio_keys/button@21: node has a unit name, but no reg or ranges property
> arch/arm/boot/dts/imx6dl-plybas.dts:20.12-37.4: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
> ---
> arch/arm/boot/dts/imx6dl-plybas.dts | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-plybas.dts b/arch/arm/boot/dts/imx6dl-plybas.dts
> index 333c306aa946..e6e9721ceea2 100644
> --- a/arch/arm/boot/dts/imx6dl-plybas.dts
> +++ b/arch/arm/boot/dts/imx6dl-plybas.dts
> @@ -19,17 +19,15 @@ chosen {
>
> gpio_keys {
> compatible = "gpio-keys";
> - #address-cells = <1>;
> - #size-cells = <0>;
> autorepeat;
>
> - button@20 {
> + start-button {
> label = "START";
> linux,code = <31>;
> gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;
> };
>
> - button@21 {
> + clean-button {
> label = "CLEAN";
> linux,code = <46>;
> gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> --
> 2.25.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings
2021-02-09 9:21 ` Oleksij Rempel
@ 2021-03-05 11:07 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2021-03-05 11:07 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
David Jander
Hi Shawn,
On Tue, Feb 9, 2021 at 6:21 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
>
> On Mon, Feb 08, 2021 at 11:21:23AM -0300, Fabio Estevam wrote:
> > Remove the unnecessary #address-cells/#size-cells and rename the node
> > names to fix the following W=1 dtc warnings:
> >
> > arch/arm/boot/dts/imx6dl-plybas.dts:26.13-30.5: Warning (unit_address_vs_reg): /gpio_keys/button@20: node has a unit name, but no reg or ranges property
> > arch/arm/boot/dts/imx6dl-plybas.dts:32.13-36.5: Warning (unit_address_vs_reg): /gpio_keys/button@21: node has a unit name, but no reg or ranges property
> > arch/arm/boot/dts/imx6dl-plybas.dts:20.12-37.4: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> >
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
A gentle ping.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings
2021-02-08 14:21 [PATCH] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings Fabio Estevam
2021-02-09 9:21 ` Oleksij Rempel
@ 2021-03-07 1:31 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2021-03-07 1:31 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-arm-kernel, david, o.rempel
On Mon, Feb 08, 2021 at 11:21:23AM -0300, Fabio Estevam wrote:
> Remove the unnecessary #address-cells/#size-cells and rename the node
> names to fix the following W=1 dtc warnings:
>
> arch/arm/boot/dts/imx6dl-plybas.dts:26.13-30.5: Warning (unit_address_vs_reg): /gpio_keys/button@20: node has a unit name, but no reg or ranges property
> arch/arm/boot/dts/imx6dl-plybas.dts:32.13-36.5: Warning (unit_address_vs_reg): /gpio_keys/button@21: node has a unit name, but no reg or ranges property
> arch/arm/boot/dts/imx6dl-plybas.dts:20.12-37.4: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm/boot/dts/imx6dl-plybas.dts | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-plybas.dts b/arch/arm/boot/dts/imx6dl-plybas.dts
> index 333c306aa946..e6e9721ceea2 100644
> --- a/arch/arm/boot/dts/imx6dl-plybas.dts
> +++ b/arch/arm/boot/dts/imx6dl-plybas.dts
> @@ -19,17 +19,15 @@ chosen {
>
> gpio_keys {
> compatible = "gpio-keys";
> - #address-cells = <1>;
> - #size-cells = <0>;
> autorepeat;
>
> - button@20 {
> + start-button {
I prefer name style like button-xxx.
Shawn
> label = "START";
> linux,code = <31>;
> gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;
> };
>
> - button@21 {
> + clean-button {
> label = "CLEAN";
> linux,code = <46>;
> gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-07 1:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08 14:21 [PATCH] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings Fabio Estevam
2021-02-09 9:21 ` Oleksij Rempel
2021-03-05 11:07 ` Fabio Estevam
2021-03-07 1:31 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.