From: Serge Semin <Sergey.Semin@baikalelectronics.ru> To: Andrew Lunn <andrew@lunn.ch> Cc: Serge Semin <fancer.lancer@gmail.com>, Rob Herring <robh+dt@kernel.org>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@st.com>, Jose Abreu <joabreu@synopsys.com>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>, Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>, Vyacheslav Mitrofanov <Vyacheslav.Mitrofanov@baikalelectronics.ru>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, <netdev@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support Date: Tue, 9 Feb 2021 14:16:09 +0300 [thread overview] Message-ID: <20210209111609.tjxoqr6stkcf22jy@mobilestation> (raw) In-Reply-To: <YCGSwZnSXIz5Ssef@lunn.ch> On Mon, Feb 08, 2021 at 08:36:33PM +0100, Andrew Lunn wrote: > On Mon, Feb 08, 2021 at 05:08:04PM +0300, Serge Semin wrote: > > Hi Serge > > I suggest you split this patchset up. This uses the generic GPIO > framework, which is great. But that also means you should be Cc: the > GPIO subsystem maintainers and list. But you don't want to spam them > with all the preparation work, which has little to do with the GPIO > code. > > So please split the actual GPIO driver and DT binding patches from the > rest. netdev can review the preparation work, with a comment in the > 0/X patch about what the big picture is, and then afterwards review > the GPIO patchset with a wider audience. > > And as Jakub pointed out, nobody is going to review 60 patches all at > once. Please submit one series at a time, get it merged, and then > move onto the next. Hello Andrew Right, with all that preparation work I've forgotten to Cc the GPIO-subsystem maintainers. Thanks for noticing this. Regarding the 60-patches. Please see my response to Jakub' post in the first series. To cut it short let's start working with that patchset: Link: https://lore.kernel.org/netdev/20210208135609.7685-1-Sergey.Semin@baikalelectronics.ru/ I'll rebase and resubmit the rest of the work when the time comes. Regarding splitting the series up. I don't see a problem in just sending the cover-letter patch and actual GPIO-related patches to the GPIO-maintainers with no need to have them added to Cc in the rest of the series. That's a normal practice. Splitting is not really required. But since I have to split the very first patchset anyway. I'll split this one up too, when it comes to have this part of changes reviewed. -Sergey > > Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Serge Semin <Sergey.Semin@baikalelectronics.ru> To: Andrew Lunn <andrew@lunn.ch> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Torgue <alexandre.torgue@st.com>, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Vyacheslav Mitrofanov <Vyacheslav.Mitrofanov@baikalelectronics.ru>, Rob Herring <robh+dt@kernel.org>, Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>, Jose Abreu <joabreu@synopsys.com>, Serge Semin <fancer.lancer@gmail.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Jakub Kicinski <kuba@kernel.org>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, "David S. Miller" <davem@davemloft.net>, linux-arm-kernel@lists.infradead.org, Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru> Subject: Re: [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support Date: Tue, 9 Feb 2021 14:16:09 +0300 [thread overview] Message-ID: <20210209111609.tjxoqr6stkcf22jy@mobilestation> (raw) In-Reply-To: <YCGSwZnSXIz5Ssef@lunn.ch> On Mon, Feb 08, 2021 at 08:36:33PM +0100, Andrew Lunn wrote: > On Mon, Feb 08, 2021 at 05:08:04PM +0300, Serge Semin wrote: > > Hi Serge > > I suggest you split this patchset up. This uses the generic GPIO > framework, which is great. But that also means you should be Cc: the > GPIO subsystem maintainers and list. But you don't want to spam them > with all the preparation work, which has little to do with the GPIO > code. > > So please split the actual GPIO driver and DT binding patches from the > rest. netdev can review the preparation work, with a comment in the > 0/X patch about what the big picture is, and then afterwards review > the GPIO patchset with a wider audience. > > And as Jakub pointed out, nobody is going to review 60 patches all at > once. Please submit one series at a time, get it merged, and then > move onto the next. Hello Andrew Right, with all that preparation work I've forgotten to Cc the GPIO-subsystem maintainers. Thanks for noticing this. Regarding the 60-patches. Please see my response to Jakub' post in the first series. To cut it short let's start working with that patchset: Link: https://lore.kernel.org/netdev/20210208135609.7685-1-Sergey.Semin@baikalelectronics.ru/ I'll rebase and resubmit the rest of the work when the time comes. Regarding splitting the series up. I don't see a problem in just sending the cover-letter patch and actual GPIO-related patches to the GPIO-maintainers with no need to have them added to Cc in the rest of the series. That's a normal practice. Splitting is not really required. But since I have to split the very first patchset anyway. I'll split this one up too, when it comes to have this part of changes reviewed. -Sergey > > Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-09 11:19 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-08 14:08 [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 01/16] dt-bindings: net: dwmac: Add DW GMAC GPIOs properties Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-09 23:13 ` Rob Herring 2021-02-09 23:13 ` Rob Herring 2021-02-10 22:28 ` Serge Semin 2021-02-10 22:28 ` Serge Semin 2021-02-18 15:52 ` Serge Semin 2021-02-18 15:52 ` Serge Semin 2021-02-08 14:08 ` [PATCH 02/16] dt-bindings: net: Add Baikal-T1 GMAC bindings Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-09 23:24 ` Rob Herring 2021-02-09 23:24 ` Rob Herring 2021-02-08 14:08 ` [PATCH 03/16] net: stmmac: Introduce MAC core cleanup method Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 04/16] net: stmmac: Introduce DMA " Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 05/16] net: stmmac: Introduce MAC IRQs enable/disable methods Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 06/16] net: stmmac: Extend DMA IRQs enable/disable interface Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 07/16] net: stmmac: Introduce MTL IRQs enable/disable methods Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 08/16] net: stmmac: Introduce Safety Feature " Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 09/16] net: stmmac: Disable MMC IRQs in the generic IRQs disable method Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 10/16] net: stmmac: Convert STMMAC_DOWN flag to STMMAC_UP Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 11/16] net: stmmac: Add STMMAC state getter Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 12/16] net: stmmac: Introduce NIC software reset function Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 13/16] net: stmmac: Request IRQs at device probe stage Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 14/16] net: stmmac: Add Generic DW MAC GPIO port driver Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 15/16] net: stmmac: Add DW GMAC GPIOs support Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 14:08 ` [PATCH 16/16] net: stmmac: Add DW MAC IPs of 3.72a/3.73a/3.74a versions Serge Semin 2021-02-08 14:08 ` Serge Semin 2021-02-08 19:36 ` [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support Andrew Lunn 2021-02-08 19:36 ` Andrew Lunn 2021-02-09 11:16 ` Serge Semin [this message] 2021-02-09 11:16 ` Serge Semin 2021-02-09 14:11 ` Andrew Lunn 2021-02-09 14:11 ` Andrew Lunn 2021-02-10 18:00 ` Serge Semin 2021-02-10 18:00 ` Serge Semin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210209111609.tjxoqr6stkcf22jy@mobilestation \ --to=sergey.semin@baikalelectronics.ru \ --cc=Alexey.Malahov@baikalelectronics.ru \ --cc=Pavel.Parkhomenko@baikalelectronics.ru \ --cc=Vyacheslav.Mitrofanov@baikalelectronics.ru \ --cc=alexandre.torgue@st.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=fancer.lancer@gmail.com \ --cc=joabreu@synopsys.com \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=peppe.cavallaro@st.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.