From: kernel test robot <lkp@intel.com>
To: Jyoti Bhayana <jbhayana@google.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>
Cc: kbuild-all@lists.01.org, linux-media@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v5 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors
Date: Tue, 9 Feb 2021 11:27:55 +0800 [thread overview]
Message-ID: <202102091127.VK3rzOPP-lkp@intel.com> (raw)
In-Reply-To: <20210208211918.1280588-2-jbhayana@google.com>
[-- Attachment #1: Type: text/plain, Size: 3795 bytes --]
Hi Jyoti,
I love your patch! Perhaps something to improve:
[auto build test WARNING on iio/togreg]
[also build test WARNING on linus/master sparc-next/master v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jyoti-Bhayana/Adding-support-for-IIO-SCMI-based-sensors/20210209-072954
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/90744ef17921050ddb26b5c750ba690a2e3e222e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jyoti-Bhayana/Adding-support-for-IIO-SCMI-based-sensors/20210209-072954
git checkout 90744ef17921050ddb26b5c750ba690a2e3e222e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/iio/common/scmi_sensors/scmi_iio.c:537:17: warning: no previous prototype for 'scmi_alloc_iiodev' [-Wmissing-prototypes]
537 | struct iio_dev *scmi_alloc_iiodev(struct device *dev,
| ^~~~~~~~~~~~~~~~~
vim +/scmi_alloc_iiodev +537 drivers/iio/common/scmi_sensors/scmi_iio.c
536
> 537 struct iio_dev *scmi_alloc_iiodev(struct device *dev,
538 struct scmi_handle *handle,
539 const struct scmi_sensor_info *sensor_info)
540 {
541 struct iio_chan_spec *iio_channels;
542 struct scmi_iio_priv *sensor;
543 enum iio_modifier modifier;
544 enum iio_chan_type type;
545 struct iio_dev *iiodev;
546 int i, ret;
547
548 iiodev = devm_iio_device_alloc(dev, sizeof(*sensor));
549 if (!iiodev)
550 return ERR_PTR(-ENOMEM);
551
552 iiodev->modes = INDIO_DIRECT_MODE;
553 iiodev->dev.parent = dev;
554 sensor = iio_priv(iiodev);
555 sensor->handle = handle;
556 sensor->sensor_info = sensor_info;
557 sensor->sensor_update_nb.notifier_call = scmi_iio_sensor_update_cb;
558 sensor->indio_dev = iiodev;
559
560 /* adding one additional channel for timestamp */
561 iiodev->num_channels = sensor_info->num_axis + 1;
562 iiodev->name = sensor_info->name;
563 iiodev->info = &scmi_iio_info;
564
565 iio_channels =
566 devm_kzalloc(dev,
567 sizeof(*iio_channels) * (iiodev->num_channels),
568 GFP_KERNEL);
569 if (!iio_channels)
570 return ERR_PTR(-ENOMEM);
571
572 scmi_iio_set_sampling_freq_avail(iiodev);
573
574 for (i = 0; i < sensor_info->num_axis; i++) {
575 ret = scmi_iio_get_chan_type(sensor_info->axis[i].type, &type);
576 if (ret < 0)
577 return ERR_PTR(ret);
578
579 ret = scmi_iio_get_chan_modifier(sensor_info->axis[i].name,
580 &modifier);
581 if (ret < 0)
582 return ERR_PTR(ret);
583
584 scmi_iio_set_data_channel(&iio_channels[i], type, modifier,
585 sensor_info->axis[i].id);
586 }
587
588 scmi_iio_set_timestamp_channel(&iio_channels[i], i);
589 iiodev->channels = iio_channels;
590 return iiodev;
591 }
592
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 76567 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors
Date: Tue, 09 Feb 2021 11:27:55 +0800 [thread overview]
Message-ID: <202102091127.VK3rzOPP-lkp@intel.com> (raw)
In-Reply-To: <20210208211918.1280588-2-jbhayana@google.com>
[-- Attachment #1: Type: text/plain, Size: 3894 bytes --]
Hi Jyoti,
I love your patch! Perhaps something to improve:
[auto build test WARNING on iio/togreg]
[also build test WARNING on linus/master sparc-next/master v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jyoti-Bhayana/Adding-support-for-IIO-SCMI-based-sensors/20210209-072954
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/90744ef17921050ddb26b5c750ba690a2e3e222e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jyoti-Bhayana/Adding-support-for-IIO-SCMI-based-sensors/20210209-072954
git checkout 90744ef17921050ddb26b5c750ba690a2e3e222e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/iio/common/scmi_sensors/scmi_iio.c:537:17: warning: no previous prototype for 'scmi_alloc_iiodev' [-Wmissing-prototypes]
537 | struct iio_dev *scmi_alloc_iiodev(struct device *dev,
| ^~~~~~~~~~~~~~~~~
vim +/scmi_alloc_iiodev +537 drivers/iio/common/scmi_sensors/scmi_iio.c
536
> 537 struct iio_dev *scmi_alloc_iiodev(struct device *dev,
538 struct scmi_handle *handle,
539 const struct scmi_sensor_info *sensor_info)
540 {
541 struct iio_chan_spec *iio_channels;
542 struct scmi_iio_priv *sensor;
543 enum iio_modifier modifier;
544 enum iio_chan_type type;
545 struct iio_dev *iiodev;
546 int i, ret;
547
548 iiodev = devm_iio_device_alloc(dev, sizeof(*sensor));
549 if (!iiodev)
550 return ERR_PTR(-ENOMEM);
551
552 iiodev->modes = INDIO_DIRECT_MODE;
553 iiodev->dev.parent = dev;
554 sensor = iio_priv(iiodev);
555 sensor->handle = handle;
556 sensor->sensor_info = sensor_info;
557 sensor->sensor_update_nb.notifier_call = scmi_iio_sensor_update_cb;
558 sensor->indio_dev = iiodev;
559
560 /* adding one additional channel for timestamp */
561 iiodev->num_channels = sensor_info->num_axis + 1;
562 iiodev->name = sensor_info->name;
563 iiodev->info = &scmi_iio_info;
564
565 iio_channels =
566 devm_kzalloc(dev,
567 sizeof(*iio_channels) * (iiodev->num_channels),
568 GFP_KERNEL);
569 if (!iio_channels)
570 return ERR_PTR(-ENOMEM);
571
572 scmi_iio_set_sampling_freq_avail(iiodev);
573
574 for (i = 0; i < sensor_info->num_axis; i++) {
575 ret = scmi_iio_get_chan_type(sensor_info->axis[i].type, &type);
576 if (ret < 0)
577 return ERR_PTR(ret);
578
579 ret = scmi_iio_get_chan_modifier(sensor_info->axis[i].name,
580 &modifier);
581 if (ret < 0)
582 return ERR_PTR(ret);
583
584 scmi_iio_set_data_channel(&iio_channels[i], type, modifier,
585 sensor_info->axis[i].id);
586 }
587
588 scmi_iio_set_timestamp_channel(&iio_channels[i], i);
589 iiodev->channels = iio_channels;
590 return iiodev;
591 }
592
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 76567 bytes --]
next prev parent reply other threads:[~2021-02-09 3:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 21:19 [PATCH v5 0/1] Adding support for IIO SCMI based sensors Jyoti Bhayana
2021-02-08 21:19 ` [PATCH v5 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors Jyoti Bhayana
2021-02-09 3:27 ` kernel test robot [this message]
2021-02-09 3:27 ` kernel test robot
2021-02-09 11:56 ` Cristian Marussi
[not found] ` <CA+=V6c12nRxLCxM2DPst8RV=i+1WatPyHcQQZp4xAzuoN0vKaw@mail.gmail.com>
2021-02-10 21:46 ` Cristian Marussi
2021-02-12 19:18 ` Jonathan Cameron
2021-02-15 9:25 ` Cristian Marussi
2021-02-15 11:07 ` Jonathan Cameron
2021-02-15 11:17 ` Sudeep Holla
2021-02-15 14:47 ` Cristian Marussi
[not found] ` <CA+=V6c3xmidg9BCZuEoigwcbDwW-sTCZWnVCkPhj4KMCzYCehg@mail.gmail.com>
2021-02-16 10:20 ` Cristian Marussi
2021-02-16 20:05 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102091127.VK3rzOPP-lkp@intel.com \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=jbhayana@google.com \
--cc=jic23@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.