From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: amd-gfx@lists.freedesktop.org Cc: "David Airlie" <airlied@linux.ie>, "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>, dri-devel@lists.freedesktop.org, "Alex Deucher" <alexander.deucher@amd.com>, "Thomas Gleixner" <tglx@linutronix.de>, "Christian König" <christian.koenig@amd.com> Subject: [PATCH 2/3] drm/amdgpu: Remove in_interrupt() usage in gfx_v9_0_kiq_read_clock() Date: Tue, 9 Feb 2021 13:44:38 +0100 [thread overview] Message-ID: <20210209124439.408140-3-bigeasy@linutronix.de> (raw) In-Reply-To: <20210209124439.408140-1-bigeasy@linutronix.de> gfx_v9_0_get_gpu_clock_counter() acquires a mutex_t lock and is the only caller of gfx_v9_0_kiq_read_clock(). If it safe to acquire a mutex_t then gfx_v9_0_get_gpu_clock_counter() is always invoked from preemptible context. Remove in_interrupt() because it superfluous as it will always return false. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index ca7e7264926e6..72c319b860a33 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c @@ -4105,7 +4105,7 @@ static uint64_t gfx_v9_0_kiq_read_clock(struct amdgpu_device *adev) * * also don't wait anymore for IRQ context * */ - if (r < 1 && (amdgpu_in_reset(adev) || in_interrupt())) + if (r < 1 && (amdgpu_in_reset(adev))) goto failed_kiq_read; might_sleep(); -- 2.30.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: amd-gfx@lists.freedesktop.org Cc: "David Airlie" <airlied@linux.ie>, "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>, dri-devel@lists.freedesktop.org, "Daniel Vetter" <daniel@ffwll.ch>, "Alex Deucher" <alexander.deucher@amd.com>, "Thomas Gleixner" <tglx@linutronix.de>, "Christian König" <christian.koenig@amd.com> Subject: [PATCH 2/3] drm/amdgpu: Remove in_interrupt() usage in gfx_v9_0_kiq_read_clock() Date: Tue, 9 Feb 2021 13:44:38 +0100 [thread overview] Message-ID: <20210209124439.408140-3-bigeasy@linutronix.de> (raw) In-Reply-To: <20210209124439.408140-1-bigeasy@linutronix.de> gfx_v9_0_get_gpu_clock_counter() acquires a mutex_t lock and is the only caller of gfx_v9_0_kiq_read_clock(). If it safe to acquire a mutex_t then gfx_v9_0_get_gpu_clock_counter() is always invoked from preemptible context. Remove in_interrupt() because it superfluous as it will always return false. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index ca7e7264926e6..72c319b860a33 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c @@ -4105,7 +4105,7 @@ static uint64_t gfx_v9_0_kiq_read_clock(struct amdgpu_device *adev) * * also don't wait anymore for IRQ context * */ - if (r < 1 && (amdgpu_in_reset(adev) || in_interrupt())) + if (r < 1 && (amdgpu_in_reset(adev))) goto failed_kiq_read; might_sleep(); -- 2.30.0 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-02-09 12:44 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-09 12:44 [PATCH v2 0/3] drm/amdgpu: Remove in_interrupt() usage Sebastian Andrzej Siewior 2021-02-09 12:44 ` Sebastian Andrzej Siewior 2021-02-09 12:44 ` [PATCH 1/3] drm/amdgpu: Replace in_interrupt() usage in gmc_v*_process_interrupt() Sebastian Andrzej Siewior 2021-02-09 12:44 ` Sebastian Andrzej Siewior 2021-02-09 12:44 ` Sebastian Andrzej Siewior [this message] 2021-02-09 12:44 ` [PATCH 2/3] drm/amdgpu: Remove in_interrupt() usage in gfx_v9_0_kiq_read_clock() Sebastian Andrzej Siewior 2021-02-09 12:44 ` [PATCH 3/3] drm/amdgpu: Replace in_task() in gfx_v8_0_parse_sq_irq() Sebastian Andrzej Siewior 2021-02-09 12:44 ` Sebastian Andrzej Siewior 2021-02-09 12:50 ` [PATCH v2 0/3] drm/amdgpu: Remove in_interrupt() usage Christian König 2021-02-09 12:50 ` Christian König 2021-02-09 16:53 ` Sebastian Andrzej Siewior 2021-02-09 16:53 ` Sebastian Andrzej Siewior 2021-02-09 17:43 ` Christian König 2021-02-09 17:43 ` Christian König 2021-03-10 17:47 ` Sebastian Andrzej Siewior 2021-03-10 17:47 ` Sebastian Andrzej Siewior 2021-03-11 10:42 ` Christian König 2021-03-11 10:42 ` Christian König 2021-03-11 15:45 ` Alex Deucher 2021-03-11 15:45 ` Alex Deucher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210209124439.408140-3-bigeasy@linutronix.de \ --to=bigeasy@linutronix.de \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.