All of lore.kernel.org
 help / color / mirror / Atom feed
* [intel-linux-intel-lts:5.4/yocto 6901/14495] drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:6293:6: warning: no previous prototype for function 'stmmac_clean_all_tx_rings'
@ 2021-02-09 17:19 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-02-09 17:19 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 7189 bytes --]

Hi Ong,

FYI, the error/warning still remains.

tree:   https://github.com/intel/linux-intel-lts.git 5.4/yocto
head:   8d1d3c280f86dbbaea50114eace1c9a1a398685f
commit: c2198809408cf67767651a83f3024c6340602479 [6901/14495] net: stmmac: clean all pending Tx buffers during suspend
config: x86_64-randconfig-a014-20210209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/intel/linux-intel-lts/commit/c2198809408cf67767651a83f3024c6340602479
        git remote add intel-linux-intel-lts https://github.com/intel/linux-intel-lts.git
        git fetch --no-tags intel-linux-intel-lts 5.4/yocto
        git checkout c2198809408cf67767651a83f3024c6340602479
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:802:3: warning: variable 'sec_inc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
                   stmmac_config_sub_second_increment(priv,
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/stmicro/stmmac/hwif.h:666:2: note: expanded from macro 'stmmac_config_sub_second_increment'
           stmmac_do_void_callback(__priv, ptp, config_sub_second_increment, __args)
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/stmicro/stmmac/hwif.h:14:6: note: expanded from macro 'stmmac_do_void_callback'
           if ((__priv)->hw->__module && (__priv)->hw->__module->__cname) { \
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:807:33: note: uninitialized use occurs here
                   temp = div_u64(1000000000ULL, sec_inc);
                                                 ^~~~~~~
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:802:3: note: remove the 'if' if its condition is always true
                   stmmac_config_sub_second_increment(priv,
                   ^
   drivers/net/ethernet/stmicro/stmmac/hwif.h:666:2: note: expanded from macro 'stmmac_config_sub_second_increment'
           stmmac_do_void_callback(__priv, ptp, config_sub_second_increment, __args)
           ^
   drivers/net/ethernet/stmicro/stmmac/hwif.h:14:2: note: expanded from macro 'stmmac_do_void_callback'
           if ((__priv)->hw->__module && (__priv)->hw->__module->__cname) { \
           ^
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:802:3: warning: variable 'sec_inc' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
                   stmmac_config_sub_second_increment(priv,
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/stmicro/stmmac/hwif.h:666:2: note: expanded from macro 'stmmac_config_sub_second_increment'
           stmmac_do_void_callback(__priv, ptp, config_sub_second_increment, __args)
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/stmicro/stmmac/hwif.h:14:6: note: expanded from macro 'stmmac_do_void_callback'
           if ((__priv)->hw->__module && (__priv)->hw->__module->__cname) { \
               ^~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:807:33: note: uninitialized use occurs here
                   temp = div_u64(1000000000ULL, sec_inc);
                                                 ^~~~~~~
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:802:3: note: remove the '&&' if its condition is always true
                   stmmac_config_sub_second_increment(priv,
                   ^
   drivers/net/ethernet/stmicro/stmmac/hwif.h:666:2: note: expanded from macro 'stmmac_config_sub_second_increment'
           stmmac_do_void_callback(__priv, ptp, config_sub_second_increment, __args)
           ^
   drivers/net/ethernet/stmicro/stmmac/hwif.h:14:6: note: expanded from macro 'stmmac_do_void_callback'
           if ((__priv)->hw->__module && (__priv)->hw->__module->__cname) { \
               ^
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:767:13: note: initialize the variable 'sec_inc' to silence this warning
           u32 sec_inc;
                      ^
                       = 0
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1403:6: warning: no previous prototype for function 'stmmac_alloc_rx_buffers' [-Wmissing-prototypes]
   bool stmmac_alloc_rx_buffers(struct stmmac_rx_queue *rx_q, u32 count)
        ^
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1403:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   bool stmmac_alloc_rx_buffers(struct stmmac_rx_queue *rx_q, u32 count)
   ^
   static 
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:5615:5: warning: no previous prototype for function 'stmmac_xdp_xmit' [-Wmissing-prototypes]
   int stmmac_xdp_xmit(struct net_device *dev, int n, struct xdp_frame **frames,
       ^
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:5615:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int stmmac_xdp_xmit(struct net_device *dev, int n, struct xdp_frame **frames,
   ^
   static 
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:6293:6: warning: no previous prototype for function 'stmmac_clean_all_tx_rings' [-Wmissing-prototypes]
   void stmmac_clean_all_tx_rings(struct stmmac_priv *priv)
        ^
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:6293:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void stmmac_clean_all_tx_rings(struct stmmac_priv *priv)
   ^
   static 
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4232:19: warning: unused function 'stmmac_rx_threshold_count' [-Wunused-function]
   static inline int stmmac_rx_threshold_count(struct stmmac_rx_queue *rx_q)
                     ^
   6 warnings generated.


vim +/stmmac_clean_all_tx_rings +6293 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

  6292	
> 6293	void stmmac_clean_all_tx_rings(struct stmmac_priv *priv)
  6294	{
  6295		u32 tx_count = priv->plat->tx_queues_to_use;
  6296		u32 queue;
  6297	
  6298		for (queue = 0; queue < tx_count; queue++) {
  6299			struct stmmac_tx_queue *tx_q = get_tx_queue(priv, queue);
  6300	
  6301			stmmac_clean_tx_queue(priv, tx_q);
  6302		}
  6303	}
  6304	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35359 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-02-09 17:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09 17:19 [intel-linux-intel-lts:5.4/yocto 6901/14495] drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:6293:6: warning: no previous prototype for function 'stmmac_clean_all_tx_rings' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.